gstreamer/libs/gst/controller/gstdirectcontrolbinding.c
Adrian Pardini d4f6c8e0e6 controller: fixes int overflow with properties that span +-INT_MAX
When the range for a property is defined as -INT_MAX-1 .. INT_MAX, like
the xpos in a videomixer the following expression in the macro
definitions of convert_g_value_to_##type (and the equivalent in
convert_value_to_##type)

v = pspec->minimum + (g##type) ROUNDING_OP ((pspec->maximum - pspec->minimum) * s);

are converted to:

v = -2147483648 + (g##type) ROUNDING_OP ((2147483647 - -2147483648) * s);

(2147483647 - -2147483648) overflows to -1 and the net result is:

v = -2147483648 + (g##type) ROUNDING_OP (-1 * s);

so v only takes the values -2147483648 for s == 0 and 2147483647
for s == 1.

Rewriting the expression as minimum*(1-s) + maximum*s gives the correct
result in this case.

https://bugzilla.gnome.org//show_bug.cgi?id=705630
2013-08-08 12:31:49 +02:00

494 lines
16 KiB
C

/* GStreamer
*
* Copyright (C) 2011 Stefan Sauer <ensonic@users.sf.net>
*
* gstdirectcontrolbinding.c: Direct attachment for control sources
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Library General Public
* License along with this library; if not, write to the
* Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/
/**
* SECTION:gstdirectcontrolbinding
* @short_description: direct attachment for control sources
*
* A value mapping object that attaches control sources to gobject properties. It
* will map the control values [0.0 ... 1.0] to the target property range. If a
* control value is outside of the range, it will be clipped.
*/
#include <glib-object.h>
#include <gst/gst.h>
#include "gstdirectcontrolbinding.h"
#include <gst/math-compat.h>
#define GST_CAT_DEFAULT control_binding_debug
GST_DEBUG_CATEGORY_STATIC (GST_CAT_DEFAULT);
static GObject *gst_direct_control_binding_constructor (GType type,
guint n_construct_params, GObjectConstructParam * construct_params);
static void gst_direct_control_binding_set_property (GObject * object,
guint prop_id, const GValue * value, GParamSpec * pspec);
static void gst_direct_control_binding_get_property (GObject * object,
guint prop_id, GValue * value, GParamSpec * pspec);
static void gst_direct_control_binding_dispose (GObject * object);
static void gst_direct_control_binding_finalize (GObject * object);
static gboolean gst_direct_control_binding_sync_values (GstControlBinding *
_self, GstObject * object, GstClockTime timestamp, GstClockTime last_sync);
static GValue *gst_direct_control_binding_get_value (GstControlBinding * _self,
GstClockTime timestamp);
static gboolean gst_direct_control_binding_get_value_array (GstControlBinding *
_self, GstClockTime timestamp, GstClockTime interval, guint n_values,
gpointer values);
static gboolean gst_direct_control_binding_get_g_value_array (GstControlBinding
* _self, GstClockTime timestamp, GstClockTime interval, guint n_values,
GValue * values);
#define _do_init \
GST_DEBUG_CATEGORY_INIT (GST_CAT_DEFAULT, "gstdirectcontrolbinding", 0, \
"dynamic parameter control source attachment");
#define gst_direct_control_binding_parent_class parent_class
G_DEFINE_TYPE_WITH_CODE (GstDirectControlBinding, gst_direct_control_binding,
GST_TYPE_CONTROL_BINDING, _do_init);
enum
{
PROP_0,
PROP_CS,
PROP_LAST
};
static GParamSpec *properties[PROP_LAST];
/* mapping functions */
#define DEFINE_CONVERT(type,Type,TYPE,ROUNDING_OP) \
static void \
convert_g_value_to_##type (GstDirectControlBinding *self, gdouble s, GValue *d) \
{ \
GParamSpec##Type *pspec = G_PARAM_SPEC_##TYPE (((GstControlBinding *)self)->pspec); \
g##type v; \
\
s = CLAMP (s, 0.0, 1.0); \
v = (g##type) ROUNDING_OP (pspec->minimum * (1-s)) + (g##type) ROUNDING_OP (pspec->maximum * s); \
g_value_set_##type (d, v); \
} \
\
static void \
convert_value_to_##type (GstDirectControlBinding *self, gdouble s, gpointer d_) \
{ \
GParamSpec##Type *pspec = G_PARAM_SPEC_##TYPE (((GstControlBinding *)self)->pspec); \
g##type *d = (g##type *)d_; \
\
s = CLAMP (s, 0.0, 1.0); \
*d = (g##type) ROUNDING_OP (pspec->minimum * (1-s)) + (g##type) ROUNDING_OP (pspec->maximum * s); \
}
DEFINE_CONVERT (int, Int, INT, rint);
DEFINE_CONVERT (uint, UInt, UINT, rint);
DEFINE_CONVERT (long, Long, LONG, rint);
DEFINE_CONVERT (ulong, ULong, ULONG, rint);
DEFINE_CONVERT (int64, Int64, INT64, rint);
DEFINE_CONVERT (uint64, UInt64, UINT64, rint);
DEFINE_CONVERT (float, Float, FLOAT, /*NOOP*/);
DEFINE_CONVERT (double, Double, DOUBLE, /*NOOP*/);
static void
convert_g_value_to_boolean (GstDirectControlBinding * self, gdouble s,
GValue * d)
{
s = CLAMP (s, 0.0, 1.0);
g_value_set_boolean (d, (gboolean) (s + 0.5));
}
static void
convert_value_to_boolean (GstDirectControlBinding * self, gdouble s,
gpointer d_)
{
gboolean *d = (gboolean *) d_;
s = CLAMP (s, 0.0, 1.0);
*d = (gboolean) (s + 0.5);
}
static void
convert_g_value_to_enum (GstDirectControlBinding * self, gdouble s, GValue * d)
{
GParamSpecEnum *pspec =
G_PARAM_SPEC_ENUM (((GstControlBinding *) self)->pspec);
GEnumClass *e = pspec->enum_class;
gint v;
s = CLAMP (s, 0.0, 1.0);
v = s * (e->n_values - 1);
g_value_set_enum (d, e->values[v].value);
}
static void
convert_value_to_enum (GstDirectControlBinding * self, gdouble s, gpointer d_)
{
GParamSpecEnum *pspec =
G_PARAM_SPEC_ENUM (((GstControlBinding *) self)->pspec);
GEnumClass *e = pspec->enum_class;
gint *d = (gint *) d_;
s = CLAMP (s, 0.0, 1.0);
*d = e->values[(gint) (s * (e->n_values - 1))].value;
}
/* vmethods */
static void
gst_direct_control_binding_class_init (GstDirectControlBindingClass * klass)
{
GObjectClass *gobject_class = G_OBJECT_CLASS (klass);
GstControlBindingClass *control_binding_class =
GST_CONTROL_BINDING_CLASS (klass);
gobject_class->constructor = gst_direct_control_binding_constructor;
gobject_class->set_property = gst_direct_control_binding_set_property;
gobject_class->get_property = gst_direct_control_binding_get_property;
gobject_class->dispose = gst_direct_control_binding_dispose;
gobject_class->finalize = gst_direct_control_binding_finalize;
control_binding_class->sync_values = gst_direct_control_binding_sync_values;
control_binding_class->get_value = gst_direct_control_binding_get_value;
control_binding_class->get_value_array =
gst_direct_control_binding_get_value_array;
control_binding_class->get_g_value_array =
gst_direct_control_binding_get_g_value_array;
properties[PROP_CS] =
g_param_spec_object ("control-source", "ControlSource",
"The control source",
GST_TYPE_CONTROL_SOURCE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);
g_object_class_install_properties (gobject_class, PROP_LAST, properties);
}
static void
gst_direct_control_binding_init (GstDirectControlBinding * self)
{
}
static GObject *
gst_direct_control_binding_constructor (GType type, guint n_construct_params,
GObjectConstructParam * construct_params)
{
GstDirectControlBinding *self;
self =
GST_DIRECT_CONTROL_BINDING (G_OBJECT_CLASS (parent_class)->constructor
(type, n_construct_params, construct_params));
if (GST_CONTROL_BINDING_PSPEC (self)) {
GType type, base;
base = type = G_PARAM_SPEC_VALUE_TYPE (GST_CONTROL_BINDING_PSPEC (self));
g_value_init (&self->cur_value, type);
while ((type = g_type_parent (type)))
base = type;
GST_DEBUG (" using type %s", g_type_name (base));
/* select mapping function */
switch (base) {
case G_TYPE_INT:
self->convert_g_value = convert_g_value_to_int;
self->convert_value = convert_value_to_int;
self->byte_size = sizeof (gint);
break;
case G_TYPE_UINT:
self->convert_g_value = convert_g_value_to_uint;
self->convert_value = convert_value_to_uint;
self->byte_size = sizeof (guint);
break;
case G_TYPE_LONG:
self->convert_g_value = convert_g_value_to_long;
self->convert_value = convert_value_to_long;
self->byte_size = sizeof (glong);
break;
case G_TYPE_ULONG:
self->convert_g_value = convert_g_value_to_ulong;
self->convert_value = convert_value_to_ulong;
self->byte_size = sizeof (gulong);
break;
case G_TYPE_INT64:
self->convert_g_value = convert_g_value_to_int64;
self->convert_value = convert_value_to_int64;
self->byte_size = sizeof (gint64);
break;
case G_TYPE_UINT64:
self->convert_g_value = convert_g_value_to_uint64;
self->convert_value = convert_value_to_uint64;
self->byte_size = sizeof (guint64);
break;
case G_TYPE_FLOAT:
self->convert_g_value = convert_g_value_to_float;
self->convert_value = convert_value_to_float;
self->byte_size = sizeof (gfloat);
break;
case G_TYPE_DOUBLE:
self->convert_g_value = convert_g_value_to_double;
self->convert_value = convert_value_to_double;
self->byte_size = sizeof (gdouble);
break;
case G_TYPE_BOOLEAN:
self->convert_g_value = convert_g_value_to_boolean;
self->convert_value = convert_value_to_boolean;
self->byte_size = sizeof (gboolean);
break;
case G_TYPE_ENUM:
self->convert_g_value = convert_g_value_to_enum;
self->convert_value = convert_value_to_enum;
self->byte_size = sizeof (gint);
break;
default:
GST_WARNING ("incomplete implementation for paramspec type '%s'",
G_PARAM_SPEC_TYPE_NAME (GST_CONTROL_BINDING_PSPEC (self)));
GST_CONTROL_BINDING_PSPEC (self) = NULL;
break;
}
}
return (GObject *) self;
}
static void
gst_direct_control_binding_set_property (GObject * object, guint prop_id,
const GValue * value, GParamSpec * pspec)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (object);
switch (prop_id) {
case PROP_CS:
self->cs = g_value_dup_object (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
}
}
static void
gst_direct_control_binding_get_property (GObject * object, guint prop_id,
GValue * value, GParamSpec * pspec)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (object);
switch (prop_id) {
case PROP_CS:
g_value_set_object (value, self->cs);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
}
}
static void
gst_direct_control_binding_dispose (GObject * object)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (object);
if (self->cs)
gst_object_replace ((GstObject **) & self->cs, NULL);
G_OBJECT_CLASS (parent_class)->dispose (object);
}
static void
gst_direct_control_binding_finalize (GObject * object)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (object);
g_value_unset (&self->cur_value);
G_OBJECT_CLASS (parent_class)->finalize (object);
}
static gboolean
gst_direct_control_binding_sync_values (GstControlBinding * _self,
GstObject * object, GstClockTime timestamp, GstClockTime last_sync)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (_self);
gdouble src_val;
gboolean ret;
g_return_val_if_fail (GST_IS_DIRECT_CONTROL_BINDING (self), FALSE);
g_return_val_if_fail (GST_CONTROL_BINDING_PSPEC (self), FALSE);
GST_LOG_OBJECT (object, "property '%s' at ts=%" GST_TIME_FORMAT,
_self->name, GST_TIME_ARGS (timestamp));
ret = gst_control_source_get_value (self->cs, timestamp, &src_val);
if (G_LIKELY (ret)) {
GST_LOG_OBJECT (object, " new value %lf", src_val);
/* always set the value for first time, but then only if it changed
* this should limit g_object_notify invocations.
* FIXME: can we detect negative playback rates?
*/
if ((timestamp < last_sync) || (src_val != self->last_value)) {
GValue *dst_val = &self->cur_value;
GST_LOG_OBJECT (object, " mapping %s to value of type %s", _self->name,
G_VALUE_TYPE_NAME (dst_val));
/* run mapping function to convert gdouble to GValue */
self->convert_g_value (self, src_val, dst_val);
/* we can make this faster
* http://bugzilla.gnome.org/show_bug.cgi?id=536939
*/
g_object_set_property ((GObject *) object, _self->name, dst_val);
self->last_value = src_val;
}
} else {
GST_DEBUG_OBJECT (object, "no control value for param %s", _self->name);
}
return (ret);
}
static GValue *
gst_direct_control_binding_get_value (GstControlBinding * _self,
GstClockTime timestamp)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (_self);
GValue *dst_val = NULL;
gdouble src_val;
g_return_val_if_fail (GST_IS_DIRECT_CONTROL_BINDING (self), NULL);
g_return_val_if_fail (GST_CLOCK_TIME_IS_VALID (timestamp), NULL);
g_return_val_if_fail (GST_CONTROL_BINDING_PSPEC (self), FALSE);
/* get current value via control source */
if (gst_control_source_get_value (self->cs, timestamp, &src_val)) {
dst_val = g_new0 (GValue, 1);
g_value_init (dst_val, G_PARAM_SPEC_VALUE_TYPE (_self->pspec));
self->convert_g_value (self, src_val, dst_val);
} else {
GST_LOG ("no control value for property %s at ts %" GST_TIME_FORMAT,
_self->name, GST_TIME_ARGS (timestamp));
}
return dst_val;
}
static gboolean
gst_direct_control_binding_get_value_array (GstControlBinding * _self,
GstClockTime timestamp, GstClockTime interval, guint n_values,
gpointer values_)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (_self);
gint i;
gdouble *src_val;
gboolean res = FALSE;
GstDirectControlBindingConvertValue convert;
gint byte_size;
guint8 *values = (guint8 *) values_;
g_return_val_if_fail (GST_IS_DIRECT_CONTROL_BINDING (self), FALSE);
g_return_val_if_fail (GST_CLOCK_TIME_IS_VALID (timestamp), FALSE);
g_return_val_if_fail (GST_CLOCK_TIME_IS_VALID (interval), FALSE);
g_return_val_if_fail (values, FALSE);
g_return_val_if_fail (GST_CONTROL_BINDING_PSPEC (self), FALSE);
convert = self->convert_value;
byte_size = self->byte_size;
src_val = g_new0 (gdouble, n_values);
if ((res = gst_control_source_get_value_array (self->cs, timestamp,
interval, n_values, src_val))) {
for (i = 0; i < n_values; i++) {
/* we will only get NAN for sparse control sources, such as triggers */
if (!isnan (src_val[i])) {
convert (self, src_val[i], (gpointer) values);
} else {
GST_LOG ("no control value for property %s at index %d", _self->name,
i);
}
values += byte_size;
}
} else {
GST_LOG ("failed to get control value for property %s at ts %"
GST_TIME_FORMAT, _self->name, GST_TIME_ARGS (timestamp));
}
g_free (src_val);
return res;
}
static gboolean
gst_direct_control_binding_get_g_value_array (GstControlBinding * _self,
GstClockTime timestamp, GstClockTime interval, guint n_values,
GValue * values)
{
GstDirectControlBinding *self = GST_DIRECT_CONTROL_BINDING (_self);
gint i;
gdouble *src_val;
gboolean res = FALSE;
GType type;
GstDirectControlBindingConvertGValue convert;
g_return_val_if_fail (GST_IS_DIRECT_CONTROL_BINDING (self), FALSE);
g_return_val_if_fail (GST_CLOCK_TIME_IS_VALID (timestamp), FALSE);
g_return_val_if_fail (GST_CLOCK_TIME_IS_VALID (interval), FALSE);
g_return_val_if_fail (values, FALSE);
g_return_val_if_fail (GST_CONTROL_BINDING_PSPEC (self), FALSE);
convert = self->convert_g_value;
type = G_PARAM_SPEC_VALUE_TYPE (_self->pspec);
src_val = g_new0 (gdouble, n_values);
if ((res = gst_control_source_get_value_array (self->cs, timestamp,
interval, n_values, src_val))) {
for (i = 0; i < n_values; i++) {
/* we will only get NAN for sparse control sources, such as triggers */
if (!isnan (src_val[i])) {
g_value_init (&values[i], type);
convert (self, src_val[i], &values[i]);
} else {
GST_LOG ("no control value for property %s at index %d", _self->name,
i);
}
}
} else {
GST_LOG ("failed to get control value for property %s at ts %"
GST_TIME_FORMAT, _self->name, GST_TIME_ARGS (timestamp));
}
g_free (src_val);
return res;
}
/* functions */
/**
* gst_direct_control_binding_new:
* @object: the object of the property
* @property_name: the property-name to attach the control source
* @cs: the control source
*
* Create a new control-binding that attaches the #GstControlSource to the
* #GObject property.
*
* Returns: (transfer floating): the new #GstDirectControlBinding
*/
GstControlBinding *
gst_direct_control_binding_new (GstObject * object, const gchar * property_name,
GstControlSource * cs)
{
return (GstControlBinding *) g_object_new (GST_TYPE_DIRECT_CONTROL_BINDING,
"object", object, "name", property_name, "control-source", cs, NULL);
}