mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-19 14:56:36 +00:00
Code Issues 1 Projects Releases Wiki Activity
gstreamer/gst
History
Matthew Gruenke cd06aea103 poll: Fix various race conditions with read_control() and write_control() 
This addresses slightly different race conditions on Linux and Windows, and
fixes gst_poll_read_control() when control_pending == 0.

On Linux, the socketpair() used for control should not be made O_NONBLOCK.
If there's any propagation delay between set->control_write_fd.fd and
set->control_read_fd.fd, even the mutex now held will not be sufficient to
prevent a race condition.  There's no benefit to using O_NONBLOCK, here.
Only liabilities.

For Windows, it's necessary to fix the race condition between testing
set->control_pending and performing WAKE_EVENT()/RELEASE_EVENT().  This is
accomplished by acquiring and holding set->lock, for both of these operations.
We could optimize the Linux version by making this Windows-specific.

For consistency with the Linux implementation, Windows' RELEASE_EVENT()
has also been made to block, although it should never happen.

Also, changed release_wakeup() to return TRUE and decrement control_pending
only when > 0.  Furthermore, RELEASE_EVENT() is called only when
control_pending == 1.

Finally, changed control_pending to use normal, non-atomic arithmetic
operations, since it's now protected by set->lock.

Note: even though the underlying signaling mechanisms are blocking,
release_wakeup() is effectively non-blocking, as it will only attempt to read
from control_read_fd.fd after a byte has been written to control_write_fd.fd
or WaitForSingleObject() after it's been signaled.

https://bugzilla.gnome.org/show_bug.cgi?id=750397
2016-06-29 21:21:04 +02:00
..
parse gst/parse: Also pass -DGST_EXPORTS here 2016-05-23 14:24:16 +01:00
printf printf: On MSVC, also define HAVE_STDINT_H_WITH_UINTMAX 2016-02-20 10:07:37 +00:00
.gitignore gstbase: Add gobject-introspection support 2009-09-05 10:28:46 +02:00
gettext.h Fix FSF address 2012-11-03 20:44:48 +00:00
glib-compat-private.h Fix FSF address 2012-11-03 20:44:48 +00:00
glib-compat.c Whenever we include windows.h, also define WIN32_LEAN_AND_MEAN 2016-02-20 10:07:42 +00:00
glib-compat.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gst-i18n-app.h Fix FSF address 2012-11-03 20:44:48 +00:00
gst-i18n-lib.h Fix FSF address 2012-11-03 20:44:48 +00:00
gst.c gst_deinit: move down tracers cleaning 2016-06-02 23:08:04 +01:00
gst.h gst.h: Don't spew warnings if GST_USE_UNSTABLE_API is not defined 2016-01-16 16:00:16 +00:00
gst_private.h gst_private: Fix gstconfig include 2016-05-25 15:31:52 +02:00
gstallocator.c allocator: add cleanup method 2016-04-18 11:33:32 -04:00
gstallocator.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstatomicqueue.c introspection: add missing (nullable) annotations to return values 2014-06-26 18:56:38 +02:00
gstatomicqueue.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstbin.c bin: emit deep-element-{added,removed} for children of newly-added/removed bin 2016-05-16 09:10:09 +01:00
gstbin.h bin: add "deep-element-added" and "deep-element-removed" signals 2016-05-16 09:10:09 +01:00
gstbuffer.c Fix some nonsensical g-i annotations 2016-04-30 14:15:08 +01:00
gstbuffer.h gstbuffer: fix GstParentBufferMeta GType name 2016-03-07 12:02:00 +01:00
gstbufferlist.c bufferlist: Warn if copying a buffer fails in gst_buffer_list_copy_deep() 2015-06-24 10:52:56 +02:00
gstbufferlist.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstbufferpool.c GST_REFCOUNTING: Add logging of pointer address for dispose, finalize, etc messages 2016-04-02 18:18:10 +01:00
gstbufferpool.h doc: Fix Since: marks 2015-06-13 20:19:59 -04:00
gstbus.c bus: chain up GObject::constructed() to the parent class' implementation 2016-06-28 17:23:17 +03:00
gstbus.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstcaps.c Use MAY_BE_LEAKED_FLAG 2016-06-02 23:14:15 +01:00
gstcaps.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstcapsfeatures.c capsfeature: add cleanup priv function 2016-04-26 14:29:01 +01:00
gstcapsfeatures.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstchildproxy.c introspection: add missing (nullable) annotations to return values 2014-06-26 18:56:38 +02:00
gstchildproxy.h Fix FSF address 2012-11-03 20:44:48 +00:00
gstclock-linreg.c clock: Make linear regression x/y base start from maximum observation. 2015-02-07 04:38:39 +11:00
gstclock.c clock: Return FALSE in all paths that don't set out parameters in gst_clock_add_observation_unapplied() 2016-04-02 01:34:46 +03:00
gstclock.h docs: annotate C examples as such 2016-02-15 17:45:15 +00:00
gstcompat.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gstconfig.h.in gstconfig.h: Don't use extern with dllexport 2016-06-24 01:09:32 +01:00
gstcontext.c context: fix some copy and paste leftover in docs 2015-11-10 17:37:22 -03:00
gstcontext.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstcontrolbinding.c Don't compare booleans for equality to TRUE and FALSE 2014-12-01 09:51:37 +01:00
gstcontrolbinding.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstcontrolsource.c controlsource: Annotate get_value[_array] as (method) 2015-11-30 23:17:32 +01:00
gstcontrolsource.h controlsource: fix GetValue and GetValueArray documentation 2016-01-08 18:24:06 +00:00
gstdatetime.c datetime: Sanity check year, month and day when parsing ISO-8601 strings 2016-04-21 13:49:32 +03:00
gstdatetime.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstdebugutils.c debugutils: fix warning on enum properties printing 2016-05-11 10:02:49 +03:00
gstdebugutils.h docs: mention xdot utility to view .dot files directly 2015-10-16 15:59:49 +01:00
gstdevice.c device: Fix typo 2016-06-15 16:12:36 +02:00
gstdevice.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstdevicemonitor.c GstDeviceMonitor: Clarify the behaviour of gst_device_monitor_add_filter 2016-01-14 22:07:51 +00:00
gstdevicemonitor.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstdeviceprovider.c deviceprovider: remove base_class_finalize function 2016-06-04 13:35:12 +01:00
gstdeviceprovider.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstdeviceproviderfactory.c Use MAY_BE_LEAKED_FLAG 2016-06-02 23:14:15 +01:00
gstdeviceproviderfactory.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstelement.c element: remove base_class_finalize_func which is never called 2016-06-04 13:11:55 +01:00
gstelement.h element: Add gst_element_call_async() 2016-04-27 18:51:33 +03:00
gstelementfactory.c Use MAY_BE_LEAKED_FLAG 2016-06-02 23:14:15 +01:00
gstelementfactory.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstelementmetadata.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gsterror.c fixme: bump leftover 0.11 fixme comments 2014-09-25 21:27:03 +02:00
gsterror.h doc: Fix Since: marks 2015-06-13 20:19:59 -04:00
gstevent.c event: add some more documentation on stream-id 2016-02-22 16:21:31 +01:00
gstevent.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstformat.c introspection: add missing (nullable) annotations to return values 2014-06-26 18:56:38 +02:00
gstformat.h Fix FSF address 2012-11-03 20:44:48 +00:00
gstghostpad.c Fix some nonsensical g-i annotations 2016-04-30 14:15:08 +01:00
gstghostpad.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstinfo.c info: only open log file when adding it to the log function 2016-04-02 10:47:57 +01:00
gstinfo.h info: flesh out GST_PTR_FORMAT docs a bit 2016-06-14 19:16:33 +01:00
gstiterator.c iterator: only unset GValue if it was inited 2016-05-23 18:09:48 +01:00
gstiterator.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstmacros.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gstmemory.c memory: provide a mem_map_full that takes the GstMapInfo 2015-06-12 16:12:10 +10:00
gstmemory.h memory: fix C++ compiler warnings with GST_MAP_INFO_INIT 2016-04-06 17:46:31 +01:00
gstmessage.c element: add API to get property change notifications via messages 2016-04-08 13:27:59 +01:00
gstmessage.h element: add API to get property change notifications via messages 2016-04-08 13:27:59 +01:00
gstmeta.c meta: Warn if a meta implementation is registered without init function 2016-04-13 10:21:15 +03:00
gstmeta.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gstminiobject.c tracing: add hooks when objects or miniobjects are created and destroyed 2016-06-02 23:10:44 +01:00
gstminiobject.h (mini)object: add MAY_BE_LEAKED flag 2016-05-20 09:11:08 +01:00
gstobject.c tracing: add hooks when objects or miniobjects are created and destroyed 2016-06-02 23:10:44 +01:00
gstobject.h (mini)object: add MAY_BE_LEAKED flag 2016-05-20 09:11:08 +01:00
gstpad.c pad: Log pad offsets as signed times 2016-06-11 22:18:22 +03:00
gstpad.h pad: Improve IDLE probe docs 2016-05-15 15:02:49 +03:00
gstpadtemplate.c Use MAY_BE_LEAKED_FLAG 2016-06-02 23:14:15 +01:00
gstpadtemplate.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstparamspecs.c docs: remove outdated and pointless 'Last reviewed' lines from docs 2014-04-26 21:21:51 +01:00
gstparamspecs.h Fix FSF address 2012-11-03 20:44:48 +00:00
gstparse.c parse-launch: Add flag for placing elements in a bin instead of a pipeline 2016-03-24 14:50:12 +02:00
gstparse.h parse-launch: Add flag for placing elements in a bin instead of a pipeline 2016-03-24 14:50:12 +02:00
gstpipeline.c GST_REFCOUNTING: Add logging of pointer address for dispose, finalize, etc messages 2016-04-02 18:18:10 +01:00
gstpipeline.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstplugin.c plugin: Only check for S_IFBLK if it is defined 2016-02-20 10:07:25 +00:00
gstplugin.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstpluginfeature.c docs: annotate C examples as such 2016-02-15 17:45:15 +00:00
gstpluginfeature.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstpluginloader.c pluginloader: Fix typos 2015-03-25 23:36:54 +00:00
gstpluginloader.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gstpoll.c poll: Fix various race conditions with read_control() and write_control() 2016-06-29 21:21:04 +02:00
gstpoll.h Fix FSF address 2012-11-03 20:44:48 +00:00
gstpreset.c preset: Use GST_PRESET_PATH as an extension of the system path, not a replacement of the user path 2016-03-22 19:32:48 +02:00
gstpreset.h preset: add gst_preset_is_editable() 2014-12-12 21:49:16 +01:00
gstprotection.c protection/harness/systemclock: move declaration out of for loop initialization 2016-02-15 12:33:46 -03:00
gstprotection.h doc: Fix Since: marks 2015-06-13 20:19:59 -04:00
gstquark.c element: add API to get property change notifications via messages 2016-04-08 13:27:59 +01:00
gstquark.h element: add API to get property change notifications via messages 2016-04-08 13:27:59 +01:00
gstquery.c docs: xref the free function and expand allocation query docs 2016-05-30 02:04:18 -07:00
gstquery.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstregistry.c registry: allow plugin and feature filter funcs to call registry API 2016-03-26 11:13:09 +00:00
gstregistry.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstregistrybinary.c DeviceProvider: Rename from DeviceMonitor 2014-06-26 14:45:30 -04:00
gstregistrybinary.h tracer: initial prototype for the tracing subsystem 2015-10-05 20:59:39 +02:00
gstregistrychunks.c registrychunks: remove unused macro 2016-02-16 17:53:10 -03:00
gstregistrychunks.h DeviceProvider: Rename from DeviceMonitor 2014-06-26 14:45:30 -04:00
gstsample.c sample: add gst_sample_set/get_buffer_list apis 2015-06-22 13:17:01 +02:00
gstsample.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstsegment.c segment: Return -1 if gst_segment_to_stream_time_full() considers the position not inside the segment 2015-10-26 10:53:35 +02:00
gstsegment.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gststructure.c tracerrecord: allow G_TYPE_POINTER for field types 2016-06-02 22:53:28 +01:00
gststructure.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gstsystemclock.c systemclock: Fix wait/unschedule race 2016-02-10 08:59:33 -03:00
gstsystemclock.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gsttaglist.c taglist: add guard to check writability when removing tags from a taglist 2016-02-28 13:59:48 +00:00
gsttaglist.h taglist: add GST_TAG_CONDUCTOR 2016-02-22 21:12:37 +00:00
gsttagsetter.c docs: annotate C examples as such 2016-02-15 17:45:15 +00:00
gsttagsetter.h Fix FSF address 2012-11-03 20:44:48 +00:00
gsttask.c Use MAY_BE_LEAKED_FLAG 2016-06-02 23:14:15 +01:00
gsttask.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gsttaskpool.c introspection: add missing (nullable) annotations to return values 2014-06-26 18:56:38 +02:00
gsttaskpool.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gsttoc.c toc: minor code clean-up 2014-11-02 20:18:38 +00:00
gsttoc.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gsttocsetter.c introspection: add missing (nullable) annotations to return values 2014-06-26 18:56:38 +02:00
gsttocsetter.h Fix FSF address 2012-11-03 20:44:48 +00:00
gsttrace.c alloctrace: print size and allocator details for buffers and memories 2016-03-26 13:46:58 +00:00
gsttrace.h Headers: add missing includes. 2015-08-15 13:17:07 +02:00
gsttracer.c tracer.h: don't include private noinst header gsttracerutils.h in a public header 2016-01-17 00:00:51 +00:00
gsttracer.h tracer.h: don't include private noinst header gsttracerutils.h in a public header 2016-01-17 00:00:51 +00:00
gsttracerfactory.c docs: fix some warnings and add some since markers 2016-01-03 17:50:35 +00:00
gsttracerfactory.h docs: fix some warnings and add some since markers 2016-01-03 17:50:35 +00:00
gsttracerrecord.c tracerrecord: Remove useless NULL check and add assertion for making assumptions explicit 2016-03-02 10:37:09 +02:00
gsttracerrecord.h tracerrecord: don't leak the spec structures 2016-01-22 10:07:26 +01:00
gsttracerutils.c tracing: add hooks when objects or miniobjects are created and destroyed 2016-06-02 23:10:44 +01:00
gsttracerutils.h tracing: add hooks when objects or miniobjects are created and destroyed 2016-06-02 23:10:44 +01:00
gsttypefind.c typefind: simplify registration code 2014-10-17 12:41:04 +02:00
gsttypefind.h docs: Fix typos in function/object descriptions 2013-12-07 17:11:12 +00:00
gsttypefindfactory.c docs: annotate C examples as such 2016-02-15 17:45:15 +00:00
gsttypefindfactory.h core: Add g_autoptr() support to all types 2015-12-14 12:06:55 -05:00
gsturi.c uri: unref instead of using _gst_uri_free() directly 2016-05-04 10:08:24 +03:00
gsturi.h miniobject, memory, uri: warn on unused return value of some funcs 2016-03-26 11:35:39 +00:00
gstutils.c utils: Add gst_pad_link_maybe_ghosting() for consistency 2016-06-08 12:12:28 +03:00
gstutils.h utils: Add gst_pad_link_maybe_ghosting() for consistency 2016-06-08 12:12:28 +03:00
gstvalue.c gstvalue: remove a half finishesh sentence in the docs 2016-01-20 10:02:37 +01:00
gstvalue.h gstvalue: Add GstFlagSet type 2015-05-25 16:23:33 +10:00
gstversion.h.in gstversion: Add missing include in .in file. 2015-08-15 13:26:12 +02:00
Makefile.am g-i: pass compiler env to g-ir-scanner 2016-05-24 00:40:27 +01:00
math-compat.h Fix FSF address 2012-11-03 20:44:48 +00:00