mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-11-18 07:47:17 +00:00
b9f7ab6052
This is a fix for a data race leading to: > GLib-CRITICAL: g_hash_table_foreach: > assertion 'version == hash_table->version' failed Identified sequence: * `rtp_session_on_timeout` acquires the lock on `session` and proceeds with its processing. * `rtp_session_process_rtcp` is called (debug log : received RTCP packet) and attempts to acquire the lock on `session`, which is still held by `rtp_session_on_timeout`. * as part of an hash table iterator, `rtp_session_on_timeout` transitively invokes `source_caps` which releases the lock on `session` so as to call `session->callbacks.caps`. * Since `rtp_session_process_rtcp` was waiting for the lock to be released, it succeeds in acquiring it and proceeds with `rtp_session_process_rr` which transitively calls `g_hash_table_insert` via `add_source`. * After `source_caps` re-acquires the lock and gives the control flow back to `rtp_session_on_timeout`, the hash table iterator is changed, resulting in the assertion failure. This commits copies `sess->ssrcs[sess->mask_idx]` and iterates on the copy so the iterator is not affected by a concurrent change due to the lock being released in the `source_caps` callback. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4585> |
||
|---|---|---|
| .. | ||
| gst-devtools | ||
| gst-docs | ||
| gst-editing-services | ||
| gst-examples | ||
| gst-integration-testsuites | ||
| gst-libav | ||
| gst-omx | ||
| gst-plugins-bad | ||
| gst-plugins-base | ||
| gst-plugins-good | ||
| gst-plugins-ugly | ||
| gst-python | ||
| gst-rtsp-server | ||
| gstreamer | ||
| gstreamer-sharp | ||
| gstreamer-vaapi | ||
| macos-bison-binary | ||
| packagefiles/pango-1.50.12 | ||
| win-flex-bison-binaries | ||
| win-nasm | ||
| avtp.wrap | ||
| bindinator.wrap | ||
| cairo.wrap | ||
| dav1d.wrap | ||
| dssim.wrap | ||
| dv.wrap | ||
| expat.wrap | ||
| fdk-aac.wrap | ||
| FFmpeg.wrap | ||
| fontconfig.wrap | ||
| freetype2.wrap | ||
| fribidi.wrap | ||
| gl-headers.wrap | ||
| glib-networking.wrap | ||
| glib.wrap | ||
| graphene.wrap | ||
| gst-plugins-rs.wrap | ||
| gtk-sharp.wrap | ||
| harfbuzz.wrap | ||
| json-glib.wrap | ||
| lame.wrap | ||
| libdrm.wrap | ||
| libffi.wrap | ||
| libjpeg-turbo.wrap | ||
| libmicrodns.wrap | ||
| libnice.wrap | ||
| libopenjp2.wrap | ||
| libpng.wrap | ||
| libpsl.wrap | ||
| libsoup.wrap | ||
| libwpe.wrap | ||
| libxml2.wrap | ||
| ogg.wrap | ||
| openh264.wrap | ||
| opus.wrap | ||
| orc.wrap | ||
| pango.wrap | ||
| pixman.wrap | ||
| proxy-libintl.wrap | ||
| pycairo.wrap | ||
| pygobject.wrap | ||
| sqlite3.wrap | ||
| vorbis.wrap | ||
| webrtc-audio-processing.wrap | ||
| wpebackend-fdo.wrap | ||
| x264.wrap | ||
| zlib.wrap | ||