Alicia Boya García 5fd3c8a16c qtdemux: Fix premature EOS when some files are played in push mode ... Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/2771 This EOS branch exists so that if a seek with a stop is made, qtdemux stops accepting bytes from the sink after the entire requested playback range is demuxed, as otherwise we could keep download content that is not being used. This patch fixes two flaws that were present in that EOS check: 1) A comparison was made between track time and movie time without conversion. This made the check trigger early in files with edit lists. This patch fixes this by converting the track PTS to movie PTS (stream time) for the check. 2) To avoid sending a EOS prematurely when the segment stop is within a GOP and B-frames are present, the check for EOS should only be done for keyframes. I gather this was already the intention with the existing code, but because it used `stream->on_keyframe` instead of the local variable `keyframe` the old code was checking if the *previous* frame was a keyframe. It's interesting to note that these two flaws in the old code mask each other in most cases: the track PTS will have reached the movie end PTS, but EOS would only be sent if the previous frame was a keyframe. A simple case where they wouldn't mask each other, reproducing the bug, is a sequence of 3 frame GOPs with structure I-B-P. The following validateflow tests have been added to future-proof the fix: * validate.test.mp4.qtdemux_ibpibp_non_frag_pull.default * validate.test.mp4.qtdemux_ibpibp_non_frag_push.default Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5021>		2023-07-26 19:14:43 +00:00
..
atoms.c	qtmux: fix byte order for opus extension	2023-06-19 14:31:55 +00:00
atoms.h	qtmux: add support for writing vpcC box for VP9	2022-10-28 00:06:07 +00:00
atomsrecovery.c
atomsrecovery.h
descriptors.c
descriptors.h
fourcc.h	qtdemux: Add support for SpeedHQ video codec	2023-05-19 07:16:03 +00:00
gstisoff.c	isoff: Fix earliest pts field parse issue	2022-08-23 10:59:56 +00:00
gstisoff.h
gstisomp4element.c	Replace gst-i18n-*.h with gi18n-lib.h	2022-04-19 18:01:06 +00:00
gstisomp4elements.h
gstqtmoovrecover.c
gstqtmoovrecover.h
gstqtmux-doc.c
gstqtmux-doc.h
gstqtmux.c	isomp4: Fix (E)AC-3 channel count handling	2023-06-02 19:07:58 +00:00
gstqtmux.h
GstQTMux.prs
gstqtmuxmap.c	isomp4: Add stream-format = (string) obu-stream to AV1 caps	2023-01-19 12:10:40 +02:00
gstqtmuxmap.h
gstrtpxqtdepay.c
gstrtpxqtdepay.h
isomp4-plugin.c	Replace gst-i18n-*.h with gi18n-lib.h	2022-04-19 18:01:06 +00:00
LEGAL
meson.build	meson: Call pkgconfig.generate in the loop where we declare plugins dependencies	2022-09-01 21:17:35 +00:00
properties.c
properties.h
qtatomparser.h
qtdemux-webvtt.c	qtdemux: Add support for wvtt (WebVTT) subtitles.	2021-10-19 08:56:58 +00:00
qtdemux-webvtt.h	qtdemux: Add support for wvtt (WebVTT) subtitles.	2021-10-19 08:56:58 +00:00
qtdemux.c	qtdemux: Fix premature EOS when some files are played in push mode	2023-07-26 19:14:43 +00:00
qtdemux.h	qtdemux: Add audio clipping meta when playing gapless m4a content	2023-05-03 08:47:55 +00:00
qtdemux_debug.h
qtdemux_dump.c	qtdemux: parse Opus and dOps as qtdemux nodes and add size checks	2023-06-19 14:31:55 +00:00
qtdemux_dump.h	qtdemux: parse Opus and dOps as qtdemux nodes and add size checks	2023-06-19 14:31:55 +00:00
qtdemux_lang.c
qtdemux_lang.h
qtdemux_tags.c	qtdemux: Add audio clipping meta when playing gapless m4a content	2023-05-03 08:47:55 +00:00
qtdemux_tags.h
qtdemux_tree.c
qtdemux_tree.h
qtdemux_types.c	qtdemux: parse Opus and dOps as qtdemux nodes and add size checks	2023-06-19 14:31:55 +00:00
qtdemux_types.h
qtpalette.h