mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-10-06 02:32:23 +00:00
a842daf05e
Original commit message from CVS: * docs/random/ds/element-checklist: Notes about gst_caps_to_string() * gst/registries/gstxmlregistry.c: (gst_xml_registry_save_caps): Fix memory leakage of gst_caps_to_string(). Use GST_PTR_FORMAT instead of gst_caps_to_string(): * gst/autoplug/gstsearchfuncs.c: (gst_autoplug_sp): * gst/autoplug/gstspideridentity.c: (spider_find_suggest), (gst_spider_identity_sink_loop_type_finding): * gst/elements/gsttypefind.c: (gst_type_find_element_have_type), (find_suggest): * gst/gstpad.c: (gst_pad_try_relink_filtered), (gst_pad_set_explicit_caps): * gst/parse/grammar.y:
35 lines
836 B
Text
35 lines
836 B
Text
|
|
This is a list of things to check in elements.
|
|
|
|
|
|
|
|
1. Add a "Element-Checklist-Version: 1" comment
|
|
|
|
This comment is to indicate which items on this checklist have been
|
|
checked, so that future checkers can skip things that you've already
|
|
carefully checked. This number should obviously be updated whenever
|
|
you do additional checks. Ideally, you should not do checks out of
|
|
order, but using "1, also 4-6" is acceptable.
|
|
|
|
|
|
2. Each pad should have a pad template
|
|
|
|
Create and register a pad template to the element class.
|
|
|
|
|
|
3. config.h
|
|
|
|
Make sure that each .c file includes config.h (conditionally on
|
|
HAVE_CONFIG_H). Make sure that each .h file does _not_ include
|
|
config.h.
|
|
|
|
|
|
|
|
|
|
|
|
other ideas:
|
|
|
|
- plugins should avoid using gst_caps_to_string() in debug statement.
|
|
They should use %"GST_PTR_FORMAT" instead. Check all usage for leaks.
|
|
|
|
|