mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-10-04 17:52:29 +00:00
a4d97f49e2
This fixes the reverse playback scenario when upstream is not fully parsing the stream and does not send every keyframe chain separately with the DISCONT flag on the keyframe. To explain this, let's suppose we have this stream: 0 1 2 3 4 5 6 7 8 K K K In most circumstances, the upstream parser will chain in the decoder the buffers in the following order: 6 7 8 3 4 5 0 1 2 D D D In this case, GstVideoDecoder will flush the parse queue every time it receives discont (D) and we will eventually get in the output queue: (flush here) 8 7 6 (flush here) 5 4 3 (flush here) 2 1 0 In case the upstream parser doesn't do this work, though, GstVideoDecoder will receive the whole stream at once and will flush the parse queue afterwards: 0 1 2 3 4 5 6 7 8 D During the flush, it will look backwards for keyframes and will decode in this order: 6 7 8 3 4 5 0 1 2 This is the same order that it would receive from upstream if upstream was parsing and looking for the keyframes, only that now there is no flushing of the output queue in between keyframes, which will result in the output queue looking like this: 2 1 0 6 5 3 8 7 6 This will confuse downstream obviously and will play incorrectly. This patch forces the decoder to flush the output queue every time it picks a new keyframe to decode, so it will end up decoding 6 7 8 and then flushing before picking 3 for decoding, so the output will get 8 7 6 before 6 5 3 and the video will play back correctly. https://bugzilla.gnome.org/show_bug.cgi?id=734441 |
||
|---|---|---|
| .. | ||
| allocators | ||
| app | ||
| audio | ||
| fft | ||
| pbutils | ||
| riff | ||
| rtp | ||
| rtsp | ||
| sdp | ||
| tag | ||
| video | ||
| gettext.h | ||
| glib-compat-private.h | ||
| gst-i18n-app.h | ||
| gst-i18n-plugin.h | ||
| Makefile.am | ||