mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-23 00:36:51 +00:00
Code Issues 1 Projects Releases Wiki Activity
gstreamer/subprojects/gst-integration-testsuites/testsuites
History
Enrique Ocaña González 92a4cfe20f qtdemux: Don't emit GstSegment correcting start time when in MSE mode 
When using qtdemux in a pipeline that should only work as a pure demuxer (not
for actual playback), qtdemux shouldn't emit new GstSegments to correct
the start time (jump to the future) to ensure that the user experiences no
playback delay. By doing so, it's generating the wrong segments when an append
of data from the past happens. When that happens, downstream elements such as
parsers (eg: aacparse) may clip those buffers laying before the GstSegment and
create problems on the GStreamer client app (eg: WebKit).

Getting buffers clipped out because of the wrong GstSegments started becoming
a problen when this commit was introduced:

ab6e49e9cc audioparsers: add back segment clipping to parsers that have lost it

This clipping makes test DASH shaka 35 from MVT tests[1] to fail in
WebKitGTK/WPE (at least) and can potentially cause a number of other problems
in the WebKit Media Source Extensions (MSE) code.

Note that this new behaviour of not emitting new GstSegments only makes sense
when qtdemux is being used as a pure demuxer and not as part of a regular
pipeline. This is why the variant field has been added. When equal to
VARIANT_MSE_BYTESTREAM, it will make qtdemux behave differently in push mode,
taking decisions that meet the expectations for an MSE-like processing mode.
This kind of tweaks have been done in the past for MSS streams, for instance.
That code has been refactored to use VARIANT_MSS_FRAGMENTED now, instead of
its own dedicated boolean flag.

Co-authored by: Alicia Boya García <ntrrgc@gmail.com>

...who suggested to use "variant: mse-bytestream" in the caps to identify that
mode, as proposed in her unmerged patch:

https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/467

[1] https://github.com/rdkcentral/mvt

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3867>
2023-02-06 12:42:49 +00:00
..
validate qtdemux: Don't emit GstSegment correcting start time when in MSE mode 2023-02-06 12:42:49 +00:00
__init__.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
adaptive.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
dashifutils.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
ges.py validate:launcher: Sync asset only when passing --sync 2021-10-06 17:00:54 +00:00
ges.testslist Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
ges_known_issues.py validate:launcher: Allow more flexible handling of flaky tests 2021-10-12 16:59:16 +00:00
gesextras.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
gesextras.testslist Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
testsuiteutils.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
testvector.json Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
validate.py validate:launcher: Sync asset only when passing --sync 2021-10-06 17:00:54 +00:00
validate.testslist qtdemux: Don't emit GstSegment correcting start time when in MSE mode 2023-02-06 12:42:49 +00:00
validate_known_issues.py validate: Handle testfiles that need an HTTP server 2022-10-05 20:29:22 +00:00
validateelements.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
validateextra.py Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00
validateextra.testslist Import gst-integration-testsuites 2021-09-24 16:29:33 -03:00