gstreamer/sys/v4l2
Thibault Saunier 7b7a809818 v4l2dec: Fix race when going from PAUSED to READY
Running `gst-validate-launcher -t validate.file.playback.change_state_intensive.vorbis_vp8_1_webm`
on odroid XU4 (s5p-mfc v4l2 driver) often leads to:

  ERROR:../subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c:215:gst_v4l2_video_dec_stop: assertion failed: (g_atomic_int_get (&self->processing) == FALSE)

This happens when the following race happens:

- T0: Main thread
- T1: Upstream streaming thread
- T2. v4l2dec processing thread)

[The decoder is in PAUSED state]

T0. The validate scenario runs `Executing (36/40) set-state: state=null repeat=40`
T1- The decoder handles a frame
T2- A decoded frame is push downstream
T2- Downstream returns FLUSHING as it is already flushing changing state
T2- The decoder stops its processing thread and sets `->processing = FALSE`
T1- The decoder handles another frame
T1- `->process` is FALSE so the decoder restarts its streaming thread
T0- In v4l2dec-> stop the processing thread is stopped
NOTE: At this point the processing thread loop never started.
T0- assertion failed: (g_atomic_int_get (&self->processing) == FALSE)

Here I am removing the whole ->processing logic to base it all on the
GstTask state to avoid duplicating the knowledge.

https://bugzilla.gnome.org/show_bug.cgi?id=778830
2017-04-07 11:31:03 -03:00
..
ext v4l2: Update kernel headers to latest from media tree 2015-06-08 17:56:48 -04:00
gstv4l2.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2allocator.c v4l2allocator: reference memory before the buffer is queued 2017-01-24 11:30:57 -05:00
gstv4l2allocator.h gstv4l2bufferpool: handle -EPIPE from DQBUF to signal EOS 2015-06-09 21:56:40 -04:00
gstv4l2bufferpool.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2bufferpool.h Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2colorbalance.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2colorbalance.h Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2deviceprovider.c v4l2: consistently check #ifdef HAVE_GUDEV instead of #if 2016-08-18 20:20:20 +01:00
gstv4l2deviceprovider.h pulse, v4l2: add missing G_END_DECLS in some places 2014-10-28 21:32:06 +00:00
gstv4l2object.c v4l2object: set streamparm for outputs that support it 2017-04-05 09:26:05 -04:00
gstv4l2object.h v4l2: Remove unused macro 2017-03-14 16:38:02 -04:00
gstv4l2radio.c v4l2: use opened device caps instead of physical device ones 2016-07-07 17:46:06 -04:00
gstv4l2radio.h Fix FSF address 2012-11-04 00:07:18 +00:00
gstv4l2sink.c v4l2sink: Block in preroll_wait on unlock 2017-04-05 09:05:03 -04:00
gstv4l2sink.h v4l2: De-duplicate caps probing between src and sink 2013-08-19 13:08:18 -04:00
gstv4l2src.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2src.h Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2transform.c v4l2: Add an error return to _try/_set_format 2016-06-07 17:02:43 -04:00
gstv4l2transform.h v4l2transform: Check if caps have changes before asserting 2014-05-08 15:56:36 -04:00
gstv4l2tuner.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2tuner.h Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2videodec.c v4l2dec: Fix race when going from PAUSED to READY 2017-04-07 11:31:03 -03:00
gstv4l2videodec.h v4l2dec: Fix race when going from PAUSED to READY 2017-04-07 11:31:03 -03:00
gstv4l2vidorient.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
gstv4l2vidorient.h Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
Makefile.am Rename GstDeviceMonitor to GstDeviceProvider 2014-06-26 14:57:36 -04:00
meson.build v4l2: Fix meson plugin shared object name 2017-03-17 20:59:44 -04:00
README Fix level for multi-channel case. 2007-02-22 14:35:28 +00:00
tuner.c v4l2: Use G_DEFINE_ macros for added thread safety 2013-08-19 12:48:35 -04:00
tuner.h v4l2: remove unused enumtypes and use generic marshaller 2013-08-04 11:03:49 +01:00
tunerchannel.c v4l2: Use G_DEFINE_ macros for added thread safety 2013-08-19 12:48:35 -04:00
tunerchannel.h Fix FSF address 2012-11-04 00:07:18 +00:00
tunernorm.c v4l2: Use G_DEFINE_ macros for added thread safety 2013-08-19 12:48:35 -04:00
tunernorm.h Fix FSF address 2012-11-04 00:07:18 +00:00
v4l2-utils.c v4l2: consistently check #ifdef HAVE_GUDEV instead of #if 2016-08-18 20:20:20 +01:00
v4l2-utils.h v4l2-util: Introduce GstV4l2Error 2016-06-07 17:02:34 -04:00
v4l2_calls.c Update Edgard Lima's email 2017-02-27 00:34:19 +00:00
v4l2_calls.h Update Edgard Lima's email 2017-02-27 00:34:19 +00:00

v4l2 plugins
============

The idea is a bit the same as the idea for the v4l1 plugins. We want
one generic v4l2element, and a few child objects (probably only two:
v4l2src and v4l2sink):

                /-------- v4l2src
v4l2element ---=
                \-------- v4l2sink

Both v4l2src and v4l2sink have a uncompressed and a compressed
recording-/playback-mode. Since this is all part of v4l2, the 'client'
of these elements, i.e. an application using v4l2src/v4l2sink, will
hardly notice this. All capsnego stuff is done inside, and the plugin
knows which formats are compressed and which are not.

Please note that the v4l1 and the v4l2 plugins are *not* compatible
concerning properties. Naming has been kept the same where possible,
but in some cases, properties had to be removed or added to make
full use of v4l2.

V4L2 API: http://linux.bytesex.org/v4l2/.
          http://v4l2spec.bytesex.org/
          /usr/include/linux/videodev2.h or

Kernel patches available from
          http://dl.bytesex.org/patches/.

Articles:
          http://lwn.net/Articles/203924/