mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-09-08 21:28:45 +00:00
GObject may crash if two threads do concurrent g_object_notify() on the same object. This may happen if fakesink receives an out-of-band event such as FLUSH_START while processing a buffer or serialised event in the streaming thread. Since this may happen with the default settings during a common operation like a seek, and there seems to be little chance of a timely fix in GObject (see #166020), we should hack around this issue by protecting all of fakesink's direct g_object_notify() calls with a lock. Also add unit test for the above. Fixes #554460.
100 lines
3.2 KiB
C
100 lines
3.2 KiB
C
/* GStreamer
|
|
* Copyright (C) 1999,2000 Erik Walthinsen <omega@cse.ogi.edu>
|
|
* 2000 Wim Taymans <wtay@chello.be>
|
|
*
|
|
* gstfakesink.h:
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 02111-1307, USA.
|
|
*/
|
|
|
|
|
|
#ifndef __GST_FAKE_SINK_H__
|
|
#define __GST_FAKE_SINK_H__
|
|
|
|
#include <gst/gst.h>
|
|
#include <gst/base/gstbasesink.h>
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
|
|
#define GST_TYPE_FAKE_SINK \
|
|
(gst_fake_sink_get_type())
|
|
#define GST_FAKE_SINK(obj) \
|
|
(G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_FAKE_SINK,GstFakeSink))
|
|
#define GST_FAKE_SINK_CLASS(klass) \
|
|
(G_TYPE_CHECK_CLASS_CAST((klass),GST_TYPE_FAKE_SINK,GstFakeSinkClass))
|
|
#define GST_IS_FAKE_SINK(obj) \
|
|
(G_TYPE_CHECK_INSTANCE_TYPE((obj),GST_TYPE_FAKE_SINK))
|
|
#define GST_IS_FAKE_SINK_CLASS(klass) \
|
|
(G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_FAKE_SINK))
|
|
#define GST_FAKE_SINK_CAST(obj) ((GstFakeSink *)obj)
|
|
|
|
/**
|
|
* GstFakeSinkStateError:
|
|
* @FAKE_SINK_STATE_ERROR_NONE: no error
|
|
* @FAKE_SINK_STATE_ERROR_NULL_READY: cause the NULL to READY state change to fail
|
|
* @FAKE_SINK_STATE_ERROR_READY_PAUSED: cause the READY to PAUSED state change to fail:
|
|
* @FAKE_SINK_STATE_ERROR_PAUSED_PLAYING: cause the PAUSED to PLAYING state change to fail:
|
|
* @FAKE_SINK_STATE_ERROR_PLAYING_PAUSED: cause the PLAYING to PAUSED state change to fail:
|
|
* @FAKE_SINK_STATE_ERROR_PAUSED_READY: cause the PAUSED to READY state change to fail:
|
|
* @FAKE_SINK_STATE_ERROR_READY_NULL: cause the READY to NULL state change to fail:
|
|
*
|
|
* Possible state change errors for the state-error property.
|
|
*/
|
|
typedef enum {
|
|
FAKE_SINK_STATE_ERROR_NONE = 0,
|
|
FAKE_SINK_STATE_ERROR_NULL_READY,
|
|
FAKE_SINK_STATE_ERROR_READY_PAUSED,
|
|
FAKE_SINK_STATE_ERROR_PAUSED_PLAYING,
|
|
FAKE_SINK_STATE_ERROR_PLAYING_PAUSED,
|
|
FAKE_SINK_STATE_ERROR_PAUSED_READY,
|
|
FAKE_SINK_STATE_ERROR_READY_NULL
|
|
} GstFakeSinkStateError;
|
|
|
|
typedef struct _GstFakeSink GstFakeSink;
|
|
typedef struct _GstFakeSinkClass GstFakeSinkClass;
|
|
|
|
/**
|
|
* GstFakeSink:
|
|
*
|
|
* The opaque #GstFakeSink data structure.
|
|
*/
|
|
struct _GstFakeSink {
|
|
GstBaseSink element;
|
|
|
|
gboolean silent;
|
|
gboolean dump;
|
|
gboolean signal_handoffs;
|
|
GstFakeSinkStateError state_error;
|
|
gchar *last_message;
|
|
gint num_buffers;
|
|
gint num_buffers_left;
|
|
GStaticRecMutex notify_lock;
|
|
};
|
|
|
|
struct _GstFakeSinkClass {
|
|
GstBaseSinkClass parent_class;
|
|
|
|
/* signals */
|
|
void (*handoff) (GstElement *element, GstBuffer *buf, GstPad *pad);
|
|
void (*preroll_handoff) (GstElement *element, GstBuffer *buf, GstPad *pad);
|
|
};
|
|
|
|
GType gst_fake_sink_get_type (void);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* __GST_FAKE_SINK_H__ */
|