mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-06-30 11:50:38 +00:00
5ef2ce69ff
While testing the [implementation for insertable streams] in `webrtcsink` & `webrtcsrc`, I encountered critical warnings, which turned out to result from two race conditions in `rtpsession`. Both race conditions produce: > GLib-CRITICAL: g_hash_table_foreach: > assertion 'version == hash_table->version' failed This commit fixes one of the race conditions observed. In its simplest form, the test consists in 2 pipelines and a Signalling server: * pipelines_sink: audiotestsrc ! webrtcsink * pipelines_src: webrtcsrc ! appsrc 1. Set `pipelines_sink` to `Playing`. 2. The Signalling server delivers the `producer_id`. 3. Initialize `pipelines_src` to establish a session with `producer_id`. 4. Set `pipelines_src` to `Playing`. 5. Wait for a buffer to be received by the `appsrc`. 6. Set `pipelines_src` to `Null`. 7. Set `pipelines_sink` to `Null`. The race condition happens in the following sequence: * `webrtcsink` runs a task to periodically retrieve statistics from `webrtcbin`. This transitively ends up executing `rtp_session_create_stats`. * `pipelines_sink` is set to `Null`. * In `Paused` to `Ready`, `gst_rtp_session_change_state()` calls `rtp_session_reset()`. * The assertion failure occurs when `rtp_session_reset` is called while `rtp_session_create_stats` is executing. This is because `rtp_session_create_stats` acquires the lock on `session` prior to calling `g_hash_table_foreach`, but `rtp_session_reset` doesn't acquire the lock before calling `g_hash_table_remove_all`. Acquiring the lock in `rtp_session_reset` fixes the issue. [implementing insertable streams support]: https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1176 Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4528> |
||
|---|---|---|
| .. | ||
| gst-devtools | ||
| gst-docs | ||
| gst-editing-services | ||
| gst-examples | ||
| gst-integration-testsuites | ||
| gst-libav | ||
| gst-omx | ||
| gst-plugins-bad | ||
| gst-plugins-base | ||
| gst-plugins-good | ||
| gst-plugins-ugly | ||
| gst-python | ||
| gst-rtsp-server | ||
| gstreamer | ||
| gstreamer-sharp | ||
| gstreamer-vaapi | ||
| macos-bison-binary | ||
| packagefiles/pango-1.50.12 | ||
| win-flex-bison-binaries | ||
| win-nasm | ||
| avtp.wrap | ||
| bindinator.wrap | ||
| cairo.wrap | ||
| dav1d.wrap | ||
| dssim.wrap | ||
| dv.wrap | ||
| expat.wrap | ||
| fdk-aac.wrap | ||
| FFmpeg.wrap | ||
| fontconfig.wrap | ||
| freetype2.wrap | ||
| fribidi.wrap | ||
| gl-headers.wrap | ||
| glib-networking.wrap | ||
| glib.wrap | ||
| graphene.wrap | ||
| gst-plugins-rs.wrap | ||
| gtk-sharp.wrap | ||
| gtk.wrap | ||
| harfbuzz.wrap | ||
| json-glib.wrap | ||
| lame.wrap | ||
| libdrm.wrap | ||
| libffi.wrap | ||
| libgudev.wrap | ||
| libjpeg-turbo.wrap | ||
| libmicrodns.wrap | ||
| libnice.wrap | ||
| libopenjp2.wrap | ||
| libpng.wrap | ||
| libpsl.wrap | ||
| libsoup.wrap | ||
| libsrtp2.wrap | ||
| libwpe.wrap | ||
| libxml2.wrap | ||
| ogg.wrap | ||
| openh264.wrap | ||
| opus.wrap | ||
| orc.wrap | ||
| pango.wrap | ||
| pixman.wrap | ||
| proxy-libintl.wrap | ||
| pycairo.wrap | ||
| pygobject.wrap | ||
| sqlite3.wrap | ||
| vorbis.wrap | ||
| webrtc-audio-processing.wrap | ||
| wpebackend-fdo.wrap | ||
| x264.wrap | ||
| zlib.wrap | ||