mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-09-23 04:20:17 +00:00
346b077ae0
This is ad adaptation of a Pexip patch for dealing with spurious GstRTPPacketLost events caused by lost ulpfec packets: as FEC packets under that scheme are spliced in the same sequence domain as the media packets, it is not generally possible to determine whether a lost packet was a FEC packet or a media packet. When upstreaming pexip's ulpfec patches, we decided to drop all lost events at the base depayloader level, and where the original patch from pexip was making use of picture ids and marker bits to determine whether a packet should be forwarded, this patch makes use of those to determine whether they should be dropped instead (by removing their might-have-been-fec field). Spurious lost events coming out of the depayloader can cause the decoder to stop decoding until the next keyframe and / or request a new keyframe, and while this is not desirable it makes sense to forward that information when we have other means to determine whether a lost packet was indeed a FEC packet, as is the case with VP8 / VP9 payloads when they carry a picture id. Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/769>
362 lines
12 KiB
C
362 lines
12 KiB
C
/* GStreamer
|
|
*
|
|
* Copyright (C) 2016 Pexip AS
|
|
* @author Stian Selnes <stian@pexip.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#include <gst/check/check.h>
|
|
#include <gst/check/gstharness.h>
|
|
|
|
#define RTP_VP9_CAPS_STR \
|
|
"application/x-rtp,media=video,encoding-name=VP9,clock-rate=90000,payload=96"
|
|
|
|
GST_START_TEST (test_depay_flexible_mode)
|
|
{
|
|
/* b-bit, e-bit, f-bit and marker bit set */
|
|
/* First packet of first frame, handcrafted to also set the e-bit and marker
|
|
* bit in addition to changing the seqnum */
|
|
guint8 intra[] = {
|
|
0x80, 0xf4, 0x00, 0x00, 0x49, 0xb5, 0xbe, 0x32, 0xb1, 0x01, 0x64, 0xd1,
|
|
0xbc, 0x98, 0xbf, 0x00, 0x83, 0x49, 0x83, 0x42, 0x00, 0x77, 0xf0, 0x43,
|
|
0x71, 0xd8, 0xe0, 0x90, 0x70, 0x66, 0x80, 0x60, 0x0e, 0xf0, 0x5f, 0xfd,
|
|
};
|
|
/* b-bit, e-bit, p-bit, f-bit and marker bit set */
|
|
/* First packet of second frame, handcrafted to also set the e-bit and
|
|
* marker bit in addition to changing the seqnum */
|
|
guint8 inter[] = {
|
|
0x80, 0xf4, 0x00, 0x01, 0x49, 0xb6, 0x02, 0xc0, 0xb1, 0x01, 0x64, 0xd1,
|
|
0xfc, 0x98, 0xc0, 0x00, 0x02, 0x87, 0x01, 0x00, 0x09, 0x3f, 0x1c, 0x12,
|
|
0x0e, 0x0c, 0xd0, 0x1b, 0xa7, 0x80, 0x80, 0xb0, 0x18, 0x0f, 0xda, 0x11,
|
|
};
|
|
|
|
GstHarness *h = gst_harness_new ("rtpvp9depay");
|
|
gst_harness_set_src_caps_str (h, RTP_VP9_CAPS_STR);
|
|
|
|
gst_harness_push (h, gst_buffer_new_wrapped_full (GST_MEMORY_FLAG_READONLY,
|
|
intra, sizeof (intra), 0, sizeof (intra), NULL, NULL));
|
|
fail_unless_equals_int (1, gst_harness_buffers_received (h));
|
|
|
|
gst_harness_push (h, gst_buffer_new_wrapped_full (GST_MEMORY_FLAG_READONLY,
|
|
inter, sizeof (inter), 0, sizeof (inter), NULL, NULL));
|
|
fail_unless_equals_int (2, gst_harness_buffers_received (h));
|
|
|
|
gst_harness_teardown (h);
|
|
}
|
|
|
|
GST_END_TEST;
|
|
|
|
GST_START_TEST (test_depay_non_flexible_mode)
|
|
{
|
|
/* b-bit, e-bit and marker bit set. f-bit NOT set */
|
|
/* First packet of first frame, handcrafted to also set the e-bit and marker
|
|
* bit in addition to changing the seqnum */
|
|
guint8 intra[] = {
|
|
0x80, 0xf4, 0x00, 0x00, 0x49, 0x88, 0xd9, 0xf8, 0xa0, 0x6c, 0x65, 0x6c,
|
|
0x8c, 0x98, 0xc0, 0x87, 0x01, 0x02, 0x49, 0x3f, 0x1c, 0x12, 0x0e, 0x0c,
|
|
0xd0, 0x1b, 0xb9, 0x80, 0x80, 0xb0, 0x18, 0x0f, 0xa6, 0x4d, 0x01, 0xa5
|
|
};
|
|
/* b-bit, e-bit, p-bit and marker bit set. f-bit NOT set */
|
|
/* First packet of second frame, handcrafted to also set the e-bit and
|
|
* marker bit in addition to changing the seqnum */
|
|
guint8 inter[] = {
|
|
0x80, 0xf4, 0x00, 0x01, 0x49, 0x88, 0xe5, 0x38, 0xa0, 0x6c, 0x65, 0x6c,
|
|
0xcc, 0x98, 0xc1, 0x87, 0x01, 0x02, 0x49, 0x3f, 0x1c, 0x12, 0x0e, 0x0c,
|
|
0xd0, 0x1b, 0x97, 0x80, 0x80, 0xb0, 0x18, 0x0f, 0x8a, 0x9f, 0x01, 0xbc
|
|
};
|
|
|
|
GstHarness *h = gst_harness_new ("rtpvp9depay");
|
|
gst_harness_set_src_caps_str (h, RTP_VP9_CAPS_STR);
|
|
|
|
gst_harness_push (h, gst_buffer_new_wrapped_full (GST_MEMORY_FLAG_READONLY,
|
|
intra, sizeof (intra), 0, sizeof (intra), NULL, NULL));
|
|
fail_unless_equals_int (1, gst_harness_buffers_received (h));
|
|
|
|
gst_harness_push (h, gst_buffer_new_wrapped_full (GST_MEMORY_FLAG_READONLY,
|
|
inter, sizeof (inter), 0, sizeof (inter), NULL, NULL));
|
|
fail_unless_equals_int (2, gst_harness_buffers_received (h));
|
|
|
|
gst_harness_teardown (h);
|
|
}
|
|
|
|
GST_END_TEST;
|
|
|
|
static guint8 intra_picid6336_seqnum0[] = {
|
|
0x80, 0xf4, 0x00, 0x00, 0x49, 0x88, 0xd9, 0xf8, 0xa0, 0x6c, 0x65, 0x6c,
|
|
0x8c, 0x98, 0xc0, 0x87, 0x01, 0x02, 0x49, 0x3f, 0x1c, 0x12, 0x0e, 0x0c,
|
|
0xd0, 0x1b, 0xb9, 0x80, 0x80, 0xb0, 0x18, 0x0f, 0xa6, 0x4d, 0x01, 0xa5
|
|
};
|
|
|
|
static guint8 intra_picid24_seqnum0[] = {
|
|
0x80, 0xf4, 0x00, 0x00, 0x49, 0x88, 0xd9, 0xf8, 0xa0, 0x6c, 0x65, 0x6c,
|
|
0x8c, 0x18, 0x87, 0x01, 0x02, 0x49, 0x3f, 0x1c, 0x12, 0x0e, 0x0c,
|
|
0xd0, 0x1b, 0xb9, 0x80, 0x80, 0xb0, 0x18, 0x0f, 0xa6, 0x4d, 0x01, 0xa5
|
|
};
|
|
|
|
static guint8 intra_nopicid_seqnum0[] = {
|
|
0x80, 0xf4, 0x00, 0x00, 0x49, 0x88, 0xd9, 0xf8, 0xa0, 0x6c, 0x65, 0x6c,
|
|
0x0c, 0x87, 0x01, 0x02, 0x49, 0x3f, 0x1c, 0x12, 0x0e, 0x0c,
|
|
0xd0, 0x1b, 0xb9, 0x80, 0x80, 0xb0, 0x18, 0x0f, 0xa6, 0x4d, 0x01, 0xa5
|
|
};
|
|
|
|
enum
|
|
{
|
|
BT_PLAIN_PICID_NONE,
|
|
BT_PLAIN_PICID_7,
|
|
BT_PLAIN_PICID_15,
|
|
/* Commented out for now, until added VP9 equvivalents.
|
|
BT_TS_PICID_NONE,
|
|
BT_TS_PICID_7,
|
|
BT_TS_PICID_15,
|
|
BT_TS_PICID_7_NO_TLOPICIDX,
|
|
BT_TS_PICID_7_NO_TID_Y_KEYIDX
|
|
*/
|
|
};
|
|
|
|
static GstBuffer *
|
|
create_rtp_vp9_buffer_full (guint seqnum, guint picid, guint buffer_type,
|
|
GstClockTime buf_pts, gboolean B_bit_start_of_frame, gboolean marker_bit)
|
|
{
|
|
static struct BufferTemplate
|
|
{
|
|
guint8 *template;
|
|
gsize size;
|
|
gint picid_bits;
|
|
} templates[] = {
|
|
{
|
|
intra_nopicid_seqnum0, sizeof (intra_nopicid_seqnum0), 0}
|
|
, {
|
|
intra_picid24_seqnum0, sizeof (intra_picid24_seqnum0), 7}
|
|
, {
|
|
intra_picid6336_seqnum0, sizeof (intra_picid6336_seqnum0), 15}
|
|
,
|
|
/*
|
|
{ intra_nopicid_seqnum0_tl1_sync_tl0picidx12,
|
|
sizeof (intra_nopicid_seqnum0_tl1_sync_tl0picidx12),
|
|
0
|
|
},
|
|
{ intra_picid24_seqnum0_tl1_sync_tl0picidx12,
|
|
sizeof (intra_picid24_seqnum0_tl1_sync_tl0picidx12),
|
|
7
|
|
},
|
|
{ intra_picid6336_seqnum0_tl1_sync_tl0picidx12,
|
|
sizeof (intra_picid6336_seqnum0_tl1_sync_tl0picidx12),
|
|
15
|
|
},
|
|
{ intra_picid24_seqnum0_tl1_sync_no_tl0picidx,
|
|
sizeof (intra_picid24_seqnum0_tl1_sync_no_tl0picidx),
|
|
7
|
|
},
|
|
{ intra_picid24_seqnum0_notyk_tl0picidx12,
|
|
sizeof (intra_picid24_seqnum0_notyk_tl0picidx12),
|
|
7
|
|
}
|
|
*/
|
|
};
|
|
struct BufferTemplate *template = &templates[buffer_type];
|
|
guint8 *packet = g_memdup (template->template, template->size);
|
|
GstBuffer *ret;
|
|
|
|
packet[2] = (seqnum >> 8) & 0xff;
|
|
packet[3] = (seqnum >> 0) & 0xff;
|
|
|
|
/* We're forcing the E-bit (EndOfFrame) together with the RTP marker bit here, which is a bit of a hack.
|
|
* If we're to enable spatial scalability tests, we need to take that into account when setting the E bit.
|
|
*/
|
|
if (marker_bit) {
|
|
packet[1] |= 0x80;
|
|
packet[12] |= 0x4;
|
|
} else {
|
|
packet[1] &= ~0x80;
|
|
packet[12] &= ~0x4;
|
|
}
|
|
|
|
if (B_bit_start_of_frame)
|
|
packet[12] |= 0x8;
|
|
else
|
|
packet[12] &= ~0x8;
|
|
|
|
if (template->picid_bits == 7) {
|
|
/* Prerequisites for this to be correct:
|
|
((packet[12] & 0x80) == 0x80); I bit set
|
|
*/
|
|
g_assert ((packet[12] & 0x80) == 0x80);
|
|
packet[13] = picid & 0x7f;
|
|
|
|
} else if (template->picid_bits == 15) {
|
|
/* Prerequisites for this to be correct:
|
|
((packet[12] & 0x80) == 0x80); I bit set
|
|
*/
|
|
g_assert ((packet[12] & 0x80) == 0x80);
|
|
packet[13] = ((picid >> 8) & 0xff) | 0x80;
|
|
packet[14] = (picid >> 0) & 0xff;
|
|
}
|
|
|
|
ret = gst_buffer_new_wrapped (packet, template->size);
|
|
GST_BUFFER_PTS (ret) = buf_pts;
|
|
return ret;
|
|
}
|
|
|
|
static GstBuffer *
|
|
create_rtp_vp9_buffer (guint seqnum, guint picid, guint buffer_type,
|
|
GstClockTime buf_pts)
|
|
{
|
|
return create_rtp_vp9_buffer_full (seqnum, picid, buffer_type, buf_pts, TRUE,
|
|
TRUE);
|
|
}
|
|
|
|
typedef struct _DepayGapEventTestData
|
|
{
|
|
gint seq_num;
|
|
gint picid;
|
|
guint buffer_type;
|
|
} DepayGapEventTestData;
|
|
|
|
typedef struct
|
|
{
|
|
gint seq_num;
|
|
gint picid;
|
|
guint buffer_type;
|
|
gboolean s_bit;
|
|
gboolean marker_bit;
|
|
} DepayGapEventTestDataFull;
|
|
|
|
static void
|
|
test_depay_gap_event_base (const DepayGapEventTestData * data,
|
|
gboolean send_lost_event, gboolean expect_gap_event, int iter)
|
|
{
|
|
GstEvent *event;
|
|
GstClockTime pts = 0;
|
|
GstHarness *h = gst_harness_new ("rtpvp9depay");
|
|
if (send_lost_event == FALSE && expect_gap_event) {
|
|
/* Expect picture ID gaps to be concealed, so tell the element to do so. */
|
|
g_object_set (h->element, "hide-picture-id-gap", TRUE, NULL);
|
|
}
|
|
gst_harness_set_src_caps_str (h, RTP_VP9_CAPS_STR);
|
|
|
|
gst_harness_push (h, create_rtp_vp9_buffer (data[0].seq_num, data[0].picid,
|
|
data[0].buffer_type, pts));
|
|
pts += 33 * GST_MSECOND;
|
|
|
|
/* Preparation before pushing gap event. Getting rid of all events which
|
|
* came by this point - segment, caps, etc */
|
|
for (gint i = 0; i < 3; i++)
|
|
gst_event_unref (gst_harness_pull_event (h));
|
|
fail_unless_equals_int (gst_harness_events_in_queue (h), 0);
|
|
|
|
if (send_lost_event) {
|
|
gst_harness_push_event (h,
|
|
gst_event_new_custom (GST_EVENT_CUSTOM_DOWNSTREAM,
|
|
gst_structure_new ("GstRTPPacketLost", "timestamp", G_TYPE_UINT64,
|
|
pts, "duration", G_TYPE_UINT64, 33 * GST_MSECOND,
|
|
"might-have-been-fec", G_TYPE_BOOLEAN, TRUE, NULL)));
|
|
pts += 33 * GST_MSECOND;
|
|
}
|
|
|
|
gst_harness_push (h, create_rtp_vp9_buffer (data[1].seq_num, data[1].picid,
|
|
data[1].buffer_type, pts));
|
|
fail_unless_equals_int (2, gst_harness_buffers_received (h));
|
|
|
|
if (expect_gap_event) {
|
|
gboolean noloss = FALSE;
|
|
|
|
/* Making sure the GAP event was pushed downstream */
|
|
event = gst_harness_pull_event (h);
|
|
fail_unless_equals_string ("gap",
|
|
gst_event_type_get_name (GST_EVENT_TYPE (event)));
|
|
gst_structure_get_boolean (gst_event_get_structure (event),
|
|
"no-packet-loss", &noloss);
|
|
|
|
/* If we didn't send GstRTPPacketLost event, the gap
|
|
* event should indicate that with 'no-packet-loss' parameter */
|
|
fail_unless_equals_int (noloss, !send_lost_event);
|
|
gst_event_unref (event);
|
|
}
|
|
|
|
fail_unless_equals_int (gst_harness_events_in_queue (h), 0);
|
|
|
|
gst_harness_teardown (h);
|
|
}
|
|
|
|
static const DepayGapEventTestData stop_gap_events_test_data[][2] = {
|
|
/* 7bit picture ids */
|
|
{{100, 24, BT_PLAIN_PICID_7}, {102, 25, BT_PLAIN_PICID_7}},
|
|
|
|
/* 15bit picture ids */
|
|
{{100, 250, BT_PLAIN_PICID_15}, {102, 251, BT_PLAIN_PICID_15}},
|
|
|
|
/* 7bit picture ids wrap */
|
|
{{100, 127, BT_PLAIN_PICID_7}, {102, 0, BT_PLAIN_PICID_7}},
|
|
|
|
/* 15bit picture ids wrap */
|
|
{{100, 32767, BT_PLAIN_PICID_15}, {102, 0, BT_PLAIN_PICID_15}},
|
|
|
|
/* 7bit to 15bit picture id */
|
|
{{100, 127, BT_PLAIN_PICID_7}, {102, 128, BT_PLAIN_PICID_15}},
|
|
};
|
|
|
|
GST_START_TEST (test_depay_stop_gap_events)
|
|
{
|
|
test_depay_gap_event_base (&stop_gap_events_test_data[__i__][0], TRUE, FALSE,
|
|
__i__);
|
|
}
|
|
|
|
GST_END_TEST;
|
|
|
|
/* Packet loss + lost picture ids */
|
|
static const DepayGapEventTestData resend_gap_event_test_data[][2] = {
|
|
/* 7bit picture ids */
|
|
{{100, 24, BT_PLAIN_PICID_7}, {102, 26, BT_PLAIN_PICID_7}},
|
|
|
|
/* 15bit picture ids */
|
|
{{100, 250, BT_PLAIN_PICID_15}, {102, 252, BT_PLAIN_PICID_15}},
|
|
|
|
/* 7bit picture ids wrap */
|
|
{{100, 127, BT_PLAIN_PICID_7}, {102, 1, BT_PLAIN_PICID_7}},
|
|
|
|
/* 15bit picture ids wrap */
|
|
{{100, 32767, BT_PLAIN_PICID_15}, {102, 1, BT_PLAIN_PICID_15}},
|
|
|
|
/* 7bit to 15bit picture id */
|
|
{{100, 126, BT_PLAIN_PICID_7}, {102, 129, BT_PLAIN_PICID_15}},
|
|
};
|
|
|
|
GST_START_TEST (test_depay_resend_gap_event)
|
|
{
|
|
test_depay_gap_event_base (&resend_gap_event_test_data[__i__][0], TRUE, TRUE,
|
|
__i__);
|
|
}
|
|
|
|
GST_END_TEST;
|
|
|
|
static Suite *
|
|
rtpvp9_suite (void)
|
|
{
|
|
Suite *s = suite_create ("rtpvp9");
|
|
TCase *tc_chain;
|
|
suite_add_tcase (s, (tc_chain = tcase_create ("vp9depay")));
|
|
tcase_add_test (tc_chain, test_depay_flexible_mode);
|
|
tcase_add_test (tc_chain, test_depay_non_flexible_mode);
|
|
tcase_add_loop_test (tc_chain, test_depay_stop_gap_events, 0,
|
|
G_N_ELEMENTS (stop_gap_events_test_data));
|
|
tcase_add_loop_test (tc_chain, test_depay_resend_gap_event, 0,
|
|
G_N_ELEMENTS (resend_gap_event_test_data));
|
|
|
|
return s;
|
|
}
|
|
|
|
GST_CHECK_MAIN (rtpvp9);
|