mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-11-26 03:31:05 +00:00
32fbad8d39
A race condition can occur in `srtpdec` during the READY -> NULL transition: an RTCP buffer can make its way to `gst_srtp_dec_chain` while the element is partially stopped, resulting in the following critical warning: > Got data flow before segment event The problematic sequence is the following: 1. An RTCP buffer is being handled by the chain function for the `rtcp_sinkpad`. Since, this is the first buffer, we try pushing the sticky events to `rtcp_srcpad`. 2. At the same moment, the element is being transitioned from PAUSED to READY. 3. While checking and pushing the sticky events for `rtcp_srcpad`, we reach the Segment event. For this, we try to get it from the "otherpad", in this case `rtp_srcpad`. In the problematic case, `rtp_srcpad` has already been deactivated so its sticky events have been cleared. We won't be pushing any Segment event to `rtcp_srcpad`. 4. We return to the chain function for `rtcp_sinkpad` and try pushing the buffer to `rtcp_srcpad` for which deactivation hasn't started yet, hence the "Got data flow before segment event". This commit: - Adds a boolean return value to `gst_srtp_dec_push_early_events`: in case the Segment event can't be retrieved, `gst_srtp_dec_chain` can return an error instead of calling `gst_pad_push`. - Replaces the obsolete `gst_pad_set_caps` with `gst_pad_push_event`. The additional preconditions checked by previous function are guaranteed here since we push a fixed Caps which was built in the same function. Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4844> |
||
|---|---|---|
| .. | ||
| gst-devtools | ||
| gst-docs | ||
| gst-editing-services | ||
| gst-examples | ||
| gst-integration-testsuites | ||
| gst-libav | ||
| gst-omx | ||
| gst-plugins-bad | ||
| gst-plugins-base | ||
| gst-plugins-good | ||
| gst-plugins-ugly | ||
| gst-python | ||
| gst-rtsp-server | ||
| gstreamer | ||
| gstreamer-sharp | ||
| gstreamer-vaapi | ||
| macos-bison-binary | ||
| packagefiles/pango-1.50.12 | ||
| win-flex-bison-binaries | ||
| win-nasm | ||
| avtp.wrap | ||
| bindinator.wrap | ||
| cairo.wrap | ||
| dav1d.wrap | ||
| dssim.wrap | ||
| dv.wrap | ||
| expat.wrap | ||
| fdk-aac.wrap | ||
| FFmpeg.wrap | ||
| fontconfig.wrap | ||
| freetype2.wrap | ||
| fribidi.wrap | ||
| gl-headers.wrap | ||
| glib-networking.wrap | ||
| glib.wrap | ||
| graphene.wrap | ||
| gst-plugins-rs.wrap | ||
| gtk-sharp.wrap | ||
| gtk.wrap | ||
| harfbuzz.wrap | ||
| json-glib.wrap | ||
| lame.wrap | ||
| libdrm.wrap | ||
| libffi.wrap | ||
| libgudev.wrap | ||
| libjpeg-turbo.wrap | ||
| libmicrodns.wrap | ||
| libnice.wrap | ||
| libopenjp2.wrap | ||
| libpng.wrap | ||
| libpsl.wrap | ||
| libsoup.wrap | ||
| libsrtp2.wrap | ||
| libva.wrap | ||
| libwpe.wrap | ||
| libxml2.wrap | ||
| ogg.wrap | ||
| openh264.wrap | ||
| opus.wrap | ||
| orc.wrap | ||
| pango.wrap | ||
| pixman.wrap | ||
| proxy-libintl.wrap | ||
| pycairo.wrap | ||
| pygobject.wrap | ||
| sqlite3.wrap | ||
| vorbis.wrap | ||
| webrtc-audio-processing.wrap | ||
| wpebackend-fdo.wrap | ||
| x264.wrap | ||
| zlib.wrap | ||