mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-09-19 10:30:30 +00:00
aafa59f01e
Because the decoder uses the thread from handle_frame() to decode a frame, the src pad task creates an unsolveable AB-BA deadlock between handle_frame() waiting for a free surface and decode_loop() pushing decoded frames out. Instead, have handle_frame() take responsibility for pushing surfaces, and remove the deadlock completely. If you need a separate thread downstream, you can insert a queue between vaapidecode and its downstream to get one. Another justification for the single thread implementation is, there are two many point of locking in gstreamer-vaapi's current implementation which can lead to deadlocks. https://bugzilla.gnome.org/show_bug.cgi?id=742605 Signed-off-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk> Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com> Signed-off-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
88 lines
2.9 KiB
C
88 lines
2.9 KiB
C
/*
|
|
* gstvaapidecode.h - VA-API video decoder
|
|
*
|
|
* Copyright (C) 2010-2011 Splitted-Desktop Systems
|
|
* Author: Gwenole Beauchesne <gwenole.beauchesne@splitted-desktop.com>
|
|
* Copyright (C) 2011-2013 Intel Corporation
|
|
* Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public License
|
|
* as published by the Free Software Foundation; either version 2.1
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free
|
|
* Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#ifndef GST_VAAPIDECODE_H
|
|
#define GST_VAAPIDECODE_H
|
|
|
|
#include "gstvaapipluginbase.h"
|
|
#include <gst/vaapi/gstvaapidecoder.h>
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
#define GST_TYPE_VAAPIDECODE \
|
|
(gst_vaapidecode_get_type())
|
|
|
|
#define GST_VAAPIDECODE(obj) \
|
|
(G_TYPE_CHECK_INSTANCE_CAST((obj), \
|
|
GST_TYPE_VAAPIDECODE, \
|
|
GstVaapiDecode))
|
|
|
|
#define GST_VAAPIDECODE_CLASS(klass) \
|
|
(G_TYPE_CHECK_CLASS_CAST((klass), \
|
|
GST_TYPE_VAAPIDECODE, \
|
|
GstVaapiDecodeClass))
|
|
|
|
#define GST_IS_VAAPIDECODE(obj) \
|
|
(G_TYPE_CHECK_INSTANCE_TYPE((obj), GST_TYPE_VAAPIDECODE))
|
|
|
|
#define GST_IS_VAAPIDECODE_CLASS(klass) \
|
|
(G_TYPE_CHECK_CLASS_TYPE((klass), GST_TYPE_VAAPIDECODE))
|
|
|
|
#define GST_VAAPIDECODE_GET_CLASS(obj) \
|
|
(G_TYPE_INSTANCE_GET_CLASS((obj), \
|
|
GST_TYPE_VAAPIDECODE, \
|
|
GstVaapiDecodeClass))
|
|
|
|
typedef struct _GstVaapiDecode GstVaapiDecode;
|
|
typedef struct _GstVaapiDecodeClass GstVaapiDecodeClass;
|
|
|
|
struct _GstVaapiDecode {
|
|
/*< private >*/
|
|
GstVaapiPluginBase parent_instance;
|
|
|
|
GstCaps *sinkpad_caps;
|
|
GstCaps *srcpad_caps;
|
|
GstVaapiDecoder *decoder;
|
|
GMutex surface_ready_mutex;
|
|
GCond surface_ready;
|
|
GstCaps *decoder_caps;
|
|
GstCaps *allowed_caps;
|
|
guint current_frame_size;
|
|
guint has_texture_upload_meta : 1;
|
|
|
|
GstVideoCodecState *input_state;
|
|
volatile gboolean active;
|
|
};
|
|
|
|
struct _GstVaapiDecodeClass {
|
|
/*< private >*/
|
|
GstVaapiPluginBaseClass parent_class;
|
|
};
|
|
|
|
GType
|
|
gst_vaapidecode_get_type(void) G_GNUC_CONST;
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* GST_VAAPIDECODE_H */
|