mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-24 01:00:37 +00:00
Code Issues 1 Projects Releases Wiki Activity
gstreamer/gst/mpegtsdemux
History
Jan Alexander Steffens (heftig) 9b2ed3a3fc mpegtsdemux: Close a buffer leak and simplify input_done 
tsparse leaked input buffers quite badly:

    GST_TRACERS=leaks GST_DEBUG=GST_TRACER:9 gst-launch-1.0 audiotestsrc num-buffers=3 ! avenc_aac ! mpegtsmux ! tsparse ! fakesink

The input_done vfunc was passed the input buffer, which it had to
consume. For this reason, the base class takes a reference on the buffer
if and only if input_done is not NULL.

Before 34af8ed66a, input_done was used in
tsparse to pass on the input buffer on the "src" pad. That commit
changed the code to packetize for that pad as well and removed the use
of input_done.

Afterwards, 0d2e908523 set input_done
again in order to handle automatic alignment of the output buffers to
the input buffers. However, it ignored the provided buffer and did not
even unref it, causing a leak.

Since no code makes use of the buffer provided with input_done, just
remove the argument in order to simplify things a bit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1274>
2020-05-18 14:11:40 +00:00
..
gstmpegdefs.h tsdemux: Add support for AC4 2020-03-09 21:54:09 +00:00
gstmpegdesc.h tsdemux: Add format_identifier for AC4 codec 2020-03-10 16:32:59 +09:00
gsttsdemux.c mpegtsdemux: Update plugin license field 2014-02-06 14:28:54 +01:00
meson.build docs: Build documentation with hotdoc 2019-05-13 17:00:00 -04:00
mpegtsbase.c mpegtsdemux: Close a buffer leak and simplify input_done 2020-05-18 14:11:40 +00:00
mpegtsbase.h mpegtsdemux: Close a buffer leak and simplify input_done 2020-05-18 14:11:40 +00:00
mpegtspacketizer.c mpegtspacketizer: be more tolerant when parsing the adaptation field 2020-04-07 08:21:04 +00:00
mpegtspacketizer.h mpegtspacketizer: Fix typo in flag name 2020-01-29 20:39:44 +00:00
mpegtsparse.c mpegtsdemux: Close a buffer leak and simplify input_done 2020-05-18 14:11:40 +00:00
mpegtsparse.h tsparse: Add split-on-rai property 2020-02-11 10:56:54 +00:00
pesparse.c mpegtsdemux: Fix wrong usage of '<<' operator 2017-02-28 09:27:41 +01:00
pesparse.h tsdemux: fix overflow of packet_length field of PESHeader 2014-09-12 11:27:52 +02:00
TODO documentation: fixed a heap o' typos 2019-11-05 09:11:25 -05:00
tsdemux.c mpegtsdemux: Don't pretend doing NAL alignment 2020-04-14 11:36:16 -04:00
tsdemux.h tsdemux: Make latency configurable 2019-08-27 12:09:57 -04:00