mirror of
https://gitlab.freedesktop.org/gstreamer/gstreamer.git
synced 2024-07-15 10:48:16 +00:00
7b7a809818
Running `gst-validate-launcher -t validate.file.playback.change_state_intensive.vorbis_vp8_1_webm` on odroid XU4 (s5p-mfc v4l2 driver) often leads to: ERROR:../subprojects/gst-plugins-good/sys/v4l2/gstv4l2videodec.c:215:gst_v4l2_video_dec_stop: assertion failed: (g_atomic_int_get (&self->processing) == FALSE) This happens when the following race happens: - T0: Main thread - T1: Upstream streaming thread - T2. v4l2dec processing thread) [The decoder is in PAUSED state] T0. The validate scenario runs `Executing (36/40) set-state: state=null repeat=40` T1- The decoder handles a frame T2- A decoded frame is push downstream T2- Downstream returns FLUSHING as it is already flushing changing state T2- The decoder stops its processing thread and sets `->processing = FALSE` T1- The decoder handles another frame T1- `->process` is FALSE so the decoder restarts its streaming thread T0- In v4l2dec-> stop the processing thread is stopped NOTE: At this point the processing thread loop never started. T0- assertion failed: (g_atomic_int_get (&self->processing) == FALSE) Here I am removing the whole ->processing logic to base it all on the GstTask state to avoid duplicating the knowledge. https://bugzilla.gnome.org/show_bug.cgi?id=778830
87 lines
2.6 KiB
C
87 lines
2.6 KiB
C
/*
|
|
* Copyright (C) 2014 Collabora Ltd.
|
|
* Author: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef __GST_V4L2_VIDEO_DEC_H__
|
|
#define __GST_V4L2_VIDEO_DEC_H__
|
|
|
|
#include <gst/gst.h>
|
|
#include <gst/video/video.h>
|
|
#include <gst/video/gstvideodecoder.h>
|
|
#include <gst/video/gstvideometa.h>
|
|
|
|
#include <gstv4l2object.h>
|
|
#include <gstv4l2bufferpool.h>
|
|
|
|
GST_DEBUG_CATEGORY_EXTERN (v4l2videodec_debug);
|
|
|
|
G_BEGIN_DECLS
|
|
|
|
#define GST_TYPE_V4L2_VIDEO_DEC \
|
|
(gst_v4l2_video_dec_get_type())
|
|
#define GST_V4L2_VIDEO_DEC(obj) \
|
|
(G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_V4L2_VIDEO_DEC,GstV4l2VideoDec))
|
|
#define GST_V4L2_VIDEO_DEC_CLASS(klass) \
|
|
(G_TYPE_CHECK_CLASS_CAST((klass),GST_TYPE_V4L2_VIDEO_DEC,GstV4l2VideoDecClass))
|
|
#define GST_IS_V4L2_VIDEO_DEC(obj) \
|
|
(G_TYPE_CHECK_INSTANCE_TYPE((obj),GST_TYPE_V4L2_VIDEO_DEC))
|
|
#define GST_IS_V4L2_VIDEO_DEC_CLASS(obj) \
|
|
(G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_V4L2_VIDEO_DEC))
|
|
|
|
typedef struct _GstV4l2VideoDec GstV4l2VideoDec;
|
|
typedef struct _GstV4l2VideoDecClass GstV4l2VideoDecClass;
|
|
|
|
struct _GstV4l2VideoDec
|
|
{
|
|
GstVideoDecoder parent;
|
|
|
|
/* < private > */
|
|
GstV4l2Object * v4l2output;
|
|
GstV4l2Object * v4l2capture;
|
|
|
|
/* pads */
|
|
GstCaps *probed_srccaps;
|
|
GstCaps *probed_sinkcaps;
|
|
|
|
/* State */
|
|
GstVideoCodecState *input_state;
|
|
gboolean active;
|
|
GstFlowReturn output_flow;
|
|
};
|
|
|
|
struct _GstV4l2VideoDecClass
|
|
{
|
|
GstVideoDecoderClass parent_class;
|
|
|
|
gchar *default_device;
|
|
};
|
|
|
|
GType gst_v4l2_video_dec_get_type (void);
|
|
|
|
gboolean gst_v4l2_is_video_dec (GstCaps * sink_caps, GstCaps * src_caps);
|
|
gboolean gst_v4l2_video_dec_register (GstPlugin * plugin,
|
|
const gchar *basename,
|
|
const gchar *device_path,
|
|
GstCaps * sink_caps, GstCaps * src_caps);
|
|
|
|
G_END_DECLS
|
|
|
|
#endif /* __GST_V4L2_VIDEO_DEC_H__ */
|