mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-12-15 04:46:32 +00:00
Code Issues 1 Projects Releases Wiki Activity
gstreamer/subprojects/gst-plugins-bad/gst-libs/gst/vulkan
History
Víctor Manuel Jáquez Leal 11824d6279 vkfullscreenquad: set enable_clear as TRUE by default 
While using the validation layer with this pipeline:

gst-launch-1.0 videotestsrc num-buffers=10 ! vulkanupload ! vulkancolorconvert ! vulkansink

The validation layer throws this message:

Code 0 : Validation Error: [ VUID-VkAttachmentDescription-format-06699 ]
Object 0: handle = 0x5555562e9610, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x52b3229e |
vkCreateRenderPass: pCreateInfo->pAttachments[0] format is
VK_FORMAT_B8G8R8A8_UNORM and loadOp is VK_ATTACHMENT_LOAD_OP_LOAD, but
initialLayout is VK_IMAGE_LAYOUT_UNDEFINED.
The Vulkan spec states: If format includes a color or depth aspect and loadOp is
VK_ATTACHMENT_LOAD_OP_LOAD, then initialLayout must not be VK_IMAGE_LAYOUT_UNDEFINED

When creating the render pass the loadOp can be either
`VK_ATTACHMENT_LOAD_OP_CLEAR` or `VK_ATTACHMENT_LOAD_OP_LOAD` depending on
`enable_clear`. While `enable_clear` is FALSE by default (which means
`VK_ATTACHMENT_LOAD_OP_LOAD`). Nonetheless, its value is explicitly changed by
`vkoverlaycompositor` to FALSE too!

This behavior was introduced in merge request #2470 where
`VK_ATTACHMENT_LOAD_OP_CLEAR` was a fixed value for loadOp. Thus, the bug
consists in a missing initialization of `enable_clear` to TRUE from that merge
request.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4311>
2023-03-30 19:08:09 +01:00
..
android vulkan: Add/fix various annotations 2022-10-18 13:51:17 +03:00
cocoa gl/vulkan: Fix static linking on macOS 2022-10-24 00:48:08 +00:00
ios gl/vulkan: Fix static linking on macOS 2022-10-24 00:48:08 +00:00
wayland vulkan: Add/fix various annotations 2022-10-18 13:51:17 +03:00
win32 meson: Do hard build error for some MSVC warnings 2022-02-16 17:03:29 +00:00
xcb vulkan: Add/fix various annotations 2022-10-18 13:51:17 +03:00
gstvkapi.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkbarrier.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkbuffermemory.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkbuffermemory.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkbufferpool.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkbufferpool.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkcommandbuffer.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkcommandbuffer.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkcommandpool-private.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkcommandpool.c vulkan: Remove unnecessary null checks 2022-11-01 15:19:51 +01:00
gstvkcommandpool.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkconfig.h.meson Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkdebug-private.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkdebug.c vulkan/swapper: add some debug logging for surface size and present modes 2021-10-21 11:32:04 +00:00
gstvkdebug.h vulkan/swapper: add some debug logging for surface size and present modes 2021-10-21 11:32:04 +00:00
gstvkdescriptorcache.c vulkan: Add missing array length and (out) annotation to parameters 2022-11-01 15:19:51 +01:00
gstvkdescriptorcache.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkdescriptorpool.c vulkan: Remove unnecessary null checks 2022-11-01 15:19:51 +01:00
gstvkdescriptorpool.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkdescriptorset.c vulkan: Add missing array length and (out) annotation to parameters 2022-11-01 15:19:51 +01:00
gstvkdescriptorset.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkdevice.c vulkan: Remove unnecessary null checks 2022-11-01 15:19:51 +01:00
gstvkdevice.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkdisplay.c vulkan: Add missing (nullable) annotation to Returns 2022-11-01 15:19:51 +01:00
gstvkdisplay.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkerror.c Fix various warnings from gobject-introspection 2022-10-25 09:45:25 +03:00
gstvkerror.h gstvulkan: Expose gst_vulkan_result_to_string 2022-02-05 16:33:04 +00:00
gstvkfence.c vulkan: Add missing (nullable) annotation to Returns 2022-11-01 15:19:51 +01:00
gstvkfence.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkformat.c vulkan: Add/fix various annotations 2022-10-18 13:51:17 +03:00
gstvkformat.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkfullscreenquad.c vkfullscreenquad: set enable_clear as TRUE by default 2023-03-30 19:08:09 +01:00
gstvkfullscreenquad.h vkfullscreenquad: add support for disabling clearing 2022-06-14 03:34:05 +00:00
gstvkhandle.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkhandle.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkhandlepool.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkhandlepool.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkimagebufferpool.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkimagebufferpool.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkimagememory.c vulkan: Add missing (nullable) annotation to Returns 2022-11-01 15:19:51 +01:00
gstvkimagememory.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkimageview.c vulkan: Mark gst_vulkan_image_view_new create_info as constant pointer 2022-11-01 15:19:51 +01:00
gstvkimageview.h vulkan: Mark gst_vulkan_image_view_new create_info as constant pointer 2022-11-01 15:19:51 +01:00
gstvkinstance.c vulkan: Add missing array length and (out) annotation to parameters 2022-11-01 15:19:51 +01:00
gstvkinstance.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkmemory.c vulkan: memory: Flush non coherent memory after write. 2023-01-26 23:29:06 +00:00
gstvkmemory.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkphysicaldevice.c vulkan: Remove unnecessary null checks 2022-11-01 15:19:51 +01:00
gstvkphysicaldevice.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkqueue.c vulkan: Remove unnecessary null checks 2022-11-01 15:19:51 +01:00
gstvkqueue.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkswapper.c vulkanswapper: correctly handle force-aspect-ratio=false 2023-03-28 10:40:08 +00:00
gstvkswapper.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvktrash.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvktrash.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkutils.c vulkan: Add/fix various annotations 2022-10-18 13:51:17 +03:00
gstvkutils.h gstvulkan: Constify code in create_shader 2021-10-21 23:35:41 -03:00
gstvkvideofilter.c Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
gstvkvideofilter.h vulkan: add some missing GAutoPtr definitions 2022-06-14 03:34:05 +00:00
gstvkwindow.c vulkan: Add missing array length and (out) annotation to parameters 2022-11-01 15:19:51 +01:00
gstvkwindow.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
meson.build meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
vulkan-prelude.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
vulkan.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
vulkan_fwd.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
vulkan_mkenum.py Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00