gstreamer/subprojects/gst-plugins-bad/gst-libs/gst
Víctor Manuel Jáquez Leal 11824d6279 vkfullscreenquad: set enable_clear as TRUE by default
While using the validation layer with this pipeline:

gst-launch-1.0 videotestsrc num-buffers=10 ! vulkanupload ! vulkancolorconvert ! vulkansink

The validation layer throws this message:

Code 0 : Validation Error: [ VUID-VkAttachmentDescription-format-06699 ]
Object 0: handle = 0x5555562e9610, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x52b3229e |
vkCreateRenderPass: pCreateInfo->pAttachments[0] format is
VK_FORMAT_B8G8R8A8_UNORM and loadOp is VK_ATTACHMENT_LOAD_OP_LOAD, but
initialLayout is VK_IMAGE_LAYOUT_UNDEFINED.
The Vulkan spec states: If format includes a color or depth aspect and loadOp is
VK_ATTACHMENT_LOAD_OP_LOAD, then initialLayout must not be VK_IMAGE_LAYOUT_UNDEFINED

When creating the render pass the loadOp can be either
`VK_ATTACHMENT_LOAD_OP_CLEAR` or `VK_ATTACHMENT_LOAD_OP_LOAD` depending on
`enable_clear`. While `enable_clear` is FALSE by default (which means
`VK_ATTACHMENT_LOAD_OP_LOAD`). Nonetheless, its value is explicitly changed by
`vkoverlaycompositor` to FALSE too!

This behavior was introduced in merge request #2470 where
`VK_ATTACHMENT_LOAD_OP_CLEAR` was a fixed value for loadOp. Thus, the bug
consists in a missing initialization of `enable_clear` to TRUE from that merge
request.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4311>
2023-03-30 19:08:09 +01:00
..
adaptivedemux adaptivedemux: Minor typo fix 2022-10-27 19:45:44 +00:00
audio badaudio: Add/fix annotations 2022-10-18 13:51:16 +03:00
basecamerabinsrc docs: fix unnecessary ampersand, < and > escaping in code blocks 2021-11-12 11:39:19 +00:00
codecparsers av1parser, h265parser: Fix some code defects 2023-02-20 11:28:14 +00:00
codecs h264decoder: Fix DPB bumping process 2023-03-18 10:19:05 +00:00
cuda cuda: Fix runtime compiler library loading on Windows 2022-12-09 19:24:08 +09:00
d3d11 d3d11bufferpool: Fix invalid access in debug print loop 2023-03-24 15:46:50 +00:00
insertbin meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
interfaces meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
isoff gst-plugins-bad: define G_LOG_DOMAIN for all libraries 2021-10-19 00:12:25 +00:00
mpegts mpegts: Handle when iconv doesn't support ISO 6937 2022-12-12 10:17:26 +00:00
opencv meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
play gstplay: add warning message details check before post it 2022-11-15 01:01:10 +00:00
player meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
sctp meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
transcoder transcoder: Don't leak API bus and GMainLoop 2022-11-12 10:33:51 +01:00
uridownloader meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
va vaallocator: Check return value from va_sync_surface 2023-02-22 00:19:45 +00:00
vulkan vkfullscreenquad: set enable_clear as TRUE by default 2023-03-30 19:08:09 +01:00
wayland meson: Namespace the plugins_doc_dep/libraries variables 2022-09-01 21:17:35 +00:00
webrtc webrtc: Fix segfault traversing ice transports 2023-03-18 03:50:38 +00:00
winrt gst-plugins-bad: define G_LOG_DOMAIN for all libraries 2021-10-19 00:12:25 +00:00
glib-compat-private.h Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir 2021-09-24 16:14:36 -03:00
meson.build cuda: Factor out a public GstCUDA library 2022-04-19 16:39:43 +00:00