Commit graph

2279 commits

Author SHA1 Message Date
Mathieu Duponchelle
c70f005970 completions: Fix completions after the first command. 2015-03-24 17:13:20 +01:00
Mathieu Duponchelle
b55265c70d Revert "ges-launch: no need for a tmp string pointer"
This reverts commit 44a0924c1f.

There indeed is a need for a tmp string pointer.
2015-03-24 13:01:39 +01:00
Luis de Bethencourt
44a0924c1f ges-launch: no need for a tmp string pointer 2015-03-24 11:21:08 +00:00
Luis de Bethencourt
865634d66c ges-launch: free string before going out of scope
CID #1291632
2015-03-24 11:19:50 +00:00
Mathieu Duponchelle
710d34adf4 build: fix make distcheck. 2015-03-23 12:41:00 +01:00
Thibault Saunier
d114cc60bd ges: Do not clear potentially NULL errors
And avoid dereferencing NULL errors
2015-03-23 12:41:00 +01:00
Thibault Saunier
663824d20f ges-launch: Prefix clip, transition and effect instruction with a +
Slightly changing the CLI so that we have indicators of the timeline
commands adding new objects.
2015-03-23 12:41:00 +01:00
Thibault Saunier
20d94bea13 ges: Accept path as URI in the create clip structured interface 2015-03-23 12:41:00 +01:00
Mathieu Duponchelle
7efa8c86a9 ges-launch: Remove useless options, rename some short options. 2015-03-23 12:41:00 +01:00
Mathieu Duponchelle
8e18fd790c bash-completion: Add support for new ges-launch commands. 2015-03-23 12:41:00 +01:00
Mathieu Duponchelle
d77ad923a6 parse.l: Modify command arguments.
+ --clip uri=file:// becomes clip file:// for example.
2015-03-20 13:53:42 +01:00
Thibault Saunier
e37d8e768f ges: command-line-formatter: Properly error out on invalid arguments 2015-03-20 13:53:42 +01:00
Thibault Saunier
28a1e97aa2 ges: Factor out a GESCommandLineFormatter class
This formatter will allow any user to deserialize a timeline using
the new ges-launch command line interface
2015-03-20 13:53:42 +01:00
Mathieu Duponchelle
ed0839dd82 structured-interface: Be clever when no layer priority specified.
And add the new element to the same layer as the last clip that
was added, insted of adding to the last layer of the timeline
(and with the current code, actually adding a new layer each time)
2015-03-20 13:53:41 +01:00
Mathieu Duponchelle
7cfdc2265d ges-structured-interface: fix build 2015-03-20 13:53:41 +01:00
Thibault Saunier
dbb2368a39 ges: Automatically put clips at the end of layer if no start specified
In the 'structured' interface we should add it at the end of the layer

And make use of the new ges_timeline_get_layer API
2015-03-20 13:53:41 +01:00
Mathieu Duponchelle
761067b685 structure-interface: rename layer-priority to layer.
+ And add a short name for it in ges-launch.
2015-03-20 13:53:41 +01:00
Thibault Saunier
396196dfdf ges: Add layer up to the wanted layer priority in the structure interface
Making the thing easier to use
2015-03-20 13:53:41 +01:00
Mathieu Duponchelle
6f1091f84a ges-launch: parse property names longer than 1 char.
+ And finish the previous structure when encountering a setter.
2015-03-20 13:53:41 +01:00
Mathieu Duponchelle
c6dedf2f36 ges-launch: Update lexer / parser to handle set-*
+ cleanup of the lexer
2015-03-20 13:53:40 +01:00
Thibault Saunier
ecf167e95e tools: Implement a new CLI interface for the timeline creation 2015-03-20 13:53:40 +01:00
Thibault Saunier
2ffa9477e9 ges: Handle setting child property on container directly in the structured based interface 2015-03-20 13:53:40 +01:00
Thibault Saunier
5d7b37112f launcher: Add support to --set-property in the parser 2015-03-20 13:53:40 +01:00
Mathieu Duponchelle
abb5f2cc2f ges-launch: Implement a new parser for the commandline.
Summary: + flex-based lexing and manual simplistic parsing.

Test Plan: Use that stuff to make awesome things, see if it breaks.
2015-03-20 13:53:40 +01:00
Thibault Saunier
3105797913 ges: Add an internal GstStructure based interface
To be use by GstValidate action and ges-launch

Reviewers: Mathieu_Du, thiblahute

Differential Revision: http://phabricator.freedesktop.org/D42
2015-03-20 13:53:35 +01:00
Thibault Saunier
7d0015b973 ges: Fix build for older GLib
The return type of g_hash_table_insert changed from void to boolean
2015-03-19 09:33:18 +01:00
Thibault Saunier
dd47def4e3 container: implement children property handling 2015-03-18 20:36:39 +01:00
Thibault Saunier
42477a5ec3 ges: Move the notion of children properties to GESTimelineElement
Summary:
Deprecate the old GESTrackElement children property handling API.

New APIs:
  * ges_timeline_element_list_children_properties
  * ges_timeline_element_lookup_child
  * ges_timeline_element_get_child_property_by_pspec
  * ges_timeline_element_get_child_property_valist
  * ges_timeline_element_get_child_properties
  * ges_timeline_element_set_child_property_valist
  * ges_timeline_element_set_child_property_by_pspec
  * ges_timeline_element_set_child_properties
  * ges_timeline_element_set_child_property
  * ges_timeline_element_get_child_property
  * ges_timeline_element_add_child_property
  * ges_timeline_element_remove_child_property

Deprecated APIs:
  * ges_track_element_list_children_properties
  * ges_track_element_lookup_child
  * ges_track_element_get_child_property_by_pspec
  * ges_track_element_get_child_property_valist
  * ges_track_element_get_child_properties
  * ges_track_element_set_child_property_valist
  * ges_track_element_set_child_property_by_pspec
  * ges_track_element_set_child_properties
  * ges_track_element_set_child_property
  * ges_track_element_get_child_property
  * ges_track_element_add_child_property

Reviewers: Mathieu_Du

Differential Revision: http://phabricator.freedesktop.org/D40
2015-03-18 20:36:39 +01:00
Thibault Saunier
3e49850e6d timeline: Add API to find a layer with a specific priority in a timeline
Summary:
API:
  * ges_timeline_get_layer

Test Plan: Nan

Reviewers: mathieu.duponchelle
2015-03-18 20:36:38 +01:00
Thibault Saunier
f470222f3d Revert "ges: Move the notion of children properties to GESTimelineElement"
I got some trouble with

  arc land

and I wanted to push the 3 commit coming after this revert as 3
different commits but they ended up being all squash into one single
commit, which is clearly not cool for later bisecting and blaming.
Reverting that commit and re pushing those 3 commits as they were
supposed to be.

This reverts commit 9fe15ef435.
2015-03-18 20:33:48 +01:00
Thibault Saunier
9fe15ef435 ges: Move the notion of children properties to GESTimelineElement
Summary:
Deprecate the old GESTrackElement children property handling API.

New APIs:
  * ges_timeline_element_list_children_properties
  * ges_timeline_element_lookup_child
  * ges_timeline_element_get_child_property_by_pspec
  * ges_timeline_element_get_child_property_valist
  * ges_timeline_element_get_child_properties
  * ges_timeline_element_set_child_property_valist
  * ges_timeline_element_set_child_property_by_pspec
  * ges_timeline_element_set_child_properties
  * ges_timeline_element_set_child_property
  * ges_timeline_element_get_child_property
  * ges_timeline_element_add_child_property
  * ges_timeline_element_remove_child_property

Deprecated APIs:
  * ges_track_element_list_children_properties
  * ges_track_element_lookup_child
  * ges_track_element_get_child_property_by_pspec
  * ges_track_element_get_child_property_valist
  * ges_track_element_get_child_properties
  * ges_track_element_set_child_property_valist
  * ges_track_element_set_child_property_by_pspec
  * ges_track_element_set_child_properties
  * ges_track_element_set_child_property
  * ges_track_element_get_child_property
  * ges_track_element_add_child_property

Reviewers: Mathieu_Du

Reviewed By: Mathieu_Du

Differential Revision: http://phabricator.freedesktop.org/D40
2015-03-18 20:23:55 +01:00
Thibault Saunier
f21132c3d5 ges: Remove all reference to already dead GESSimpleLayer 2015-03-13 10:02:39 +00:00
Luis de Bethencourt
8b4b2562a6 project: remove unnecessary dereference
g_clear_error() already dereferences the error pointer, no need to manually
check and do it.

CID #1257630
2015-03-05 13:53:32 +00:00
Luis de Bethencourt
c9089e15b3 examples: check argument is valid 2015-03-03 14:26:55 +00:00
Tim-Philipp Müller
af3fd19637 ges-base-xml-formatter: fix setting of child properties
Make sure all child properties get set. GstStructureForeachFunc
takes a gboolean return value that decides whether to
continue or not.
2015-02-27 01:26:24 +00:00
Tim-Philipp Müller
7e9a2ef6c0 ges-meta-container: fix ges_meta_container_foreach()
Really call function on all metadata inside the container
instead of stopping randomly. GstStructureForeachFunc
takes a gboolean return value.
2015-02-27 01:24:30 +00:00
Tim-Philipp Müller
80909fb99a ges-base-xml-formatter: fix property setting
GstStructureForeachFunc has a gboolean return value,
and the foreach function will stop unless we return
TRUE here. This meant it was potluck whether all
properties in the structure got set or not.

Fixes setting of text overlay clip text property
in particular.

https://bugzilla.gnome.org/show_bug.cgi?id=743874
2015-02-26 20:14:31 +00:00
Mathieu Duponchelle
462727d6d8 build: fix make distcheck.
And install bash-completions in the supplied prefix.
2015-02-24 18:00:34 +01:00
Mathieu Duponchelle
b5d5173860 ges-launch: enable auto-completion.
Summary: + And be a little smart about it.

Test Plan: New feature, working, not testing bash completion

Reviewers: tsaunier

Differential Revision: http://internal.opencreed.com:8888/D25
2015-02-23 21:21:17 +01:00
Thibault Saunier
d0421639e0 ges: Always set ANY capsfeatures on tracks caps property
Summary:
We should not restrict the CapsFeatures on the track caps.
If someone want to do such a restriction he should add it to
the restriction caps directly

Test Plan: Run testsuite

Reviewers: mathieu.duponchelle
2015-02-20 14:10:56 +01:00
Mathieu Duponchelle
6321a9135f ges-project: no need to commit an empty timeline.
Summary: Can lead to deadlocks if the user commits at the same time.

Test Plan: Ran make check, it worked

Reviewers: tsaunier
2015-02-19 18:24:39 +01:00
Luis de Bethencourt
7dd8dbab28 ges: initialize timeline_duration value
If priv->timeline is False the function does not set any value for
timeline_duration before using it in gap_new (). Initialize the value to aviod
unexpected behaviour.

CID #1268405
2015-02-10 10:29:39 +00:00
Thibault Saunier
fa3658053e configure: Bump our Gst related dependencies to 1.5.0.1 2015-02-06 10:06:05 +01:00
Thibault Saunier
f192ba3192 nlecomposition: Properly protect the children task 2015-02-06 10:06:05 +01:00
Mathieu Duponchelle
1bfe0b7ef3 Cleanly handle removing the last object in a composition
The strategy here is to seek at the new end of the composition. And in
GES we always add a 1ns long gap at the end of the tracks so that all
track have the exact same duration, and we have black frames when the
timeline is empty
2015-02-03 12:03:33 +01:00
Thibault Saunier
f3f27bd636 validate: Do not wrongly set clip duration for UriClips
That was making no sense at all....
2015-02-02 11:57:19 +01:00
Thibault Saunier
23c71e8222 validate: Properly expose the commit action as ASYNC 2015-02-02 11:57:03 +01:00
Thibault Saunier
0bb313030b layer: Remove child from children list before emitting "child-removed" 2015-01-28 11:39:58 +01:00
Luis de Bethencourt
1efe0639de ges: remove useless gpointer variable
gpointer useless is indeed useless since we can use GST_DEBUG_REGISTER_FUNCPTR
to avoid having to store the return of the GST_DEBUG_FUNCPTR registration.

CID #1265771
2015-01-26 18:25:02 +00:00
Luis de Bethencourt
8f79ee9230 ges: merge MIN() and MAX() into CLAMP()
Merge the usage of MIN() and MAX() into one CLAMP() function.

CID #1265770
2015-01-26 17:47:55 +00:00