Niels De Graef
d8f61515d8
Don't pass default GLib marshallers for signals
...
By passing NULL to `g_signal_new` instead of a marshaller, GLib will
actually internally optimize the signal (if the marshaller is available
in GLib itself) by also setting the valist marshaller. This makes the
signal emission a bit more performant than the regular marshalling,
which still needs to box into `GValue` and call libffi in case of a
generic marshaller.
Note that for custom marshallers, one would use
`g_signal_set_va_marshaller()` with the valist marshaller instead.
2019-11-06 14:27:46 +00:00
Aaron Boxer
6d3429af34
documentation: fixed a heap o' typos
2019-11-05 09:11:25 -05:00
Reynaldo H. Verdejo Pinochet
43335d31c6
dvb: src: consolidate tuning stats gathering
...
Additionally: drop unneeded fe_fd variable.
2017-07-14 14:16:46 -07:00
Reynaldo H. Verdejo Pinochet
2d511343cb
dvb: src: use correct unit in tuning-timeout prop description
...
Milliseconds was wrong and made use of this timeout quite
confusing. The code uses the value as microsenconds so
any meaningful number was off by orders of magnitude.
2017-06-28 16:40:50 -07:00
Reynaldo H. Verdejo Pinochet
b09b17365d
dvb: src: fix use of wrong array index for tune signal
...
Erroneous value made "TUNE" overwrite "TUNNING_FAIL" ....
2017-06-16 13:57:49 -07:00
Reynaldo H. Verdejo Pinochet
5ad88a0352
dvb: src: issue warning on failed delsys-vs-parameter issues
...
Aids in understanding misses with the delsys auto-detection logic
2017-06-16 13:56:40 -07:00
Thibault Saunier
78022a6e0c
docs: Port all docstring to gtk-doc markdown
2017-04-12 12:57:57 -03:00
Tim-Philipp Müller
24ee608947
Update for 'mad' mp3 decoder removal
...
https://bugzilla.gnome.org/show_bug.cgi?id=776140
2017-03-20 17:15:54 +00:00
Reynaldo H. Verdejo Pinochet
3e519937a1
dvb: move adapter number set-up by way of environment to dvbsrc
...
This logic did not belong to the channel configuration
parser (only used by dvbbasebin) but to dvbsrc, which
is the element directly using this value and honoring
the "adapter" property.
Allows previously non-working cases like this to work:
GST_DVB_ADAPTER=1 gst-launch-1.0 dvbsrc delsys=11 modulation=7 frequency=689000000 ! fakesink
2016-12-22 16:39:24 -08:00
Reynaldo H. Verdejo Pinochet
6c0d9ecc35
dvbsrc: add DTV_STREAM_ID to the >= v8 (minor) group
...
Drop redundant comment while at it.
2016-12-22 13:06:21 -08:00
Reynaldo H. Verdejo Pinochet
1172b4df5a
dvbsrc: fix unconditional use of FEC 2/5
...
It is not defined for < v5 minor 7
2016-12-08 12:16:28 -08:00
Reynaldo H. Verdejo Pinochet
9d94b15310
dvbsrc: add delivery system to missing modulation check message
...
A tuning operation can spawn multiple checks. Being
able to differentiate between them makes debugging
easier.
2016-12-08 12:13:48 -08:00
Reynaldo H. Verdejo Pinochet
b00cdd944b
dvbsrc: drop needless wrapper around DVB API's dvb_diseqc_master_cmd
...
Its only purpose was to hold a wait time that was always 0
2016-12-05 23:38:53 -08:00
Reynaldo H. Verdejo Pinochet
ff9cc21933
dvbsrc: drop supperfluous wait in diseqc_send_msg()
...
It is always zero.
2016-12-05 23:18:38 -08:00
Reynaldo H. Verdejo Pinochet
1dbbd4c91e
dvbsrc: fix unconditional use of SYS_DVBC_ANNEX_C
...
It is not defined for < v5 minor 6
2016-12-05 16:18:54 -08:00
Reynaldo H. Verdejo Pinochet
43aa0462f4
dvbsrc: fix value for DVB-C annex B field in adapter structure
2016-12-05 16:18:05 -08:00
Reynaldo H. Verdejo Pinochet
3551d61af5
dvb: fix gtk-doc syntax for wrongly formatted comments
2016-10-23 21:46:27 -07:00
Reynaldo H. Verdejo Pinochet
dbdb84c2d3
dvbsrc: fix 'delivery system'-related messages
...
* Rephrase tune error to be delsys-neutral
* Refer to the actual check in the 'missing sanity check' warnings
* Use "Delivery system" instead of 'delsys'. The
latter is OK as a shorthand in the code but not
even a real word
2016-10-14 15:55:18 -07:00
Reynaldo H. Verdejo Pinochet
6f4d40ded3
Update my email address
2016-10-09 08:06:45 -07:00
Reynaldo H. Verdejo Pinochet
f6eeb314d3
dvbsrc: fix ISDB-T property descriptions
...
Drop some stale trailing whitespace while at it.
2016-06-24 18:20:56 -07:00
Reynaldo H. Verdejo Pinochet
fe193feb42
dvbsrc: fix misplaced space on doc block
2016-06-24 18:20:56 -07:00
Reynaldo H. Verdejo Pinochet
eb0a785841
dvbsrc: do not rely on temp var for fail detection
...
Use errno instead as local var might be overwritten
before the check.
2016-06-17 15:58:09 -07:00
Reynaldo H. Verdejo Pinochet
1824703c81
dvbsrc: rework set_pids()
...
- Reflow to avoid unneeded nesting
- Free aux pids array earlier
- Adjust debug output to deliver more meaningful information
2016-06-17 15:58:09 -07:00
Reynaldo H. Verdejo Pinochet
13efbf35d9
dvbsrc: drop pointless debug msg
2016-06-17 15:58:09 -07:00
Reynaldo H. Verdejo Pinochet
ea7c0981ec
dvbsrc: unify exit paths on _start()
2016-06-09 14:45:59 -07:00
Reynaldo H. Verdejo Pinochet
33893c5242
dvbsrc: use proper acronym for PID (Packet Identifier)
...
Drop formatting tab from message while at it.
2016-06-09 14:45:59 -07:00
Reynaldo H. Verdejo Pinochet
c66f5080aa
dvbsrc: set common PES filter params once and reuse
...
Avoid setting the same harcoded values over and over again.
2016-06-09 14:45:59 -07:00
Reynaldo H. Verdejo Pinochet
bac5c4c5d2
dvbsrc: improve description of PIDs property
2016-06-03 16:28:47 -07:00
Reynaldo H. Verdejo Pinochet
9e442d5cc0
dvbsrc: remove comment on self-explanatory code
2016-06-01 13:52:48 -07:00
Reynaldo H. Verdejo Pinochet
46de31d0f8
dvbsrc: avoid out-bound write on PID filter array
...
There's no need for an end-of-list marker in the filter
PIDs array if full, as the absolute maximum number of
elements (MAX_FILTERS) is known.
CID #1362441
2016-06-01 13:23:53 -07:00
Reynaldo H. Verdejo Pinochet
1d8673af62
dvbsrc: add sample ATSC launch line
2016-05-29 23:31:05 -07:00
Reynaldo H. Verdejo Pinochet
e35bc2c2b4
dvbsrc: use single marker at end of filtering PID list
...
Avoids at least ~100 unneeded assignment operations at runtime
2016-05-26 16:18:56 -07:00
Reynaldo H. Verdejo Pinochet
faadd0f12a
dvbsrc: simplify reporting of set polarity
2016-05-26 16:18:56 -07:00
Reynaldo H. Verdejo Pinochet
6a4fa2de75
dvbsrc: fix bandwidth-hz property description
...
Bandwidth Hz is no longer a DVBT-only property
2016-05-26 16:18:56 -07:00
Reynaldo H. Verdejo Pinochet
31a52b6c7c
dvbsrc: fix usage of PES & DVR acronyms everywhere
...
Additionally, improve message on gst_poll_new() failure
2016-05-26 16:18:14 -07:00
Reynaldo H. Verdejo Pinochet
5a47f4a8bc
dvbsrc: group DVB-T2 substream-id check with its corresponding set_prop()
2016-05-20 14:08:03 -07:00
Reynaldo H. Verdejo Pinochet
25543d70a7
dvbsrc: add DVB-S2 sub-stream ID check
...
Disable if invalid (> 255) instead of blindy setting this
property regardless of its actual value.
2016-05-20 13:57:45 -07:00
Reynaldo H. Verdejo Pinochet
e41b1c510a
dvbsrc: clarify consequence of passing a wrong ID to the substream filter
2016-05-20 13:47:06 -07:00
Reynaldo H. Verdejo Pinochet
1d9adb14dc
dvbsrc: move ISDB-T bandwidth check to _is_valid_bandwidth()
...
Allows test to be used for delivery system auto-detection.
Additionally, add 0 (auto) as valid value.
2016-05-17 15:06:49 -07:00
Reynaldo H. Verdejo Pinochet
ae060943a8
dvbsrc: add '0' as a valid value for bandwidth
...
Underlying API considers this the BANDWIDTH_HZ equivalent
to the old BANDWIDTH_AUTO for BANDWIDTH.
2016-05-17 14:40:11 -07:00
Reynaldo H. Verdejo Pinochet
dde02e2d63
dvbsrc: factor out and reuse DVB-T/T2 bandwidth checks
...
Use new utility function as an additional check for delivery
system auto-detection.
2016-05-17 14:40:01 -07:00
Reynaldo H. Verdejo Pinochet
10b020095b
dvbsrc: special case detection when DVB-T and T2 seem valid
...
There is no way to tell one over the other when parameters
seem valid for DVB-T and DVB-T2 and the adapter supports
both. Reason to go with the former here is that, from
experience, most DVB-T2 channels out there seem to use
parameters that are not valid for DVB-T, like QAM_256
https://bugzilla.gnome.org/show_bug.cgi?id=765731
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
378fdad176
dvbsrc: add transmission mode check for DTMB
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
39c50e7b85
dvbsrc: explicitly disable stream filter for invalid ids
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
8fcdf14846
dvbsrc: consider transmission mode for delsys autodetection
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
f0d7a8cb89
dvbsrc: factor out transmission mode check against delsys
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
15e21fee71
dvbsrc: improve delivery system autodetection
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
793c1a2423
dvbsrc: add modulation checks for DVB-T and T2
2016-05-15 17:12:28 -07:00
Reynaldo H. Verdejo Pinochet
4f0e42b8e4
dvbsrc: improve debug output from _open_frontend()
...
* Clarify message on delsys info gathering
* Combine redundant INFO/DEBUG pair
2016-05-11 16:10:27 -07:00
Reynaldo H. Verdejo Pinochet
16643e2db7
dvbsrc: fix invalid dereference of delsys data
...
Use GPOINTER_TO_INT to read GINT_TO_POINTER stored
data.
2016-05-11 16:10:16 -07:00