Commit graph

3 commits

Author SHA1 Message Date
Antonio Ospite
cfc1be0d61 tools: play: fix leaving STDIN in non-blocking mode after exit
gst-play-1.0 sets STDIN to non-blocking mode to have the input
characters read as soon as they arrive.

However, when gst_play_kb_set_key_handler() gets called from
restore_terminal() it forgets to restore the STDIN blocking status.

This can result in broken behavior for cli command executed in the same
terminal after gst-play-1.0 exited.

It turns out that putting STDIN in non-blocking mode is not even the
proper way to achieve the desired effect, instead VMIN and VTIME in
struct termios should be set to 0.

Let's do that, and don't mess with the STDIN blocking mode now that it's
not necessary.

https://bugzilla.gnome.org/show_bug.cgi?id=794591
2018-03-26 11:59:56 +01:00
Tim-Philipp Müller
da6d3cfacf tools: play: fix compiler warning on windows 2013-12-09 13:55:28 +00:00
Tim-Philipp Müller
5a36b793d6 tools: play: add --interactive switch and basic keyboard handling
Only pause/play with spacebar for now.
2013-11-24 01:08:48 +00:00