Edward Hervey
d91cc7e7b6
ges: Fix sizeof() usage
...
The entries of the array are "gchar *" and not "gchar **"
CID #1427091
CID #1427120
2018-01-11 10:57:30 +01:00
Mathieu Duponchelle
0bb5227017
ges-smart-adder: use capsfilter instead of GstAudioMixer:caps
...
The property has been removed, and using a capsfilter instead
is the appropriate solution.
2017-12-19 23:30:18 +01:00
Edward Hervey
9a45d0ef85
ges: Fix a bunch of leaks
...
There are definitely more left, but don't have time for more debugging
2017-11-27 11:49:43 +01:00
Tim-Philipp Müller
5016c80311
win32: remove .def file with exports
...
They're no longer needed, symbol exporting is now explicit
via GST_EXPORT in all cases (autotools, meson, incl. MSVC).
2017-11-26 13:30:08 +00:00
Thibault Saunier
a97ab50ab9
uri-clip: Copy previous track elements bindings when setting a new asset
...
Fixes https://phabricator.freedesktop.org/T7862
2017-11-25 16:12:22 -03:00
Ashish Kumar
23e9044b4e
GESAsset, GESLayer: add some function guards
...
https://bugzilla.gnome.org/show_bug.cgi?id=789521
2017-11-21 14:13:53 +01:00
Thibault Saunier
f20876b9db
auto-transition: Fix debug printf format
2017-11-07 11:26:58 -03:00
Thibault Saunier
f3dbcd2753
timeline: Do not snap object within the moving context
...
Reviewed-by: Alex Băluț <<alexandru.balut@gmail.com>>
Differential Revision: https://phabricator.freedesktop.org/D1873
2017-11-07 10:18:45 -03:00
Thibault Saunier
62891c3f03
ges: Sync 'par' to track restriction caps in the frame positionner
...
Allowing GES users to have control over how compositing is done
2017-10-31 12:57:08 -03:00
Sebastian Dröge
6c7c4e0257
ges-source: Fix caps memory leak and compiler warnings when compiling without debug logging
2017-09-20 12:59:40 +03:00
Stefan Popa
5b321dbe3a
track_element: Always emit "control-binding-removed" signal.
...
When setting a new control binding on a track element, the old control
binding (if any) is going to be removed. Make sure the
"control-binding-removed" signal is emitted in this case.
Fixes https://phabricator.freedesktop.org/T7340#95666
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D1842
2017-09-01 09:38:45 -03:00
Thibault Saunier
4db3800f98
Revert "timeline: Return FALSE when commiting an empty timeline"
...
This commit means that we do not get ASYNC_DONE anymore when commiting
an empty timeline, which means that we need to special case that.
This actually broke some code and does not bring in much.
Fixes https://phabricator.freedesktop.org/T7802
Fixes https://phabricator.freedesktop.org/T7797
This reverts commit e570d1e080
.
Thanks @stefanzzz for investigating!
2017-08-29 22:27:42 -03:00
Stefan Popa
6b67ff61ad
xml-formatter: Save encoder and muxer advanced settings
...
Added support for saving/loading encoder and muxer advanced settings.
Differential Revision: https://phabricator.freedesktop.org/D1837
2017-08-26 11:20:42 -03:00
Thibault Saunier
ce4d2d8102
pipeline: Allow up to 2 seconds queueing in the playsink video queue
...
In playsink the default video queue max size is 3 buffers, which is
sometimes not enough for our use case.
Allow up to 2 seconds of buffered data, giving us more time to do
the transition between clips, and thus avoiding dropping frames in
the sink when bringing up new clip takes too much time.
Differential Revision: https://phabricator.freedesktop.org/D1854
2017-08-19 23:21:57 -03:00
Thibault Saunier
959a3c70b0
timeline: Add from first element with wanted start to the move context
...
We need to iterate over the previous element from trackelement_iter
to find the first element that is at the moving point. Several
elements can have the same start as the one initiating the move,
and we need to take all of them into account.
Fixes https://phabricator.freedesktop.org/T7819
2017-08-18 23:52:35 -03:00
Thibault Saunier
6e2354bd79
validate: Add an action type to ungroup containers
2017-08-18 23:52:35 -03:00
Tim-Philipp Müller
b14b8b77e8
Hide ges_smart_mixer_* API
...
The header file isn't installed anyway.
2017-08-12 10:07:22 +01:00
Tim-Philipp Müller
7bec37a755
tests: don't use private debug category in asset test
...
That will lead to undefined symbol errors once it no
longer gets exported.
2017-08-11 22:24:28 +01:00
Tim-Philipp Müller
b0f0655343
ges: sprinkle more GST_EXPORT
2017-08-11 22:24:12 +01:00
Thibault Saunier
a8b7180918
smartmixer: Give a unique name to each compositor instances
2017-08-10 21:40:37 -04:00
Thibault Saunier
2e9fd0b712
Mark symbols explicitly for export with GST_EXPORT
...
With two exceptions:
* ges_clip_create_track_elements_func
* ges_uri_clip_set_uri
which were never declared in headers and should always have been static.
2017-08-07 15:41:28 -04:00
Thibault Saunier
ef86b7f7e6
transition: Fix usage of transition types != crossfade
...
We need to make sure the crossfade ratio is disabled in that case.
2017-08-03 17:04:04 -04:00
Thibault Saunier
57be9b6799
video-transition: Make use of the new compositor::crossfade-ratio
property
...
To achieve a real transition about to handle several level of layers.
https://bugzilla.gnome.org/show_bug.cgi?id=784827
2017-08-03 13:16:46 -04:00
Thibault Saunier
9a76617fc7
asset: Add a function to stop proxying an asset
...
And remove any reference as it beeing a proxy.
2017-07-31 13:14:04 -04:00
Thibault Saunier
eae6b70523
asset: Clear loading error when reload is requested
2017-07-31 13:03:59 -04:00
Thibault Saunier
487d9df367
timeline: Remove trackelements initating move from the moving context
...
They are handled specially when moving the context and having them
part of the context can lead to weird behaviours.
Fixes https://phabricator.freedesktop.org/T7693
2017-07-27 16:32:31 -04:00
Thibault Saunier
daca7acf96
xml-formatter: Serialize encoding profiles in reverse order
...
So they are reloaded in the right order.
2017-07-26 19:25:48 -04:00
Thibault Saunier
2efebc8587
pipeline: Make sure tracks are unlinked on NULL->NULL state changes
2017-07-26 19:25:46 -04:00
Thibault Saunier
c37fac7c27
Enhance some pad linking issue debug logging.
2017-07-26 19:25:44 -04:00
Nicolas Dufresne
c5eae31cf7
ges: Ref the GES class to avoid later deadlock
...
This ensure that that all class are initialized from the main thread,
avoid class initialization in random thread, which may cause deadlocks.
https://bugzilla.gnome.org/show_bug.cgi?id=784769
2017-07-11 10:23:58 -04:00
Stefan Popa
e9794d2bf2
"deep-notify" signal gets emitted only from the main thread
...
https://bugzilla.gnome.org/show_bug.cgi?id=784414
2017-07-03 11:40:04 -04:00
Thibault Saunier
50865a4f37
video-transition: Make sure crossfade output never contains alpha
...
Otherwise it would get mixed with lower layers, which is totally
unexpected.
Fixes T7773
Differential Revision: https://phabricator.freedesktop.org/D1764
2017-06-30 16:24:10 -04:00
Thibault Saunier
88a5894fbd
ges: Handle g_object_newv deprecation in latest GLib
2017-06-23 16:17:57 -04:00
Thibault Saunier
b6746dfd4c
validate: Port to new GstValidate API for pipeline retrieval
2017-05-20 18:04:42 +02:00
Sebastian Dröge
be67574245
ges: Correctly handling floating references
...
If we ref_sink() a parameter, it must be marked as (transfer floating)
and it also has to be handled consistently between error and normal cases.
See https://bugzilla.gnome.org/show_bug.cgi?id=782499
https://bugzilla.gnome.org/show_bug.cgi?id=782652
2017-05-20 16:53:57 +02:00
Corentin Noël
1a4c4d3ac0
Tiny fixes in the documentation
...
https://bugzilla.gnome.org/show_bug.cgi?id=780854
2017-04-02 21:25:38 -03:00
suhas2go
6dc0cd0dec
layer: Add ability to get clips in a given interval
...
Reviewed-by: Alex Băluț <<alexandru.balut@gmail.com>>
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D1689
2017-03-28 11:29:37 -03:00
Thibault Saunier
dd8dacdfde
docs: Fix generation using markdown for titles around tables
2017-03-13 09:30:39 -03:00
Thibault Saunier
909f0b7412
Revert "Fhotdoc"
...
This reverts commit 220618ecc7
.
This was not meant to be pushed.
2017-03-10 19:46:24 -03:00
Thibault Saunier
a125b8d73b
ges: Minor GESTimeline documentation fix
2017-03-10 19:34:21 -03:00
Thibault Saunier
107ad1d3e1
extractable: Typedef only in its own .h
2017-03-09 13:11:37 -03:00
Thibault Saunier
220618ecc7
Fhotdoc
2017-03-09 13:10:46 -03:00
Thibault Saunier
35256b47ff
docs: Port all docstring to gtk-doc markdown
2017-03-08 18:13:48 -03:00
Thibault Saunier
e570d1e080
timeline: Return FALSE when commiting an empty timeline
...
Meaning that ASYNC_DONE/COMMITED is always emited when TRUE is returned
2017-03-06 12:19:16 -03:00
Sebastian Dröge
50c98bae24
framepositioner: Prevent division by zero
...
CID 1369046
CID 1369047
2017-02-28 15:40:08 +02:00
Sebastian Dröge
58e8277a78
ges-timeline: Document intentional case-fall-through
...
CID 1364754
2017-02-28 15:36:46 +02:00
Sebastian Dröge
1c6893c57d
ges-project: Check for set/unset error correctly by dereferencing
...
... or simply calling g_clear_error() on it which does that for us.
CID 1257630
2017-02-28 12:59:35 +02:00
Thibault Saunier
fe2efd161d
ges: Keep internal symbols internal
...
The following implementation details where exposed as public symbols:
- _ges_container_get_priority_offset
- _ges_container_set_height
- _ges_container_set_priority_offset
- _ges_uri_asset_cleanup
but it was not correct and that should never have been used outside
GES.
Moving those declarations to the internal header and marking as
internal.
2017-02-24 16:05:34 -03:00
Thibault Saunier
b27078d8de
Minor documentation fix
2017-02-15 12:53:22 -03:00
Thibault Saunier
c5f59a319b
ges-meta: Minor documenation fix
2017-02-06 10:05:49 -03:00
Guillaume Desmottes
53c5bc069c
introduce ges_deinit()
...
GstDiscoverer objects were leaked by tests making the leaks detector
unusable.
Introduce ges_deinit(), similiar to gst_deinit(), doing some cleanup
before exiting the process.
https://bugzilla.gnome.org/show_bug.cgi?id=776805
2017-02-06 09:49:20 -03:00
namanyadav12
7ba2c22ccb
uri-clip-asset: Add file-size metadata
...
Add file-size metadata to GESUriClipAsset.
Reviewed-by: Thibault Saunier <thibault.saunier@osg.samsung.com>
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D1645
2017-02-04 18:52:59 -03:00
Thibault Saunier
a563578b0a
timeline: Cleanup the moved_clip list before rolling back
...
Otherwise we might end up using an already freed pointer
Differential Revision: https://phabricator.freedesktop.org/D1640
2017-02-04 18:52:57 -03:00
Thibault Saunier
ab7865d41c
clip: Make sure that clip start change is notified before children changes
...
Fixes https://phabricator.freedesktop.org/T7577
Differential Revision: https://phabricator.freedesktop.org/D1600
2017-01-09 19:49:19 -03:00
Alexandru Băluț
872d15eb9d
asset: Fix set_proxy to abort when an error happens
...
Differential Revision: https://phabricator.freedesktop.org/D1574
2017-01-09 11:43:13 -03:00
Alexandru Băluț
6b9faec7dc
asset: Reuse local variable
...
Differential Revision: https://phabricator.freedesktop.org/D1573
2017-01-09 11:43:11 -03:00
Thibault Saunier
8aa407ff27
video-mixer: Fix the way we release mixer pads
...
We were using the actual mixer pad to release the smart mixer
pad, which seemed to be on purpose, but was not properly handle,
moreover, it is now forbiden to pass a pad not inside a GstElement
when releasing it.
Also properly remove ghost pads from Smart mixer, we were planly
failling at it.
2016-12-22 09:50:39 -03:00
Antonio Ospite
1d32be0c08
ges: fix the description of the --help-GES command line option
...
Use "Show GES Options" which is more appropriate and avoids duplication
with --help-gst which already says "Show GStreamer Options".
https://bugzilla.gnome.org/show_bug.cgi?id=776063
2016-12-14 09:13:41 -03:00
Thibault Saunier
ad27229dac
element: Rework set_child_property_by_pspec
...
It was making no sense to loose the information about the pspec itself
to retrieve the child associated to it and was failling when we were
forcing the AssociateType::prop synthax
2016-12-01 17:08:43 -03:00
Sebastian Dröge
f536db2b71
ges-timeline: Properly calculate absolute diff of two unsigned integers
...
CID 1394491.
2016-11-23 18:42:27 +02:00
Sebastian Dröge
d9ab6f14e8
ges: Add NULL check before dereferencing
...
CID 1394494.
2016-11-23 18:28:35 +02:00
Philippe Renon
be48b040ea
ges-uri-asset: fix compile error 'timeout' may be used uninitialized
...
https://bugzilla.gnome.org/show_bug.cgi?id=774751
2016-11-21 09:29:59 +02:00
Scott D Phillips
9feee792c5
Enable building with MSVC
...
https://bugzilla.gnome.org/show_bug.cgi?id=774641
2016-11-18 09:13:53 -03:00
Scott D Phillips
3319ed17d8
Cast away const from GstMetaInfo in *_get_meta_info() functions
...
MSVC warns about the const in the implicit argument conversion in the
calls to g_once_init_{enter,leave}. It's OK so explicitly cast it.
https://bugzilla.gnome.org/show_bug.cgi?id=774641
2016-11-18 09:13:53 -03:00
Scott D Phillips
f203c01af2
Pass gint/guint pointers instead of enum pointers
...
The underlying integer type for enums are implementation defined and may
not be the same size as gint/guint. So implicitly casting from pointers-
to-enum-types to pointers-to-int-types is unsafe. MSVC warns on these.
https://bugzilla.gnome.org/show_bug.cgi?id=774641
2016-11-18 09:13:53 -03:00
Scott D Phillips
f1dd6f4226
parse: Don't #include <unistd.h>
...
It isn't needed and isn't present in non-posix environments like windows
with MSVC or mingw.
https://bugzilla.gnome.org/show_bug.cgi?id=774641
2016-11-18 09:13:53 -03:00
Thibault Saunier
9bc06c755a
ges: Check if GstDiscoverer could be created at init time
...
And fail initialization if it is not the case, we make the assumption
it worked all around the codebase so we should really concider it fatal.
2016-11-15 15:19:42 -03:00
Alexandru Băluț
3ed09c370a
ges: Fix documentation and debug comments
...
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D1393
2016-11-09 18:35:15 -03:00
Mathieu Duponchelle
73cf36fa25
timeline: reimplement snap_to_position a bit more appropriately.
...
It could yet be made be simpler, but it would require
touching the rest of the timeline editing code.
Fixes https://phabricator.freedesktop.org/T7587
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D657
2016-11-09 18:35:12 -03:00
Sebastian Dröge
748d466ac9
ges-timeline: Fix typo in debug messages
2016-11-09 11:48:09 +02:00
Thibault Saunier
1b5c3cb865
timeline: Avoid creating extra transition when rippling clips
...
In some cases when rippling clip we could get the algo lost because
a transition existed between two clips (for example at the end of c1
and at the begining of c2) but while rippling it would have required
a transition at the end of c2 and beginning of c1, and we were properly
not destroying the old one (as the two clips were in the moving context)
but we were still creating the other transition in the end...
Reviewed-by: Alex Băluț <alexandru.balut@gmail.com>
Differential Revision: https://phabricator.freedesktop.org/D1362
2016-11-04 15:56:36 -03:00
Thibault Saunier
a2ae8762af
timeline: Make sure transitions between rippled clips are never deleted
...
Reviewed-by: Alex Băluț <alexandru.balut@gmail.com>
Differential Revision: https://phabricator.freedesktop.org/D1361
2016-11-04 15:56:34 -03:00
Thibault Saunier
e31b8627ef
timeline: Destroy transition if a neighbor is not being moved to a layer
...
And make sure that we move the transition to the right layer, not trying
to figure it out.
Differential Revision: https://phabricator.freedesktop.org/D1360
2016-11-04 15:56:31 -03:00
Thibault Saunier
4432efcfad
track-element: Avoid dereferencing NULL pointer
...
We set TrackElement track type very early when creating effects
so it now uses that information to find TrackElement in clips
by track type.
Reviewed-by: Alex Băluț <alexandru.balut@gmail.com>
Differential Revision: https://phabricator.freedesktop.org/D1370
2016-10-11 19:25:51 +02:00
Thibault Saunier
b51fd6184a
meson: Fix gtkdoc using new meson features
2016-09-28 20:41:32 -03:00
Thibault Saunier
08397318f6
meson: Fix installing configured files
2016-09-28 20:41:32 -03:00
Thibault Saunier
e065fde526
uriclip: Remove some filesource leftovers
...
Differential Revision: https://phabricator.freedesktop.org/D1329
2016-09-26 13:33:26 -03:00
Thibault Saunier
cd76231f64
timeline: Properly compute the end of groups when checking snapping
...
Computation was not taking into account the fact that the start of
the element being moved could be at the middle of a group and not
necessarily at the start!
Fixes T7544
Reviewed-by: Alex Băluț <alexandru.balut@gmail.com>
Differential Revision: https://phabricator.freedesktop.org/D1282
2016-09-26 13:33:19 -03:00
Thibault Saunier
1757ae2e5e
ges: Handle moving groups with effects inside
...
We were only concidering that we should let the group handle moving
transitions when changing transitions but in fact as soon as a
transition is happenning between two clips that are in a same group
the group properly handles moving the transition, so let the
group do its job.
Fixes T7543
Differential Revision: https://phabricator.freedesktop.org/D1281
2016-09-26 13:33:00 -03:00
Thibault Saunier
3409719de5
ges: Deprecate GESTimelineElement::priority writability
...
GESLayer is now responsible for setting clips priorites. Also
GESClip top effects priorities are now set by the
ges_clip_set_top_effect_index method, the user should never call
ges_timeline_element_set_priority as it will anyway be overriden
by GES itself.
Differential Revision: https://phabricator.freedesktop.org/D1280
2016-09-26 13:32:58 -03:00
Thibault Saunier
f79c73789f
layer: Handle operation priorities
...
All operations should have higher priorites and sources should be
on top of those. We now first set the operations priorities in
a first pass and then stack sources on top of those.
Differential Revision: https://phabricator.freedesktop.org/D1279
2016-09-26 13:32:57 -03:00
Thibault Saunier
eb48faf342
ges: transition: Make crossfade fade out at the same time as it fade in
...
Until now fade out was just fading in the new clip, but this is not
correct and crossfade should at the same time fade out while fading
in.
Fixes https://phabricator.freedesktop.org/T3451
Differential Revision: https://phabricator.freedesktop.org/D1278
2016-09-26 13:32:56 -03:00
Thibault Saunier
564bd8d473
layer: Make sure to resync priorities on commit
...
In case effects have been added priorites might become wrong,
but until the timeline is not commited, it does not matter.
Make sure all priorities are correct before commiting compositions
Differential Revision: https://phabricator.freedesktop.org/D1277
2016-09-26 13:32:55 -03:00
Thibault Saunier
3daf8bd788
Finally move clip priority handling to GESLayer.
...
Fix all tests as we now have 1 priority inside the layer
dedicated to transitions (basically no source clip will
ever have a priority of 0 inside a layer).
Differential Revision: https://phabricator.freedesktop.org/D1276
2016-09-26 13:32:53 -03:00
Thibault Saunier
2854c91ebc
clip: Make top effect priority inside the clip priority range
...
And simplify the way we start computing children priority
making min_priority already relative to the clip itself.
Differential Revision: https://phabricator.freedesktop.org/D1275
2016-09-26 13:32:52 -03:00
Alexandru Băluț
a63c754222
timeline: Make get_groups public
...
Had to separate timeline_emit_group_added from timeline_add_group
to avoid emitting group-added when the project is being loaded.
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D1302
2016-09-13 16:47:24 -03:00
Alexandru Băluț
760909bc9e
timeline: Fix documentation
...
Reviewed-by: Thibault Saunier <thibault.saunier@collabora.com>
Differential Revision: https://phabricator.freedesktop.org/D1300
2016-09-13 16:45:27 -03:00
Thibault Saunier
8b4983daf1
test:validate: Handle new expected_failures Test argument
2016-09-09 10:27:24 -03:00
Thibault Saunier
c7ade2bf84
meson: Handle building the gir file when used as subproject
...
Add support for building GIR when used as subproject
Add an option to disable GIR generation
And bump version to 1.9.2
2016-09-05 12:46:52 -03:00
Sebastian Dröge
d4af1b6c9a
ges: Rename parse_lex.h to ges-parse-lex.h
...
Fixes the build and makes it consistent with the meson build system.
2016-08-25 10:06:51 +03:00
Thibault Saunier
383c5d1f6d
Add support for Meson as alternative/parallel build system
...
https://github.com/mesonbuild/meson
2016-08-24 16:44:32 -03:00
Philippe Renon
3cf28775f3
ges-track-element: fix typos in control_binding_removed signal declaration
...
https://bugzilla.gnome.org/show_bug.cgi?id=770101
2016-08-18 10:21:57 -07:00
Edward Hervey
53fb174443
ges-timeline: Demote some debugging statements
...
locking should be in a lower level to avoid too many messages
2016-08-14 17:44:36 +02:00
Edward Hervey
be5b9270ac
timeline-element: Reset pointer after freeing
...
dispose can be called multiple times, make sure we don't call functions
on free'd pointers.
2016-08-13 11:08:34 +02:00
Thibault Saunier
855488f58e
ges: Do not rescale videos if the track aspect ratio changes
...
Differential Revision: https://phabricator.freedesktop.org/D1242
2016-08-05 21:40:57 -04:00
Thibault Saunier
1cef62ab79
ges: Let the compositor do the scaling if mixing is enabled
...
Differential Revision: https://phabricator.freedesktop.org/D1241
2016-08-05 21:40:56 -04:00
Thibault Saunier
e1f6b9fefb
validate: Start also testing jpeg encoding
2016-07-29 15:57:05 -04:00
Thibault Saunier
8162811bce
timeline: Keep transitions when moving the moving context between layers
...
Differential Revision: https://phabricator.freedesktop.org/D1225
2016-07-29 15:57:05 -04:00
Thibault Saunier
fff6a73735
timeline: Ripple from start of clips and not the end.
...
Fixes https://phabricator.freedesktop.org/T7503
2016-07-28 19:37:25 -04:00
Thibault Saunier
aa38d80797
enums: Fix absolute text overlay alignment value
...
It needs to be in sync with GstBaseTextOverlayHAlign order.
2016-07-28 17:23:43 -04:00