Diogo Goncalves
acfc9ae216
avfvideosrc: fix wrong framerate selected for caps
...
This fix solves an issue where a format that doesn't support the
requested framerate would be selected. It ensures that we use the first
format and framerate pair that supports the requested caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2331 >
2022-05-13 19:38:45 +00:00
Matthew Waters
b8a5e7a4e4
applemeida/texturecache: remove unused variable
...
Fixes:
../sys/applemedia/videotexturecache.m:71:20: error: variable 'features' set but not used [-Werror,-Wunused-but-set-variable]
GstCapsFeatures *features;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046 >
2022-03-28 10:30:23 +00:00
Matthew Waters
3ffbb66593
applemedia/corevideobuffer: remove unused variable
...
Fixes:
../sys/applemedia/corevideobuffer.c:209:19: error: variable 'video_meta' set but not used [-Werror,-Wunused-but-set-variable]
GstVideoMeta *video_meta;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046 >
2022-03-28 10:30:23 +00:00
Matthew Waters
b8f83c9d14
applemedia/iosgl: remove unused variable
...
Fixes:
../sys/applemedia/iosurfaceglmemory.c:219:41: error: variable 'texfmt' set but not used [-Werror,-Wunused-but-set-variable]
GLuint tex_id, tex_target, texifmt, texfmt;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046 >
2022-03-28 10:30:23 +00:00
Matthew Waters
49e452525d
vtdec: remove unused variable
...
Fixes:
../sys/applemedia/vtdec.c:611:35: error: variable 'output_flags' set but not used [-Werror,-Wunused-but-set-variable]
VTDecodeFrameFlags input_flags, output_flags;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046 >
2022-03-28 10:30:23 +00:00
Matthew Waters
edd9ec0456
avsamplevideosink: remove unused variable
...
Fixes
../sys/applemedia/avsamplevideosink.m:80:20: error: variable 'gstelement_class' set but not used [-Werror,-Wunused-but-set-variable]
GstElementClass *gstelement_class;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046 >
2022-03-28 10:30:23 +00:00
Matthew Waters
651cd8e0bb
avfassetsrc: fix unused-but-set warning
...
../sys/applemedia/avfassetsrc.m:1014:12: error: variable 'caps' set but not used [-Werror,-Wunused-but-set-variable]
GstCaps *caps;
^
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2046 >
2022-03-28 10:30:23 +00:00
Nirbheek Chauhan
bb32532f60
applemedia: Disable 64RGBALE support on older macOS
...
The kCVPixelFormatType_64RGBALE enum is only available on macOS Big
Sur (11.3) and newer. We also cannot use that while configuring the
encoder or decoder on older macOS.
Define the symbol unconditionally, but only use it when we're running
on Big Sur with __builtin_available().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1613 >
2022-02-01 16:57:04 +00:00
Nirbheek Chauhan
6ae4497c07
applemedia: Remove some unnecessary variables
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1613 >
2022-02-01 16:57:04 +00:00
Nirbheek Chauhan
67656c5eeb
docs: Add objc and objcpp files to hotdoc gst_c_sources
...
Hotdoc should be able to extract and parse comments out of these. Just
need to be careful to only add the glob in directories that actually
contain *.m (objc) and *.mm (objcpp) files.
Also fix some doc comments and remove redundant ones.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1614 >
2022-02-01 05:25:42 +05:30
Nirbheek Chauhan
f1449ac116
docs: Rename "OS X" to "macOS" in some documentation
...
No one uses the term "Mac OS X" anymore, it's "macOS". "OS X" is even
worse, because people will usually start the search with "mac".
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1607 >
2022-01-30 19:17:18 +05:30
Nirbheek Chauhan
d05fcadf4e
applemedia: Document vtenc / vtdec elements
...
Also preserve-alpha property should only be exposed on the
vtenc_prores element since h264 does not support transparency.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-docs/-/issues/94
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601 >
2022-01-30 02:17:24 +05:30
Nirbheek Chauhan
6b7d819c25
vtenc: Signal ignored alpha component with ProRes
...
When the image is opaque but the output ProRes format has an alpha
component (4 component, 32 bits per pixel), Apple requires that we
signal that it should be ignored by setting the depth to 24 bits per
pixel. Not doing so causes the encoded files to fail validation.
So we set that in the caps and qtmux sets the depth value in the
container, which will be read by demuxers so that decoders can skip
those bytes entirely. qtdemux does this, but vtdec does not use this
information at present.
The sister change was made in qtmux and qtdemux in:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1061
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1489 >
2022-01-04 18:01:54 +00:00
Nirbheek Chauhan
b8d6fd905e
applemedia: Add ARGB64_BE, RGBA64_LE support to vtenc/vtdec
...
We can add this now that ARGB64_BE videoconvert support was added in:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
fed69c48b6
vtenc: Add FieldDetail properties for interlaced input
...
Standard interlace handling:
* If we have interlace-mode=interleaved and the field order, we just
set it when creating the session
* If we have interlace-mode=(interleaved|mixed) and no field order, we
set the field order on the first buffer
The encoder session does not support changing the FieldDetail after it
has started encoding frames, so we cannot support mixed streams
correctly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
29a32703a5
vtenc: Add a property to forcibly ignore alpha values
...
This PropertyKey is not documented in any headers anywhere, so we need
to define it ourselves.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
4e37f99975
vtenc: Set colorimetry information
...
It looks like VideoToolbox doesn't support all our colorimetries.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
0f0e68080c
applemedia: Add ProRes support to vtenc and vtdec
...
For vtdec, we continue to prefer NV12; else we pick whatever
downstream wants. In the special case where we're decoding 10-bit or
12-bit ProRes formats, we will prefer AYUV64.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
db638134e7
vtenc: Improve error reporting in chain function
...
Otherwise it is quite difficult to figure out why the chain function
failed. Also assert not reached for case statements that should not be
hit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
d7f6f8172a
vtdec: Remove dead code in switch statement
...
We never advertise these formats, so these cases will never be hit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Thibault Saunier
019971a3c7
Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir
2021-09-24 16:14:36 -03:00