Commit graph

1077 commits

Author SHA1 Message Date
Zaheer Abbas Merali
eaad31d7e6 testsuite/multifilesink/: New media tests
Original commit message from CVS:
2004-09-21  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* testsuite/multifilesink/Makefile.am:
* testsuite/multifilesink/lame_test.c: (gst_newmedia_base_init),
(gst_newmedia_class_init), (gst_newmedia_init),
(gst_newmedia_chain), (gst_newmedia_trigger), (test_format),
(newfile_signal), (test_signal), (main):
* testsuite/multifilesink/multifilesrc_test.c: (main):
* testsuite/multifilesink/oggtheora_test.c:
(gst_newmedia_base_init), (gst_newmedia_class_init),
(gst_newmedia_init), (gst_newmedia_chain), (gst_newmedia_trigger),
(test_format), (newfile_signal), (test_signal), (main):
* testsuite/multifilesink/oggvorbis_test.c:
(gst_newmedia_base_init), (gst_newmedia_class_init),
(gst_newmedia_init), (gst_newmedia_chain), (gst_newmedia_trigger),
(test_format), (newfile_signal), (test_signal), (main):
* testsuite/multifilesink/wavenc_test.c: (gst_newmedia_base_init),
(gst_newmedia_class_init), (gst_newmedia_init),
(gst_newmedia_chain), (gst_newmedia_trigger), (test_format),
(newfile_signal), (test_signal), (main):
New media tests
2004-09-21 18:41:15 +00:00
Christian Schaller
19f5e1f3a0 fix license information
Original commit message from CVS:
fix license information
2004-09-20 14:25:08 +00:00
Ronald S. Bultje
e138796b88 ext/mad/gstmad.c: Allow for mp3 rate/channels changes. However, only very conservatively. Reason that we *have* to en...
Original commit message from CVS:
* ext/mad/gstmad.c: (gst_mad_check_caps_reset),
(gst_mad_change_state):
Allow for mp3 rate/channels changes. However, only very
conservatively. Reason that we *have* to enable this is smiply
because the mad find_sync() function is not good enough, it will
regularly sync on random data as valid frames and therefore make
us provide random caps as *final* caps of the stream. The best fix
I could think of is to simply require several of the same stream
changes in a row before we change caps.
The actual testcase that works now is #
* ext/ogg/Makefile.am:
* ext/ogg/gstogg.c: (plugin_init):
* ext/ogg/gstogmparse.c:
OGM support (video only for now; I need an audio sample file).
* gst/asfdemux/gstasfdemux.c: (gst_asf_demux_base_init),
(gst_asf_demux_process_stream), (gst_asf_demux_video_caps),
(gst_asf_demux_add_video_stream):
WMV extradata.
* gst/playback/gstplaybasebin.c: (unknown_type):
Don't error out on single unknown-types after all. It's wrong.
If we found type of video and audio but not of a subtitle stream,
it will still error out (which is unwanted). Will find a better fix
later on.
* gst/typefind/gsttypefindfunctions.c: (ogmvideo_type_find),
(ogmaudio_type_find), (plugin_init):
OGM support.
2004-09-20 12:40:40 +00:00
Johan Dahlin
d56ae2abd1 ext/jpeg/gstjpegdec.c (gst_jpegdec_chain): Allocate the buffer after setting caps. Fixes mysterious segfault. Blessed...
Original commit message from CVS:
* ext/jpeg/gstjpegdec.c (gst_jpegdec_chain): Allocate the buffer
after setting caps. Fixes mysterious segfault. Blessed by Wim.
2004-09-20 09:58:34 +00:00
Zaheer Abbas Merali
11de7cdb8c gst/wavenc/gstwavenc.*: Added newmedia support to wavenc
Original commit message from CVS:
2004-09-19  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* gst/wavenc/gstwavenc.c: (gst_wavenc_init), (gst_wavenc_chain):
* gst/wavenc/gstwavenc.h:
Added newmedia support to wavenc
2004-09-19 17:55:04 +00:00
Wim Taymans
c79de85d57 gst/tcp/: Small cleanups in fdset.c
Original commit message from CVS:
* gst/tcp/gstfdset.c: (gst_fdset_fd_has_closed),
(gst_fdset_fd_has_error), (gst_fdset_fd_can_read),
(gst_fdset_fd_can_write), (gst_fdset_wait):
* gst/tcp/gstmultifdsink.c: (gst_client_status_get_type),
(gst_multifdsink_init), (gst_multifdsink_add),
(gst_multifdsink_remove), (gst_multifdsink_get_stats),
(gst_multifdsink_remove_client_link),
(gst_multifdsink_client_queue_buffer),
(gst_multifdsink_handle_client_write),
(gst_multifdsink_recover_client), (gst_multifdsink_handle_clients),
(gst_multifdsink_close), (gst_multifdsink_change_state):
* gst/tcp/gstmultifdsink.h:
* gst/tcp/gsttcpserversink.c: (gst_tcpserversink_class_init),
(gst_tcpserversink_removed):
Small cleanups in fdset.c
Use a hastable to map fd to the client structure for faster
lookup in _remove and get_stats.
Added virtual function to close the fds.
Handle clients even when the select/poll call was unblocked because
of a command.
Implement syncing to keyframe in the recovery procedure.
2004-09-17 10:06:52 +00:00
Iain Holmes
a0317b4feb Free the caps used for the try
Original commit message from CVS:
Free the caps used for the try
2004-09-16 11:34:50 +00:00
Ronald S. Bultje
e167cdeaf1 gst/mpegstream/gstdvddemux.c: Caps are only set if the type of the stream is unknown, but this is initialized in ->in...
Original commit message from CVS:
* gst/mpegstream/gstdvddemux.c: (gst_dvd_demux_get_audio_stream):
Caps are only set if the type of the stream is unknown, but this
is initialized in ->init_stream(), so set to UNKNOWN after calling
->init_stream() so that capsnego starts.
2004-09-15 21:43:05 +00:00
Ronald S. Bultje
b465cd10f1 gst/avi/gstavidemux.c: Just hardcode for raw audio then. AVI audio sucks.
Original commit message from CVS:
* gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_query),
(gst_avi_demux_stream_data):
Just hardcode for raw audio then. AVI audio sucks.
2004-09-15 20:06:15 +00:00
Arwed v. Merkatz
bf5574d94a use audio/x-ttafile and audio/x-tta for tta instead of audio/x-tta and audio/x-raw-tta
Original commit message from CVS:
use audio/x-ttafile and audio/x-tta for tta instead of audio/x-tta and audio/x-raw-tta
2004-09-15 19:43:37 +00:00
Ronald S. Bultje
1bb35c3fa4 gst/avi/gstavidemux.c: Try to fix a/v sync issues.
Original commit message from CVS:
* gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_query),
(gst_avi_demux_stream_data):
Try to fix a/v sync issues.
2004-09-15 19:31:47 +00:00
David Schleef
bbccf23eed configure.ac: remove NASM check, since we don't use it. Update dirac check to 0.4
Original commit message from CVS:
* configure.ac: remove NASM check, since we don't use it.  Update
dirac check to 0.4
* ext/dirac/gstdiracdec.cc: update to current 0.4 API
* gst/audioconvert/gstaudioconvert.c: (gst_audio_convert_link):
Initialized variables.
* gst/qtdemux/qtdemux.c: (gst_qtdemux_change_state),
(gst_qtdemux_loop_header), (qtdemux_parse), (qtdemux_parse_trak),
(gst_qtdemux_handle_esds), (qtdemux_audio_caps): Fix seeking, add
SVQ3 format
2004-09-15 19:29:24 +00:00
Ronald S. Bultje
9ce02e0a6c gst/avi/gstavidemux.*: Fix for compressed audio (mp3) timestamp generation. How did this ever work?
Original commit message from CVS:
* gst/avi/gstavidemux.c: (gst_avi_demux_handle_src_query),
(gst_avi_demux_add_stream), (gst_avi_demux_stream_data):
* gst/avi/gstavidemux.h:
Fix for compressed audio (mp3) timestamp generation. How did this
ever work?
2004-09-15 17:14:34 +00:00
Ronald S. Bultje
63887ed630 gst/playback/gstplaybin.c: Volume is a double not a float.
Original commit message from CVS:
* gst/playback/gstplaybin.c: (gst_play_bin_get_property):
Volume is a double not a float.
2004-09-15 16:48:43 +00:00
Wim Taymans
1fc7835095 gst/tcp/gstmultifdsink.c: Don't close the fd in multifdsink as we didn't open it in the first place. Some cleanups.
Original commit message from CVS:
* gst/tcp/gstmultifdsink.c: (gst_multifdsink_remove_client_link),
(gst_multifdsink_handle_clients), (gst_multifdsink_change_state):
Don't close the fd in multifdsink as we didn't open it in the
first place. Some cleanups.
2004-09-15 16:03:14 +00:00
Wim Taymans
678795eedf ext/ogg/: Fix the case where the muxer would mark pages as delta frames when they are not (vorbis only ogg).
Original commit message from CVS:
* ext/ogg/gstoggdemux.c: (gst_ogg_pad_push):
* ext/ogg/gstoggmux.c: (gst_ogg_mux_next_buffer),
(gst_ogg_mux_send_headers), (gst_ogg_mux_loop):
Fix the case where the muxer would mark pages as delta
frames when they are not (vorbis only ogg).
2004-09-15 15:37:35 +00:00
Ronald S. Bultje
7ab41eba04 gst/playback/gstplaybasebin.c: Handle the case where we failed to setup a clear pipeline. This will throw an error (o...
Original commit message from CVS:
* gst/playback/gstplaybasebin.c: (state_change), (setup_source),
(gst_play_base_bin_change_state):
Handle the case where we failed to setup a clear pipeline. This
will throw an error (or EOS, another nice case) and if you don't
catch that, the app will wait for the signal forever (and thus
hang).
2004-09-15 08:35:17 +00:00
Ronald S. Bultje
cfe43f5cb7 ext/gnomevfs/: Use _uri_new() instead of _open(), so it doesn't take as long and
Original commit message from CVS:
* ext/gnomevfs/gstgnomevfssink.c:
(gst_gnomevfssink_uri_get_protocols):
* ext/gnomevfs/gstgnomevfssrc.c:
(gst_gnomevfssrc_uri_get_protocols):
* ext/gnomevfs/gstgnomevfsuri.c: (gst_gnomevfs_get_supported_uris):
* ext/gnomevfs/gstgnomevfsuri.h:
Use _uri_new() instead of _open(), so it doesn't take as long and
Christophe's computer won't hang.
* gst/playback/gstplaybasebin.c: (unknown_type):
Throw error on unknown media type, so apps actually display it.
2004-09-15 06:33:43 +00:00
Brian Cameron
818fb5f797 2004-09-14 Brian Cameron <brian.cameron@sun.com
Original commit message from CVS:
2004-09-14  Brian Cameron  <brian.cameron@sun.com

* tools/gst-launch-ext-m.m:  Changed ~ to $ENV{HOME} to allow
this script to work on Solaris since bash shell handles echo
differenly than bash.
2004-09-14 19:30:07 +00:00
Wim Taymans
4de7bdb3ba gst/playback/: Some more work on making sure seeking pauses the pipeline and that changing the uri actually does some...
Original commit message from CVS:
* gst/playback/gstplaybasebin.c: (queue_overrun), (no_more_pads),
(setup_source), (gst_play_base_bin_set_property),
(gst_play_base_bin_add_element):
* gst/playback/gstplaybin.c: (gst_play_bin_send_event):
Some more work on making sure seeking pauses the pipeline and
that changing the uri actually does something.
2004-09-14 16:54:14 +00:00
Wim Taymans
167ec6f8fd gst/tcp/: Be a bit more paranoid when freeing memory.
Original commit message from CVS:
* gst/tcp/gstfdset.c: (gst_fdset_wait):
* gst/tcp/gstmultifdsink.c: (gst_multifdsink_close):
* gst/tcp/gsttcpserversink.c: (gst_tcpserversink_init_send),
(gst_tcpserversink_close):
Be a bit more paranoid when freeing memory.
2004-09-14 14:03:14 +00:00
Ronald S. Bultje
84f449bd4b gst/qtdemux/qtdemux.c: Don't crash by dividing by zero (see sample movie in #126922).
Original commit message from CVS:
* gst/qtdemux/qtdemux.c: (gst_qtdemux_add_stream),
(qtdemux_parse_trak):
Don't crash by dividing by zero (see sample movie in #126922).
2004-09-13 20:13:32 +00:00
Ronald S. Bultje
fe20ee4218 gst/qtdemux/qtdemux.c: Don't touch non-existing data (fixes crash on file in #140147).
Original commit message from CVS:
* gst/qtdemux/qtdemux.c: (qtdemux_audio_caps):
Don't touch non-existing data (fixes crash on file in #140147).
2004-09-13 19:38:42 +00:00
Stéphane Loeuillet
e24bb3990d gst/mpegstream/gstmpegparse.c: fix synchronistation for streams recorded from digital PCR fixes bug #119376
Original commit message from CVS:
* gst/mpegstream/gstmpegparse.c:
fix synchronistation for streams recorded from digital PCR
fixes bug #119376
2004-09-13 18:56:32 +00:00
Ronald S. Bultje
fb76e59415 gst/playback/gstplaybasebin.c: Handle double disposals, and proper change of URIs.
Original commit message from CVS:
* gst/playback/gstplaybasebin.c:
(gst_play_base_bin_dispose), (gst_play_base_bin_set_property):
Handle double disposals, and proper change of URIs.
2004-09-13 18:23:49 +00:00
Ronald S. Bultje
81ca2b2719 ext/gnomevfs/: Add URI support to Gnome-VFS plugins. Tries to load a fixed list of fake URIs to see which this versio...
Original commit message from CVS:
* ext/gnomevfs/Makefile.am:
* ext/gnomevfs/gstgnomevfs.c: (plugin_init):
* ext/gnomevfs/gstgnomevfssink.c: (gst_gnomevfssink_get_type),
(gst_gnomevfssink_dispose), (gst_gnomevfssink_init),
(gst_gnomevfssink_uri_get_type),
(gst_gnomevfssink_uri_get_protocols),
(gst_gnomevfssink_uri_get_uri), (gst_gnomevfssink_uri_set_uri),
(gst_gnomevfssink_uri_handler_init),
(gst_gnomevfssink_set_property), (gst_gnomevfssink_get_property),
(gst_gnomevfssink_open_file), (gst_gnomevfssink_close_file):
* ext/gnomevfs/gstgnomevfssrc.c: (gst_gnomevfssrc_get_type),
(gst_gnomevfssrc_init), (gst_gnomevfssrc_dispose),
(gst_gnomevfssrc_uri_get_type),
(gst_gnomevfssrc_uri_get_protocols), (gst_gnomevfssrc_uri_get_uri),
(gst_gnomevfssrc_uri_set_uri), (gst_gnomevfssrc_uri_handler_init),
(gst_gnomevfssrc_set_property), (gst_gnomevfssrc_get_property),
(gst_gnomevfssrc_open_file), (gst_gnomevfssrc_close_file):
* ext/gnomevfs/gstgnomevfsuri.c: (gst_gnomevfs_get_supported_uris):
* ext/gnomevfs/gstgnomevfsuri.h:
Add URI support to Gnome-VFS plugins. Tries to load a fixed list
of fake URIs to see which this version of Gnome-VFS likes, and
uses that for the Gst-URI interface. Makes playbin support http://
streams. Also fix up some stupid behaviour in gnomevfssrc.
2004-09-13 17:33:18 +00:00
Ronald S. Bultje
56319357ff ext/alsa/gstalsamixer.c: Update mixer (to sync with other sessions) if we try to obtain a new value. This makes alsam...
Original commit message from CVS:
* ext/alsa/gstalsamixer.c: (gst_alsa_mixer_update),
(gst_alsa_mixer_get_volume), (gst_alsa_mixer_set_volume),
(gst_alsa_mixer_set_mute), (gst_alsa_mixer_set_record),
(gst_alsa_mixer_set_option), (gst_alsa_mixer_get_option):
Update mixer (to sync with other sessions) if we try to obtain
a new value. This makes alsamixer work accross applications.
* ext/alsa/gstalsasink.c: (gst_alsa_sink_get_time):
Only call sync functions if we're running, else alsalib asserts.
* ext/ogg/gstoggdemux.c: (gst_ogg_demux_src_query):
Sometimes fails to compile. Possibly a gcc bug.
* gst/playback/gstplaybin.c: (gen_video_element),
(gen_audio_element):
Add a reference to an application-provided object, because we lose
this same reference if we add it to the bin. If we don't do this,
we can only use this object once and thus crash if we go from
ready to playing, back to ready and back to playing again.
Also add an audioscale element because several cheap soundcards -
like mine - don't support all samplerates.
* sys/ximage/ximagesink.c: (gst_ximagesink_xcontext_get),
(gst_ximagesink_xcontext_clear), (gst_ximagesink_change_state):
Fix wrong order or PAR calls. Makes automatically obtained PAR
from the X server atually being used.
2004-09-13 09:24:00 +00:00
David Schleef
e77b1b0e38 Fixes: #151879, #151881, #151882, #151883, #151884, #151886, #151887, #152102, #152247.
Original commit message from CVS:
Fixes: #151879, #151881, #151882, #151883, #151884, #151886,
#151887, #152102, #152247.
* examples/indexing/indexmpeg.c: 64-bit warning fixes.
* examples/seeking/cdparanoia.c: same
* examples/seeking/cdplayer.c: same
* examples/seeking/seek.c: same
* examples/seeking/spider_seek.c: same
* examples/seeking/vorbisfile.c: same
* examples/stats/mp2ogg.c: same
* ext/esd/esdsink.c: (gst_esdsink_class_init),
(gst_esdsink_dispose): Dispose of element properly.
* ext/ivorbis/vorbisfile.c: (gst_ivorbisfile_seek): 64-bit warning
fixes.
* ext/nas/nassink.c: (gst_nassink_class_init),
(gst_nassink_dispose): Dispose of element correctly.
* gst/wavenc/gstwavenc.c: (gst_wavenc_chain): Fix leak.
* sys/ximage/ximagesink.c: (gst_ximagesink_check_xshm_calls),
(gst_ximagesink_ximage_new), (gst_ximagesink_ximage_destroy):
Fix 64-bit warning.
* sys/xvimage/xvimagesink.c: (gst_xvimagesink_check_xshm_calls),
(gst_xvimagesink_xvimage_new), (gst_xvimagesink_xvimage_destroy):
Fix 64-bit warning.
2004-09-12 22:57:26 +00:00
Stéphane Loeuillet
2e89acbcea configure.ac: change speex detection as 1.1.6 now uses .pc/pkg-config and they changed their headers location.
Original commit message from CVS:
* configure.ac : change speex detection as 1.1.6 now uses
.pc/pkg-config and they changed their headers location.
2004-09-12 13:35:52 +00:00
Arwed v. Merkatz
514350e827 Write meta-seek information (seek heads).
Original commit message from CVS:
Write meta-seek information (seek heads).
2004-09-09 17:54:26 +00:00
Arwed v. Merkatz
0cc752a8ac Write multiple blocks/frames per cluster.
Original commit message from CVS:
Write multiple blocks/frames per cluster.
2004-09-09 15:40:06 +00:00
Scott Wheeler
49656f5fad Added a volume element to the gstplaybin pipeline and an element for setting it.
Original commit message from CVS:
Added a volume element to the gstplaybin pipeline and an element for setting
it.
2004-09-09 15:28:20 +00:00
Wim Taymans
53aaed648c gst/videomixer/videomixer.c: Copy timestamps from the master pad to the output buffers.
Original commit message from CVS:
* gst/videomixer/videomixer.c: (gst_videomixer_blend_buffers):
Copy timestamps from the master pad to the output buffers.
2004-09-07 13:40:52 +00:00
Thomas Vander Stichele
2dcf08d1fe throw errors when applicable
Original commit message from CVS:
throw errors when applicable
2004-09-03 16:45:35 +00:00
Arwed v. Merkatz
4de25edc2e Create cue entries for audio only files.
Original commit message from CVS:
Create cue entries for audio only files.
Fix writing of CUETIME, wrongly used gst_ebml_write_date.
2004-09-01 13:41:36 +00:00
Arwed v. Merkatz
cf31caeb87 Write track and segment UIDs, write muxing date, write TRACKDEFAULTDURATION for TTA audio, write BLOCKDURATION if known.
Original commit message from CVS:
Write track and segment UIDs, write muxing date, write TRACKDEFAULTDURATION for TTA audio, write BLOCKDURATION if known.
2004-09-01 12:10:11 +00:00
Ronald S. Bultje
5638dbb982 ext/alsa/: Re-commit ALSA switches.
Original commit message from CVS:
* ext/alsa/gstalsamixer.c: (gst_alsa_mixer_build_list):
* ext/alsa/gstalsamixertrack.c: (gst_alsa_mixer_track_new):
Re-commit ALSA switches.
* gst/adder/gstadder.c: (gst_adder_loop):
64-bit fix (#151416).
* gst/debug/progressreport.c: (gst_progressreport_report):
64-bit fix (#151419).
* gst/matroska/matroska-demux.c:
(gst_matroska_demux_parse_contents):
64-bit fix (#151420).
* gst/playback/test3.c: (update_scale):
64-bit fix (#151421).
2004-08-31 14:12:40 +00:00
Thomas Vander Stichele
6288919988 bump nano to cvs
Original commit message from CVS:
bump nano to cvs
2004-08-31 14:04:38 +00:00
Thomas Vander Stichele
c53237a743 releasing
Original commit message from CVS:
releasing
2004-08-31 09:51:49 +00:00
Thomas Vander Stichele
9d659fe404 fix #151462
Original commit message from CVS:
fix #151462
2004-08-31 08:45:46 +00:00
Ronald S. Bultje
232ca30200 revert (freeze) until release has been made
Original commit message from CVS:
revert (freeze) until release has been made
2004-08-30 18:41:32 +00:00
Wim Taymans
1d6ff4028b gst/tcp/: Fix some memory leaks.
Original commit message from CVS:
* gst/tcp/gstfdset.c: (gst_fdset_free), (gst_fdset_wait):
* gst/tcp/gstmultifdsink.c: (gst_multifdsink_add),
(gst_multifdsink_remove_client_link),
(gst_multifdsink_client_queue_buffer),
(gst_multifdsink_handle_client_write):
* gst/tcp/gsttcpclientsink.c: (gst_tcpclientsink_init_send):
* gst/tcp/gsttcpclientsrc.c: (gst_tcpclientsrc_init_receive):
Fix some memory leaks.
2004-08-30 10:28:40 +00:00
Thomas Vander Stichele
81be759fc6 fix for 151236
Original commit message from CVS:
fix for 151236
2004-08-30 10:26:52 +00:00
Thomas Vander Stichele
22e8e61f2a fixes #151232
Original commit message from CVS:
fixes #151232
2004-08-30 10:03:18 +00:00
Ronald S. Bultje
beda391579 ext/alsa/: Add switches (simple boolean on/off).
Original commit message from CVS:
* ext/alsa/gstalsamixer.c: (gst_alsa_mixer_build_list):
* ext/alsa/gstalsamixertrack.c: (gst_alsa_mixer_track_new):
Add switches (simple boolean on/off).
2004-08-29 19:37:38 +00:00
David Schleef
da2168ed41 sys/glsink/glimagesink.c: Move local variable declarations to make gcc-2.95 happy.
Original commit message from CVS:
* sys/glsink/glimagesink.c: (gst_glimagesink_ximage_put),
(gst_glimagesink_xwindow_new), (gst_glimagesink_xcontext_get),
(gst_glimagesink_fixate):  Move local variable declarations to
make gcc-2.95 happy.
2004-08-27 19:18:24 +00:00
Thomas Vander Stichele
5176ff36f6 prerelease
Original commit message from CVS:
prerelease
2004-08-27 17:38:17 +00:00
Balamurali Viswanathan
51613ff6ac sys/sunaudio/Makefile.am: Add sunaudiosrc patch from Bala
Original commit message from CVS:
* sys/sunaudio/Makefile.am: Add sunaudiosrc patch from Bala
* sys/sunaudio/gstsunaudiosrc.c:
* sys/sunaudio/gstsunaudiosrc.h:
2004-08-27 17:05:20 +00:00
Arwed v. Merkatz
d6605f3d6d Mux video/x-divx and video/x-xvid in VFW compatibility mode so it actually works
Original commit message from CVS:
Mux video/x-divx and video/x-xvid in VFW compatibility mode so it actually works
2004-08-27 17:01:11 +00:00
Arwed v. Merkatz
22f8db881a Handle EOS correctly.
Original commit message from CVS:
Handle EOS correctly.
2004-08-27 14:10:08 +00:00