Tim-Philipp Müller
9bf90f47cf
video/x-xvid -> video/mpeg,mpegversion=4
2012-09-03 02:51:24 +01:00
Tim-Philipp Müller
045c4b6ec8
deinterlace: the field in caps is "interlace-mode" not "interlace-method"
...
Fix deinterlace unit test. Need to set right field on output caps.
Also remove right field (not old 0.10 "interlaced" boolean field)
from caps in unit test before comparing old and new.
2012-08-27 21:20:29 +01:00
Tim-Philipp Müller
d35fbcf6f1
tests: fix icydemux unit test
...
Was waiting for a tag message on the bus, which would never
come, because elements don't post those themselves any more
but let sinks post them from tag events. Only that there are
no sinks in this unit test.
2012-08-27 21:20:29 +01:00
Tim-Philipp Müller
a62f9b178d
tests: fix videocrop crop_to_1x1 unit test for GRAY8 format
...
Update table with pixel values with the value actually produced
by videotestsrc.
2012-08-27 21:20:29 +01:00
Stefan Sauer
1f255a585b
equalizer: enable presets for the n-band equalizer
...
Add a test for saving and restoring the preset.
2012-08-17 15:01:40 +02:00
Olivier Crête
264bcf7d6f
rtph264pay: Make it actually work after cleanups
2012-08-08 19:49:05 -07:00
Tim-Philipp Müller
c074bfd0b9
gst_tag_list_free -> gst_tag_list_unref
2012-08-04 16:10:16 +01:00
Sebastian Dröge
0827f54b93
tag: Update for taglist/tag event API changes
2012-07-28 00:19:51 +02:00
Tim-Philipp Müller
f3f71b9749
tests: minor jpegdec clean-ups and fixes
...
Fix race condition in eos checking and a leak. And
build pipeline without parse_launch.
2012-07-08 13:30:34 +01:00
Mathias Hasselmann
0da9456ba2
tests: Add some basic tests for jpegdec
...
https://bugzilla.gnome.org/show_bug.cgi?id=676302
2012-07-08 12:56:31 +01:00
Tim-Philipp Müller
48706beb70
rtph263ppay: accept any h263 input unless downstream forces specific requirements
...
rtph263ppay should accept any input compatible with its sink template
caps if it just outputs to e.g. udpsink or fakesink.
rtph263ppay ! rtph263pdepay should also work with any compatible input.
This would fail before with not-negotiated errors because the get_caps
function would see the encoding-name in the depayloader's template caps
and default to baseline H.263 because there's no profile/level information
in those caps, which is the right thing to do if downstream has filtercaps
from an SDP, but not if those fields are absent because they can be
anything like with the depayloader's template caps. Makes
videotestsrc ! avenc_h263p ! rtph263ppay ! rtph263pdepay ! fakesink
work.
2012-07-06 11:57:38 +01:00
Tim-Philipp Müller
76625d20d7
tests: fix h263p payload ! depayload unit test
...
Need to add h263version field to input caps since the
payloader sink get_caps function will contain it in the
the caps, and the stricter caps subset check requires
this to be present in the input caps as well then.
2012-07-06 11:57:38 +01:00
Tim-Philipp Müller
91d97d31e2
tests: fix rgvolume unit test event handling
...
Must flush after EOS before sending more buffers or
another EOS event, or the event or buffer will be
rejected. Also send a SEGMENT event at the start
of each stream for good measure.
2012-07-05 15:14:33 +01:00
Tim-Philipp Müller
a94c1a7fdb
tests: fix rganalysis unit test event handling
...
Must flush after EOS before sending more buffers or
another EOS event, or the event or buffer will be
rejected. Also send a SEGMENT event at the start
of each stream for good measure.
2012-07-04 23:57:18 +01:00
Tim-Philipp Müller
94e54887fb
tests: disable deinterlace test for now, element still needs to be ported
...
But leave it active and print a FIXME. Porting is in progress.
2012-07-04 12:39:07 +01:00
Wim Taymans
d1b0ff6c06
update for bus api changes
2012-06-20 12:31:01 +02:00
Wim Taymans
f65495d405
update for audio api change
2012-06-08 10:11:12 +02:00
Wim Taymans
443a14bdbf
tests: add test for rtpsession cleanup
2012-06-07 10:44:31 +02:00
Wim Taymans
b5df4f0e62
update for tag event change
2012-06-06 13:02:12 +02:00
Wim Taymans
37df608fdc
fix Y800 format
2012-06-06 13:00:58 +02:00
Tim-Philipp Müller
dd75c21670
annodex: remove annodex plugin and CMML elements
...
This never really took off and is most likely completely
unused. If there is still a need for this, it should
probably be done differently, perhaps inside oggdemux/mux.
2012-05-13 19:21:19 +01:00
Tim-Philipp Müller
95da93fcb7
tests: fix matroskamux unit test after media type changes
2012-04-28 23:14:24 +01:00
Tim-Philipp Müller
fa5edd2680
interleave: make channel-poisitions property a GValueArray again
...
Or perhaps it should just be a guint64 channel mask, which would
be nicer in C, but more awkward for bindings (even more so since
we can't add a flags type for it, since that only supports guint
size flags). Fixes wavenc unit test.
https://bugzilla.gnome.org/show_bug.cgi?id=669643
2012-04-09 11:13:05 +01:00
Mark Nauwelaerts
6a0339bf24
tests: make few tests more valgrind-friendly
2012-04-05 19:17:48 +02:00
Mark Nauwelaerts
0c49dcd0c6
(de)interleave: fix ported unit test and enable as ported
2012-04-05 19:17:42 +02:00
Mark Nauwelaerts
ac0d2254f0
tests: cmmldec: adjust to tag events no longer posted on bus by element
2012-04-05 19:17:38 +02:00
Mark Nauwelaerts
732f29dbbe
tests: qtmux: ensure initialized test buffer memory
2012-04-04 21:38:14 +02:00
Wim Taymans
068ee88862
update for child proxy api change
2012-03-31 15:43:49 +02:00
Wim Taymans
3d61d12e03
update for buffer api change
2012-03-30 18:15:34 +02:00
Mark Nauwelaerts
fce8f3486b
tests: videocrop: unmap video frame and unref caps
2012-03-29 17:22:19 +02:00
Mark Nauwelaerts
9f93f503a1
tests: audiowsincband: unmap examined output buffers
2012-03-29 17:22:04 +02:00
Wim Taymans
69002aa24f
update for buffer changes
2012-03-28 12:53:05 +02:00
Mark Nauwelaerts
8f68db9cc3
tests: audiodynamic: correctly port original test to mind in place transform
2012-03-28 12:23:56 +02:00
Mark Nauwelaerts
2ed647a900
tests: audiofirfilter: negotiate the intended raw audio format
2012-03-28 12:23:56 +02:00
Wim Taymans
e310ee8218
caps: improve caps handling
...
Avoid caps copy and leaks
2012-03-27 16:42:41 +02:00
Mark Nauwelaerts
8f52f8c5c8
tests: icydemux: activate internal test helper src pad
2012-03-27 14:05:27 +02:00
Mark Nauwelaerts
117de9fd47
tests: replaygain: misc compatibility fixes
...
Discard caps event when checking for and counting various tag events,
and remove all testing of 8 bits depth in 16 bits width format since
it no longer exists.
2012-03-26 18:38:34 +02:00
Mark Nauwelaerts
85bf98fe1a
tests: rtp: misc compatibiliy fixes
...
... such as always setting pad caps and providing needed caps fields.
2012-03-26 18:38:34 +02:00
Mark Nauwelaerts
9c1787851d
tests: videofilter: ensure initial segment event
2012-03-26 18:38:34 +02:00
Mark Nauwelaerts
e937d38544
tests: imagefreeze: remove extraneous _unref
2012-03-23 18:49:01 +01:00
Mark Nauwelaerts
e94f68fd6b
tests: avimux: adjust to modified sink pad template name
2012-03-23 18:49:01 +01:00
Mark Nauwelaerts
43ceadb0df
tests: qtmux: cleanup element sooner
...
... to avoid stray refs in sticky caps events.
2012-03-23 18:49:01 +01:00
Mark Nauwelaerts
6bb7fdf4c5
tests: arrange for sending an initial segment event
...
... which is needed nowadays since various gst_segment_to_...
no longer automatically set the format to the specified one
(from _UNDEFINED).
2012-03-23 18:49:01 +01:00
Wim Taymans
3e8ae7603c
tests: update for memory api changes
2012-03-21 13:22:43 +01:00
Wim Taymans
ecaea36c3d
update for memory api changes
2012-03-15 13:36:17 +01:00
Wim Taymans
075cd54019
fix for caps _normalize changes
2012-03-12 12:23:15 +01:00
Wim Taymans
bb8bc237b5
tests: improve more tests
2012-03-08 11:36:01 +01:00
Wim Taymans
65d59232b1
tests: fix some more tests
2012-03-08 11:20:43 +01:00
Mark Nauwelaerts
e637cfb212
tests: port wavpack tests to 0.11
2012-03-05 13:44:21 +01:00
Mark Nauwelaerts
f189f62b13
Merge branch 'master' into 0.11
...
Conflicts:
ext/wavpack/gstwavpackenc.c
tests/check/elements/audioiirfilter.c
tests/examples/v4l2/probe.c
2012-03-01 11:29:50 +01:00
Mark Nauwelaerts
a5144cbba0
wavpackdec: adjust to audio format limitations
...
... which does not allow expressing arbitrary depth in a GstAudioFormat.
Also adjust unit test to modified behaviour.
2012-02-27 23:46:15 +01:00
Mark Nauwelaerts
b863df570f
wavpackenc: port to audioencoder
...
Also adjust unit test to slightly modified behaviour.
2012-02-27 23:45:54 +01:00
Edward Hervey
9beda57c3a
Suppress deprecation warnings in selected files, for g_value_array_* mostly
2012-02-27 14:47:25 +01:00
Wim Taymans
ca9532ccc5
update for new memory api
2012-02-22 02:10:33 +01:00
Tim-Philipp Müller
dc3beab0ab
tests: fix up level test for GstValueList -> GValueArray change
...
https://bugzilla.gnome.org/show_bug.cgi?id=670303
2012-02-18 11:38:36 +00:00
Philippe Normand
4945af5eff
interleave: port to 0.11
...
Port of the interleave element and its unittests.
https://bugzilla.gnome.org/show_bug.cgi?id=669643
2012-02-16 14:40:59 +00:00
Wim Taymans
63ec4ca38b
Merge branch 'master' into 0.11
...
Conflicts:
tests/check/elements/flacparse.c
2012-02-14 10:51:38 +01:00
Mark Nauwelaerts
ec6b2e8659
tests: flacparse: check and compare intended data
2012-02-13 12:07:17 +01:00
Wim Taymans
225e98d623
Merge branch 'master' into 0.11
...
Conflicts:
ext/flac/gstflacenc.c
ext/jack/gstjackaudioclient.c
ext/jack/gstjackaudiosink.c
ext/jack/gstjackaudiosrc.c
ext/pulse/plugin.c
ext/shout2/gstshout2.c
gst/matroska/matroska-mux.c
gst/rtp/gstrtph264pay.c
2012-02-10 16:23:14 +01:00
Tim-Philipp Müller
dca42d4767
tests: clean up rtp-payloading test a little
...
Feed data into the pipeline using appsrc instead of fdsrc and
a pipe. Store unsigned byte values in guint8 instead of char.
Getting rid of the capsfilter also helps to avoid 'format is
not fully specified' warnings when pushing "video/x-h264" data
into rtph264pay with fully specified h264 caps in the sink template.
2012-02-10 14:07:45 +00:00
Mark Nauwelaerts
507f936778
tests: mpegaudioparse: remove stray declaration
2012-02-09 22:13:11 +01:00
Wim Taymans
9737bf26f0
tests: fix compilation
2012-02-09 18:09:45 +01:00
Philippe Normand
640be49e21
deinterleave: port to 0.11
...
Port of the deinterleave element and its unittests. The interleave
element will be ported as part of another patch, hence disabling it
for now.
https://bugzilla.gnome.org/show_bug.cgi?id=668847
2012-02-08 10:40:39 +01:00
Wim Taymans
412510d6ed
tests: improve tagmux tests
2012-02-07 10:47:19 +01:00
Wim Taymans
3644e23184
tests: fix jpeg test
2012-02-07 10:30:28 +01:00
Wim Taymans
02034ce772
tests: fix more tests
2012-02-07 10:30:28 +01:00
Wim Taymans
92a0c01732
test: fix more tests
2012-02-06 18:35:01 +01:00
Wim Taymans
9a76a00a4d
tests: fix more tests
2012-02-06 15:52:49 +01:00
Wim Taymans
dd26b14930
iirequalizer: fix equalizer and unit test
2012-02-06 15:20:55 +01:00
Wim Taymans
41648135b2
tests: fix some more tests
2012-02-06 13:44:20 +01:00
Wim Taymans
f3f54403b1
tests: fix more unit tests
2012-02-06 13:29:24 +01:00
Wim Taymans
ef0686c52c
tests: fix more tests
2012-02-06 10:07:06 +01:00
Wim Taymans
16cc9b3807
tests: improve some tests
2012-02-06 09:49:38 +01:00
Wim Taymans
f75fa8e3c3
tests: fix jitterbuffer test
2012-02-06 09:23:49 +01:00
Wim Taymans
8f2ef99b5b
tests: fix more tests
2012-02-03 17:23:48 +01:00
Wim Taymans
56eb65babc
tests: fix some more tests
2012-02-03 16:14:08 +01:00
Wim Taymans
a6370cdb50
tests: fix more tests
2012-01-31 15:39:09 +01:00
Wim Taymans
2a91bbbc0b
tests: update some tests for new memory api
2012-01-31 13:42:55 +01:00
Wim Taymans
bb2bd604e0
update for HEADER flag
2012-01-30 17:16:51 +01:00
Sebastian Dröge
0b517ce9fb
Merge branch '0.11' of ssh://git.freedesktop.org/git/gstreamer/gst-plugins-good into 0.11
2012-01-25 12:49:34 +01:00
Sebastian Dröge
10554b271f
Merge branch 'master' into 0.11
...
Conflicts:
ext/flac/gstflacdec.c
ext/jpeg/gstjpegenc.c
ext/pulse/pulsesink.c
sys/v4l2/gstv4l2src.c
2012-01-25 12:49:11 +01:00
Wim Taymans
b4630dd3e0
more memory API porting
2012-01-25 12:30:29 +01:00
Tim-Philipp Müller
7cb9b7ab9d
Use new GLib API unconditionally
2012-01-22 23:15:19 +00:00
Wim Taymans
1584806634
port to new gthread API
2012-01-19 11:33:53 +01:00
Vincent Penquerc'h
e9e0bebde3
tests: fix autodetect test not testing correctly for state change success
...
State change to PAUSED can be done async, so if this happens, we need
to wait for the change to be done (or failed).
2012-01-16 16:10:08 +00:00
Vincent Penquerc'h
4c2a2063cf
tests: fix caps leak in videotestsrc test
2012-01-13 15:57:20 +00:00
Leo Singer
56353e24d2
audiofx: Use most common convention for definitions of IIR filter coefficients.
...
Most signal processing texts, including MATLAB, use the following convention for IIR filter coefficients:
a_0 y[n] + a_1 y[n-1] + ... + a_M y[n-M] = b_0 x[n] + b_1 x[n-1] + ... + b[N] x[n-N]
Usually, a_0 is set to 1 because the coefficients can always be rescaled, giving
y[n] = b_0 x[n] + b_1 x[n-1] + ... + b[N] x[n-N] - a_1 y[n-1] - ... - a_M y[n-M]
The convention that was previously used by audiofxbaseiirfilter and derived class had the a and b coefficients swapped, and did not have the minus signs.
This change makes the audiofx plugin use the more common convention described above.
2012-01-11 15:24:00 +01:00
Sebastian Dröge
93e3ed5a86
Merge branch 'master' into 0.11
...
Conflicts:
ext/cairo/gsttextoverlay.c
ext/pulse/pulseaudiosink.c
gst/audioparsers/gstaacparse.c
gst/avi/gstavimux.c
gst/flv/gstflvmux.c
gst/interleave/interleave.c
gst/isomp4/gstqtmux.c
gst/matroska/matroska-demux.c
gst/matroska/matroska-mux.c
gst/matroska/matroska-mux.h
gst/matroska/matroska-read-common.c
gst/multifile/gstmultifilesink.c
gst/multipart/multipartmux.c
gst/shapewipe/gstshapewipe.c
gst/smpte/gstsmpte.c
gst/udp/gstmultiudpsink.c
gst/videobox/gstvideobox.c
gst/videocrop/gstaspectratiocrop.c
gst/videomixer/videomixer.c
gst/videomixer/videomixer2.c
gst/wavparse/gstwavparse.c
po/ja.po
po/lv.po
po/sr.po
tests/check/Makefile.am
tests/check/elements/qtmux.c
tests/check/elements/rgvolume.c
2012-01-10 14:32:32 +01:00
Tim-Philipp Müller
12ff707854
tests: fix some leaks and remove files when done in qtmux test
2012-01-04 18:05:41 +00:00
Edward Hervey
63ee1009c2
alphacolor: More fixes/cleanup
2012-01-04 13:26:45 +01:00
Wim Taymans
8e39d52bbb
tests: make more tests compile
2012-01-03 14:16:28 +01:00
Wim Taymans
06b3c265b8
test: make more unit tests compile
2012-01-03 11:56:25 +01:00
Wim Taymans
08d8b81005
tests: fix some unit tests
...
Remove unit test for GstIndex.
Make some other unit tests compile
2012-01-03 10:26:48 +01:00
Tim-Philipp Müller
56c1003f7a
tests: make git ignore new unit test binary
2011-12-27 12:06:25 +00:00
Tim-Philipp Müller
b744ad03cc
udpsrc: add unit test that sends 0-size packet
...
https://bugzilla.gnome.org/show_bug.cgi?id=666644
2011-12-27 11:49:10 +00:00
Tim-Philipp Müller
abd27e2caa
tests: use atexit, g_atexit has been deprecated in glib master
2011-12-12 10:18:14 +00:00
Tim-Philipp Müller
72fc3d1bd9
tests: g_thread_init() is deprecated in glib master
...
It's not needed any longer.
2011-12-12 09:46:27 +00:00
Tim-Philipp Müller
60e53346af
tests: fix up rgvolume test for basetransform event caching
...
Some tests assumed that tag events would always pushed through
immediately, which isn't the case any longer, so push a newsegment
event and an empty buffer first.
2011-12-10 13:05:07 +00:00
Tim-Philipp Müller
d895ac645f
Merge remote-tracking branch 'origin/master' into 0.11
...
Conflicts:
docs/plugins/inspect/plugin-esdsink.xml
docs/plugins/inspect/plugin-gconfelements.xml
ext/pulse/pulseaudiosink.c
gst/matroska/matroska-demux.c
gst/matroska/matroska-mux.c
gst/multifile/gstmultifilesink.c
2011-12-02 01:58:30 +00:00
Wim Taymans
f1558baf83
update for tag API changes
2011-12-01 18:55:45 +01:00
Alessandro Decina
5cc1c6c897
tests: fix g_mkdtemp presence check in multifile tests
...
g_mkdtemp was added in glib 2.30 even though the doc claims it was added in
2.26.
2011-12-01 13:25:45 +01:00
Alessandro Decina
ed98755241
multifilesink: add flag to cut after a force key unit event
2011-12-01 13:25:45 +01:00
Vincent Penquerc'h
c0e101e93f
various: fix pad template leaks
...
https://bugzilla.gnome.org/show_bug.cgi?id=662664
2011-11-28 13:30:27 +00:00
René Stadler
17240ac9ec
matroska: port to 0.11
...
Support for TAG_IMAGE and TAG_ATTACHMENT is commented out; this requires caps
on buffers which is gone from 0.11.
Segment handling in the demuxer is a bit complex; I added some FIXME comments
in places where I'm not yet sure if I ported correctly.
2011-11-26 15:01:01 +01:00
Tim-Philipp Müller
be0d6baac5
Merge remote-tracking branch 'origin/master' into 0.11
...
Conflicts:
ext/pulse/pulseaudiosink.c
ext/pulse/pulsesrc.c
gst/audioparsers/gstaacparse.c
gst/audioparsers/gstamrparse.c
gst/audioparsers/gstdcaparse.c
gst/audioparsers/gstflacparse.c
gst/effectv/gstradioac.c
gst/effectv/gstradioac.h
gst/effectv/gstripple.c
Some possible FIXMEs remaining in the audio parser getcaps functions.
2011-11-26 13:34:10 +00:00
René Stadler
a806ae2edd
tests: update for gstcheck API change
2011-11-24 21:41:03 +01:00
Thiago Santos
3dc5a09a5c
multifile: fix build of tests
...
Tests fail to build because g_mkdtemp is available from glib since
2.26.
This patch adds a condition around the redefinition of
g_mkdtemp on the tests to only build it if glib is older than
2.26.
2011-11-24 14:18:44 -03:00
Tim-Philipp Müller
32365953c3
tests: update soup test for removed iradio-mode property
2011-11-24 01:48:25 +00:00
Tim-Philipp Müller
09ca5fa910
rtpmanager: rename gstrtp* -> rtp*
...
This was done in 0.10 to avoid conflict with the rtp elements in
farsight, but the gst-prefixing is no longer needed in 0.11
2011-11-24 00:54:08 +00:00
Wim Taymans
c5cad2aff2
Merge branch 'master' into 0.11
2011-11-23 10:23:28 +01:00
Tim-Philipp Müller
38c9fefa01
tests: add basic unit test for matroskaparse
2011-11-23 01:00:17 +00:00
Tim-Philipp Müller
7900933a52
tests: make id3demux test compile
...
Still fails though.
2011-11-14 09:50:08 +00:00
Wim Taymans
a95acb7122
make %u in all request pad templates
2011-11-04 11:58:22 +01:00
René Stadler
fb63372713
tests: audioecho: port to 0.11
2011-10-28 21:22:38 +02:00
René Stadler
ad095ae316
tests: audiochebband: port to 0.11
2011-10-28 21:22:38 +02:00
René Stadler
8e0213a47a
tests: audiocheblimit: port to 0.11
2011-10-28 13:08:48 +02:00
René Stadler
0b3f685dbd
tests: audioamplify: port to 0.11
2011-10-28 13:08:48 +02:00
René Stadler
b44647c043
tests: audiodynamic: port to 0.11
2011-10-28 11:25:37 +02:00
René Stadler
24300315e7
tests: spectrum: port to 0.11
2011-10-28 11:25:37 +02:00
René Stadler
f1c471b2b1
tests: audiopanorama: port to 0.11
2011-10-28 11:25:37 +02:00
Thiago Santos
2490d39a90
tests: aspectratiocrop: Port to 0.11
2011-10-13 15:37:47 -03:00
Thiago Santos
12534340fd
tests: alphacolor: Port to 0.11
2011-10-13 15:37:46 -03:00
Thiago Santos
36d069fe37
tests: cmmlenc: Port to 0.11
2011-10-12 08:09:33 -03:00
Thiago Santos
011c3f4d1b
tests: cmmldec: Port to 0.11
2011-10-12 08:09:16 -03:00
Wim Taymans
586ef0babd
Merge branch 'master' into 0.11
...
Conflicts:
ext/speex/gstspeexdec.c
ext/speex/gstspeexenc.c
gst/isomp4/atoms.c
gst/isomp4/gstqtmux.c
2011-10-06 12:23:39 +02:00
Thiago Santos
a4154e9db2
tests: qtmux: Refactor bitrate check test
...
Refactor bitrate check test to accomodate multiple tests
for bitrate
2011-09-30 13:05:24 -03:00
Thiago Santos
e58b0466ec
tests: qtmux: add tests for bitrate average calculation
...
Adds tests to make sure qtmux/mp4mux sets average bitrate
correctly
2011-09-30 13:05:20 -03:00
Wim Taymans
87fbd1e784
Merge branch 'master' into 0.11
...
Conflicts:
common
ext/pulse/pulsesink.c
ext/soup/gstsouphttpclientsink.c
gst/audioparsers/gstaacparse.c
gst/audioparsers/gstac3parse.c
gst/rtp/gstrtph264depay.c
gst/rtpmanager/gstrtpjitterbuffer.c
gst/rtpmanager/rtpjitterbuffer.c
gst/rtsp/gstrtspsrc.c
sys/ximage/gstximagesrc.c
2011-09-28 12:44:59 +02:00
Tim-Philipp Müller
b6b072e948
tests: add unit test to make sure encodebin picks mp4mux for variant=iso
...
https://bugzilla.gnome.org/show_bug.cgi?id=651496
2011-09-20 12:55:31 +01:00
Thiago Santos
c78048bc25
tests: flvmux: Fix flvmux's tests after fix for request pads handling
...
Now that flvmux doesn't release its request pads on PAUSED->READY the
test doesn't need to re-request them for every reuse test start.
2011-09-12 09:21:47 -03:00
Sebastian Dröge
8f1f6d1a57
cmml: Use complete cmml caps in the unit test
2011-09-07 14:30:27 +02:00
Sebastian Dröge
0fd1397921
qtmux: Use complete MPEG caps in the unit test
2011-09-07 14:30:27 +02:00
Wim Taymans
33f18b8ea4
Merge branch 'master' into 0.11
...
Conflicts:
gst/audioparsers/gstamrparse.c
gst/isomp4/qtdemux.c
2011-09-06 16:06:25 +02:00
Mark Nauwelaerts
077a306054
tests: parsers: provide more real data when testing draining of garbage
2011-09-05 15:51:53 +02:00
Wim Taymans
77ad0a1363
port more elements to new audio caps and API
2011-08-19 14:01:45 +02:00
Wim Taymans
dfd91ba704
tests: update for _negotiated_caps() change
2011-08-15 12:19:14 +02:00
Wim Taymans
4121021bb2
Merge branch 'master' into 0.11
...
Conflicts:
ext/pulse/pulsesink.c
ext/pulse/pulsesrc.c
gst/audioparsers/gstac3parse.c
gst/rtp/gstrtph264depay.c
gst/rtp/gstrtph264pay.c
gst/rtpmanager/gstrtpssrcdemux.c
2011-08-03 18:25:30 +02:00
Edward Hervey
70fcf510be
Revert "tests/check/Makefile.am: Disable autodetect test temporarily, so that the build bots update -bad and the ranks of unr..."
...
This reverts commit 475aed8af6
.
It won't consider elements from anywhere else anymore
2011-08-03 13:33:59 +02:00
Edward Hervey
a2341918c4
check: Update parser mini-lib to 0.11 API
2011-08-03 13:10:46 +02:00
Arun Raghavan
96972eb462
ac3parse: Add support for IEC 61937 alignment
...
When pushing out buffers over S/PDIF or HDMI, IEC 61937 payloading
requires each buffer to contain 6 blocks from each substream. This adds
code to collect all the frames needed to meet this requirement before
pushing out a buffer.
https://bugzilla.gnome.org/show_bug.cgi?id=650313
2011-07-26 10:40:00 +05:30
Alessandro Decina
072bd74cc4
multifilesink: add max-files property
...
Add max-files property to limit the number of files saved on disk.
API: multifilesink::max-files
2011-07-18 10:21:41 +02:00
Tim-Philipp Müller
c6abc45d27
tests: add index-setting test for baseparse/flacparse
...
https://bugzilla.gnome.org/show_bug.cgi?id=646811
2011-04-19 14:20:37 +01:00
Sebastian Dröge
dd2ff5a902
imagefreeze: Remove bus GSource to prevent a valgrind warning
2011-04-18 11:10:01 +02:00
Robert Swain
4893678fd1
tests: Address unused but set variables
...
GCC 4.6.x spits warnings about such usage of variables.
2011-04-16 13:10:58 +01:00
Mark Nauwelaerts
5f051fd996
tests: qtmux: test various dts-methods
2011-04-15 12:49:14 +02:00
Tim-Philipp Müller
025417f124
qtmux: add variant-less video/quicktime to source pad template caps
...
This is needed for automatic transcoding using encodebin. Our typefinder
does not always add a variant to the found caps, and encodebin needs
an *exact* match to the caps on the source pad template, so we need
to add the variant-less video/quicktime caps to the template as well
for encodebin to be able to find it. Add unit test for this as well.
https://bugzilla.gnome.org/show_bug.cgi?id=642879
2011-04-13 15:21:59 +01:00
Tim-Philipp Müller
9648747ce9
tests: ignore new qtmux-related test binaries
2011-04-13 12:45:27 +01:00
Thiago Santos
3d2280beb9
test: qtmux: Tests qtmux reuse
...
Forces the use of qtmux after it has been put to PLAYING and back
to NULL once
https://bugzilla.gnome.org/show_bug.cgi?id=639338
2011-04-12 20:32:21 +01:00
Mark Nauwelaerts
197c3e8a7d
tests: qtmux: also unit test fragmented file cases
2011-04-12 20:32:20 +01:00
Benjamin Otte
c4161b3c33
Add -Wwrite-strings
...
and fix its warnings
2011-04-12 20:32:17 +01:00
Benjamin Otte
62be91708f
Add -Wmissing-declarations -Wmissing-prototypes to configure flags
...
And fix all warnings
2011-04-12 20:32:17 +01:00
Mark Nauwelaerts
2196cf6b49
tests/check/: Add unit test for qtmux.
...
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/elements/qtmux.c: (setup_src_pad),
(teardown_src_pad), (setup_qtmux), (cleanup_qtmux),
(check_qtmux_pad), (GST_START_TEST), (qtmux_suite), (main):
Add unit test for qtmux.
2011-04-12 20:32:09 +01:00
Tim-Philipp Müller
6be6fe5db8
tests: hook up audioparser unit tests
2011-04-08 18:07:18 +01:00
David Schleef
6c9a7f6323
tests: fix baseparse test
2011-04-08 18:07:16 +01:00
Sebastian Dröge
46ea4eaa1f
flacparse: Adjust unit tests to new flacparse behaviour
...
Garbage after frames is now included in the frames because flacparse
has no easy way to detect the real end of a frame. Decoders are
expected to everything after the frame because only decoding the
bitstream will reveal the real end of the frame.
Fixes bug #631814 .
2011-04-08 18:07:11 +01:00
Mark Nauwelaerts
fbbc09e47d
audioparsers: add flacparse unit test
...
... and tweak parser test helper in the process.
2011-04-08 18:07:09 +01:00
Mark Nauwelaerts
f8ec616d9d
audioparsers: add ac3parse and mpegaudioparse unit test
2011-04-08 18:07:08 +01:00
Mark Nauwelaerts
edb495646d
audioparsers: refactor existing unit tests using common helper
2011-04-08 18:07:08 +01:00
Edward Hervey
6bd1be78bf
check: Don't re-declare 'GList *buffers' in the tests
...
It's an external which lives in gstcheck.c. Redeclaring it makes some
compilers/architectures think the 'buffers' in the individual tests are
a different symbol... and therefore we end up comparing holodecks with
oranges.
2011-04-08 18:07:06 +01:00
Benjamin Otte
ead9bd6b62
Add -Wold-style-definition
...
and fix the warnings
2011-04-08 18:07:04 +01:00
Benjamin Otte
50356ade08
Add -Wmissing-declarations -Wmissing-prototypes to configure flags
...
And fix all warnings
2011-04-08 18:07:04 +01:00
Thiago Santos
13c76e3bc3
Rename aac's stream-format 'none' to 'raw'
...
Renames aac's stream-format from previous commits from none to
raw
2011-04-08 18:07:04 +01:00
Thiago Santos
ed0c1564ca
aacparse: update tests to stream-format changes
...
Updates aacparse unit tests to check for stream-format
correctness as well.
2011-04-08 18:07:04 +01:00
Tim-Philipp Müller
fc09fe78af
aacparse: set channels and rate on output caps, and keep codec_data
...
Create output caps from input caps, so we maintain any fields we
might get on the input caps, such as codec_data or rate and channels.
Set channels and rate on the output caps if we don't have input caps
or they don't contain such fields. We do this partly because we can,
but also because some muxers need this information. Tagreadbin will
also be happy about this.
2011-04-08 18:06:57 +01:00
Stefan Kost
c3faaa2daa
tests/check/: Add unit tests for new parsers.
...
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/elements/aacparse.c:
* tests/check/elements/amrparse.c:
Add unit tests for new parsers.
2011-04-08 18:06:56 +01:00
Sebastian Dröge
9f256d81db
rtpbin: Don't try to request the same request pad twice
2011-03-29 16:34:53 +02:00
Tim-Philipp Müller
2a8103553d
tests: enable more formats in videofilter unit test, check more resolutions
2011-03-15 20:23:25 +00:00
Tim-Philipp Müller
3e1c707495
tests: in videofilter unit test also check with 'odd' widths and heights
...
And only use one test suite.
2011-03-15 09:45:23 +00:00
Thiago Santos
cb527623a3
deinterlace: Handle image caps without asserting
...
Images might have framerate=0/1 in the caps, which caused an
assertion on deinterlace. I don't know of interlaced image formats
but deinterlace might be hardcoded on some generic pipelines and
it shouldn't assert.
The fix was to set field_duration to 0 if the input has a framerate
with a 0 numerator.
This patch also adds checks for this situation on the unit tests.
https://bugzilla.gnome.org/show_bug.cgi?id=641400
2011-02-04 09:38:35 -03:00
Ognyan Tonchev
0add79cbf1
matroskamux: don't leak ebml writer caps when re-using matroskamux
...
https://bugzilla.gnome.org/show_bug.cgi?id=640542
2011-01-26 08:51:04 +00:00
Thiago Santos
dde7af4b9d
jpegenc: Adds another test case
...
Adds a test for jpegenc to check that is possible to negotiate and
push buffers with different resolution one after another.
https://bugzilla.gnome.org/show_bug.cgi?id=637686
2010-12-21 15:23:11 -03:00
Edward Hervey
1d0f79478f
check: Fixup the shutting down order
...
First bring down everything to NULL before attempting to unlink
or unref anything.
Avoids the tests just hanging there for ever waiting to acquire a
lock that doesn't exist anymore.
2010-12-05 14:45:07 +01:00
Edward Hervey
f8b8c0476a
check: Use fail_unless_equals_int instead of fail_if
...
Makes the error message more interesting
2010-12-03 14:52:42 +01:00
Stefan Kost
35232cd490
tests: remove newlines between variable decls (old gst-indent failure)
2010-12-03 09:49:26 +02:00
Wim Taymans
5a5c0d6911
tests: fix rtpjpegpay test
...
Make the data we send to the jpeg payloader be a valid jpeg file because the
payloader now expects this.
2010-09-09 18:48:54 +02:00
Sebastian Dröge
89bb403ffc
imagefreeze: Add test for checking if imagefreeze correctly returns UNEXPECTED after the first buffer
2010-09-04 14:52:08 +02:00
Sebastian Dröge
6b705ba6f5
imagefreeze: Add test for bufferalloc passthrough
2010-09-04 14:52:08 +02:00
Sebastian Dröge
5cd240952e
imagefreeze: Fix race conditions in the unit test
...
If setting the pipeline to PLAYING before issuing the seek, buffers
are already arriving at the sink before the seek is handled and
will have the wrong timestamps and everything.
Fixes bug #625547 .
2010-09-04 14:52:08 +02:00
Jonathan Matthew
debe2d5634
id3v2mux: write beats-per-minute tag using TBPM frame
...
https://bugzilla.gnome.org/show_bug.cgi?id=621520
2010-08-05 00:04:48 +01:00
Mark Nauwelaerts
f5adfaed23
tests: rtp payloading: fix pad leak
2010-08-02 13:04:37 +02:00
Zaheer Abbas Merali
e49c31fd25
matroskamux: revert change that set a reserved flag on the Block.
...
So matroska's Block structure has no keyframe flag, only the SimpleBlock has it.
To detect keyframes in Blocks, it is just the BlockGroup container that needs
to have a ReferenceBlock attached if it is a delta frame in video.
2010-06-14 14:28:53 +01:00
Sebastian Dröge
307e7f7a21
matroskamux: Fix unit test for changed key-frame behaviour
...
All audio frames are marked as keyframe now instead of marking
them all as delta unit...
2010-06-10 22:55:17 +02:00
Mark Nauwelaerts
4e5c985ba4
matroskamux: adjust unit test to modified behaviour
2010-06-01 15:55:24 +02:00
Mark Nauwelaerts
b967b035a9
matroskamux: unit test checks version 1 files
2010-05-20 17:32:24 +02:00
Tim-Philipp Müller
14305e4f9b
tests: fix leak in souphttpsrc unit test
...
Unref server objects when done. Fixes check-valgrind.
2010-05-14 18:16:45 +01:00
Tim-Philipp Müller
5fcbea7e7e
Move imagefreeze plugin from -bad to -good
...
Hook up build infrastructure, docs and unit test for new plugin.
Fixes #613786 .
2010-05-11 14:31:44 +01:00
Benjamin Otte
e258a91f8b
Add -Wmissing-declarations -Wmissing-prototypes to configure flags
...
And fix all warnings
2010-05-11 14:31:44 +01:00
Sebastian Dröge
f152f6e20f
imagefreeze: Add some unit tests
2010-05-11 14:31:43 +01:00
Tim-Philipp Müller
f9ced7df94
Move capsfilter element from -bad to -good
...
Hook up moved files to the build infrastructure and docs.
Fixes #617739 .
2010-05-11 14:31:43 +01:00
Benjamin Otte
a200ec01b8
Add -Wold-style-definition
...
and fix the warnings
2010-05-11 14:31:43 +01:00
Mark Nauwelaerts
0eee8477df
capssetter: add unit test
2010-05-11 14:31:43 +01:00
Mark Nauwelaerts
798ccb7e97
y4menc: adjust unit test to element behaviour
2010-04-30 13:54:41 +02:00
Sebastian Dröge
88451daa03
deinterlace: Fix unit test that checks caps handling
...
deinterlace now always adds the interlaced field to the output caps,
if it wasn't present in the input caps the output caps will still
contain interlaced=false.
2010-04-29 19:28:23 +02:00
Sebastian Dröge
f9edd9b169
videofilter: Extend the unit test to test different color formats
2010-04-29 19:28:21 +02:00
Sebastian Dröge
d214820001
videofilter: Add some more tests
...
These check different property combinations
2010-04-29 19:28:21 +02:00
Edward Hervey
552f790e84
check: Don't re-declare 'GList *buffers' in the tests
...
It's an external which lives in gstcheck.c. Redeclaring it makes some
compilers/architectures think the 'buffers' in the individual tests are
a different symbol... and therefore we end up comparing holodecks with
oranges.
2010-04-12 18:03:20 +02:00
Edward Hervey
d11998247c
check: Ignore jpegenc test
2010-04-12 11:17:34 +02:00
Thiago Santos
f5dba3a7a3
tests: jpegenc: Adds some getcaps test
...
Adds tests for the jpegenc getcaps function, to avoid
having it returning non-subset caps
2010-04-05 16:10:06 -03:00
Tim-Philipp Müller
c4a9ed774e
tests: use loop test for long-running videocrop check
...
This should avoid timeouts on slow machines.
Fixes #597739 .
2010-03-23 00:19:29 +00:00
Benjamin Otte
412cc10314
Add -Wold-style-definition flag
...
And fix the warnings
2010-03-21 15:17:46 +01:00
Benjamin Otte
3f511ec361
Add -Wwrite-strings to the configure flags
...
... and fix all warnings
2010-03-21 14:17:47 +01:00
Benjamin Otte
c76e72a7f5
Add -Wundef to configure flags
...
and fix the resulting warnings
2010-03-17 21:33:28 +01:00
Benjamin Otte
3342b1679e
Add -Wmissing-declarations -Wmissing-prototypes warning flags
...
And fix all the warnings.
2010-03-17 18:23:28 +01:00
Tim-Philipp Müller
a18164d56e
tests: fix metadata not writable warnings in interleave and deinterleave tests
2010-03-11 15:51:40 +00:00
Tim-Philipp Müller
df2c773e7d
tests: fix metadata not writable warnings with apev2mux and id3v2mux tests
2010-03-11 15:38:19 +00:00
Tim-Philipp Müller
27569e53e8
Make git ignore shapewipe examples and tests
2010-02-19 12:13:08 +00:00
Sebastian Dröge
5196ee5148
shapewipe: Fix unit test for latest changes
...
Now the alpha is multiplied with the already existing alpha
value instead of simply ignoring it and the luma/chroma values
are kept, even if the output is 100% transparent.
2010-02-15 00:50:27 +01:00
Sebastian Dröge
9ba1aaef67
shapewipe: Improve unit test output on errors
2010-02-15 00:47:08 +01:00
Sebastian Dröge
9b70be59c7
[MOVED FROM BAD 09/29] shapewipe: Increase timeout of the unit test
2010-02-12 11:12:33 +01:00
Sebastian Dröge
aeca13bac2
[MOVED FROM BAD 07/29] shapewipe: Add unit test for shapewipe
2010-02-12 11:12:32 +01:00
Tim-Philipp Müller
f40b016ec3
checks: ignore deinterlace check binary
2010-01-27 01:49:49 +00:00
Thiago Santos
62900a4c13
deinterlace: Improve passthrough tests
...
Improve passthrough tests by forcing more specific
interlaced/deinterlaced caps to be tested
2010-01-05 19:04:23 -03:00
Thiago Santos
096c759427
deinterlace: Adds some docs to the new tests
...
Adds some docs explaining the utility functions of the check
tests of deinterlace
2010-01-05 18:23:33 -03:00
Thiago Santos
80e66a5db4
deinterlace: Adds tests for passthrough
...
Adds tests for checking if the element really does
passthrough in disabled mode and in auto (if the input is
not interlaced)
2010-01-05 18:23:32 -03:00
Thiago Santos
8ba4d1b683
deinterlace: Adds tests for caps acceptance
...
Adds check unit tests for deinterlace for validating
caps accepting and the expected caps output on the
other pad
2010-01-05 18:23:32 -03:00
Thiago Santos
2370c452ca
deinterlace: Adds basic check test
...
Adds a basic check test for deinterlace element
2010-01-05 18:23:32 -03:00
Olivier Crête
e8dcea17fc
tests: Add G.729 RTP payloader/depayloader test
...
https://bugzilla.gnome.org/show_bug.cgi?id=606050
2010-01-05 13:23:26 -05:00
Wim Taymans
5c8527bb20
check: fix jitterbuffer check
...
Make sure we set a base_time on the element.
Fix the timeout to at least twice the jitterbuffer latency.
Enable previously failing tests.
Remove impossible checks.
2009-11-28 12:25:06 +01:00
Stefan Kost
0079f98632
rtpjitterbuffertest: add one more test and file a bug now
...
CHange the backwards test to always send first buffer first to have a define
basetime. Add another test that sends buffers backwards to assert that only
first sent buffer is keep and used as basetime. Disabled those tests still,
as its not passing/failing consitently and file a bug for jitterbuffer.
2009-11-25 16:05:10 +02:00
Stefan Kost
38bd5e5106
jitterbuffertest: improve the test
...
the tests are a bit more solid now but still not produce reliable results.
Wonder if they are still flawky or if its a bug in jitterbuffer.
2009-11-25 10:19:12 +02:00
Sebastian Dröge
a68d676fb1
wavpackparse: Fix unit test for recent position reporting changes
2009-11-20 09:58:26 +01:00
Tim-Philipp Müller
4fb9720cd7
tests: disable all jitterbuffer tests for now
...
Since even the one enabled seems to fail.
2009-10-23 11:21:44 +01:00
Stefan Kost
347caecbe9
tests: also include the new test for prev commit
2009-10-22 13:39:58 +03:00
Stefan Kost
e43eb89449
tests: add a jitterbuffer test
...
Tests pushing a few buffers in various order and asserting the order sent by the
jitterbuffer. Contains two disabled tests that need more work.
2009-10-22 13:35:57 +03:00
Stefan Kost
3503cfa456
tests: include stdio.h for sscanf
2009-10-20 17:34:34 +03:00
Marvin Schmidt
2543d9c28c
flvmux: Use loop test to prevent timeout on slow machines
...
Partially fixes bug #597739 .
2009-10-15 06:03:17 +02:00
Jan Schmidt
993a29a390
check: Make the level unit test succeed on Solaris 10
...
Add a configure check for functional isinf() and fpclass(), and
use fpclass() where possible when isinf() is not available.
2009-10-09 00:14:07 +01:00
Jan Schmidt
0f5711d1dc
check: Link against LIBM and include math.h for isinf()
2009-10-08 16:17:13 +01:00
Jan Schmidt
7c2489ca77
check: Fix a couple of tests.
...
The souphttpsrc test wasn't compiling. The soup-misc.h header is needed for
soup_ssl_supported.
Fix the y4menc test to use a 'progressive' header for the test data now that
the element outputs correct interlacing info.
2009-09-12 00:13:04 +01:00
Marvin Schmidt
ffa63329cb
checks: only run HTTPS test if libsoup has SSL support
2009-09-08 15:28:07 +02:00
Tim-Philipp Müller
80e43452a1
checks: add test for leak to rtpbin unit test
...
See #591476 .
2009-08-14 13:47:18 +01:00
Tim-Philipp Müller
4701696a92
Move rtpmanager from -bad to -good.
...
Hook up build infrastructure (autotools, docs, unit test).
2009-08-11 02:43:09 +01:00
Wim Taymans
512ba93159
rtpbin: do better cleanup of the src ghostpads
...
Connect to the pad-removed signal of the ptdemux elements so that we remove the
ghostpads for them. Fixes cleanup when going to NULL as well as when releasing
the sinkpads.
Fixes #561752
2009-08-11 02:30:46 +01:00
Branko Subasic
779f67adc4
rtpbin: add support for buffer-list
...
Add support for sending buffer-lists.
Add unit test for testing that the buffer-list passed through rtpbin.
fixes #585839
2009-08-11 02:30:45 +01:00
Wim Taymans
57653143c3
tests: add receive rtpbin unit test
2009-08-11 02:30:44 +01:00
Wim Taymans
02b34602c4
tests: more rtpbin checks
2009-08-11 02:30:44 +01:00
Wim Taymans
232624c908
tests: add more rtpbin tests
2009-08-11 02:30:44 +01:00
Wim Taymans
1710d8a3a5
tests: add rtpbin unit test
...
Add the beginnings of an rtpbin unit test
Add some more stuff to .gitignore
2009-08-11 02:30:43 +01:00
Tim-Philipp Müller
04efc92897
check: fix flvmux unit test on big endian machines
...
flvmux only accepts raw audio in little endian, but audiotestsrc
produces audio in the native endianness, which makes linking
between audiotestsrc and flvmux fail on big endian machines. Add
an audioconvert element in between the two to fix this.
2009-08-09 01:28:40 +01:00
Tim-Philipp Müller
2e05af3876
id3demux: fix parsing of unsync'ed ID3 v2.4 tags and frames
...
Reversing the unsynchronisation seems to work slightly differently
for ID3 v2.3 tags and v2.4 tags: v2.3 tags don't have syncsafe frame
sizes in the frame header, so the unsynchronisation is applied to
the whole frame data including all the frame headers. v2.4 frames
have sync-safe sizes, however, so the unsynchronisation only needs
to be applied to the actual frame data, and it seems that's what's
being done as well. So we need to undo the unsynchronisation on a
per-frame basis for v2.4 tags for things to work properly.
Fixes extraction of coverart/images from APIC frames in ID3 v2.4
tags (#588148 ).
Add unit test for this as well.
2009-08-07 16:02:23 +01:00
Sebastian Dröge
a931c67597
flvmux: Fix unit test to correctly handle request pads
...
Request pads are removed by the element instance in PAUSED->READY
so we need to re-request pads for every run and link them again.
Last fix for bug #590447 .
2009-08-03 20:08:33 +02:00
Tim-Philipp Müller
8c230e08f5
checks: add basic unit test for flvmux, but disable it for now
...
Basic unit test for flvmux. Fails miserably, hence disabled for now.
2009-08-01 12:19:41 +01:00
Tim-Philipp Müller
6227a6118e
check: add basic unit test for flvdemux
...
In particular, test re-use of flvdemux in both pull and push mode
(see #583030 ).
2009-07-31 23:55:01 +01:00
Jan Schmidt
988123b186
gitignore: Ignore some new binaries
2009-07-19 11:42:12 +01:00
Ognyan Tonchev
11b7016f7d
tests: add unit tests for buffer-list payloaders
...
See #585559
2009-06-19 18:12:27 +02:00
Wim Taymans
d1606beaca
tests: add some debug, send newsegment
2009-06-16 15:25:54 +02:00
Ognyan Tonchev
375523be71
multiudpsink: add support for buffer lists
...
Add support for BufferList and add a unit test.
Fixes #585842
2009-06-16 15:04:15 +02:00
Jan Schmidt
fa15557bf5
check: Remove assertion that breaks check again git master
...
Remove the assertion that the sender of the tags message is the
element until we decide whether that's going to be true or not.
2009-05-16 01:21:34 +01:00
Jan Schmidt
135e61f753
Moved 'y4menc' from -bad to -good
2009-05-16 00:16:31 +01:00
Tim-Philipp Müller
c014c4a621
checks: move files required by unit tests into tests/files and make sure they're disted
...
Move unit test data into the directory where it belongs and make in particular
the flacdec unit test cd into the directory with the test files instead of making
assumptions about the current working directory in that unit test. As a side effect
of movng those files, there's only one EXTRA_DIST in tests/check/Makefile.am now,
which is likely to work better than having two. Hopefully fixes #582753 .
2009-05-15 17:17:20 +01:00