Jimmy Ohn
c0bba84244
encoding-target: Properly free when missing type field in parse_encoding_profile
...
pname and description in parse_encoding_profile function causes
memory leakages when missing the 'type' field for streamprofile.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5750 >
2023-12-01 15:01:41 +00:00
Philippe Normand
36f653fdc5
pbutils: Don't include default vp9 parameters in resulting codec mime string
...
According to the document defining the vp9 codec string, the optional fields
should all be present only if at least one of them has a non-default value.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5719 >
2023-11-27 12:14:54 +00:00
Víctor Manuel Jáquez Leal
f74fb5142d
pbutils: Fix vp9 mime mapping when caps when no chroma-site.
...
It's possible to have 4:2:0 chroma format without chroma-site in caps, but it
isn't validated by the current code. This patch fixes it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3405 >
2022-11-16 01:29:50 +00:00
Edward Hervey
7988144048
pbutils/encoding-profile: Streamline cleanup
...
Cleanup all local variables in one place, and ensure failure cases go through there.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3390 >
2022-11-13 06:59:11 +01:00
Edward Hervey
872b0a65cb
pbutils/encoding-profile: Don't leak string array
...
It was never freed
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3390 >
2022-11-12 10:33:51 +01:00
Sebastian Dröge
40800fa117
discoverer: Annotate DiscovererInfo::get_audio_streams()
and others with the concrete stream info type
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3353 >
2022-11-07 19:04:49 +00:00
Matthew Waters
1c835695a3
pbutils: add correct mime mapping for vp9
...
Based on https://www.webmproject.org/vp9/mp4/#codecs-parameter-string
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3260 >
2022-10-28 00:06:07 +00:00
Sebastian Dröge
366893e9ac
Fix various warnings from gobject-introspection
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3261 >
2022-10-25 09:45:25 +03:00
Sebastian Dröge
533ea9bd7c
pbutils: Add/fix various annotations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194 >
2022-10-18 08:56:58 +00:00
Tim-Philipp Müller
4c8a621809
pbutils: descriptions: add meta/x-klv
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3094 >
2022-09-30 11:08:45 +03:00
Tim-Philipp Müller
2d53f9f97c
pbutils: descriptions: fix gst_pb_utils_get_caps_description_flags()
...
And add a little unit test.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3094 >
2022-09-30 11:08:45 +03:00
Thibault Saunier
1c4950718f
discoverer: Fix discovering source that expose raw audio/video
...
Exposes a "uridecodebin:post-stream-topology" property as the discoverer
needs to have topology information about all streams so we need
`uridecodebin` to always plug decodebins for that case.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3009 >
2022-09-15 19:25:01 +00:00
Thibault Saunier
bc9c1e3956
meson: Namespace the plugins_doc_dep/libraries variables
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2970 >
2022-09-01 21:17:35 +00:00
8648f5f7d2
audiovisualizer: fix buffer mapping to not increase refcount
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2953 >
2022-08-30 15:22:42 +00:00
Mathieu Duponchelle
62c303c2e0
encoding-profile: don't order profiles by stream ID ..
...
when creating a profile from a discoverer info.
There is no justification for the existing code, and talking with
Thibault he cannot remember why the sort was in place.
On the other hand, this allows GES users to not have to implement
a callback for the select-tracks-for-object callback when using
it to trim a single clip, which the output profile was built from:
track elements will be placed in the appropriate track by default,
that is the one that will be connected to the matching profile.
For multi-clip timelines, the situation doesn't change, users will
still have to implement a callback and do the leg work of placing
track elements (if any) in a matching track (if any).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1549 >
2022-08-02 15:48:12 +00:00
Mathieu Duponchelle
0f85a46148
encoding-profile: ignore more output caps fields
...
chroma-format, bit-depth-chroma, bit-depth-luma are all informative
fields set by the H265 and H265 parser upon receiving an SPS.
They shouldn't be constrained downstream of the parser, instead
if a user wants those to ultimately match certain values they
should do so by constraining a profile.
In this case however, we also always remove the profile constraint
in order to let encoders pick a suitable one as a function of the
raw input video format and their own capabilities.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1549 >
2022-08-02 15:48:12 +00:00
Sebastian Dröge
39568918de
pbutils: Add GST_PBUTILS_CAPS_DESCRIPTION_FLAG_METADATA and ONVIF XML Timed MetaData
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2453 >
2022-05-20 13:01:44 +00:00
Xavier Claessens
b99ecc78ca
Replace gst-i18n-*.h with gi18n-lib.h
...
GLib guarantees libintl is always present, using proxy-libintl as
last resort. There is no need to mock gettex API any more.
This fix static build on Windows because G_INTL_STATIC_COMPILATION must
be defined before including libintl.h, and glib does it for us as part
as including glib.h.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2028 >
2022-04-19 18:01:06 +00:00
Edward Hervey
00187ddb0c
pbutils: Fix wmv screen detection
...
strncmp vs !strncmp :)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2050 >
2022-03-29 17:31:44 +00:00
Matthew Waters
203e34fb75
discoverer: chain up to parent finalize methods in all our types
...
Fixes a memory leak:
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x5ac5cd in malloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3
#1 0x1007007 in g_malloc /work/glib-2.72.0/_builddir/../glib/gmem.c:125:13
#2 0xf82e82 in g_data_set_internal /work/glib-2.72.0/_builddir/../glib/gdataset.c:464:8
#3 0xf833f7 in g_datalist_id_set_data_full /work/glib-2.72.0/_builddir/../glib/gdataset.c:670:3
#4 0xef81be in g_object_notify_queue_freeze /work/glib-2.72.0/_builddir/../gobject/gobject.c:295:7
#5 0xef79c6 in g_object_unref /work/glib-2.72.0/_builddir/../gobject/gobject.c:3632:16
#6 0x5e58bf in LLVMFuzzerTestOneInput /src/gstreamer/ci/fuzzing/gst-discoverer.c:132:5
#7 0x4dd1a2 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
#8 0x4dc98a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:514:3
#9 0x4de6c4 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:809:5
#10 0x4dea29 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:857:3
#11 0x4ce4a0 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6
#12 0x4f6f52 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
#13 0x7f1c709980b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x240b2)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1984 >
2022-03-18 17:49:08 +00:00
Edward Hervey
bce779e66d
pbutils: Add function to parse RFC 6381 codecs field
...
This is the opposite of `gst_codec_utils_caps_get_mime_codec()`, which allows
elements to get the `GstCaps`
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1894 >
2022-03-11 07:14:33 +00:00
Sebastian Groß
6372aaa608
audiovisualizer: shader: Fix dframe out of bound write
...
shader_fade_and_move_horiz_out writes a complete stride at the end of its
dframe data
This led to SIGSEGV since the stride reached into sframe->map[0]->memory
which could not be umpapped later on.
This is due to `d` is increased twice. Once at the end of the upper loop
and at the start of the lower loop.
The corresponding dframe stride is therefore skipped.
Rewind `d` and start at the correct position.
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1702
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1751 >
2022-02-21 08:20:44 +01:00
Seungha Yang
04f3a2bd22
gstinfo,ptpclock,libcheck: Use GetCurrentProcessId() instead of getpid() on Windows
...
getpid() shouldn't be used in case of UWP. Use GetCurrentProcessId()
instead which provides exactly the same functionality and can be
used with UWP as well.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1006 >
2022-02-16 17:03:29 +00:00
David Svensson Fors
b3d300bc26
codec-utils: Avoid out-of-bounds error
...
For artificial input (in unit tests), all six bytes of
constraint_indicator_flags in hevc_caps_get_mime_codec() can be
zero. Add a guard against an out-of-bounds error that occurred in that
case. Change variables to signed int so comparison with -1 works.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1677 >
2022-02-10 07:58:36 +00:00
Sebastian Dröge
8dfe70d17f
codec-utils: Mark various string return values as nullable
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1539 >
2022-01-19 11:05:26 +02:00
Philippe Normand
62b8caa6ab
pbutils: Define one debug category per module
...
Follow-up of https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1526 >
2022-01-18 18:19:46 +00:00
Philippe Normand
6a3f2f0ba6
pbutils: Simplify h264_caps_structure_get_profile_flags_level a bit
...
Refactoring, removing one level of indentation from the function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505 >
2022-01-13 17:15:36 +00:00
Philippe Normand
074c5d85cb
pbutils: H.265 support for gst_codec_utils_caps_get_mime_codec()
...
The codec_data caps payload is parsed and a MIME codec string is generated
according to the ISO/IEC 14496-15 specification.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505 >
2022-01-13 17:15:36 +00:00
Philippe Normand
1c8f7c32aa
pbutils: Add a pbutils debug category
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1505 >
2022-01-13 17:15:36 +00:00
Sebastian Dröge
79ce12416f
codec-utils: Use nullable annotation instead of allow-none for various Opus functions
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506 >
2022-01-12 10:19:45 +00:00
Sebastian Dröge
e667c95674
codec-utils: Annotate out parameters for Opus functions as (optional)
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506 >
2022-01-12 10:19:45 +00:00
Sebastian Dröge
6de587593a
codec-utils: Add missing annotations to gst_codec_utils_h264_get_profile_flags_level()
...
And fix some minor typos.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1506 >
2022-01-12 10:19:45 +00:00
Tim-Philipp Müller
972615cf22
docs: fix unnecessary ampersand, < and > escaping in code blocks
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1340 >
2021-11-12 11:39:19 +00:00
Thibault Saunier
95c1f67d69
discoverer: Set number to stream infos
...
The idea is that we can reference to streams using this unique number,
within the context of that discoverer info. That number should always
be usable to reference the streams for a specific stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/897 >
2021-10-20 09:16:38 +00:00
Edward Hervey
879526b2e2
discoverer: Don't ref NULL taglist
...
Fixes warning introduced in 064f7bbbfa
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1200 >
2021-10-20 09:47:29 +02:00
Tim-Philipp Müller
cf9be70946
gst-plugins-base: define G_LOG_DOMAIN for all libraries
...
Fixes #634
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009 >
2021-10-19 00:12:25 +00:00
Philippe Normand
064f7bbbfa
discoverer: Advertise container-specific tags with a new API
...
Since commit a55dafe341
, stream-scoped tags no
longer appeared as top-level tags, introducing a behaviour regression, specially
for MP3 files.
The `gst_discoverer_info_get_tags()` API now returns all tags detected for the
given media, as documented.
A new API is introduced to get container-specific tags,
`gst_discoverer_container_info_get_tags()`. The discoverer tool was adapted to
use it. `gst_discoverer_info_get_tags()` is now deprecated in favor of
`gst_discoverer_container_info_get_tags()` and
`gst_discoverer_stream_info_get_tags()`.
Fixes #759
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1107 >
2021-10-18 20:08:35 +00:00
Thibault Saunier
fec6270205
encoding-profile: ignore more fields when creating for discover info
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062 >
2021-10-18 10:11:08 -03:00
Thibault Saunier
6e79932ad9
meson: List libraries and their corresponding gir definition
...
Introduces a `libraries` variable that contains all libraries in a
list with the following format:
``` meson
libraries = [
[pkg_name, {
'lib': library_object
'gir': [ {full gir definition in a dict } ]
],
....
]
```
It therefore refactors the way we build the gir so that we can reuse the
same information to build them against 'gstreamer-full' in gst-build
when linking statically
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093 >
2021-10-15 19:27:30 -03:00
Thibault Saunier
e2dd28a753
meson: Mark files as files()
...
Making it more robust and future proof
And fix issues that it creates
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093 >
2021-10-15 19:27:30 -03:00
Ludvig Rappe
b099ba649e
pbutils: Remove sample entry code "raw"
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1045 >
2021-10-05 09:00:23 +00:00
Thibault Saunier
2fd28195ca
Move files from gst-plugins-base into the "subprojects/gst-plugins-base/" subdir
2021-09-24 16:13:26 -03:00