Commit graph

107 commits

Author SHA1 Message Date
Jan Schmidt
df470fa7f8 ext/lame/gstlame.c: Disable the bitrate checking when the user has requested
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_setup):
Disable the bitrate checking when the user has requested
Free Format mode, as all bitrates less than the maximum
are valid then.
2007-03-21 12:53:57 +00:00
Jan Schmidt
925d6a3712 ext/lame/gstlame.c: Display sensible defaults and limits for the vbr-min/max/mean properties. Fix the 'hard-limit' VB...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init),
(gst_lame_setup):
Display sensible defaults and limits for the
vbr-min/max/mean properties. Fix the 'hard-limit' VBR min
property - it's supposed to be a boolean 0/1 value.
2007-02-28 18:41:38 +00:00
Jan Schmidt
552273cdcc ext/lame/gstlame.c: Initialise the variables so gcc doesn't complain about possibly uninitialised uses, even though t...
Original commit message from CVS:
* ext/lame/gstlame.c:
Initialise the variables so gcc doesn't complain about possibly
uninitialised uses, even though they can't actually happen.
2007-02-28 16:01:08 +00:00
Thomas Vander Stichele
151206dec5 ext/lame/gstlame.c: Fix up bitrate checking macro. Make it give us a
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps),
(gst_lame_set_property), (gst_lame_setup):
Fix up bitrate checking macro.  Make it give us a
GST_ELEMENT_WARNING message so the application has a chance of
reporting this to the user.  Move the checking to _setup, so we
are sure it runs in the READY state, when we hope to have a pipeline
and a bus that is not flushing.
This fixes e.g. using 96 kbit/sec as a bitrate.
2007-02-21 16:02:33 +00:00
Tim-Philipp Müller
0d4e832887 ext/lame/gstlame.*: On receiving EOS, we try to push a last buffer with the remaining samples. Don't do that if we go...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event), (gst_lame_chain),
(gst_lame_change_state):
* ext/lame/gstlame.h:
On receiving EOS, we try to push a last buffer with the remaining
samples. Don't do that if we got an unclean flow return on the last
gst_pad_push(), downstream might not handle this very gracefully
(see #403168).
* gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_chain):
Pass flow returns upstream (helps #403168).
2007-02-09 16:24:45 +00:00
Thomas Vander Stichele
9847c13491 ext/lame/gstlame.c: warn when outgoing sample rate is different from incoming
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps), (gst_lame_chain):
warn when outgoing sample rate is different from incoming
2006-12-30 20:01:35 +00:00
Roland Kay
bcc7663ebe ext/lame/gstlame.*: Fix leak (by calling lame_init_params() before lame_close()); handle
Original commit message from CVS:
Based on patch by: Roland Kay  <roland.kay at ox compsoc net>
* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_chain),
(gst_lame_setup):
* ext/lame/gstlame.h:
Fix leak (by calling lame_init_params() before lame_close()); handle
NULL return from lame_init() more gracefully. Fixes #385311.
2006-12-14 10:15:24 +00:00
Wim Taymans
9fd95df00e ext/lame/gstlame.*: Make lame timestamp flushed eos buffer by some additional timestamp accounting. Fixes #374760.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event), (gst_lame_chain),
(gst_lame_change_state):
* ext/lame/gstlame.h:
Make lame timestamp flushed eos buffer by some additional timestamp
accounting. Fixes #374760.
2006-11-14 10:29:37 +00:00
Tim-Philipp Müller
71735842de ext/lame/gstlame.c: Round up not allowed bitrates to the next higher allowed one (Closes: #361140).
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_set_property):
Round up not allowed bitrates to the next higher allowed one
(Closes: #361140).
2006-10-13 14:45:11 +00:00
Tim-Philipp Müller
25f02025a4 Add docs for lame and lame to docs. Specify allowed bitrates in the properties description (#361140). Canonicalise ob...
Original commit message from CVS:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-ugly-plugins-docs.sgml:
* docs/plugins/gst-plugins-ugly-plugins-sections.txt:
* ext/lame/gstlame.c: (gst_lame_class_init):
* ext/lame/gstlame.h:
Add docs for lame and lame to docs. Specify allowed bitrates
in the properties description (#361140). Canonicalise object
property names (ie. use hyphen instead of underscore).
* docs/plugins/inspect/plugin-a52dec.xml:
* docs/plugins/inspect/plugin-amrnb.xml:
* docs/plugins/inspect/plugin-asf.xml:
* docs/plugins/inspect/plugin-dvdlpcmdec.xml:
* docs/plugins/inspect/plugin-dvdread.xml:
* docs/plugins/inspect/plugin-dvdsub.xml:
* docs/plugins/inspect/plugin-iec958.xml:
* docs/plugins/inspect/plugin-lame.xml:
* docs/plugins/inspect/plugin-mad.xml:
* docs/plugins/inspect/plugin-mpeg2dec.xml:
* docs/plugins/inspect/plugin-mpegaudioparse.xml:
* docs/plugins/inspect/plugin-mpegstream.xml:
* docs/plugins/inspect/plugin-siddec.xml:
Update version to CVS.
2006-10-13 14:19:24 +00:00
Tim-Philipp Müller
5fed8f44e1 Add i18n magic to lame plugin. Throw decent error message when we fail to setup the encoder (#361140, 361151); misc. ...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps),
(gst_lame_set_property), (gst_lame_get_property), (gst_lame_chain),
(plugin_init):
* po/POTFILES.in:
Add i18n magic to lame plugin. Throw decent error message when we
fail to setup the encoder (#361140, 361151); misc. minor clean-ups.
2006-10-13 10:00:27 +00:00
Zaheer Abbas Merali
6e31592841 ext/lame/gstlame.c: Fix lame putting lots of 0's at start of mp3. Fixes bug #348786.
Original commit message from CVS:
2006-07-26  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_setup):
Fix lame putting lots of 0's at start of mp3.  Fixes bug #348786.
2006-07-26 17:09:04 +00:00
Tim-Philipp Müller
9133228852 ext/lame/gstlame.*: Remove tag writing from lame (which was completely broken anyway, #329184). Leaving GstTagSetter ...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_get_type),
(gst_lame_release_memory), (gst_lame_init), (gst_lame_sink_event),
(gst_lame_setup), (gst_lame_change_state):
* ext/lame/gstlame.h:
Remove tag writing from lame (which was completely broken
anyway, #329184). Leaving GstTagSetter interface around for
now, albeit non-functional. Should be removed completely
in 0.11. Use the 'id3v2mux' plugin from -good for writing
tags.
2006-05-06 11:38:30 +00:00
Andres Salomon
1e0b270ab6 ext/lame/gstlame.c: Fix typo (comma vs. semicolon) (#340710).
Original commit message from CVS:
Patch by: Andres Salomon  <dilinger at debian org>
* ext/lame/gstlame.c: (gst_lame_sink_event):
Fix typo (comma vs. semicolon) (#340710).
2006-05-05 08:23:39 +00:00
Ed Catmur
a0f4d95e0b ext/lame/gstlame.c: Don't crash if we get an EOS event before the encoder has been set up (#339287).
Original commit message from CVS:
Patch by: Ed Catmur  <ed at catmur dot co dot uk>
* ext/lame/gstlame.c: (gst_lame_sink_event):
Don't crash if we get an EOS event before the encoder
has been set up (#339287).
2006-04-21 12:40:41 +00:00
Thomas Vander Stichele
23f496bebc configure.ac: rework similarly to other modules
Original commit message from CVS:

* configure.ac:
rework similarly to other modules
* ext/a52dec/gsta52dec.c:
* ext/amrnb/amrnb.c:
* ext/dvdnav/dvdnavsrc.c:
* ext/dvdread/dvdreadsrc.c:
* ext/lame/gstlame.c:
* ext/mad/gstid3tag.c:
* ext/mpeg2dec/gstmpeg2dec.c:
* ext/sidplay/gstsiddec.cc:
* gst/asfdemux/gstasf.c:
* gst/dvdlpcmdec/gstdvdlpcmdec.c:
* gst/dvdsub/gstdvdsubdec.c:
* gst/iec958/ac3iec.c:
* gst/mpegaudioparse/gstmpegaudioparse.c:
* gst/mpegstream/gstmpegstream.c:
* gst/realmedia/rmdemux.c: (plugin_init):
use the correct defines
2006-04-01 09:54:39 +00:00
Tim-Philipp Müller
dfdac6c84c ext/lame/gstlame.*: Make xingheader property non-functional, it's broken anyway after all (use xingmux instead).
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_set_property),
(gst_lame_get_property), (gst_lame_setup):
* ext/lame/gstlame.h:
Make xingheader property non-functional, it's broken anyway
after all (use xingmux instead).
2006-03-28 16:06:05 +00:00
Tim-Philipp Müller
6b67aca635 ext/lame/gstlame.c: On EOS, flush encoder and send remaining data. Fix return value handling in sink event function.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event):
On EOS, flush encoder and send remaining data. Fix
return value handling in sink event function.
2006-03-28 15:10:18 +00:00
Christophe Fergeau
f3fd9afefd ext/lame/gstlame.c: use GST_DEBUG_FUNCPTR more often.
Original commit message from CVS:
Patch by: Christophe Fergeau  <teuf gnome org>
* ext/lame/gstlame.c: (gst_lame_release_memory),
(gst_lame_finalize), (gst_lame_class_init),
(gst_lame_sink_setcaps), (gst_lame_init), (gst_lame_sink_event),
(gst_lame_change_state):
Fix some memory leaks (#333345), use GST_DEBUG_FUNCPTR more often.
2006-03-15 13:43:42 +00:00
Christophe Fergeau
6b069c0c1e ext/lame/gstlame.c: mark the xing-header property as BROKEN (see http://bugzilla.gnome.org/show_bug.cgi?id=330317#c19...
Original commit message from CVS:
2006-03-12  Christophe Fergeau  <teuf@gnome.org>

Reviewed by: Tim-Philipp Müller  <tim at centricular dot net>

* ext/lame/gstlame.c: (gst_lame_class_init): mark the xing-header
property as BROKEN (see
http://bugzilla.gnome.org/show_bug.cgi?id=330317#c19 for an
explanation why it's broken).
2006-03-12 11:00:33 +00:00
Wim Taymans
92f24f4395 ext/lame/gstlame.c: Fix up lame a bit.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_chain),
(gst_lame_change_state):
Fix up lame a bit.
Apply patch #319782 by Gautier Portet.
2006-02-16 17:16:06 +00:00
Tim-Philipp Müller
f0e3a8e101 ext/lame/gstlame.*: Contrary to what the const char in the lame API might suggest, lame expects us to keep the string...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_finalize), (gst_lame_class_init),
(gst_lame_init), (add_one_tag), (gst_lame_set_metadata):
* ext/lame/gstlame.h:
Contrary to what the const char in the lame API might suggest,
lame expects us to keep the strings we pass to id3tag_set_foo()
around; it doesn't free them either though, so we have to store
them somewhere and free them later when we can be sure lame
doesn't need them any longer.
2006-01-23 18:37:16 +00:00
Tim-Philipp Müller
9b224309a2 ext/lame/gstlame.c: don't pass an uninitialised string pointer to lame if we don't know how to handle the tag type, a...
Original commit message from CVS:
* ext/lame/gstlame.c: (add_one_tag):
Fix handling of GST_TAG_DATE (#311679), don't pass an
uninitialised string pointer to lame if we don't know
how to handle the tag type, and fix minor memory leak.
2006-01-23 15:02:04 +00:00
Thomas Vander Stichele
fd183e8d6c doh
Original commit message from CVS:
doh
2005-11-22 17:15:25 +00:00
Thomas Vander Stichele
9a7654bc79 fix up GValueEnum
Original commit message from CVS:
fix up GValueEnum
2005-11-22 17:04:38 +00:00
Andy Wingo
2d4d7ebcb7 Update for gst_tag_setter API changes.
Original commit message from CVS:
2005-11-22  Andy Wingo  <wingo@pobox.com>

* Update for gst_tag_setter API changes.
2005-11-22 12:39:29 +00:00
Edward Hervey
125512b120 ext/lame/gstlame.c: Don't take the stream lock
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event):
Don't take the stream lock
2005-11-21 23:50:02 +00:00
Wim Taymans
23aedb3b9d ext/lame/gstlame.c: Set caps on outgoing buffers.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_chain):
Set caps on outgoing buffers.
2005-09-19 11:07:40 +00:00
Thomas Vander Stichele
61d0ed02a5 clean up further so we don't try to set up five times for a simple pipeline
Original commit message from CVS:
clean up further so we don't try to set up five times for
a simple pipeline
2005-09-16 16:04:28 +00:00
Andy Wingo
fa4bd0499f All plugins updated for element state changes.
Original commit message from CVS:
2005-09-02  Andy Wingo  <wingo@pobox.com>

* All plugins updated for element state changes.
2005-09-02 15:43:54 +00:00
Wim Taymans
c3326a7da2 configure.ac: Added mpegaudioparse
Original commit message from CVS:
* configure.ac:
Added mpegaudioparse

* ext/lame/gstlame.c: (gst_lame_src_getcaps),
(gst_lame_src_setcaps), (gst_lame_sink_setcaps),
(gst_lame_sink_event), (gst_lame_chain):
Some cleanups.
Fix memleak.

* gst/mpegaudioparse/gstmpegaudioparse.c:
(gst_mp3parse_class_init), (gst_mp3parse_init),
(gst_mp3parse_chain), (gst_mp3parse_change_state):
* gst/mpegaudioparse/gstmpegaudioparse.h:
Ported mpegaudioparse
2005-08-17 19:05:51 +00:00
Wim Taymans
4bd0e6e60b Fix compile warning.
Original commit message from CVS:
* configure.ac:
* ext/amrnb/amrnbparse.c: (gst_amrnbparse_read_header):
Fix compile warning.

* ext/lame/gstlame.c: (gst_lame_class_init),
(gst_lame_src_getcaps), (gst_lame_src_setcaps),
(gst_lame_sink_setcaps), (gst_lame_init), (gst_lame_sink_event),
(gst_lame_chain), (gst_lame_change_state):
* ext/lame/gstlame.h:
Port lame plugin
2005-08-16 16:12:15 +00:00
Andy Wingo
8349527f92 Way, way, way too many files: Remove crack comment from the 2000 era.
Original commit message from CVS:
2005-07-05  Andy Wingo  <wingo@pobox.com>

* Way, way, way too many files:
Remove crack comment from the 2000 era.
2005-07-05 10:51:41 +00:00
Iain Holmes
b2e3b07496 Memory leak fixes
Original commit message from CVS:
Memory leak fixes
Allow level to take mono or stereo audio
2004-10-26 11:36:52 +00:00
Zaheer Abbas Merali
a05b0279c2 ext/lame/gstlame.*: Added new media support to lame
Original commit message from CVS:
2004-08-26  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_chain):
* ext/lame/gstlame.h:
Added new media support to lame
2004-08-26 00:32:00 +00:00
Zaheer Abbas Merali
f330591169 Only enable lame presets if version of lame has presets in API
Original commit message from CVS:
2004-08-19  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* configure.ac:
* ext/lame/Makefile.am:
* ext/lame/gstlame.c: (gst_lame_class_init),
(gst_lame_set_property), (gst_lame_get_property), (gst_lame_setup):
Only enable lame presets if version of lame has presets in API
2004-08-19 22:44:50 +00:00
Zaheer Abbas Merali
d3f92857b5 ext/lame/gstlame.c: describe the enum values for vbr mode and presets more verbosely
Original commit message from CVS:
2004-08-15  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_vbrmode_get_type),
(gst_lame_preset_get_type), (gst_lame_class_init):
describe the enum values for vbr mode and presets more verbosely
2004-08-15 13:47:00 +00:00
Zaheer Abbas Merali
8722272eb0 ext/lame/gstlame.*: add preset property to lame so it can use lame presets
Original commit message from CVS:
2004-08-13  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_mode_get_type),
(gst_lame_quality_get_type), (gst_lame_padding_get_type),
(gst_lame_preset_get_type), (gst_lame_class_init), (gst_lame_init),
(gst_lame_set_property), (gst_lame_get_property), (gst_lame_setup):
* ext/lame/gstlame.h:
add preset property to lame so it can use lame presets
2004-08-13 15:22:49 +00:00
Zaheer Abbas Merali
3cc5393fff ext/lame/gstlame.c: whoops forgot break, thanks teuf
Original commit message from CVS:
2004-08-13  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_get_property):
whoops forgot break, thanks teuf
2004-08-13 14:55:27 +00:00
Zaheer Abbas Merali
a82b0b4133 ext/lame/gstlame.*: fix lame's broken vbr stuff, allow it to resample if need be, and also make xing header optional
Original commit message from CVS:
2004-08-13  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_vbrmode_get_type),
(gst_lame_class_init), (gst_lame_src_getcaps),
(gst_lame_sink_link), (gst_lame_init), (gst_lame_set_property),
(gst_lame_get_property), (gst_lame_setup):
* ext/lame/gstlame.h:
fix lame's broken vbr stuff, allow it to resample if need be, and also
make xing header optional
2004-08-13 14:41:02 +00:00
Zaheer Abbas Merali
16f716f8bb ext/lame/gstlame.c: added getcaps function so samplerate doesntget fixated to silly values
Original commit message from CVS:
2004-08-12  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_src_getcaps), (gst_lame_init):
added getcaps function so samplerate doesntget fixated to silly values
2004-08-12 17:22:30 +00:00
Zaheer Abbas Merali
ca18e2eed7 ext/lame/gstlame.c: revert previous fix
Original commit message from CVS:
2004-08-12  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_src_link):
revert previous fix
2004-08-12 16:44:14 +00:00
Zaheer Abbas Merali
e8f897794b ext/lame/gstlame.c: made source pad link function check if sinkpad is ok..fixes the problem where core fixates the ou...
Original commit message from CVS:
2004-08-12  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_src_link):
made source pad link function check if sinkpad is ok..fixes the problem
where core fixates the output rate of lame stupidly
2004-08-12 16:12:00 +00:00
Zaheer Abbas Merali
dd46af96e7 ext/lame/gstlame.c: set default compression ratio paramter to 0.0 so bitrate parameter works :)
Original commit message from CVS:
2004-08-12  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init):
set default compression ratio paramter to 0.0 so bitrate parameter
works :)
2004-08-12 15:48:50 +00:00
Thomas Vander Stichele
1a4a00d37f fix add debugging
Original commit message from CVS:
fix add debugging
2004-08-09 09:22:12 +00:00
Thomas Vander Stichele
b038e214c0 gearing up for release
Original commit message from CVS:
gearing up for release
2004-08-02 11:39:17 +00:00
Thomas Vander Stichele
c18babeef1 add link function. fixes @148986
Original commit message from CVS:
add link function. fixes @148986
2004-08-02 09:16:14 +00:00
Zaheer Abbas Merali
5ba6a086db ext/lame/gstlame.c: send tag events downstream
Original commit message from CVS:
2004-07-28  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_chain): send tag events downstream
* ext/shout2/gstshout2.c: (gst_shout2send_protocol_get_type),
(gst_shout2send_get_type), (gst_shout2send_set_clock),
(gst_shout2send_class_init), (gst_shout2send_init),
(set_shout_metadata), (gst_shout2send_set_metadata),
(gst_shout2send_chain), (gst_shout2send_set_property),
(gst_shout2send_get_property), (gst_shout2send_connect),
(gst_shout2send_change_state):
* ext/shout2/gstshout2.h:
- fix for sending mp3 audio to icecast2 server, if pad link function not
called before PAUSED state
- added option to use GStreamer clock sync (as opposed to libshout's own sync)
- added tagging support for mp3 audio broadcasted
* gst/monoscope/gstmonoscope.c: (gst_monoscope_class_init):
debug info
2004-07-28 20:26:31 +00:00
Benjamin Otte
3a0f0ccc68 ext/lame/gstlame.c: add debugging category, add error checks like checking return values of setup calls, make sure it...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_link), (gst_lame_init),
(gst_lame_chain), (gst_lame_setup), (gst_lame_change_state),
(plugin_init):
add debugging category, add error checks like checking return values
of setup calls, make sure it still works after
PLAYING=>NULL=>PLAYING, fix encoding of mono streams
2004-07-26 15:42:18 +00:00
Thomas Vander Stichele
6db1495c32 sync mp3 caps
Original commit message from CVS:
sync mp3 caps
2004-06-14 10:58:27 +00:00