Timo Wischer
de95d3a1c4
avtp: crfsync: Warn when CRF package not yet received
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1075 >
2021-11-09 15:36:25 +01:00
Timo Wischer
214691b972
test: avtp: crf: Check for rounding errors
...
on average period calculation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1073 >
2021-11-09 10:59:00 +00:00
Timo Wischer
5a25eb61b7
avtp: crf: Use double for average period calculation
...
to also support CRF intervals like every 1,333,333ns 64 events
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1073 >
2021-11-09 10:59:00 +00:00
Timo Wischer
6a576938ac
tests: avtp: crf: Test for timestamp_interval > 1
...
in case of CRF AVTPDUs with single CRF timestamp.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1076 >
2021-11-09 09:07:01 +01:00
Timo Wischer
5a9e9895ab
avtp: crf: Properly handling one timestamp per PDU
...
The average_period should always represent the time between two
events. The specification defines the event time as the time
between audio samples, video frame sync, video line sync, etc.
In case of one timestamp per PDU the timestamp_interval identifies
the amount of events between the timestamp of one PDU and the
timestamp of the next PDU.
As described in IEEE 1722-2016 chapter
"10.4.12 timestamp_interval field" timestamp_interval shall be
nonzero.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1076 >
2021-11-09 09:07:01 +01:00
Thomas Klausner
49449dfa41
shm: NetBSD build fix
...
shm_unlink() and friends live in librt on NetBSD. Adapt build system.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1323 >
2021-11-08 21:14:42 +00:00
Martin Reboredo
2546cef4be
aom: Set fixed_qp_offsets to a deactivated value
...
aom only uses fixed_qp_offsets with the
Constant Quality (Q) Rate Control mode,
previously this was locking any usage
with another Rate Control mode.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1198 >
2021-11-08 16:42:17 +00:00
Antonio Ospite
7deee582d2
magicleap: update lumin_rt libraries names to the latest official version
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1314 >
2021-11-05 16:21:34 +00:00
He Junyan
0345188aaa
codecs: h264dec: Calculate the latency by its bump mode.
...
The current latency calculation just uses the num_reorder_frames,
which is not very precise. We should consider the bump mode of the
DPB, the faster it bumps, the lower latency we will have.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1046 >
2021-11-05 14:40:42 +00:00
Thibault Saunier
d0c5778669
doc: Update nvdec documentation
...
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/870
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1309 >
2021-11-05 13:26:33 +00:00
Seungha Yang
21d7bd09ce
h264parse: Don't insert extra AUD if exists in bitstream already
...
AUD nalu in packetized format is completely valid and therefore we should not
assume that we should insert AUD for packetized -> bytestream
conversion.
Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/862
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1296 >
2021-11-04 16:32:55 +00:00
Seungha Yang
aa1d97b0fb
tests: h264parse: Add test for AUD insertion
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1296 >
2021-11-04 16:32:54 +00:00
Seungha Yang
8eee442715
wasapi2ringbuffer: Fix client object leak
...
Check whether ringbuffer is holding client object already since
open_device() may be called multiple times
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1307 >
2021-11-04 12:41:32 +00:00
Sebastian Dröge
f9a97efbe1
webrtcbin: Clear errors from finding codec preferences before the next iteration
...
The media is just skipped and the error is not propagated to the caller,
so keeping it around here would cause assertions a bit later when trying
to set a new error over the old one.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291 >
2021-11-04 10:51:15 +00:00
Sebastian Dröge
30153f1591
webrtcbin: Move addition of attributes to the caps after making sure they're not empty or any
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291 >
2021-11-04 10:51:15 +00:00
Sebastian Dröge
d628ccf0e5
webrtcbin: Don't require fixed caps when querying caps for a transceiver pad to match it with a media
...
Upstream caps might for example be
application/x-rtp,media=audio,encoding-name={OPUS, X-GST-OPUS-DRAFT-SPITTKA-00, multiopus}
and while that is not fixed caps it is enough to match it with a media.
Only caps structures that have the correct structure name and that have
the media and encoding-name field are preserved, but if both are present
then these caps are used as "codec preferences".
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1291 >
2021-11-04 10:51:15 +00:00
Tim-Philipp Müller
a7b376011b
Back to development
2021-11-03 19:31:23 +00:00
Tim-Philipp Müller
f513c289b0
Release 1.19.3
2021-11-03 15:43:43 +00:00
Tim-Philipp Müller
d51b091cd9
Update ChangeLogs for 1.19.3
2021-11-03 15:43:32 +00:00
Nicolas Dufresne
aedd5f0dd1
codecs: mpeg2: Drain before a new_sequence get signalled
...
The decoder may need to re-allocate the output buffer, it is easier if all
pictured have been outputed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
f9958eda8e
v4l2codecs: gstv4l2codecsmpeg2dec: implement a render delay
...
The v4l2 backend support delayed output for performance reasons.
It is then possible to use render delays to queue multiple requests
simultaneously, thus increasing performance.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
a8decde6d3
codecs: gstmpeg2decoder: add support for render delay
...
Some decoding APIs support delayed output for performance reasons.
One example would be to request decoding for multiple frames and
then query for the oldest frame in the output queue.
This also increases throughput for transcoding and improves seek
performance when supported by the underlying backend.
Introduce support in the mpeg2 base class, so that backends that
support render delays can actually implement it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
477b824f8e
v4l2codecs: Implement a MPEG2 V4L2 decoder element
...
Implement a MPEG2 V4L2 decoder element based on the previous h264
implementation.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
4fe6bc1afe
v4l2codecs: mpeg2: update to the new uAPI
...
The mpeg2 stateless api has undergone changes as it is being
destage. Update the v4l2-controls header to match.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
f6e17ea294
sys: va: GstVaMpeg2Dec: use slice sc_offset and size
...
Seeing as how GstMpeg2Slice will now record the start code offset
as well as its size with the above field taken into account, the
manual computation in this class is not needed.
Remove it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
Daniel Almeida
946be1a85a
codecs: GstMpeg2Slice: add field for sc_offset and size
...
Downstream might need the start code offset when decoding.
Previously this computation would be scattered in multiple sites. This
is error prone, so move it to the base class. Subclasses can access
slice->sc_offset directly without computing the address themselves
knowing that the size will also take the start code into account.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1013 >
2021-11-02 16:16:29 +00:00
James Cowgill
8b932c105f
v4l2codecs: Handle allocator creation failure
...
If `VIDIOC_REQBUFS` doesn't return enough buffers the allocator creation
function can fail and return `NULL`. Handle this by generating an error
and returning instead of segfaulting.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1220 >
2021-11-02 15:25:48 +00:00
James Cowgill
3846b0563a
v4l2codecs: Fix segfault when destroying non-detached allocator
...
The GstV4l2CodecAllocator dispose function clears `self->decoder` but
the finalize function then tries to use it if the allocator has no been
detached yet.
Fix by detaching in the dispose function before we clear
`self->decoder`.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1220 >
2021-11-02 15:25:48 +00:00
Julian Bouzas
bc358e5827
alphacombine: use the same allocation query data for both decoders
...
This allows downstream elements to set allocation query parameters for both
decoders, which should be always the same.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1277 >
2021-11-01 12:55:00 -04:00
Nirbheek Chauhan
b8d6fd905e
applemedia: Add ARGB64_BE, RGBA64_LE support to vtenc/vtdec
...
We can add this now that ARGB64_BE videoconvert support was added in:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
fed69c48b6
vtenc: Add FieldDetail properties for interlaced input
...
Standard interlace handling:
* If we have interlace-mode=interleaved and the field order, we just
set it when creating the session
* If we have interlace-mode=(interleaved|mixed) and no field order, we
set the field order on the first buffer
The encoder session does not support changing the FieldDetail after it
has started encoding frames, so we cannot support mixed streams
correctly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
29a32703a5
vtenc: Add a property to forcibly ignore alpha values
...
This PropertyKey is not documented in any headers anywhere, so we need
to define it ourselves.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
4e37f99975
vtenc: Set colorimetry information
...
It looks like VideoToolbox doesn't support all our colorimetries.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
0f0e68080c
applemedia: Add ProRes support to vtenc and vtdec
...
For vtdec, we continue to prefer NV12; else we pick whatever
downstream wants. In the special case where we're decoding 10-bit or
12-bit ProRes formats, we will prefer AYUV64.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
db638134e7
vtenc: Improve error reporting in chain function
...
Otherwise it is quite difficult to figure out why the chain function
failed. Also assert not reached for case statements that should not be
hit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Nirbheek Chauhan
d7f6f8172a
vtdec: Remove dead code in switch statement
...
We never advertise these formats, so these cases will never be hit.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1214 >
2021-11-01 09:24:52 +00:00
Sebastian Dröge
577cdcafe0
video: Fix order of new video formats
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1282 >
2021-10-31 06:38:36 +00:00
Tim-Philipp Müller
ea8dc0c737
Couple more g_memdup() -> g_memdup2() fixes
...
Fixes deprecation warnings with newer GLib versions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279 >
2021-10-30 10:37:37 +01:00
Tim-Philipp Müller
1f560af76b
dtls: don't use deprecated g_binding_get_source() with newer GLib versions
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1279 >
2021-10-30 00:52:42 +01:00
Seungha Yang
17bf17b38d
codecs: h265decoder: Fix per-slice leak
...
As documented, slice header parsed via gst_h265_parser_parse_slice_hdr()
should be cleared, otherwise it would result in memory leak.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1274 >
2021-10-29 17:25:06 +00:00
Víctor Manuel Jáquez Leal
4a4823b972
va: Delay decoders downstream negotiation.
...
Delay decoders downstream negotiation just before an output frame
needs to be allocated.
This is required, are least for H.264 and H.265 decoders, since
codec_data might trigger a new sequence before finishing upstream
negotiation, and sink pad caps need to set before setting source pad
caps, particularly to forward HDR fields. The other decoders are
changed too in order to keep the same structure among them.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257 >
2021-10-29 16:06:52 +00:00
Víctor Manuel Jáquez Leal
5494ec38d0
vabasedec: Move warning message to decoder's category.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257 >
2021-10-29 16:06:52 +00:00
Víctor Manuel Jáquez Leal
97e3f88c20
va: Move common variable need_negotiation to GstBaseDec.
...
This is a common variable to all decoders, so it's sound to move it to
the base helper.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257 >
2021-10-29 16:06:52 +00:00
Víctor Manuel Jáquez Leal
a2a3c81c85
va: Move back parent_object to each element.
...
Using GstBaseDec hack to access the parent_object of each element in
the element itself is a bit fragile. It would be better to keep its
own parent object as the usual global variable. It would make it
resistant to code changes.
The GstBaseDec macro to access the parent object now it's internal to
base decoder.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1257 >
2021-10-29 16:06:52 +00:00
Piotrek Brzeziński
428b4104b0
video-format: Add support for ARGB64 LE/BE and similar variants
...
Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1247 >
2021-10-29 14:57:58 +00:00
Heiko Becker
b83e85ab67
neon: Allow building against neon 0.32.x
...
No API/ABI changes: https://github.com/notroj/neon/blob/0.32.0/NEWS#L3
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1267 >
2021-10-29 00:14:53 +00:00
Tim-Philipp Müller
f034ec3e14
meson: require matching GStreamer dep versions for unstable development releases
...
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/929
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1244 >
2021-10-28 23:29:27 +00:00
Mathieu Duponchelle
303c8025c6
webrtcbin: fix check_negotiation computing on caps event
...
It seems logical that check_negotiation be true if received_caps
is *not* equal to the new caps.
Also clean up handling of transceivers' ssrc events, as this
patch triggered a leaky code path.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233 >
2021-10-28 19:05:59 +00:00
Mathieu Duponchelle
be0b5c54fd
webrtcbin: connect input stream when receiving caps
...
.. if a current direction has already been set
When `webrtcbin` has created an offer based on codec_preferences,
it might not have received caps on its sinkpads by the time a
remote description is set, in which case we want to connect the
input stream upon actual reception of the caps instead.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233 >
2021-10-28 19:05:59 +00:00
Mathieu Duponchelle
a9506f20d3
webrtcbin: consider pads with trans->codec_preferences ready
...
.. when determining whether we can emit on-negotiation-needed
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1233 >
2021-10-28 19:05:59 +00:00