Commit graph

171 commits

Author SHA1 Message Date
Thomas Vander Stichele
be94a147ba add a test to check that we get all decoded bytes
from a 10-buffer audiotestsrc flac, in the case of:
 - a full decode
 - a decode of a seek for the full file
 - a decode of a seek for a small part, smaller than the first buffer

The test fails because flacdec drops the first outgoing buffer on a seek
2009-04-04 15:14:31 +02:00
Peter Kjellerstedt
c83635d42c check: gst-plugins-good.supp needs to be distributed. 2009-03-04 16:15:05 +01:00
Jan Schmidt
fd75e08f45 Fix up some compile flags 2009-01-30 18:04:11 +00:00
Tim-Philipp Müller
3c1f1b195f tests: fix build of aspectratio crop unit test in uninstalled environment. 2009-01-27 20:33:02 +00:00
Thijs Vermeir
27093c19a4 Add unit test for aspectratiocrop Fixes bug #527951
Add unit test for aspectratiocrop and refactor this element. Added
finalize function to cleanup leaking mutex.
2009-01-25 18:40:42 +01:00
Sebastian Dröge
99753365c6 Rename audioreverb to audioecho. Fixes bug #568395.
The element can add an echo and a simple reverb effect to
an audio stream but for a real reverb filter it would need
some additional filtering to prevent a metallic-sounding
result.
2009-01-22 13:27:56 +01:00
Sebastian Dröge
344a9f4229 Add an echo/reverb filter to the audiofx plugin, with configurable echo delay, intensity and feedback. Fixes bug #567...
Original commit message from CVS:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/inspect/plugin-audiofx.xml:
* docs/plugins/inspect/plugin-spectrum.xml:
* gst/audiofx/Makefile.am:
* gst/audiofx/audiofx.c: (plugin_init):
* gst/audiofx/audioreverb.c: (gst_audio_reverb_base_init),
(gst_audio_reverb_class_init), (gst_audio_reverb_init),
(gst_audio_reverb_finalize), (gst_audio_reverb_set_property),
(gst_audio_reverb_get_property), (gst_audio_reverb_setup),
(gst_audio_reverb_stop), (gst_audio_reverb_transform_ip):
* gst/audiofx/audioreverb.h:
* tests/check/Makefile.am:
* tests/check/elements/audioreverb.c: (setup_reverb),
(cleanup_reverb), (GST_START_TEST), (audioreverb_suite):
Add an echo/reverb filter to the audiofx plugin, with configurable
echo delay, intensity and feedback. Fixes bug #567874.
2009-01-19 11:19:08 +00:00
Sebastian Dröge
75c1c9f378 Add audioiirfilter and audiofirfilter elements which allow generic IIR/FIR filters to be implemented by providing the...
Original commit message from CVS:
* configure.ac:
* gst/audiofx/Makefile.am:
* gst/audiofx/audiofirfilter.c: (gst_audio_fir_filter_base_init),
(gst_audio_fir_filter_class_init),
(gst_audio_fir_filter_update_kernel), (gst_audio_fir_filter_init),
(gst_audio_fir_filter_setup), (gst_audio_fir_filter_finalize),
(gst_audio_fir_filter_set_property),
(gst_audio_fir_filter_get_property):
* gst/audiofx/audiofirfilter.h:
* gst/audiofx/audiofx.c: (plugin_init):
* gst/audiofx/audioiirfilter.c: (gst_audio_iir_filter_base_init),
(gst_audio_iir_filter_class_init),
(gst_audio_iir_filter_update_coefficients),
(gst_audio_iir_filter_init), (gst_audio_iir_filter_setup),
(gst_audio_iir_filter_finalize),
(gst_audio_iir_filter_set_property),
(gst_audio_iir_filter_get_property):
* gst/audiofx/audioiirfilter.h:
Add audioiirfilter and audiofirfilter elements which allow
generic IIR/FIR filters to be implemented by providing the
filter coefficients. Fixes bug #567577.
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/gst-plugins-good-plugins.signals:
* docs/plugins/inspect/plugin-alaw.xml:
* docs/plugins/inspect/plugin-audiofx.xml:
* docs/plugins/inspect/plugin-avi.xml:
* docs/plugins/inspect/plugin-flac.xml:
* docs/plugins/inspect/plugin-mulaw.xml:
* docs/plugins/inspect/plugin-video4linux2.xml:
* docs/plugins/inspect/plugin-wavparse.xml:
Add documentation for the audioiirfilter and audiofirfilter
elements.
* tests/check/Makefile.am:
* tests/check/elements/audiofirfilter.c: (on_message),
(on_rate_changed), (on_handoff), (GST_START_TEST),
(audiofirfilter_suite):
* tests/check/elements/audioiirfilter.c: (on_message),
(on_rate_changed), (on_handoff), (GST_START_TEST),
(audioiirfilter_suite):
* tests/examples/Makefile.am:
* tests/examples/audiofx/Makefile.am:
* tests/examples/audiofx/firfilter-example.c: (on_message),
(on_rate_changed), (main):
* tests/examples/audiofx/iirfilter-example.c: (on_message),
(on_rate_changed), (main):
Add unit tests and example applications for the two filter
elements.
2009-01-13 19:23:57 +00:00
Sebastian Dröge
2a21dd6d8e tests/check/Makefile.am: Also ignore pulsemixer for the states unit test.
Original commit message from CVS:
* tests/check/Makefile.am:
Also ignore pulsemixer for the states unit test.
2008-12-09 14:30:03 +00:00
Jan Schmidt
968bee1f95 tests/check/Makefile.am: Just keep disabling elements that hang the states test until it works.
Original commit message from CVS:
* tests/check/Makefile.am:
Just keep disabling elements that hang the states test until it
works.
2008-11-20 13:58:43 +00:00
Jan Schmidt
cbeb0d1d49 tests/check/Makefile.am: Don't run the states test on pulsesrc and pulsesink
Original commit message from CVS:
* tests/check/Makefile.am:
Don't run the states test on pulsesrc and pulsesink
2008-10-16 15:30:22 +00:00
Jan Schmidt
f505a291ff Move replaygain and interleave plugins from -bad.
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/gst-plugins-good-plugins.interfaces:
* docs/plugins/gst-plugins-good-plugins.prerequisites:
* docs/plugins/inspect/plugin-interleave.xml:
* docs/plugins/inspect/plugin-replaygain.xml:
* tests/check/Makefile.am:
Move replaygain and interleave plugins from -bad.
Fixes: #543406
Fixes: #536228
2008-07-19 01:01:13 +00:00
Jan Schmidt
b47679bd95 Ignore some more generated things
Original commit message from CVS:
* docs/plugins/.cvsignore:
* tests/check/elements/.cvsignore:
Ignore some more generated things
* tests/check/Makefile.am:
Ignore OSS elements in the state changes test too.
2008-05-28 20:01:32 +00:00
Jan Schmidt
430bd1c7ec tests/check/Makefile.am: Disable some more elements in the state test.
Original commit message from CVS:
* tests/check/Makefile.am:
Disable some more elements in the state test.
Add a define so the soup test can find the test files
it needs at runtime.
* tests/check/elements/souphttpsrc.c: (run_server):
Add a define so the soup test can find the test files
it needs at runtime.
2008-04-17 22:32:16 +00:00
Jan Schmidt
2bdd92b2be tests/check/Makefile.am: Add soup test certificates to the dist.
Original commit message from CVS:
* tests/check/Makefile.am:
Add soup test certificates to the dist.
2008-04-13 23:13:32 +00:00
Jan Schmidt
8bc076ee6e Move soup plugin from -bad (Fixes: #523124)
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-soup.xml:
* ext/Makefile.am:
* tests/check/Makefile.am:
Move soup plugin from -bad (Fixes: #523124)
2008-04-12 23:30:54 +00:00
Tim-Philipp Müller
401159a255 tests/check/: Add unit test for gdkpixbufsink element.
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/gdkpixbufsink.c:
Add unit test for gdkpixbufsink element.
2008-04-03 22:59:44 +00:00
Sebastian Dröge
ec1a826cc8 tests/check/: Add unit test that encodes and decodes some data, checks that it is still the same and that all timesta...
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/pipelines/wavpack.c: (bus_handler),
(identity_handoff), (fakesink_handoff), (GST_START_TEST),
(wavpack_suite), (main):
Add unit test that encodes and decodes some data, checks that it
is still the same and that all timestamps/offsets are perfect.
2008-04-03 20:05:31 +00:00
Sebastian Dröge
2a424ead41 tests/check/Makefile.am: Ignore gconfaudiosrc for the states unit test too. It will fallback to alsasrc if the gconf ...
Original commit message from CVS:
* tests/check/Makefile.am:
Ignore gconfaudiosrc for the states unit test too. It will fallback
to alsasrc if the gconf settings can't be read and not everybody has
alsa.
2008-02-22 06:22:39 +00:00
Sebastian Dröge
4358811258 Add a few libjpeg suppressions and initialize a variable to make smokeenc valgrind clean. Fixes bug #515701.
Original commit message from CVS:
* ext/jpeg/gstsmokeenc.c: (gst_smokeenc_chain):
* tests/check/Makefile.am:
* tests/check/gst-plugins-good.supp:
Add a few libjpeg suppressions and initialize a variable to
make smokeenc valgrind clean. Fixes bug #515701.
2008-02-12 05:14:16 +00:00
Jan Schmidt
6afa17d8f0 gst/: Fix includes order
Original commit message from CVS:
* gst/equalizer/Makefile.am:
* gst/spectrum/Makefile.am:
Fix includes order
* tests/check/Makefile.am:
Exclude v4l2src from the states test - it takes too long to start.
* tests/check/elements/spectrum.c:
Make the test run properly with CK_FORK=no
2008-02-09 00:15:25 +00:00
Jan Schmidt
26a52d2733 Move multifile plugin from -bad.
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/inspect/plugin-multifile.xml:
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
Move multifile plugin from -bad.
Fixes: #490283
2008-02-08 04:25:32 +00:00
Jan Schmidt
1d5d8e1397 Move spectrum plugin from -bad.
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/inspect/plugin-spectrum.xml:
* gst/spectrum/Makefile.am:
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/examples/Makefile.am:
Move spectrum plugin from -bad.
Move examples into tests/examples/spectrum.
2008-02-08 03:28:57 +00:00
Jan Schmidt
5aa6c44ee8 Move the equalizer plugin across from -bad
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/gst-plugins-good-plugins.interfaces:
* docs/plugins/inspect/plugin-equalizer.xml:
* gst/equalizer/Makefile.am:
* tests/check/Makefile.am:
* tests/examples/Makefile.am:
Move the equalizer plugin across from -bad
* tests/check/elements/.cvsignore:
Add equalizer, audiosincwband and audiosincwlimit
* tests/check/elements/equalizer.c:
Fix compiler warnings
2008-02-08 02:49:20 +00:00
Jan Schmidt
6fe3c141d7 Move the lpwsinc and bpwsinc elements from gst-plugins-bad into the audiofx plugin, and rename to audiowsinclimit and...
Original commit message from CVS:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-audiofx.xml:
* gst/audiofx/Makefile.am:
* gst/audiofx/audiofx.c:
* gst/audiofx/audiowsincband.c:
* gst/audiofx/audiowsincband.h:
* gst/audiofx/audiowsinclimit.c:
* gst/audiofx/audiowsinclimit.h:
* tests/check/Makefile.am:
* tests/check/elements/audiowsincband.c:
* tests/check/elements/audiowsinclimit.c:
Move the lpwsinc and bpwsinc elements from gst-plugins-bad into
the audiofx plugin, and rename to audiowsinclimit and audiowsincband
respectively.
Fixes: #467666
2008-02-07 21:57:54 +00:00
Jan Schmidt
22bea9fec3 Rename audiochebyshevfreqband -> audiochebband and audiochebyshevfreqlimit -> audiocheblimit and do the requisite CVS...
Original commit message from CVS:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-audiofx.xml:
* gst/audiofx/Makefile.am:
* gst/audiofx/audiochebband.c:
* gst/audiofx/audiochebband.h:
* gst/audiofx/audiocheblimit.c:
* gst/audiofx/audiocheblimit.h:
* gst/audiofx/audiochebyshevfreqband.c:
* gst/audiofx/audiochebyshevfreqband.h:
* gst/audiofx/audiochebyshevfreqlimit.c:
* gst/audiofx/audiochebyshevfreqlimit.h:
* gst/audiofx/audiofx.c:
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/audiochebband.c:
* tests/check/elements/audiocheblimit.c:
* tests/check/elements/audiochebyshevfreqband.c:
* tests/check/elements/audiochebyshevfreqlimit.c:
Rename audiochebyshevfreqband -> audiochebband and
audiochebyshevfreqlimit -> audiocheblimit and do the requisite CVS
surgery.
Closes: #491811
2008-02-06 23:44:43 +00:00
Tim-Philipp Müller
cf1135694d tests/check/Makefile.am: Add rtp-payloading test to VALGRIND_TO_FIX.
Original commit message from CVS:
* tests/check/Makefile.am:
Add rtp-payloading test to VALGRIND_TO_FIX.
* tests/check/elements/rtp-payloading.c:
Add semicolons after GST_TEST_END so gst-indent gets the
formatting right; make test less verbose in general, but
more verbose in the error case (which should probably
make the test fail anyway).
2008-02-02 18:06:19 +00:00
Stefan Kost
956ae25e78 tests/check/: Add add testsuite for the rtp-payloader that tries simulating dataflow. Needs more test data.
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/rtp-payloading.c:
Add add testsuite for the rtp-payloader that tries simulating
dataflow. Needs more test data.
2008-01-29 15:45:48 +00:00
Jan Schmidt
23b5b27e1c tests/check/Makefile.am: Fix up some CFLAGS sets.
Original commit message from CVS:
* tests/check/Makefile.am:
Fix up some CFLAGS sets.
Don't include gconfvideosrc in the states test.
* tests/check/elements/autodetect.c: (GST_START_TEST):
Add some error strings to fail_unless arguments to fix some weird
compiler errors on Solaris.
2008-01-21 19:41:45 +00:00
Thijs Vermeir
d0c62e9108 Add avi subtitle element for bug #442034. Need seeking support and more support for character conversion.
Original commit message from CVS:
* gst/avi/Makefile.am:
* gst/avi/gstavi.c:
* gst/avi/gstavisubtitle.c:
* gst/avi/gstavisubtitle.h:
* tests/check/Makefile.am:
* tests/check/elements/avisubtitle.c:
* win32/common/config.h:
Add avi subtitle element for bug #442034. Need seeking support
and more support for character conversion.
2007-12-18 09:13:12 +00:00
Timo Hotti
123e085e75 tests/check/: Add unit tests for payloaders/depayloaders.
Original commit message from CVS:
Patch by: Timo Hotti <Timo.Hotti@sysopendigia.com>
* tests/check/Makefile.am:
* tests/check/pipelines/simple-launch-lines.c:
Add unit tests for payloaders/depayloaders.
2007-10-04 07:24:02 +00:00
Stefan Kost
ce322e50aa ext/cairo/gsttextoverlay.c: Add info about static leak.
Original commit message from CVS:
* ext/cairo/gsttextoverlay.c:
Add info about static leak.
* tests/check/Makefile.am:
* tests/check/generic/states.c:
Improved state change unit test.
2007-09-20 13:35:34 +00:00
Sebastian Dröge
842451a720 gst/audiofx/: Add Chebyshev lowpass/highpass and bandpass/bandreject elements.
Original commit message from CVS:
reviewed by: Stefan Kost  <ensonic@users.sf.net>
* gst/audiofx/Makefile.am:
* gst/audiofx/audiochebyshevfreqband.c:
(gst_audio_chebyshev_freq_band_mode_get_type),
(gst_audio_chebyshev_freq_band_base_init),
(gst_audio_chebyshev_freq_band_dispose),
(gst_audio_chebyshev_freq_band_class_init),
(gst_audio_chebyshev_freq_band_init),
(generate_biquad_coefficients), (calculate_gain),
(generate_coefficients),
(gst_audio_chebyshev_freq_band_set_property),
(gst_audio_chebyshev_freq_band_get_property),
(gst_audio_chebyshev_freq_band_setup), (process), (process_64),
(process_32), (gst_audio_chebyshev_freq_band_transform_ip),
(gst_audio_chebyshev_freq_band_start):
* gst/audiofx/audiochebyshevfreqband.h:
* gst/audiofx/audiochebyshevfreqlimit.c:
(gst_audio_chebyshev_freq_limit_mode_get_type),
(gst_audio_chebyshev_freq_limit_base_init),
(gst_audio_chebyshev_freq_limit_dispose),
(gst_audio_chebyshev_freq_limit_class_init),
(gst_audio_chebyshev_freq_limit_init),
(generate_biquad_coefficients), (calculate_gain),
(generate_coefficients),
(gst_audio_chebyshev_freq_limit_set_property),
(gst_audio_chebyshev_freq_limit_get_property),
(gst_audio_chebyshev_freq_limit_setup), (process), (process_64),
(process_32), (gst_audio_chebyshev_freq_limit_transform_ip),
(gst_audio_chebyshev_freq_limit_start):
* gst/audiofx/audiochebyshevfreqlimit.h:
* gst/audiofx/audiofx.c: (plugin_init):
Add Chebyshev lowpass/highpass and bandpass/bandreject elements.
Fixes #464800.
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/audiochebyshevfreqband.c:
(setup_audiochebyshevfreqband), (cleanup_audiochebyshevfreqband),
(GST_START_TEST), (audiochebyshevfreqband_suite), (main):
* tests/check/elements/audiochebyshevfreqlimit.c:
(setup_audiochebyshevfreqlimit), (cleanup_audiochebyshevfreqlimit),
(GST_START_TEST), (audiochebyshevfreqlimit_suite), (main):
Add unit tests for the chebyshev filters.
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-1394.xml:
* docs/plugins/inspect/plugin-audiofx.xml:
* docs/plugins/inspect/plugin-dv.xml:
* docs/plugins/inspect/plugin-flac.xml:
* docs/plugins/inspect/plugin-jpeg.xml:
* docs/plugins/inspect/plugin-png.xml:
* docs/plugins/inspect/plugin-rtp.xml:
* docs/plugins/inspect/plugin-shout2send.xml:
* docs/plugins/inspect/plugin-wavpack.xml:
And add docs for the chebyshev filters. While doing
that also run make update in docs/plugins.
2007-08-16 17:02:07 +00:00
Tim-Philipp Müller
b753979d86 tests/check/: Add GST_OPTION_CFLAGS to CFLAGS when building unit tests, so the error flags are included and it errors...
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/elements/audiopanorama.c: (GST_START_TEST):
* tests/check/elements/videocrop.c: (GST_START_TEST):
* tests/check/elements/videofilter.c:
* tests/check/elements/wavpackdec.c: (GST_START_TEST):
* tests/check/elements/wavpackparse.c: (GST_START_TEST):
Add GST_OPTION_CFLAGS to CFLAGS when building unit tests, so the
error flags are included and it errors out on compiler warnings
for CVS builds; remove unused variables in various unit tests.
2007-06-19 16:40:40 +00:00
Jan Schmidt
bbcc24410d Move videocrop and osxvideo from -bad.
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/inspect/plugin-videocrop.xml:
* gst-plugins-good.spec.in:
* sys/Makefile.am:
* tests/check/Makefile.am:
* tests/icles/Makefile.am:
* tests/icles/videocrop-test.c:
Move videocrop and osxvideo from -bad.
2007-06-12 20:15:29 +00:00
Thomas Vander Stichele
4e78ffa15c move wavpack plugin. See #352605.
Original commit message from CVS:
* configure.ac:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/gst-plugins-good-plugins.hierarchy:
* docs/plugins/gst-plugins-good-plugins.signals:
* docs/plugins/inspect/plugin-autodetect.xml:
* docs/plugins/inspect/plugin-gconfelements.xml:
* docs/plugins/inspect/plugin-ladspa.xml:
* docs/plugins/inspect/plugin-rtp.xml:
* docs/plugins/inspect/plugin-wavpack.xml:
* ext/Makefile.am:
* tests/check/Makefile.am:
move wavpack plugin.  See #352605.
2007-06-08 20:19:55 +00:00
Tim-Philipp Müller
e53a24511b gst/alpha/gstalphacolor.c: Double-check that RGB input caps are really RGBA caps (apparently the core doesn't always ...
Original commit message from CVS:
* gst/alpha/gstalphacolor.c: (gst_alpha_color_base_init),
(gst_alpha_color_transform_caps), (gst_alpha_color_set_caps):
Double-check that RGB input caps are really RGBA caps (apparently
the core doesn't always catch it if those caps aren't a subset of
our template caps, also see #421543). Fixes #429319 in a way.
Also, don't leak the pad template in the transform_caps function.
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/alphacolor.c: (setup_alphacolor),
(cleanup_alphacolor), (create_caps_rgb24), (create_caps_rgba32),
(create_buffer_rgb24_3x4), (create_buffer_rgba32_3x4),
(GST_START_TEST), (alphacolor_suite):
Add some basic unit tests for alphacolor.
2007-04-25 15:31:53 +00:00
Tim-Philipp Müller
c3e99dd86c sys/sunaudio/: Actually translate sunaudio mixer track labels instead of just marking the strings as translatable (#3...
Original commit message from CVS:
* sys/sunaudio/gstsunaudio.c: (plugin_init):
* sys/sunaudio/gstsunaudiomixertrack.c:
(gst_sunaudiomixer_track_new):
Actually translate sunaudio mixer track labels instead of just
marking the strings as translatable (#377306); clean up weird
label string mapping code that serves no apparent purpose. Also
set the 'untranslated-label' property when creating mixer tracks
if the GstMixerTrack base class supports this.
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/sunaudio.c: (GST_START_TEST),
(sunaudio_suite):
Very minimalistic unit test for sunaudiomixer element (compiles, but not
actually tested on a system where sunaudiomixer is available).
2007-03-09 19:44:30 +00:00
Jan Schmidt
d44570cfdd tests/check/Makefile.am: Re-enable the states test and see if it works on the buildbots.
Original commit message from CVS:
* tests/check/Makefile.am:
Re-enable the states test and see if it works on the buildbots.
2007-03-09 18:49:37 +00:00
Jan Schmidt
7a71c68fa8 tests/check/Makefile.am: Disable the states check until the remaining Valgrind errors are fixed or suppressed.
Original commit message from CVS:
* tests/check/Makefile.am:
Disable the states check until the remaining Valgrind errors
are fixed or suppressed.
2007-03-08 12:23:57 +00:00
Sebastian Dröge
dbd1b8490f gst/audiofx/: Add new audiodynamic element which can act as a compressor or expander. Supported are hard-knee and sof...
Original commit message from CVS:
reviewed by: Stefan Kost  <ensonic@users.sf.net>
* gst/audiofx/Makefile.am:
* gst/audiofx/audiodynamic.c:
(gst_audio_dynamic_characteristics_get_type),
(gst_audio_dynamic_mode_get_type),
(gst_audio_dynamic_set_process_function),
(gst_audio_dynamic_base_init), (gst_audio_dynamic_class_init),
(gst_audio_dynamic_init), (gst_audio_dynamic_set_property),
(gst_audio_dynamic_get_property), (gst_audio_dynamic_setup),
(gst_audio_dynamic_transform_hard_knee_compressor_int),
(gst_audio_dynamic_transform_hard_knee_compressor_float),
(gst_audio_dynamic_transform_soft_knee_compressor_int),
(gst_audio_dynamic_transform_soft_knee_compressor_float),
(gst_audio_dynamic_transform_hard_knee_expander_int),
(gst_audio_dynamic_transform_hard_knee_expander_float),
(gst_audio_dynamic_transform_soft_knee_expander_int),
(gst_audio_dynamic_transform_soft_knee_expander_float),
(gst_audio_dynamic_transform_ip):
* gst/audiofx/audiodynamic.h:
* gst/audiofx/audiofx.c: (plugin_init):
Add new audiodynamic element which can act as a compressor or
expander. Supported are hard-knee and soft-knee operation modes with
user-specified ratio and threshold.
Attack and release parameters are not yet implemented but will follow.
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-audiofx.xml:
Integrate audiodynamic into the docs.
* tests/check/Makefile.am:
* tests/check/elements/audiodynamic.c: (setup_dynamic),
(cleanup_dynamic), (GST_START_TEST), (dynamic_suite), (main):
Add unit test for audiodynamic.
2007-03-08 10:02:12 +00:00
Tim-Philipp Müller
009c9750ea gst/id3demux/gstid3demux.c: Don't leak caps: make gst_id3demux_add_srcpad() not take ownership of the caps passed to ...
Original commit message from CVS:
* gst/id3demux/gstid3demux.c: (gst_id3demux_add_srcpad),
(gst_id3demux_sink_activate):
Don't leak caps: make gst_id3demux_add_srcpad() not take ownership of the
caps passed to it (previouslly one code path assumes it takes ownership
while another one assumes it doesn't).
* configure.ac:
* tests/files/Makefile.am:
* tests/files/id3-407349-1.tag:
* tests/files/id3-407349-2.tag:
Add directory where data for unit tests can be stored.
* tests/Makefile.am:
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/id3demux.c: (pad_added_cb), (error_cb),
(read_tags_from_file), (run_check_for_file),
(check_date_1977_06_23), (GST_START_TEST), (id3demux_suite):
Add unit test for id3demux, and in particular for bug #407349. Only
testing pull-mode for now; push mode doesn't work yet because the test
files are smaller than ID3_TYPE_FIND_MIN_SIZE.
2007-03-06 23:19:30 +00:00
Tim-Philipp Müller
cc09b81c01 tests/check/Makefile.am: Add missing backslash at end of line.
Original commit message from CVS:
* tests/check/Makefile.am:
Add missing backslash at end of line.
2007-03-06 22:14:59 +00:00
Jan Schmidt
121c201c7d tests/check/Makefile.am: Gah! Also disable gconfvideosink from the tests, otherwise it will instantiate autovideosink...
Original commit message from CVS:
* tests/check/Makefile.am:
Gah! Also disable gconfvideosink from the tests, otherwise
it will instantiate autovideosink, and dfbvideosink and
leak on the buildbots.
2007-03-04 17:33:34 +00:00
Jan Schmidt
5114bbb5c2 tests/check/Makefile.am: Disable autovideosink so the buildbots don't barf over memory leaked in the directfb sink.
Original commit message from CVS:
* tests/check/Makefile.am:
Disable autovideosink so the buildbots don't barf over memory
leaked in the directfb sink.
2007-03-04 17:05:58 +00:00
Jan Schmidt
d3963f7a06 tests/check/Makefile.am: Disable cacasink from the states check too - it also calls exit(1) on us when it can't find ...
Original commit message from CVS:
* tests/check/Makefile.am:
Disable cacasink from the states check too - it also calls exit(1)
on us when it can't find a terminal to talk to.
2007-03-02 13:19:57 +00:00
Jan Schmidt
520caf5f34 tests/check/Makefile.am: Disable aasink in the states test. I suspect this is the element that is calling exit(1) whe...
Original commit message from CVS:
* tests/check/Makefile.am:
Disable aasink in the states test. I suspect this is the element that
is calling exit(1) when it can't proceed.
2007-03-01 18:14:42 +00:00
Jan Schmidt
8ed6a4aca9 tests/check/Makefile.am: Draw plugins in from the build tree sys/ dir, rather than picking up the already installed v...
Original commit message from CVS:
* tests/check/Makefile.am:
Draw plugins in from the build tree sys/ dir, rather than picking
up the already installed versions.
2007-03-01 17:26:30 +00:00
Thomas Vander Stichele
736a60807f tests/check/: add test for states
Original commit message from CVS:
* tests/check/Makefile.am:
* tests/check/generic/states.c: (GST_START_TEST), (states_suite):
add test for states
2007-02-28 12:59:43 +00:00
Mark Nauwelaerts
18f3209f29 gst/videofilter/: Port gamma filter to 0.10. Fixes #412704.
Original commit message from CVS:
Patch by: Mark Nauwelaerts <manauw at skynet be>
* gst/videofilter/Makefile.am:
* gst/videofilter/gstgamma.c: (gst_gamma_base_init),
(gst_gamma_class_init), (gst_gamma_init), (gst_gamma_set_property),
(gst_gamma_get_property), (gst_gamma_calculate_tables),
(oil_tablelookup_u8), (gst_gamma_set_caps),
(gst_gamma_planar411_ip), (gst_gamma_transform_ip), (plugin_init):
Port gamma filter to 0.10. Fixes #412704.
* tests/check/Makefile.am:
* tests/check/elements/videofilter.c: (setup_filter),
(cleanup_filter), (check_filter), (GST_START_TEST),
(videobalance_suite), (videoflip_suite), (gamma_suite), (main):
Add unit tests for videofilters.
2007-02-28 10:17:15 +00:00
Sebastian Dröge
54b10ebf2a gst/audiofx/: Add new element "audioamplify". This allows scaling of raw audio samples, similar to the "volume" eleme...
Original commit message from CVS:
reviewed by: Stefan Kost  <ensonic@users.sf.net>
* gst/audiofx/Makefile.am:
* gst/audiofx/audioamplify.c:
(gst_audio_amplify_clipping_method_get_type),
(gst_audio_amplify_base_init), (gst_audio_amplify_class_init),
(gst_audio_amplify_init), (gst_audio_amplify_set_process_function),
(gst_audio_amplify_set_property), (gst_audio_amplify_get_property),
(gst_audio_amplify_set_caps),
(gst_audio_amplify_transform_int_clip),
(gst_audio_amplify_transform_int_wrap_negative),
(gst_audio_amplify_transform_int_wrap_positive),
(gst_audio_amplify_transform_float_clip),
(gst_audio_amplify_transform_float_wrap_negative),
(gst_audio_amplify_transform_float_wrap_positive),
(gst_audio_amplify_transform_ip):
* gst/audiofx/audioamplify.h:
* gst/audiofx/audiofx.c: (plugin_init):
Add new element "audioamplify". This allows scaling of raw audio
samples, similar to the "volume" element, but provides different modes
for clipping and allows unlimited amplification. It's mainly targeted
for creative sound design and not as a replacement of the "volume"
element. Fixes #397162
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-audiofx.xml:
Add docs for audioamplify and integrate them into the build system
* tests/check/Makefile.am:
* tests/check/elements/audioamplify.c: (setup_amplify),
(cleanup_amplify), (GST_START_TEST), (amplify_suite), (main):
Add fairly extensive unit test suite for audioamplify
2007-01-24 12:41:03 +00:00
Sebastian Dröge
447ae144c2 gst/audiofx/: Add new audiofx element "audioinvert". This element swaps the upper and lower half of samples and can b...
Original commit message from CVS:
reviewed by: Stefan Kost  <ensonic@users.sf.net>
* gst/audiofx/Makefile.am:
* gst/audiofx/audiofx.c: (plugin_init):
* gst/audiofx/audioinvert.c: (gst_audio_invert_base_init),
(gst_audio_invert_class_init), (gst_audio_invert_init),
(gst_audio_invert_set_property), (gst_audio_invert_get_property),
(gst_audio_invert_set_caps), (gst_audio_invert_transform_int),
(gst_audio_invert_transform_float),
(gst_audio_invert_transform_ip):
* gst/audiofx/audioinvert.h:
Add new audiofx element "audioinvert". This element swaps the upper
and lower half of samples and can be used for example for a
wide-stereo effect. Fixes #396057
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* docs/plugins/gst-plugins-good-plugins.args:
* docs/plugins/inspect/plugin-audiofx.xml:
Add docs for the audioinvert element and add them to the build system.
* tests/check/Makefile.am:
* tests/check/elements/audioinvert.c: (setup_invert),
(cleanup_invert), (GST_START_TEST), (invert_suite), (main):
Add unit test suite for the audioinvert element.
2007-01-23 18:16:09 +00:00
Tim-Philipp Müller
475aed8af6 tests/check/Makefile.am: Disable autodetect test temporarily, so that the build bots update -bad and the ranks of unr...
Original commit message from CVS:
* tests/check/Makefile.am:
Disable autodetect test temporarily, so that the build bots
update -bad and the ranks of unreliable video sinks in there.
* tests/check/elements/autodetect.c: (GST_START_TEST):
Skip test if no usable videosink is found.
2006-09-29 15:39:41 +00:00
Tim-Philipp Müller
e4ba501855 gst/autodetect/: Make static pad templates static to appease valgrind's leak detector.
Original commit message from CVS:
* gst/autodetect/gstautoaudiosink.c:
(gst_auto_audio_sink_base_init):
* gst/autodetect/gstautovideosink.c:
(gst_auto_video_sink_base_init):
Make static pad templates static to appease valgrind's leak
detector.
* tests/check/Makefile.am:
* tests/check/elements/.cvsignore:
* tests/check/elements/autodetect.c: (GST_START_TEST),
(autodetect_suite):
Add simple test for the ghostpad lockup on shutdown fixed in core
CVS (audio bit disabled because it would need dozens of alsa
suppressions and I'm too lazy to add those now).
2006-09-22 12:12:10 +00:00
Stefan Kost
32df8f43da gst/audiofxgood/audiofx.c
Original commit message from CVS:
* configure.ac:
* gst/audiofxgood/.cvsignore:
* gst/audiofxgood/Makefile.am:
* gst/audiofxgood/audiofx.c
* gst/audiofxgood/audiopanorama.c: (gst_audio_panorama_base_init),
(gst_audio_panorama_class_init), (gst_audio_panorama_init),
(gst_audio_panorama_set_property),
(gst_audio_panorama_get_property),
(gst_audio_panorama_get_unit_size),
(gst_audio_panorama_transform_caps), (gst_audio_panorama_set_caps),
(gst_audio_panorama_transform_m2s),
(gst_audio_panorama_transform_s2s), (gst_audio_panorama_transform):
* gst/audiofxgood/audiopanorama.h:
* tests/check/Makefile.am:
* tests/check/elements/audiopanorama.c: (setup_panorama_m),
(setup_panorama_s), (cleanup_panorama), (GST_START_TEST),
(panorama_suite), (main):
Add audiofxgood plugin with audiopanorama element
2006-08-20 12:09:16 +00:00
Tim-Philipp Müller
e501141c75 tests/check/Makefile.am: Don't try to run annodex unit tests if the annodex plugin has not been built (Fixes #351116).
Original commit message from CVS:
* tests/check/Makefile.am:
Don't try to run annodex unit tests if the annodex
plugin has not been built (Fixes #351116).
2006-08-16 12:02:48 +00:00
Sebastian Dröge
c121cab661 Add apev2mux element (#343122).
Original commit message from CVS:
Patch by: Sebastian Dröge  <mail at slomosnail de >
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* ext/taglib/Makefile.am:
* ext/taglib/gstapev2mux.cc:
* ext/taglib/gstapev2mux.h:
* ext/taglib/gstid3v2mux.cc:
* ext/taglib/gsttaglibmux.c: (plugin_init):
* ext/taglib/gsttaglibmux.h:
Add apev2mux element (#343122).
* tests/check/Makefile.am:
* tests/check/elements/apev2mux.c:
(test_taglib_apev2mux_create_tags),
(test_taglib_apev2mux_check_tags), (fill_mp3_buffer), (got_buffer),
(demux_pad_added), (test_taglib_apev2mux_check_output_buffer),
(test_taglib_apev2mux_with_tags), (GST_START_TEST),
(apev2mux_suite), (main):
Add unit test for apev2mux element.
2006-05-30 14:35:18 +00:00
Thomas Vander Stichele
7df5ab1bf2 configure.ac: figure out where plugins-base plugins are
Original commit message from CVS:

* configure.ac:
figure out where plugins-base plugins are
* tests/check/Makefile.am:
use plugins-base plugins, so we have typefind functions
* tests/check/elements/id3v2mux.c: (test_taglib_id3mux_with_tags):
increase num-buffers, this makes sure the test errors out instead
of timing out when no typefind functions are present
2006-05-02 13:24:38 +00:00
Thomas Vander Stichele
8d58b030d6 docs/plugins/Makefile.am: also check .cc files for gtk-doc markup
Original commit message from CVS:

* docs/plugins/Makefile.am:
also check .cc files for gtk-doc markup
* configure.ac:
* docs/plugins/gst-plugins-good-plugins-docs.sgml:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* tests/check/Makefile.am:
* tests/check/elements/id3v2mux.c: (id3v2mux_suite), (main):
* ext/Makefile.am:
* ext/taglib/Makefile.am:
* ext/taglib/gstid3v2mux.h:
* ext/taglib/gsttaglibmux.c:
* ext/taglib/gsttaglibmux.h:
move taglib-based id3v2muxer to -good.  Fixes #336110.
2006-05-01 11:46:33 +00:00
Mark Nauwelaerts
d1cdfa6d3c gst/avi/: Port AVI muxer to GStreamer-0.10 (#332031).
Original commit message from CVS:
Patch by: Mark Nauwelaerts  <manauw at skynet dot be>
* gst/avi/Makefile.am:
* gst/avi/gstavi.c: (plugin_init):
* gst/avi/gstavimux.c: (gst_avi_mux_get_type),
(gst_avi_mux_base_init), (gst_avi_mux_finalize),
(gst_avi_mux_class_init), (gst_avi_mux_init),
(gst_avi_mux_vidsink_set_caps), (gst_avi_mux_audsink_set_caps),
(gst_avi_mux_pad_link), (gst_avi_mux_pad_unlink),
(gst_avi_mux_request_new_pad), (gst_avi_mux_release_pad),
(gst_avi_mux_write_tag), (gst_avi_mux_riff_get_avi_header),
(gst_avi_mux_riff_get_avix_header),
(gst_avi_mux_riff_get_video_header),
(gst_avi_mux_riff_get_audio_header), (gst_avi_mux_add_index),
(gst_avi_mux_write_index), (gst_avi_mux_bigfile),
(gst_avi_mux_start_file), (gst_avi_mux_stop_file),
(gst_avi_mux_restart_file), (gst_avi_mux_handle_event),
(gst_avi_mux_fill_queue), (gst_avi_mux_send_pad_data),
(gst_avi_mux_strip_buffer), (gst_avi_mux_do_audio_buffer),
(gst_avi_mux_do_video_buffer), (gst_avi_mux_do_one_buffer),
(gst_avi_mux_loop), (gst_avi_mux_collect_pads),
(gst_avi_mux_get_property), (gst_avi_mux_set_property),
(gst_avi_mux_change_state):
* gst/avi/gstavimux.h:
Port AVI muxer to GStreamer-0.10 (#332031).
* tests/check/Makefile.am:
* tests/check/elements/avimux.c:
* tests/check/elements/.cvsignore:
Add unit test for AVI muxer.
2006-04-27 14:51:06 +00:00
Michael Smith
a945c1582d Add icydemux, and tests.
Original commit message from CVS:
* configure.ac:
* gst/icydemux/Makefile.am:
* gst/icydemux/gsticydemux.c: (gst_icydemux_get_type),
(gst_icydemux_base_init), (gst_icydemux_class_init),
(gst_icydemux_reset), (gst_icydemux_init),
(gst_icydemux_sink_setcaps), (gst_icydemux_dispose),
(gst_icydemux_add_srcpad), (gst_icydemux_remove_srcpad),
(unicodify), (gst_icydemux_unicodify),
(gst_icydemux_parse_and_send_tags),
(gst_icydemux_typefind_or_forward), (gst_icydemux_add_meta),
(gst_icydemux_chain), (gst_icydemux_change_state),
(gst_icydemux_send_tag_event), (plugin_init):
* gst/icydemux/gsticydemux.h:
* tests/check/Makefile.am:
* tests/check/elements/icydemux.c: (typefind_succeed),
(plugin_init), (icydemux_found_pad), (create_icydemux),
(cleanup_icydemux), (push_data), (GST_START_TEST),
(icydemux_suite), (main):
Add icydemux, and tests.
2006-04-21 09:27:11 +00:00
Julien Moutte
22e1a6cf15 tests/check/: Fix tests so that they use the plugins-base tags.
Original commit message from CVS:
2006-02-25  Julien MOUTTE  <julien@moutte.net>

* tests/check/Makefile.am:
* tests/check/elements/cmmldec.c:
* tests/check/elements/cmmlenc.c: Fix tests so that they use
the plugins-base tags.
2006-02-24 23:52:28 +00:00
Julien Moutte
64867fc22d tests/check/Makefile.am: Forgot to remove that test.
Original commit message from CVS:
2006-02-25  Julien MOUTTE  <julien@moutte.net>

* tests/check/Makefile.am: Forgot to remove that test.
2006-02-24 23:32:14 +00:00
Julien Moutte
7f87731d5b Try to fix Annodex plugin.
Original commit message from CVS:
2006-02-25  Julien MOUTTE  <julien@moutte.net>

* ext/annodex/Makefile.am:
* ext/annodex/gstannodex.c: (plugin_init):
* ext/annodex/gstcmmldec.c:
* ext/annodex/gstskeldec.c:
* ext/annodex/gstskeldec.h:
* tests/check/Makefile.am:
* tests/check/elements/skeldec.c: Try to fix Annodex plugin.
2006-02-24 23:31:08 +00:00
Julien Moutte
7734c8c654 tests/check/Makefile.am: Disable those checks as well.
Original commit message from CVS:
2006-02-25  Julien MOUTTE  <julien@moutte.net>

* tests/check/Makefile.am: Disable those checks as well.
2006-02-24 23:06:27 +00:00
Michael Smith
73ce8c5b9e Add Annodex elements from Alessendro Decina: skeleton and CMML.
Original commit message from CVS:
* configure.ac:
* docs/plugins/gst-plugins-good-plugins-sections.txt:
* ext/Makefile.am:
* ext/annodex/Makefile.am:
* ext/annodex/gstannodex.c:
* ext/annodex/gstannodex.h:
* ext/annodex/gstcmmldec.c:
* ext/annodex/gstcmmldec.h:
* ext/annodex/gstcmmlenc.c:
* ext/annodex/gstcmmlenc.h:
* ext/annodex/gstcmmlparser.c:
* ext/annodex/gstcmmlparser.h:
* ext/annodex/gstcmmltag.c:
* ext/annodex/gstcmmltag.h:
* ext/annodex/gstcmmlutils.c:
* ext/annodex/gstcmmlutils.h:
* ext/annodex/gstskeldec.c:
* ext/annodex/gstskeldec.h:
* ext/annodex/gstskeltag.c:
* ext/annodex/gstskeltag.h:
* tests/check/Makefile.am:
* tests/check/elements/cmmldec.c:
* tests/check/elements/cmmlenc.c:
* tests/check/elements/skeldec.c:
Add Annodex elements from Alessendro Decina: skeleton and CMML.
Includes tests & docs, oh my! Passes Thomas's -good checklist
entirely. Wow.
2006-02-24 19:07:10 +00:00
Thomas Vander Stichele
29384fcfdf add Makefile.am
Original commit message from CVS:
add Makefile.am
2005-11-30 18:36:02 +00:00
Michal Benes
d52d22ca12 add a unit test for matroskamux fix the bugs that the unit test exposed
Original commit message from CVS:
Patch by: Michal Benes <michal.benes@xeris.cz>

* check/Makefile.am:
* gst/matroska/ebml-write.c: (gst_ebml_write_seek):
* gst/matroska/matroska-mux.c: (gst_matroska_mux_handle_src_event),
(gst_matroska_mux_audio_pad_setcaps), (gst_matroska_mux_start):
add a unit test for matroskamux
fix the bugs that the unit test exposed
2005-11-01 14:36:02 +00:00
Thomas Vander Stichele
006bdcecb2 set up plugin paths properly
Original commit message from CVS:
set up plugin paths properly
2005-09-24 13:34:46 +00:00
Thomas Vander Stichele
787aef18bf remove gst-register
Original commit message from CVS:
remove gst-register
2005-09-16 00:38:50 +00:00
Thomas Vander Stichele
423df73380 Andrewio Patrickoforus Wingonymus - 5 additional tests for your sins
Original commit message from CVS:
Andrewio Patrickoforus Wingonymus - 5 additional tests for your sins

Add a regression test for level and fix a casting bug that made the additional
channels turn out wrong
2005-09-01 20:23:22 +00:00