Commit graph

200 commits

Author SHA1 Message Date
Tim-Philipp Müller
6c323f5b0d multiudpsink: don't do things with side-effects inside g_return_val_if_fail()
Someone might compile this code with -DG_DISABLE_ASSERT some day.
2009-08-02 11:50:43 +01:00
Josep Torra
efcfb89b5c udputils: initialize struct content with 0.
Fixes some random crashes.
2009-07-21 01:12:44 +02:00
Benjamin Gaignard
abd383a2a6 udp: Initialize pointer to NULL
Otherwise we're calling free() with some random
memory address in error cases.

Fixes bug .
2009-07-08 15:19:03 +02:00
LRN
122d40a742 Don't use sendmsg()-dependent code on Windows
Fixes 
2009-06-30 20:38:33 +02:00
Tim-Philipp Müller
0d9dccee4f udp: fix compiler warning about EAI_ADDRFAMILY getting redefined in some cases
Include the header from where we include all the system headers with the
socket stuff before we try to define EAI_ADDRFAMILY ourselves, otherwise
we define it ourselves and then get a compiler warning if a system header
defines it as well without guarding against it being defined already.
2009-06-23 14:10:10 +01:00
Koop Mast
8ecd5f1a06 udp: Fix build on FreeBSD
Fixes bug .
2009-06-19 21:47:29 +02:00
Wim Taymans
8f43709e00 udputils: don't free invalid memory
As spotted by benjiG in IRC.
don't free invalid memory when getaddrinfo failed.
2009-06-19 16:00:51 +02:00
Wim Taymans
a0e3bc5997 udpsrc: add debug line for the socket 2009-06-16 15:06:50 +02:00
Ognyan Tonchev
375523be71 multiudpsink: add support for buffer lists
Add support for BufferList and add a unit test.

Fixes 
2009-06-16 15:04:15 +02:00
Wim Taymans
b3782442ae udpsrc: fix getaddrinfo error reporting
getaddrinfo errors should be reported with gai_strerror instead of errno as
spotted by MikeS.
2009-04-27 18:00:17 +02:00
Jan Schmidt
a097571c0a udp: Fix a simple typo in the previous commit
Use #ifdef instead of #if, to fix the build
2009-04-20 17:26:11 +01:00
Andy Wingo
07dcbacd60 only use struct ip_mreqn if it is detected
* configure.ac: Make an explicit check for struct ip_mreqn.

* gst/udp/gstudpnetutils.c: Use HAVE_IP_MREQN instead of the ad-hoc checks.
2009-04-20 15:54:31 +02:00
Edward Hervey
0cb5b42d54 Remove trivial unused variables detected by CLang static analyzer. 2009-04-18 18:51:28 +02:00
Edward Hervey
4a9e80720a Remove unused variables in _class_init
Detected by LLVM's CLang static analyzer
2009-04-18 18:51:27 +02:00
Stefan Kost
ba2c101963 udp: don't use protocol in debug message after freeing 2009-03-31 11:50:41 +03:00
David Adam
710ff959e3 udp: Fix build if on Solaris
This patch checks for Solaris and uses ip_mreq instead of ip_mreqn if on this
platform.
Fixes .
2009-03-19 13:24:02 +01:00
Wim Taymans
0c4f3d4afb udpsrc: convert _ in properties to -
--
2009-03-13 18:32:47 +01:00
Edgar E. Iglesias
469aced581 udpsrc: Add network interface selection
Add network interface selection when joining multicast groups.
Useful when using the udpsrc on multihomed hosts.
Fixes .

API: GstUDPSrc::multicast-iface
2009-03-13 18:28:59 +01:00
Sebastian Dröge
d189fe7f26 Merge branch 'master' of ssh://git.freedesktop.org/git/gstreamer/gst-plugins-good 2009-02-27 20:28:27 +01:00
LRN
5d9c947f92 udp: Don't set errno to EAFNOSUPPORT unconditionally
Fixes bug .
2009-02-27 20:24:53 +01:00
Jan Smout
474d9d7a9b udp: fix gst_udp_set_loop_ttl() again
Fix the gst_udp_set_loop_ttl() function that was commented out in a
previous commit. See .
2009-02-26 13:19:31 +01:00
Wim Taymans
40bc040064 udpsrc: fix compilation
Fix compilation on systems MSG_ERRQUEUE and IP_RECVERR.
2009-02-25 14:01:26 +01:00
Peter Kjellerstedt
7c56695160 udpsrc: Make sure the sockaddr length used for recvfrom() is big enough.
Previously the sockaddr length used for recvfrom() was calculated as
sizeof (struct sockaddr). However, this is too little to hold an IPv6
address, so the full size of the gst_sockaddr union should be used
instead.
2009-02-25 12:52:37 +01:00
Peter Kjellerstedt
6e5e9edabf udpsrc: Unify the use of union gst_sockaddr. 2009-02-25 12:52:37 +01:00
Jan Schmidt
8588ebd22a udp: Fix strict-aliasing warnings from gcc 4.4.0
Fix strict aliasing warnings by defining a union on the different
sockaddr structs that we need.
2009-02-24 18:19:57 +00:00
Aurelien Grimaud
969622b439 Read ICMP error messages instead of looping
When we are dealing with connected sockets shared between a udpsrc and a udpsink
we might receive ICMP connection refused error messages in udpsrc that will
cause it to go into a bursty loop because the poll returns right away without a
message to read.

Instead of looping, read the error message from the error queue in udpsrc.
Fixes .
2009-02-23 20:49:37 +01:00
Stefan Kost
9cf73bdd8f Update and add documentation for plugins with deps (ext).
Link to properties. Correct titles for examples. Document a few trivial cases. Keep lists in section file and docs/plugins/Makefile.am alphabetically ordered. Fix warnings that gtk-doc points out.
2009-01-28 18:05:09 +02:00
Stefan Kost
a99d3f8769 Update and add documentation for plugins with no deps (gst).
Link to properties. Correct titles for examples. Document a few trivial cases. Keep lists in section file and docs/plugins/Makefile.am alphabetically ordered.
2009-01-28 12:32:59 +02:00
Peter Kjellerstedt
5f642f38bd Correct return value from gst_udp_get_addr() when no known family is found. 2009-01-26 15:49:22 +01:00
Edward Hervey
5ad613d9b9 Switch to using GstStaticPadTemplate.
Original commit message from CVS:
* ext/flac/gstflacdec.c: (gst_flac_dec_base_init),
(gst_flac_dec_init):
* gst/law/alaw-decode.c: (gst_alaw_dec_base_init),
(gst_alaw_dec_init):
* gst/law/alaw-encode.c: (gst_alaw_enc_base_init),
(gst_alaw_enc_init):
* gst/law/alaw.c: (plugin_init):
* gst/law/mulaw-decode.c: (gst_mulawdec_base_init),
(gst_mulawdec_init):
* gst/law/mulaw-encode.c: (gst_mulawenc_base_init),
(gst_mulawenc_init):
* gst/law/mulaw.c: (plugin_init):
Switch to using GstStaticPadTemplate.
* gst/udp/gstudpnetutils.c: (gst_udp_get_addr):
Don't forget to free the addrinfo structure.
* gst/wavparse/gstwavparse.c: (gst_wavparse_reset),
(gst_wavparse_sink_activate):
Don't forget to unref the GstAdapter.
2008-12-13 15:34:01 +00:00
Sebastian Dröge
cfcc44e3ba gst/udp/gstmultiudpsink.c: Provide the parameters that are required for the format string to fix a compiler warning.
Original commit message from CVS:
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_render):
Provide the parameters that are required for the format string
to fix a compiler warning.
2008-11-30 16:24:45 +00:00
Peter Kjellerstedt
3db0832748 gst/udp/gstmultiudpsink.c: Make gst_multiudpsink_render() ignore errors from sendto() instead of breaking streaming. ...
Original commit message from CVS:
Patch by: Peter Kjellerstedt <pkj at axis com>
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_render):
Make gst_multiudpsink_render() ignore errors from sendto() instead of
breaking streaming. Emit a warning instead. Fixes .
2008-11-28 15:10:50 +00:00
Michael Smith
9b372f1bbd gst/udp/: Fix multiudpsink on OSX by passing the specific length of the socket, refactor that into a function shared ...
Original commit message from CVS:
* gst/udp/gstmultiudpsink.c:
* gst/udp/gstudpnetutils.c:
* gst/udp/gstudpnetutils.h:
* gst/udp/gstudpsrc.c:
Fix multiudpsink on OSX by passing the specific length of the socket,
refactor that into a function shared with the same thing in udpsrc.
2008-11-20 22:56:58 +00:00
Stefan Kost
084812bffd Don't install static libs for plugins. Fixes for -good.
Original commit message from CVS:
* ext/aalib/Makefile.am:
* ext/annodex/Makefile.am:
* ext/cairo/Makefile.am:
* ext/dv/Makefile.am:
* ext/esd/Makefile.am:
* ext/flac/Makefile.am:
* ext/gconf/Makefile.am:
* ext/gdk_pixbuf/Makefile.am:
* ext/hal/Makefile.am:
* ext/jpeg/Makefile.am:
* ext/ladspa/Makefile.am:
* ext/libcaca/Makefile.am:
* ext/libmng/Makefile.am:
* ext/libpng/Makefile.am:
* ext/mikmod/Makefile.am:
* ext/pulse/Makefile.am:
* ext/raw1394/Makefile.am:
* ext/shout2/Makefile.am:
* ext/soup/Makefile.am:
* ext/speex/Makefile.am:
* ext/taglib/Makefile.am:
* ext/wavpack/Makefile.am:
* gst/alpha/Makefile.am:
* gst/apetag/Makefile.am:
* gst/audiofx/Makefile.am:
* gst/auparse/Makefile.am:
* gst/autodetect/Makefile.am:
* gst/avi/Makefile.am:
* gst/cutter/Makefile.am:
* gst/debug/Makefile.am:
* gst/effectv/Makefile.am:
* gst/equalizer/Makefile.am:
* gst/flx/Makefile.am:
* gst/goom/Makefile.am:
* gst/goom2k1/Makefile.am:
* gst/icydemux/Makefile.am:
* gst/id3demux/Makefile.am:
* gst/interleave/Makefile.am:
* gst/law/Makefile.am:
* gst/level/Makefile.am:
* gst/matroska/Makefile.am:
* gst/median/Makefile.am:
* gst/monoscope/Makefile.am:
* gst/multifile/Makefile.am:
* gst/multipart/Makefile.am:
* gst/oldcore/Makefile.am:
* gst/qtdemux/Makefile.am:
* gst/replaygain/Makefile.am:
* gst/rtp/Makefile.am:
* gst/rtsp/Makefile.am:
* gst/smpte/Makefile.am:
* gst/spectrum/Makefile.am:
* gst/udp/Makefile.am:
* gst/videobox/Makefile.am:
* gst/videocrop/Makefile.am:
* gst/videofilter/Makefile.am:
* gst/videomixer/Makefile.am:
* gst/wavenc/Makefile.am:
* gst/wavparse/Makefile.am:
* sys/directdraw/Makefile.am:
* sys/directsound/Makefile.am:
* sys/oss/Makefile.am:
* sys/osxaudio/Makefile.am:
* sys/osxvideo/Makefile.am:
* sys/sunaudio/Makefile.am:
* sys/v4l2/Makefile.am:
* sys/waveform/Makefile.am:
* sys/ximage/Makefile.am:
Don't install static libs for plugins. Fixes  for -good.
2008-11-04 12:28:34 +00:00
Sebastian Dröge
d956310612 gst/udp/gstudpnetutils.h: Define the correct WINVER so getaddinfo() can be used when using mingw32. Fixes bug .
Original commit message from CVS:
Patch by: <lrn1986 at gmail dot com>
* gst/udp/gstudpnetutils.h:
Define the correct WINVER so getaddinfo() can be used when using
mingw32. Fixes bug .
2008-10-27 08:40:02 +00:00
Sebastian Dröge
cbec4b2d9d gst/udp/: Fix "argument type mismatch" compiler warnings on Windows.
Original commit message from CVS:
Patch by: <lrn1986 at gmail dot com>
* gst/udp/gstdynudpsink.c: (gst_dynudpsink_render):
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_render):
* gst/udp/gstudpsrc.c: (gst_udpsrc_create):
Fix "argument type mismatch" compiler warnings on Windows.
Fixes bug .
2008-10-27 08:36:43 +00:00
Wim Taymans
712cd620af gst/udp/gstudpsrc.c: Switch on the socket family to get the addrlen size right.
Original commit message from CVS:
* gst/udp/gstudpsrc.c: (gst_udpsrc_class_init),
(gst_udpsrc_set_uri), (gst_udpsrc_start):
Switch on the socket family to get the addrlen size right.
2008-09-25 11:30:35 +00:00
Daniel Franke
edd6239979 gst/udp/gstudpsrc.c: OS X's bind() implementation is picky about its addrlen parameter and fails with EINVAL if it is...
Original commit message from CVS:
Patch by: Daniel Franke <df at dfranke dot us>
* gst/udp/gstudpsrc.c: (gst_udpsrc_create), (gst_udpsrc_start):
OS X's bind() implementation is picky about its addrlen parameter and
fails with EINVAL if it is larger than expected for the socket's address
family. Set the length to the expected length instead. Fixes .
2008-09-25 10:34:39 +00:00
Wim Taymans
34a8fa06f9 gst/udp/gstmultiudpsink.c: Fix setting the qos.
Original commit message from CVS:
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_set_property):
Fix setting the qos.
2008-09-23 17:31:22 +00:00
Peter Kjellerstedt
7431491470 gst/udp/: Avoid leaking internally allocated file descriptors when setting custom file descriptors. Fixes .
Original commit message from CVS:
Patch by: Peter Kjellerstedt <pkj at axis com>
* gst/udp/gstdynudpsink.c: (gst_dynudpsink_init),
(gst_dynudpsink_finalize), (gst_dynudpsink_set_property),
(gst_dynudpsink_init_send), (gst_dynudpsink_close):
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_init),
(gst_multiudpsink_finalize), (gst_multiudpsink_set_property):
* gst/udp/gstudpsrc.c: (gst_udpsrc_finalize),
(gst_udpsrc_set_property):
Avoid leaking internally allocated file descriptors when setting
custom file descriptors. Fixes .
2008-08-20 11:51:38 +00:00
Michael Smith
90fdf92640 gst/goom/: Fix build with MSVC: include glib.h to define inline appropriately, use header guards where needed.
Original commit message from CVS:
* gst/goom/convolve_fx.c:
* gst/goom/filters.c:
* gst/goom/goom_config.h:
* gst/goom/goom_core.c:
* gst/goom/goom_tools.h:
Fix build with MSVC: include glib.h to define inline appropriately,
use header guards where needed.
* gst/udp/gstudpnetutils.c:
* gst/udp/gstudpsrc.c:
Fix build with MSVC: use WSA* constants/functions where appropriate, use
g_snprintf rather than snprintf.
Fixes .
2008-07-23 22:01:20 +00:00
Sebastian Dröge
0aa90f93f0 gst/udp/gstudpnetutils.c: EAI_ADDRFAMILY was obsoleted in BSD at some point. Define it to the old value (1) if it's n...
Original commit message from CVS:
* gst/udp/gstudpnetutils.c:
EAI_ADDRFAMILY was obsoleted in BSD at some point. Define it to the
old value (1) if it's not defined which should not cause any problems
as we're using it internal only anyway.
2008-07-14 13:11:14 +00:00
Tero Saarni
cf3286dac7 gst/udp/gstudpsrc.c: Fix parsing of udp:// URIs containing IPv6 addresses.
Original commit message from CVS:
Patch by: Tero Saarni <tero dot saarni at gmail dot com>
* gst/udp/gstudpsrc.c: (gst_udpsrc_set_uri):
Fix parsing of udp:// URIs containing IPv6 addresses.
Fixes bug .
2008-07-05 19:01:28 +00:00
Sebastian Dröge
8ca7dbfae5 gst/udp/gstudpsrc.c: Call getsockname() after the call to bind() to get updated values for the port, etc. This fixes ...
Original commit message from CVS:
* gst/udp/gstudpsrc.c: (gst_udpsrc_start):
Call getsockname() after the call to bind() to get updated values
for the port, etc. This fixes the usage of udpsrc on anonymous
binding and it's usage by rtspsrc. Fixes bugs , .
Thanks to Aurelien Grimaud for pointing out the obvious fix.
2008-06-25 08:12:18 +00:00
Thomas Vander Stichele
b3ac90d9e8 gst/: Added debug.
Original commit message from CVS:
* gst/rtp/gstrtptheorapay.c:
* gst/udp/gstmultiudpsink.c:
Added debug.
2008-06-20 16:24:11 +00:00
Wim Taymans
ccddfc5da7 gst/udp/gstudpsrc.*: Add property to control automatic join/leave of multicast groups.
Original commit message from CVS:
* gst/udp/gstudpsrc.c: (gst_udpsrc_class_init), (gst_udpsrc_init),
(gst_udpsrc_create), (gst_udpsrc_set_property),
(gst_udpsrc_get_property), (gst_udpsrc_start), (gst_udpsrc_stop):
* gst/udp/gstudpsrc.h:
Add property to control automatic join/leave of multicast groups.
Add G_LIKELY.
Remove setting caps on buffers explicitly, basesrc does that for us now.
Improve debug info.
Convert some non-fatal error into warnings.
Use g_ntohs for better portability.
Leave multicast groups when stopping.
When using external sockets, use getsockname() on them to fill up the
addr structure before calling methods that use the structure.
Should all fix .
API: GstUDPSrc::auto-multicast property
2008-06-13 11:54:05 +00:00
Wim Taymans
5b751d0290 gst/udp/gstudpnetutils.c: Use g_ntohl for better portability.
Original commit message from CVS:
* gst/udp/gstudpnetutils.c: (gst_udp_is_multicast):
Use g_ntohl for better portability.
2008-06-13 11:47:28 +00:00
Wim Taymans
ab58eeec2e gst/udp/gstmultiudpsink.c: Fix a typo and do some small cleanups.
Original commit message from CVS:
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_init_send),
(gst_multiudpsink_remove):
Fix a typo and do some small cleanups.
2008-06-13 11:45:54 +00:00
Tim-Philipp Müller
ec64145246 gst/udp/Makefile.am: Add -D_GNU_SOURCE to CFLAGS so we get things like EAI_ADDRFAMILY when including netdb.h when bui...
Original commit message from CVS:
* gst/udp/Makefile.am:
Add -D_GNU_SOURCE to CFLAGS so we get things like EAI_ADDRFAMILY
when including netdb.h when building against glibc >= 2.8.
2008-05-22 14:49:08 +00:00
Julien Moutte
a1a2879083 gst/smpte/gstsmptealpha.c: Fix debug statement arguments.
Original commit message from CVS:
2008-05-22  Julien Moutte  <julien@fluendo.com>

* gst/smpte/gstsmptealpha.c: (gst_smpte_alpha_setcaps): Fix
debug statement arguments.
* gst/udp/gstmultiudpsink.c: (gst_multiudpsink_setup_qos_dscp):
* gst/udp/gstudpnetutils.c: (gst_udp_join_group),
(gst_udp_leave_group): Fix IP and IPV6 options to make it work
on more platforms.
2008-05-22 11:19:03 +00:00