Guillaume Desmottes
ca7f0912c4
validate: fix leak in overrides test
...
The runner was never released.
https://bugzilla.gnome.org/show_bug.cgi?id=778279
2017-02-08 17:00:08 -03:00
Guillaume Desmottes
2b33489a2c
validate: fix leaks in pad monitor test
...
- monitors were never released
- reports were leaked
- GstValidateMediaDescriptor was leaked
- caps were leaked: gst_check_setup_events_with_stream_id() and
gst_event_new_caps() don't consume the caps
- srcpad were never released
https://bugzilla.gnome.org/show_bug.cgi?id=778279
2017-02-08 17:00:08 -03:00
Guillaume Desmottes
765cf8679f
validate: meson: fix --validate-tools-path argument
...
The path passed to --validate-tools-path was wrong when building using
gst-build, preventing the launcher to find the validate tools.
https://bugzilla.gnome.org/show_bug.cgi?id=777982
Differential Revision: https://phabricator.freedesktop.org/D1634
2017-02-02 11:01:11 -03:00
Guillaume Desmottes
4881013d66
validate: tests: call gst_validate_deinit()
...
gst_validate_deinit() needs to be called when the test is done to remove
false positives when using the leaks tracer.
https://bugzilla.gnome.org/show_bug.cgi?id=777977
Differential Revision: https://phabricator.freedesktop.org/D1630
2017-01-31 08:15:39 -03:00
Thibault Saunier
79faf44d32
validate: Properly handle proxy pads generating detailed info about NNEs
...
In cases where we had a two consecutive bins with proxy pads, we could
segfault because we were dereferencing a NULL pointer to pad.
2016-11-30 13:58:56 -03:00
Thibault Saunier
ab614e63ae
meson: Modernize the way we set test env variables
...
Removing the now useless getplugindirs script
2016-11-30 13:58:56 -03:00
Nirbheek Chauhan
388f621bd9
Revert "meson: move gstreamer-check-1.0 dependency to validate/tests/check"
...
This reverts commit e8e51bdad4
.
Does not actually work. See:
https://bugzilla.gnome.org/show_bug.cgi?id=773114#c31
2016-10-25 11:48:12 +05:30
Scott D Phillips
e8e51bdad4
meson: move gstreamer-check-1.0 dependency to validate/tests/check
...
https://bugzilla.gnome.org/show_bug.cgi?id=773114
2016-10-21 06:07:08 -03:00
Thibault Saunier
b84d4490f7
meson: Setup pre commit hook and fix getpluginsdir for standalone case
2016-09-30 13:31:16 -03:00
Thibault Saunier
64560aea32
validate: Add support for setting a report level for an issue type
...
Until now we could set report levels to the monitor, this adds support
for setting report level for the issue types too.
2016-09-26 13:36:48 -03:00
Thibault Saunier
9c9fe14293
meson:validate:test: Properly set paths to run launcher based tests
...
Adding a --validate-tools-path option to the launcher, allowing
to pass it from meson.
2016-09-09 12:24:54 -03:00
Thibault Saunier
5dee7c8f47
validate: tests: Add launcher based GstValidate tests
...
First checking the new not negotiated error reporting code.
2016-09-08 13:10:29 -03:00
Thibault Saunier
9089df6d11
validate:meson: Add tests
2016-09-08 10:41:21 -03:00
Guillaume Desmottes
8708215ce5
validate: turn GstValidateReport to a mini object
...
It handles refcounting for us and will enable automatic leak checks when
using the 'leaks' tracer.
Differential Revision: https://phabricator.freedesktop.org/D1233
2016-08-01 10:45:39 -04:00
Thibault Saunier
1de54fcd09
validate: Fix testsuite after additional check for buffer DISCONT flag
2016-07-29 14:34:17 -04:00
Vineeth T M
5d503c9271
validate: use new gst_element_class_add_static_pad_template()
...
https://bugzilla.gnome.org/show_bug.cgi?id=763197
2016-03-24 14:52:07 +02:00
Thibault Saunier
3657e7867f
validate: Namespace all our structures and objects
...
Making GI a bit happier.
Those are not stable API anyway...
Differential Revision: https://phabricator.freedesktop.org/D704
2016-02-23 11:46:58 +01:00
Thibault Saunier
8c760b0a0e
validate: Turn GstValidateRunner into a GstTracer
...
This way we do not need the LD_PRELOAD hack anymore
Add a new libgstvalidateplugin GStreamer plugin, making sure it shares
the exact same code as the library (exposing only the wanted symbols).
Fix the way we set where to install GstValidate plugins
Try to keep backward compatibility even if tracers should never be instantiated
after an GstElement has been instantiated.
Differential Revision: https://phabricator.freedesktop.org/D459
2016-02-23 11:46:32 +01:00
Thibault Saunier
633fddbb66
validate: Fix testsuite
...
Use fake elements instead of real ones in our tests so that
we control exactly the number of issues generated.
Until now we were trying to hide extra issues with a probe dropping
events and buffers but since 2dfa548f36
"pad: Append hooks instead of prepending to call them in the order they were added"
in core, hidding will not work.
2016-01-21 11:21:01 +01:00
Olivier Crête
5ce8ab213e
pad-monitor: Check that an ERROR GstMessage has been posted on GST_FLOW_ERROR
...
Summary:
Before returning GST_FLOW_ERROR, an element must post an ERROR GstMessage,
enforce that.
Reviewers: thiblahute, Mathieu_Du
Differential Revision: http://phabricator.freedesktop.org/D201
2015-06-03 11:43:12 -04:00
Guillaume Desmottes
92fa2b5681
validate: add gst_validate_deinit()
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D159
2015-05-11 21:55:24 +02:00
Mathieu Duponchelle
ac1c1aec7c
validate: Test buffer outside of received range.
...
Summary: As part of the preparation for a port to tracer.
Test Plan: This is a test, we won't test tests
Reviewers: tsaunier
Differential Revision: http://internal.opencreed.com:8888/D19
2015-02-19 12:19:46 +01:00
Mathieu Duponchelle
89048ad862
validate: tests more issues with caps.
...
https://bugzilla.gnome.org/show_bug.cgi?id=743387
2015-01-26 18:08:47 +01:00
Mathieu Duponchelle
bf2c949aee
validate: Add a test case for caps missing field.
...
+ Make the fake decoder have video/x-raw caps.
https://bugzilla.gnome.org/show_bug.cgi?id=743387
2015-01-26 18:08:47 +01:00
Mathieu Duponchelle
887349167b
validate: prepare tests for port to tracers backend.
...
https://bugzilla.gnome.org/show_bug.cgi?id=743387
2015-01-26 18:08:47 +01:00
Thibault Saunier
0c48665458
validate: tests: disable g_log handler
...
It messes up our own failures counter
And pass test-utils into gst-indent
2014-12-09 10:11:02 +01:00
Thiago Santos
6df63915c2
tests: padmonitor: disable glog handling
...
It messes up our own failures counter
2014-12-08 18:53:55 -03:00
Thibault Saunier
7f8c0c2751
validate: Do not check if first buffer running time is 0
...
It can perfectly not be 0, so it makes no sense to check that.
https://bugzilla.gnome.org/show_bug.cgi?id=739965
2014-11-19 17:59:26 +01:00
Mathieu Duponchelle
30aef5ba84
validate: rename GstValidateReportingLevel.
...
Removes the confusion with GstValidateReportLevel.
Modeled on GstDebugGraphDetails.
2014-10-21 23:41:04 +02:00
Thibault Saunier
6d0930bb36
validate: Verify that elements always send a segment before pushing EOS
...
EOS is some kind of data flow and thus a segment event should always be
pushed before the EOS is sent
2014-10-21 20:40:27 +02:00
Thibault Saunier
23d7df3788
validate: Properly check that the seqnum of the EOS is always properly set
...
In the pipeline, an EOS should always have the same seqnum of the
previous SEGMENT event that was received. If the segment is the result
of a seek, it should always be the same as the seek seqnum too.
+ (Mathieu Duponchelle): fix reporting and concatenation tests.
2014-10-21 20:37:23 +02:00
Thibault Saunier
34a9c36edc
validate: Add support for text based override files
...
Allowing user to easily determine the severity of issue
types in a config file
https://bugzilla.gnome.org/show_bug.cgi?id=737852
2014-10-21 20:23:32 +02:00
Thibault Saunier
8ec61ddac2
validate: report: Simplify the issue ID registering using GQuarks
...
+ Remove unused issue types
https://bugzilla.gnome.org/show_bug.cgi?id=737790
2014-10-21 20:21:42 +02:00
Thibault Saunier
bb93dbb9fb
validate: Check all buffers when we have the info from MediaDescriptor
...
We now check that each buffer is the expected one for each buffer that
come into the decoder.
+ Fix some minor leaks in test-utils
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:21:36 +02:00
Mathieu Duponchelle
c542d9c6bc
validate-report / reporter: rework the way we repeat issues.
...
+ runner: update reports count algorithm.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
0b1d00df25
validate-pad-monitor / runner: Check per-object reporting levels.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
030e7e8ba8
validate-runner: implement synthetic report.
...
+ Fix criticals logic in validate_runner_printf
+ Update padmonitor tests
+ Split validate_report_printf function.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1993229993
validate-runner: Implement REPORT_NONE for global reporting.
...
Yeah that was tough. Helpful already though, for example:
GST_VALIDATE_REPORT_LEVEL=none,x:all gst-validate src name=x ! sink
will only report issues reported by the source.
+ Add test.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
0a1cdb2164
tests: Check monitors correctly determine their reporting level.
...
+ [API] gst_validate_reporter_get_reporting_level
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
de554ba417
tests: Test reports refcounts.
...
+ Set the element monitor on the element as qdata.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1d7f15598f
validate-runner: Add code to parse GST_VALIDATE_REPORT_LEVEL.
...
+ Extend the tests.
+ [API] gst_validate_runner_get_default_reporting_level
+ [API] gst_validate_runner_get_reporting_level_for_name
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6ed125bfb1
validate-runner: report-level initial work.
...
+ Defines reporting levels and document them.
+ Add API to get the default level.
+ fix indentation.
+ fix some typos.
+ Add the beginning of a reporting test.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
6e08079f8b
validate-pad-monitor: concatenate issues.
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=735665
The process is to check for a similar report in intercept_report on
the pads of the upstream element, set that report as the master report
of the intercepted report, and return REPORTER_KEEP instead
of REPORTER_REPORT.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
d747e1cd05
test-utils: add a create_and_monitor element function.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
1fcaf8918f
tests/padmonitor: Correcly strdup the result of get_metadata.
...
The const pointer was becoming invalid after the first call to add_metadata,
and we ended up setting corrupted data on the second call.
2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
8cfffb4a3a
validate-runner: switch to using a GList for the reports.
...
+ Return a copy of that list in get_reports.
+ update tests.
2014-09-30 11:42:42 +02:00
Mathieu Duponchelle
1f1cf83af8
validate-runner: Hide implementation.
2014-09-30 11:42:42 +02:00
Thibault Saunier
7e85c9b0b5
validate: Start a testsuite
...
Currently implemented tests are:
* Settup and cleanup on monitor is done properly
* Some tests in the PadMonitor are done properly, namely:
- Buffer before segment
- Buffer outside segment
- First buffer running time is always 0
- The Demuxer flow aggregation is properly checked
https://bugzilla.gnome.org/show_bug.cgi?id=736379
2014-09-12 09:57:05 +02:00