Commit graph

2538 commits

Author SHA1 Message Date
Edward Hervey
c185a8db9d goom: ff and iff are only used in a '#ifdef DRAW_MOTIF' block. 2009-04-18 18:51:28 +02:00
Edward Hervey
5c52506d07 wavparse: Remove dead assignment.
res isn't read after this.
2009-04-18 18:51:28 +02:00
Edward Hervey
44256a78f8 wavparse: Remove dead assignments, move variable to where it's needed.
The header_read_error label will return GST_FLOW_ERROR
2009-04-18 18:51:28 +02:00
Edward Hervey
a12d9a80f2 rtpvrawdepay: Remove dead assignment.
The value of 'str' will never be used in these cases.
2009-04-18 18:51:28 +02:00
Edward Hervey
b28c6ca0fb matroskademux: Remove useless variable.
iret was never read outside of that loop, and is always being exited if
iret was != GST_FLOW_OK anyway.
2009-04-18 18:51:28 +02:00
Edward Hervey
1086c63827 avidemux: Move 'res' to where it's actually being used.
res was never used outside of that block except for a dead assignment.
2009-04-18 18:51:28 +02:00
Edward Hervey
a299e86cfc audiofx: Remove unused variable.
rz is never used in these methods.
2009-04-18 18:51:28 +02:00
Edward Hervey
0cb5b42d54 Remove trivial unused variables detected by CLang static analyzer. 2009-04-18 18:51:28 +02:00
Edward Hervey
cdb03bdc2b Remove blank {set|get}_property/change_state/finalize methods. 2009-04-18 18:51:27 +02:00
Edward Hervey
4a9e80720a Remove unused variables in _class_init
Detected by LLVM's CLang static analyzer
2009-04-18 18:51:27 +02:00
Josep Torra
dfb375daa1 rtspsrc: mark discont on the streams as was said the debug line
After a seek mark all streams with discont as it was said in the debug line.
Fixes that buffers after a seek are generated without a valid timestamp.
2009-04-18 14:32:40 +02:00
Josep Torra
ec2d6053a0 rtspsrc: map GST_RTSP_EEOF to EOS on server requests
Permit properly handle the EOS condition when server report it in a request.
2009-04-18 08:50:46 +02:00
Edward Hervey
f9d7640bc9 rtptheoradepay: Fix build on macosx.
Use G_GSIZE_FORMAT instead of u.
2009-04-18 08:39:57 +02:00
James Andrewartha
ac48c2d211 rtph263pay: fix compilation on big-endian
Some semicolons were missing from the big-endian structs in gstrtph263pay.h.
A GST_DEBUG call was missing a format specifier.

Fixes #579069
2009-04-15 19:26:22 +02:00
Marco Ballesio
94d5d24cf0 qtdemux: implement 3GPP (TS 26.244 V8.0.0) Asset metadata handling, Fixes #132193
Implements 3gpp iso metadata tags which are different from mov udta atoms.
2009-04-15 20:14:19 +03:00
Peter Kjellerstedt
af7f3a50dd debugutils: Use G_BEGIN_DECLS/G_END_DECLS.
Use G_BEGIN_DECLS/G_END_DECLS to avoid gst-indent messing up the
indentation due to extern "C" { }.
2009-04-15 15:51:24 +02:00
Stefan Kost
7be792fa13 debug: rename debug to debugutils to avoid clash with --disable-debug. Fixes #562168 2009-04-15 16:13:34 +03:00
Stefan Kost
99fcc86ee4 debug: indent before renaming 2009-04-15 16:13:34 +03:00
Wim Taymans
787124dad6 g726depay: add property for aal2 force 2009-04-15 14:07:57 +02:00
Wim Taymans
0802ba8730 g726depay: implement RFC3551 packing
We implemented the AAL2 packing, add the encoding-name for those to the caps and
a property to force AAL2 decoding (always TRUE for now).
Implement RFC3551 unpacking for regular G726.
See #567140.
2009-04-15 13:56:17 +02:00
Wim Taymans
c34d5aa016 rtph263pay: fix build 2009-04-15 00:22:43 +02:00
Youness Alaoui
17d9cb3319 h263pay: various fixes
Re-enable mode A support and a property to control it.
Fix memory leak of GstRtpH263PayBoundry objects.
Fix marker.
Fixes #509311
2009-04-14 18:52:48 +02:00
Janin Kolenc
de2c489526 h263pay: Fix the payloader
Fix the H263 payloader to be more RFC 2190 compliant.
See #509311
2009-04-14 18:44:51 +02:00
Wim Taymans
cb344828a4 avidemux: don't push EOS in streaming mode
In streaming mode, avidemux is not supposed to send an EOS event downstream but
it is supposed to return UNEXPECTED from the chain function instead so that
upstream can do the right EOS handling.
2009-04-14 17:27:05 +02:00
Sebastian Dröge
108774781d Add initial support for muxing/demuxing Speex audio
Note: This is not in the Matroska spec yet
Fixes bug #578310.
2009-04-13 14:03:03 +02:00
LRN
3e7aede3ea avidemux: add convert query, fix duration query
Fix the duration query so that it also works with formats other than
TIME, such as DEFAULT to get the number of frames.

Add a convert function.

Fixes #578052.
2009-04-10 00:26:44 +02:00
Stefan Kost
1095e624ec wavparse: don't leak pad-template
gst_element_class_add_pad_template() does not take ownership.
2009-04-07 22:36:39 +03:00
Zaheer Merali
988a4c6532 Fix grammar. 2009-04-03 09:57:15 +01:00
Wim Taymans
b6bf3ba7d3 rtspsrc: allow http:// on the proxy setting
Allow and ignore http:// at the start of the proxy setting, like
souphttpsrc.
Fixes #573173
2009-04-02 22:41:01 +02:00
Wim Taymans
40f6ed8875 rtspsrc: don't leak the udpsrc pad
Fix memory leak in rtspsrc because we didn't unref the udpsrc pad.
See #577318
2009-04-02 21:08:48 +02:00
Michael Smith
85d7fb0599 rtptheorapay: fix length encoding in packed headers.
As for vorbis payloader; this by inspection had the same bug.
2009-04-01 17:31:18 -07:00
Michael Smith
5f9d9e2243 rtpvorbispay: in packed headers, properly flag multibyte lengths.
In the sequence of header lengths, for headers >127 bytes, we use
multiple bytes to encode the length. Bytes other than the last must have
the top (flag) bit set.
2009-04-01 17:23:33 -07:00
Tim-Philipp Müller
cb15d09c4a rtspsrc: don't emit ugly warnings with older rtpjitterbuffer versions
The on-npt-stop signals was added only recently to rtpjitterbuffer in
-bad, so check if the signal exists before g_signal_connect()ing to
it, to avoid warnings.
2009-04-01 12:29:33 +01:00
Wim Taymans
b037369d5b rtspsrc: add proxy support 2009-03-31 19:08:37 +02:00
Stefan Kost
605ded5292 matroska: don't leak serialized values when writing tags 2009-03-31 17:16:04 +03:00
Stefan Kost
5ac6b84475 matroska: don't alter passed data and especialy don't leak.
If we need different size, Make a copy, work with that and free it.
2009-03-31 17:06:50 +03:00
Stefan Kost
fa8e2d9bfe goom: the structure is not fully initialized, but the copied.
Set to fully to 0 to avoid creep of uninitialized values.
2009-03-31 16:42:15 +03:00
Stefan Kost
ef7bcf7bd1 matroska: init endianess as such and signedness as boolean. 2009-03-31 16:25:58 +03:00
Stefan Kost
0889ac1092 qtdemux: don't use ininitialized var in debug log statement
Also make the log statement useful by printing the human readable format name.
2009-03-31 16:22:42 +03:00
Stefan Kost
f4f6d9799c qtdemux: don't leak atom data in case of a wrong fourcc 2009-03-31 12:01:21 +03:00
Stefan Kost
9b8f1cbaa2 matroska: don't leak read data in demuxer 2009-03-31 11:57:36 +03:00
Stefan Kost
ba2c101963 udp: don't use protocol in debug message after freeing 2009-03-31 11:50:41 +03:00
Tim-Philipp Müller
6e5f789fa0 rtpmp4adepay: output should be framed already 2009-03-30 14:13:29 +01:00
Wim Taymans
fd18185d44 rtspsrc: link to the on_npt_stop signal to EOS
Connect to the on_npt_stop signal of the session manager to schedule the EOS
actions.
2009-03-27 17:49:15 +01:00
Mark Nauwelaerts
3360f449c0 qtdemux: some stream synchronization to aid seeking in unbalanced clips
Some clips (trailers) may have (length-wise) unbalanced streams,
which stalls the pipeline if seeking into that region.
Additional stream synchronization can handle this, as well as
sparse (subtitle) streams (at some later time ?)
2009-03-26 14:39:06 +01:00
Mark Nauwelaerts
a5502c9b37 qtdemux: additional safety and sanity checks (push based mode) 2009-03-26 14:38:02 +01:00
Wim Taymans
07329bc083 videomixer: some more indent fixes 2009-03-26 10:18:31 +01:00
Wim Taymans
62d118678a videomixer: fix gst-indent screwup 2009-03-26 10:17:48 +01:00
Tim-Philipp Müller
37634c2afb rtspsrc: better error message when the RTSP extension for Real streams is missing
Try to post a decent error message when it looks like we're failing
because the Real RTSP extension plugin is missing. Also add i18n
bits for rtspsrc so our error messages get translated.
2009-03-25 17:54:35 +00:00
Tim-Philipp Müller
2199592039 i18n: make sure gettext gives us UTF-8 at all times 2009-03-25 15:42:15 +00:00
Tim-Philipp Müller
4bcd50ccbd rtpmp4apay,rtpmp4depay: fix buffer leaks in AAC payloader and depayloader 2009-03-25 10:36:49 +00:00
Tim-Philipp Müller
297bbfbebc rtpmp4apay: warn if input is unframed 2009-03-25 10:36:49 +00:00
Mark Nauwelaerts
cfb39dbb1b qtdemux: handle FLUSH_STOP event
Clean up some state (most notably pad flow returns) to resume
proper streaming following flushing seek.
2009-03-24 15:48:26 +01:00
Alessandro Decina
b0c5c7f19b avidemux: don't post an error if EOS can't be pushed downstream.
This aligns avidemux with other demuxers and fixes a bug using avidemux
with a recent gnonlin.
2009-03-24 12:42:13 +01:00
Mark Nauwelaerts
cc1a869a2c qtdemux: support seeking in push based mode 2009-03-20 17:59:38 +01:00
Mark Nauwelaerts
d5120cda4b qtdemux: align push based behaviour more with pull based
Cater for DELTA_UNIT flag on buffers, keep track of current
position, remove and warn about edit lists if any (as those
as are de facto discarded anyway), add some debug statements
and indent fixes.
2009-03-20 17:59:35 +01:00
Mark Nauwelaerts
21fc435c71 qtdemux: fix mem leaks and prevent excessive buffering in push based mode 2009-03-20 17:59:32 +01:00
Tim-Philipp Müller
fa3d457882 rtpmp4adepay: don't append an extra 0 byte to the codec data
The audioMuxVersion structure is packed in such a way that the codec
data does not start byte-aligned, which means there's an extra bit of
padding at the end. We don't want that bit in the codec data, since
some decoders seem get confused when they're fed with an extra codec
data byte (also it's just not right of course).
2009-03-20 01:06:14 +00:00
Wim Taymans
f18dabdd57 rtph264depay: fix base64 decoding
We can't pass -1 to _decode_step, that functions returns 0 right away instead of
decoding up to the string end.
2009-03-19 13:25:57 +01:00
David Adam
710ff959e3 udp: Fix build if on Solaris
This patch checks for Solaris and uses ip_mreq instead of ip_mreqn if on this
platform.
Fixes #575937.
2009-03-19 13:24:02 +01:00
Sebastian Dröge
77e2637590 rtp: Use GLib functions for encoding/decoding base64 2009-03-18 14:50:17 +01:00
Wim Taymans
8cf0e9ff87 rtspsrc: add some debug for the timestamps
When timestamping in TCP mode, log the first timestamp we put on the buffers.
2009-03-16 19:17:24 +01:00
Wim Taymans
0c4f3d4afb udpsrc: convert _ in properties to -
--
2009-03-13 18:32:47 +01:00
Edgar E. Iglesias
469aced581 udpsrc: Add network interface selection
Add network interface selection when joining multicast groups.
Useful when using the udpsrc on multihomed hosts.
Fixes #575234.

API: GstUDPSrc::multicast-iface
2009-03-13 18:28:59 +01:00
Wim Taymans
7782c9f890 rtspsrc: don't send PAUSE when not connected
don't send a PAUSE request when we are no longer connected.
2009-03-12 20:39:35 +01:00
Wim Taymans
515d623dcc rtspsrc: fix timeout check
---
2009-03-11 18:00:02 +01:00
Stefan Kost
a58498929c makefile: fix typo in no-static plugins rule 2009-03-10 21:35:16 +02:00
Edward Hervey
72a9b89b50 gstrtpvorbisdepay: Fix build on macosx 2009-03-10 10:16:27 +01:00
Wim Taymans
06efeff5d9 vorbisdepay: fix some leaks
And leak the codebooks.
Use glib base64 decoders.
Use subbuffers to avoid a memcpy of the headers.
2009-03-09 18:07:20 +01:00
Wim Taymans
af7aaef37a qtdemux: sanitize tag names
Sanitize the tag names before turning them into a structure name. We can only
add alphanumeric values as the structure name.
2009-03-09 15:20:05 +01:00
Wim Taymans
636cd65ebf rtspsrc: fix range parsing
Fix parsing of the range headers.
2009-03-05 14:09:03 +01:00
Olivier Crête
e4b8c514cc Move siren rtp pay/depay from gst-plugins-farsight 2009-03-04 13:24:34 -05:00
Wim Taymans
5a5ba49c9b rtspsrc: fix memory leak in close
Close the connection even when we fail to send the teardown message.
Use the connection url (which is a copy of the src url).
2009-03-04 16:31:57 +01:00
Wim Taymans
dfb2d1b7d7 rtspsrc: fix do-rtcp property description
---
2009-03-04 12:29:50 +01:00
Wim Taymans
8b6c8b934a rtpmp4vpay: Add support for more formats
Hack around short header mpeg4 video files and put the short header as the
config string.
Fixes #572551.
2009-03-02 17:18:55 +01:00
Wim Taymans
81f25317e6 rtspsrc: add support for http tunneling
Add support for http tunneling and a new rtsph:// uri for it.
See #573173.
2009-03-02 16:09:23 +01:00
Tim-Philipp Müller
7087da96dc alawdec, mulawdec: demote some debug messages from ERROR to WARNING or DEBUG
Non-ok flow returns may happen for a variety of perfectly legitimate and expected reasons
(temporarily not linked, seeking, pipeline shutdown), so we really shouldn't spew ERROR
debug messages to stderr in those cases. Fixes #570781. (Seems like someone already took
care of some of these.)
2009-02-28 19:26:35 +00:00
René Stadler
157531d91e rgvolume: Improve log message for peak values >1.0 by clamping explicitly. 2009-02-28 15:26:00 +02:00
Sebastian Dröge
d189fe7f26 Merge branch 'master' of ssh://git.freedesktop.org/git/gstreamer/gst-plugins-good 2009-02-27 20:28:27 +01:00
LRN
5d9c947f92 udp: Don't set errno to EAFNOSUPPORT unconditionally
Fixes bug #573342.
2009-02-27 20:24:53 +01:00
Michael Smith
b50452fc37 rgvolume: ignore out-of-range peak values
If the peak value is > 1 (and thus nonsensical) ignore it. Prevents
rgvolume reducing volume to effectively silent on files with bogus peak
values.
2009-02-27 11:18:40 -08:00
Mark Nauwelaerts
3310a540e3 wavparse: Fix SEEK event handling in push mode, and SEEKABLY query handling
Standard pull mode loop based SEEK handling fails in push mode,
so convert the SEEK event appropriately and dispatch to upstream.
Also cater for NEWSEGMENT event handling, and properly inform
downstream and application of SEEKABLE capabilities, depending
on scheduling mode and upstream.
2009-02-27 14:52:31 +01:00
Edward Hervey
1846e0af0f matroskademux: Remove gst_util_dump_mem() calls. 2009-02-27 11:04:08 +01:00
Julien Moutte
ec5229d75f avidemux: fix SEEK event handling in push mode
When in push mode we should not try to handle the SEEK event as there's
no code to handle it properly. Propagate upstream.
2009-02-26 19:10:41 +01:00
Patrick Radizi
51200cad41 rtspsrc: add the .h file change too
Add the .h file change for the new property.
2009-02-26 19:05:06 +01:00
Patrick Radizi
c7dd6a4902 rtspsrc: add property to disable RTCP
Some old servers don't like us doing RTCP and thus we need a property to disable
it. See #573173.
2009-02-26 19:03:52 +01:00
Jan Smout
474d9d7a9b udp: fix gst_udp_set_loop_ttl() again
Fix the gst_udp_set_loop_ttl() function that was commented out in a
previous commit. See #573115.
2009-02-26 13:19:31 +01:00
Wim Taymans
af2e8f8470 rtpvrawdepay: fail on interlaced video
Fail on interlaced video until we support it.
2009-02-26 13:06:17 +01:00
Wim Taymans
62d5787bcd rtpvrawpay: fail on interlaced video
Detect and fail when trying to payload interlaced video.
2009-02-26 13:00:58 +01:00
Wim Taymans
40bc040064 udpsrc: fix compilation
Fix compilation on systems MSG_ERRQUEUE and IP_RECVERR.
2009-02-25 14:01:26 +01:00
Peter Kjellerstedt
7c56695160 udpsrc: Make sure the sockaddr length used for recvfrom() is big enough.
Previously the sockaddr length used for recvfrom() was calculated as
sizeof (struct sockaddr). However, this is too little to hold an IPv6
address, so the full size of the gst_sockaddr union should be used
instead.
2009-02-25 12:52:37 +01:00
Peter Kjellerstedt
6e5e9edabf udpsrc: Unify the use of union gst_sockaddr. 2009-02-25 12:52:37 +01:00
Wim Taymans
1fec709792 avidemux: avoid crashing on subtitles
Avoid a crash in avi with subtitles by only dereferencing the video description
when we actually are dealing with video in the _invert function.
2009-02-25 12:05:22 +01:00
Jan Schmidt
8588ebd22a udp: Fix strict-aliasing warnings from gcc 4.4.0
Fix strict aliasing warnings by defining a union on the different
sockaddr structs that we need.
2009-02-24 18:19:57 +00:00
Tim-Philipp Müller
b4115aa83e rtp: Fix compiler warning in h264 payloader
Fix an undefined behaviour warning from gcc 4.4.0

Patch By: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Fixes: #570995
Signed-Off-By: Jan Schmidt <jan.schmidt@sun.com>
2009-02-24 17:59:29 +00:00
Edward Hervey
6512b3eb81 qtdemux: Also use "(c)inf" to fill the comment tag 2009-02-24 14:41:26 +01:00
Mark Nauwelaerts
21cb00aa9c rtspsrc: perform UDP SETUP according to MS RTSP spec
MS RTSP spec states that the UDP port pair used in subsequent SETUP
requests for various streams must be identical (since there will actually
be only 1 stream of muxed asf packets).  Following traditional specs and
using different port pairs in the SETUPs for separate streams will result
in all but the first one failing and only one stream being streamed.

So, in appropriate circumstances, retry UDP SETUP using previously used
port pair.  Fixes #552650.
2009-02-23 22:47:55 +01:00
Aurelien Grimaud
969622b439 Read ICMP error messages instead of looping
When we are dealing with connected sockets shared between a udpsrc and a udpsink
we might receive ICMP connection refused error messages in udpsrc that will
cause it to go into a bursty loop because the poll returns right away without a
message to read.

Instead of looping, read the error message from the error queue in udpsrc.
Fixes #567857.
2009-02-23 20:49:37 +01:00
Wai-Ming Ho
aeee52be05 Always add PPS to the sprop-parameters-set
Rework the parsing code that under certain circumstances dropped the PPS from
the sprop-parameters-set.
Fixes #572854.
2009-02-23 15:43:51 +01:00
Arnout Vandecappelle
b9adb5846b Don't do crazy things with 0/1 framerates
We use 0/1 framerates to mark variable framerates and matroskamux should not try
to calculate a frame duration for it.
Fixes #571294.
2009-02-23 12:14:23 +01:00