mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2025-01-02 13:38:48 +00:00
Code Issues 1 Projects Releases Wiki Activity
2459 commits 44 branches 1510 tags 395 MiB
Commit graph

50 commits

Author SHA1 Message Date
Thibault Saunier
d86fa2c44a validate: Enhance error reporting for errors in struct files 
Get a sense of files and line numbers in the parsed GstStructure
and take that information when reporting GstValidateAction errors
by letting the user know where the action comes from in the messages.

And accept non-literal string in printing formats.
 2020-02-25 16:22:10 -03:00
Thibault Saunier
1a6f404c5d validate: Add a flags to issues 
Currently those allow registering issue that:
- Won't print backtrace as it is sometimes useless info
- Will repeat the details even in smart mode
 2020-02-25 11:28:35 -03:00
Thibault Saunier
040b71a3d9 doc: Minor fixes 2019-05-13 11:37:38 -04:00
Thibault Saunier
e50d41420e validate: Handle G_LOG_ERROR in our glog handler 2019-02-01 23:46:21 +00:00
Thibault Saunier
ba9b2c5ec5 validate: Keep trying to print stack traces when our log hanlder is removed 
There are cases where a crash happens after the program ends
 2019-02-01 00:08:45 -03:00
Thibault Saunier
44260d70bd validate: Plug leak of copy of a va_list 
CID 1415490
 2017-07-18 10:12:07 -04:00
Reynaldo H. Verdejo Pinochet
a18cef9c3f validate: reporter: add doc entry for gst_validate_report()'s varargs 
Avoids GTK-Doc parser warnings
 2017-06-07 00:04:34 -07:00
Thibault Saunier
9d3b760cf3 validate: Make Reporter.runner a MT safe weak reference 
It can be used in any thread!
 2017-06-01 16:57:50 -04:00
Reynaldo H. Verdejo Pinochet
9d33d0ec9c validate: drop unneeded break+concat in some string literals 
Perform other related improvements while at it.
 2017-04-12 10:31:21 -07:00
Reynaldo H. Verdejo Pinochet
b2ec10ace3 validate: do not check for NULL before g_free() 
g_free() is NULL-safe.
 2017-03-23 15:21:58 -07:00
Reynaldo H. Verdejo Pinochet
158507585c validate: fix multiple occurrences of 'parametter' 2017-02-17 14:05:00 -08:00
Thibault Saunier
8493b18e8c validate: Fix GI warnings 2016-11-23 08:38:49 -03:00
Thibault Saunier
e247122051 validate: Add a reference to the pipeline from each monitor 
That will allow us to add more flexibility regarding the way
we report thing to the user and will allow us to properly make
reports per pipeline.
 2016-09-26 13:36:48 -03:00
Guillaume Desmottes
dc7382017d validate: reporter: break cyclic references with reports 
My patch fixing monitor leak (15e7f1bbfd)
introduced a ref cycle between GstValidateReporter and
GstValidateReport.

The reports uses its reporter so it needs a ref on it
to ensure it's stay alive. But reports are owned by GstValidateReporter and/or
GstValidateRunner.
The best way I found to break this cycle is to introduce this purge
method. It's not great but the design is a bit tricky.

Reviewed-by: Thibault Saunier <tsaunier@gnome.org>
Differential Revision: https://phabricator.freedesktop.org/D1029
 2016-08-01 10:45:30 -04:00
Guillaume Desmottes
b8c821dff4 validate: reporter: prevent usage of destroyed runner 
Fix crashes.

Reviewed-by: Thibault Saunier <tsaunier@gnome.org>
Differential Revision: https://phabricator.freedesktop.org/D1028
 2016-08-01 10:45:28 -04:00
Thibault Saunier
6a09e685f7 validate: Fix annotations 
Skipping all functions and methods that are not relevant and not easily
introspectable

Differential Revision: https://phabricator.freedesktop.org/D706
 2016-02-23 11:47:15 +01:00
Thibault Saunier
1d9c2d2a0b reporter: Properly reset g_log handler when reporter is destroyed 
Reviewed-by: Thibault Saunier <tsaunier@gnome.org>
Differential Revision: https://phabricator.freedesktop.org/D699
 2016-02-23 11:46:24 +01:00
Thibault Saunier
dbcb6d5614 validate: Mark gst_validate_report a G_GNUC_PRINTF 
Summary:
And fix the issue it raised

Reviewers: Mathieu_Du

Differential Revision: http://phabricator.freedesktop.org/D213

Depends on D211
 2015-06-08 17:40:32 +02:00
Thibault Saunier
40d00e8614 validate:override: Make overrides GObjects 
Summary:
This way we can subclass them getting a proper
context in the various override methods.

Depends on D204

Reviewers: Mathieu_Du

Differential Revision: http://phabricator.freedesktop.org/D205
 2015-06-08 17:40:31 +02:00
Thibault Saunier
dfe29c56e5 validate🏃 Add a method to force exiting the runner 
This method is similar to runner_printf() but can be used
only once. The user needs to make sure all the pipeline
are in NULL state when this is called.

The method emits a "STOPPING" signal and at that point
overrides or monitors should do extra processing/checks if
needed.

+ Make use of it everywhere where it makes sense.

API:
  gst_validate_runner_exit
  GstValidateRunner::stopping signal
 2015-06-06 08:50:47 +02:00
Guillaume Desmottes
38342dfe2e validate: reporter: fix message leak 2015-03-20 11:25:39 +01:00
Thibault Saunier
88da04e0a0 validate:report: Allow registering of issue types through the introspection 
Fixing annotations and make GstValidateIssue refcounted

We break the ABI in that commit but I do not expect anyone to register
issue type outside GstValidate yet.

Add padding in the structures so we can avoid breaking the ABI again later.
 2015-03-04 17:28:50 +01:00
Thibault Saunier
19f9172586 validate:reporter: Always print reports in the Gst debug system 2015-02-16 17:18:31 +01:00
Thibault Saunier
8125c46122 validate: Add helper functions ti print actions 
API:
  + gst_validate_scenario_get_next_action
  + gst_validate_reporter_report_simple

https://bugzilla.gnome.org/show_bug.cgi?id=743994
 2015-02-14 16:32:10 +01:00
Thibault Saunier
36aed39259 validate: Make sure to at least listen to GStreamer and GLib g_logs 
If somewhere else someone is overriding the g_log default handler,
we would not get notified of anything.
 2014-12-05 12:16:55 +01:00
Thibault Saunier
b56ebc8a43 validate: Enhance documentation 2014-11-25 19:41:00 +01:00
Ramprakash Jelari
eb47b1021f validate: Fix compiler warning about implicit enum type conversion 
gst-validate-reporter.c:119:39: error: implicit conversion from enumeration type
      'GstValidateReportingDetails' to different enumeration type
      'GstValidateInterceptionReturn' [-Werror,-Wenum-conversion]
  GstValidateInterceptionReturn ret = GST_VALIDATE_SHOW_UNKNOWN;
                                ~~~   ^~~~~~~~~~~~~~~~~~~~~~~~~
gst-validate-reporter.c:124:11: error: implicit conversion from enumeration type
      'GstValidateReportingDetails' to different enumeration type
      'GstValidateInterceptionReturn' [-Werror,-Wenum-conversion]
    ret = iface->get_reporting_level (reporter);
        ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gst-validate-reporter.c:127:10: error: implicit conversion from enumeration type
      'GstValidateInterceptionReturn' to different enumeration type
      'GstValidateReportingDetails' [-Werror,-Wenum-conversion]
  return ret;
  ~~~~~~ ^~~
 2014-10-24 15:19:19 +02:00
Mathieu Duponchelle
30aef5ba84 validate: rename GstValidateReportingLevel. 
Removes the confusion with GstValidateReportLevel.

Modeled on GstDebugGraphDetails.
 2014-10-21 23:41:04 +02:00
Mathieu Duponchelle
c542d9c6bc validate-report / reporter: rework the way we repeat issues. 
+ runner: update reports count algorithm.
 2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
0a1cdb2164 tests: Check monitors correctly determine their reporting level. 
+ [API] gst_validate_reporter_get_reporting_level
 2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
b21bb1ff34 validate-runner / reporter: Sanitize reports refcounting. 
The previous code worked but was confusing, the runner didn't actually
take the ref it was releasing later.

+ Fix indentation.
 2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
f001777cc6 validate-reporter: Add some methods 
+ gst_validate_reporter_get_reports
+ gst_validate_reporter_get_reports_count
 2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
3e557ca92b validate-reporter: Add return value to intercept_report. 
It will allow to drop, keep or report reports.
 2014-10-21 20:13:51 +02:00
Mathieu Duponchelle
fb90aa2ead validate-reporter: add gst_validate_reporter_get_report. 
+ Add locking.
 2014-10-21 20:13:51 +02:00
Thibault Saunier
d682bd29a9 validate: Print the report when aborting because of an issue 
Letting a chance to the user to know what bug he faced!
 2014-08-04 13:02:46 +02:00
Sebastian Dröge
b6c439ee88 validate: Don't call gst_debug_log_valist() if debugging is disabled 
And also stop leaking a string every time.
 2014-06-28 12:33:45 +02:00
Edward Hervey
ca44a11429 validate: Run gst-indent on all code 
so whitespace. much indent. spacing !
 2014-06-03 10:05:25 +02:00
Thibault Saunier
d280d0dbc9 validate: Add a media-descriptor parser and writer 2014-04-25 14:33:06 +02:00
Thibault Saunier
ad25b4d160 validate: Handle g_log errors at the gst-validate level 2014-04-17 12:23:04 +02:00
Thibault Saunier
a88d54aec2 validate: Plug a leak in validate-reporter 2014-02-06 12:02:59 +01:00
Thibault Saunier
7b236c96bf validate:tools: Do not forget to give a ref for reporter's reports 
Also enhance a bit report 'wording'
 2014-02-06 12:02:59 +01:00
Thiago Santos
2e216818bd Replacing mentions of qa with validate 2013-09-02 13:22:51 -03:00
Thiago Santos
1dd93bea2a licenses: improving licensing info on all files 2013-08-28 16:58:11 -03:00
Edward Hervey
de930073fc validate-reporter: More comprehensive debug message 
Some issues don't have any arguments, so put the full details in.
 2013-08-21 18:00:16 +02:00
Edward Hervey
529576e69b validate: Only use one debugging category: validate 
There's no point in having a different debug category per file, you
can filter it by source filename if you *really* want that.
 2013-08-21 17:59:51 +02:00
Thiago Santos
549bcc1fd5 reporter: do not print issues to stdout 2013-08-20 17:10:44 -03:00
Edward Hervey
15ea3bd8aa all: Enable more C warnings at build time 
And fix the issues:
* Proper forward declaration
* static functions marked properly
* absolute includes
* declaration order
 2013-08-16 15:13:54 +02:00
Edward Hervey
3e5c921217 reporter: Fix proper debug message output partially 
In order for the special gstreamer print argument handler to be used
you can't use g_strdup_printf. You need to pass it the actual va_list.
 2013-08-16 14:30:02 +02:00
Thiago Santos
6df0b6c010 validade: add missing config.h includes 2013-08-14 20:03:43 -03:00
Thiago Santos
52002376ea rename gst-qa -> gst-validate 2013-08-14 17:46:28 -03:00