Alba Mendez
4810008afa
webrtcbin: support adding TURN servers after pipeline start
...
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1680
When a TURN server is added for the first time, propagate
the change to all nice streams that already exist. This
lets us add servers after the pipeline has been started
(and streams have been added).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3217 >
2022-10-19 07:23:42 +00:00
Sebastian Dröge
64c376b5b2
webrtc: Add/fix various annotations
...
And mark string parameters as const.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194 >
2022-10-18 08:56:58 +00:00
Mathieu Duponchelle
b10e0efd3a
webrtc/nice: fix small leak of split strings
...
g_strfreev previously stopped at our manual NULL-termination. Fix by
restoring the pointer after joining.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3188 >
2022-10-14 20:15:00 +00:00
Sebastian Dröge
430ec0d860
webrtc: Move GST_WEBRTC_ERROR_TYPE_ERROR at the end of the enum to keep ABI compatibility
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3154 >
2022-10-11 11:24:19 +00:00
Sangchul Lee
94c2cd9ddd
webrtc/nice: Make sure to return NULL when validating turn server fails
...
It affects 'add-turn-server' signal action and 'turn-server' property
of webrtcbin.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3120 >
2022-10-05 16:35:00 +00:00
Johan Sternerup
212c09a70e
webrtc: return error when sending on non-open datachannel
...
According to W3C
specification (https://w3c.github.io/webrtc-pc/#datachannel-send ) we
should return InvalidStateError exception when trying to send when the
channel is not open. In the world of C/glib/gstreamer we don't have
exceptions but have to rely on gboolean/GError instead. Introducing
these calls for a change in function signature of the action signals
used to send data on the datachannel. Changing the signature of the
existing "send-string" and "send-data" signals would mean an immediate
breaking change so instead we deprecate them. Furthermore, there is no
way to express GError** as an argument to an action signal in a way
that fits language bindings (pointer-to-pointer simply does not work)
and we have to use regular functions instead.
Therefore we introduce gst_webrtc_data_channel_send_data_full() and
gst_webrtc_data_channel_send_string_full() while deprecating the old
functions and corresponding signals.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1958 >
2022-10-05 11:08:30 +00:00
Thibault Saunier
bc9c1e3956
meson: Namespace the plugins_doc_dep/libraries variables
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2970 >
2022-09-01 21:17:35 +00:00
Thibault Saunier
d04a80676e
webrtc:ice: Fix candidate stats related APIs for bindings
...
null-terminated arrays of structures is not usable.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2917 >
2022-08-19 10:46:01 -04:00
Thibault Saunier
050006e9f0
webrtc: doc: Cleanup Since markers
...
We hide some newly public symbols when moving some objects to the library
which was not really correct in the end. Properly add the Since markers
as needed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
82a7a23fa0
webrtc:ice: Reindent header
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
0ee9727df3
webrtc:ice: Mark protected fields as such
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
24b171735d
webrtc: Fix documentaton moving symbols in the right pages
...
As those symbols are documented in a 'fwd' header smart indexing in
hotdoc wasn't working.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
b3e0205c5a
webrtc:ice: Avoid using GArray in public API
...
And use plain null terminated C arrays instead.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
50202d6b53
webrtc:ice: Fix some annotations
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
8dd4c215da
webrtc: Make GstWebRTCIceCandidateStats a Boxed type
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Thibault Saunier
ff0d73be57
webrtc:ice: Add padding to structures
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2891 >
2022-08-18 08:34:36 +00:00
Philippe Normand
4bf62c788c
webrtc: nice: WeakRef access fixes
...
The GstWebRTCNiceStream::ice property getter already hands-off a full reference,
so there is no need to call g_weak_ref_get() in call sites.
Fixes #1350
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2819 >
2022-08-01 13:13:16 +00:00
Philippe Normand
3bdf3455a0
webrtc: ice: Fix GstWebRTCICE parent class
...
It is a GstObject, not a GObject.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2819 >
2022-08-01 13:13:16 +00:00
U. Artie Eoff
e3e98da727
meson: webrtc: ensure definition of libgstwebrtcnice_dep
...
... and skip if it's disabled.
Fixes #1344
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2797 >
2022-07-26 17:39:52 -04:00
yatinmaan
2c1e61ea16
webrtc: Split WebRTCICE into base classes and implementation.
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2398 >
2022-07-26 13:51:11 +00:00
Sangchul Lee
8537433f24
webrtc/datachannel: Change initial data channel state to CONNECTING
...
It complies with http://w3c.github.io/webrtc-pc/#dom-rtcdatachannelstate .
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2099 >
2022-04-04 23:46:25 +00:00
Matthew Waters
5741ee38e0
webrtc/datachannel: fix use-after-free in sctp state notification
...
g_signal_disconnect*() doesn't stop any existing callbacks from running
which means that if the notify::state callback is in progress in one
thread and the data channel object is finalize()ed in another thread,
then there could be a use-after-free trying lock the data channel
object.
We can't reasonably use a GWeakRef as we don't have a 'parent' object to
free the GWeakRef after the data channel is finalized. This is also
complicated by the fact that the application can hold a reference to the
data channel object that would live beyond the lifetime of webrtcbin
itself.
We solve this by implementing a ghetto weak-ref solution internally with
a list of outstanding data channels.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664 >
2022-03-29 23:55:40 +00:00
Matthew Waters
e28c45fd05
webrtc: explicitly error out in a couple of renegotiation cases
...
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664 >
2022-03-29 23:55:40 +00:00
Philippe Normand
5a2e1ecb4d
dtlstransport: Notify ICE transport property changes
...
The application might track the underlying ICE transport, so not notifying
changes might lead to use-after-free issues.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1688 >
2022-02-14 03:24:26 +00:00
Philippe Normand
4254920b72
webrtc: Expose RTCError enum
...
The error codes not complying with the spec are now notified with the
GST_WEBRTC_ERROR_INTERNAL_FAILURE code.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1485 >
2022-01-29 14:42:22 +00:00
Tim-Philipp Müller
be3b71d6c9
gst-plugins-bad: define G_LOG_DOMAIN for all libraries
...
Fixes #634
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009 >
2021-10-19 00:12:25 +00:00
Thibault Saunier
6e79932ad9
meson: List libraries and their corresponding gir definition
...
Introduces a `libraries` variable that contains all libraries in a
list with the following format:
``` meson
libraries = [
[pkg_name, {
'lib': library_object
'gir': [ {full gir definition in a dict } ]
],
....
]
```
It therefore refactors the way we build the gir so that we can reuse the
same information to build them against 'gstreamer-full' in gst-build
when linking statically
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093 >
2021-10-15 19:27:30 -03:00
Thibault Saunier
e2dd28a753
meson: Mark files as files()
...
Making it more robust and future proof
And fix issues that it creates
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1093 >
2021-10-15 19:27:30 -03:00
Thibault Saunier
019971a3c7
Move files from gst-plugins-bad into the "subprojects/gst-plugins-bad/" subdir
2021-09-24 16:14:36 -03:00