luz.paz
4a402c1c7d
Fix typos in comments and docs
...
Found via `codespell`
https://bugzilla.gnome.org/show_bug.cgi?id=795610
2018-05-01 11:18:03 +01:00
Thibault Saunier
a87b4551a6
Port gtk-doc comments to their equivalent markdown syntax
...
Modernizing our documentation and preparing a possible move to hotdoc.
This commits also adds missing @title metadatas to all SECTIONs
2017-01-27 16:36:38 -03:00
Jan Schmidt
e64765c0d8
typefind: Switch to normal mode before have-type
...
Before emitting have-type, switch to NORMAL
mode, as part of the have-type processing sends
the caps event downstream, which might trigger
actions like downstream autoplugging or
flushing seeks - and the latter are only
passed upstream if we've set typefind to NORMAL
mode.
2016-12-21 00:40:10 +11:00
Sebastian Dröge
d284be3505
typefind: Use gst_query_has_scheduling_mode_with_flags() convenience function
2016-12-09 18:02:41 +02:00
Jan Schmidt
a6ca8dfb42
queues: Don't return negative position queries.
...
When subtracting queued data sizes from upstream queries
in queue, queue2, downloadbuffer and typefind, clamp the
result to not go negative, in case upstream returned
a nonsense value that's too small (as could happen if
upstream is estimating, or just broken)
2016-11-16 00:12:22 +11:00
Thibault Saunier
4714ef2f8e
Make use of the new GST_ELEMENT_FLOW_ERROR API all around.
...
https://bugzilla.gnome.org/show_bug.cgi?id=770158
2016-08-27 09:33:20 -03:00
Sebastian Dröge
5e43ee5989
typefind: Only push a CAPS event downstream if the sinkpad is not in PULL mode
...
The other signal handlers of the type-found signal might have reactivated
typefind in PULL mode already, pushing a CAPS event at that point would cause
deadlocks and is in general unexpected by elements that are in PULL mode.
https://bugzilla.gnome.org/show_bug.cgi?id=765906
2016-05-11 15:06:39 +03:00
Sebastian Dröge
0d5326950a
typefind: Remove redundant assignment
...
CID 1357158
2016-03-24 11:49:44 +02:00
Romain Picard
20859af3f2
typefind: Allow caps query in "have-type" signal handlers
...
If an application calls gst_pad_query_caps from its "have-type" signal handler,
then the query fails because typefind->caps has not been set yet.
This patch sets typefind->caps in the object method handler, before the signal
handlers are called.
https://bugzilla.gnome.org/show_bug.cgi?id=763491
2016-03-15 18:58:06 +02:00
Sebastian Dröge
57bbd18471
typefind: Store caps on the pad before emitting have-type but send it downstream only in the default signal handler
...
https://bugzilla.gnome.org/show_bug.cgi?id=763491
2016-03-14 13:07:49 +02:00
Sebastian Dröge
a15fca1934
Revert "typefind: Store caps on the pad before emitting have-type but send it downstream only in the default signal handler"
...
This reverts commit 0835c3d656
.
It causes deadlocks in decodebin, which currently would deadlock if the caps
are already on the pad in have-type and are forwarded while copying the sticky
events (while holding the decodebin lock)... as that might cause the next
element to expose pads, which then calls back into decodebin and takes the
decodebin lock.
This needs some more thoughts.
2016-03-12 12:57:47 +02:00
Sebastian Dröge
0835c3d656
typefind: Store caps on the pad before emitting have-type but send it downstream only in the default signal handler
...
https://bugzilla.gnome.org/show_bug.cgi?id=763491
2016-03-12 11:56:49 +02:00
Tim-Philipp Müller
cf0680017e
elements: use new gst_element_class_add_static_pad_template()
...
https://bugzilla.gnome.org/show_bug.cgi?id=762778
2016-02-28 13:10:07 +00:00
Tim-Philipp Müller
94ec3f8a3e
typefind: fix indentation
2016-02-27 16:39:50 +00:00
Alex Henrie
78ba7f9a8e
typefindelement: Improve English grammar
...
https://bugzilla.gnome.org/show_bug.cgi?id=761273
2016-01-29 10:34:44 +01:00
Tim-Philipp Müller
7be8acbfb0
typefindelement: reset segment only once streaming has stopped
...
Fixes the occasional criticals in the discoverer unit test.
https://bugzilla.gnome.org/show_bug.cgi?id=745073
https://bugzilla.gnome.org/show_bug.cgi?id=750823
2015-06-14 21:25:29 +01:00
Sebastian Dröge
91f537edf2
typefind: Post an error if we can't typefind the data until EOS
...
https://bugzilla.gnome.org/show_bug.cgi?id=750439
2015-06-05 10:02:04 +02:00
Sebastian Dröge
d70631fe99
typefindelement: Use gst_event_unref() instead of gst_mini_object_unref() + casting
2015-04-13 17:01:41 +02:00
Guillaume Desmottes
15fd78f0b6
typefind: fix leak in gst_type_find_element_src_event()
...
gst_type_find_element_src_event() is supposed to consume @event but wasn't
doing so when it was handling the event itself.
https://bugzilla.gnome.org/show_bug.cgi?id=747775
Signed-off-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
2015-04-13 10:33:41 -03:00
Sebastian Dröge
6409420474
typefind: Run the default have-type handler after all application handlers
...
Otherwise the CAPS event will already be forwarded downstream and
the application has no way to intervene anymore.
https://bugzilla.gnome.org/show_bug.cgi?id=735896
2015-04-13 09:04:14 +02:00
Sebastian Dröge
53e8e7da75
typefind: Reset segment when deactivating pull mode or not running in pull mode
...
We use the segment format to detect if we run the streaming thread or not.
Without resetting we might believe we do so, although we only did in the past
and are now running in e.g. push mode.
https://bugzilla.gnome.org/show_bug.cgi?id=745073
2015-03-12 12:59:57 +00:00
Tim-Philipp Müller
ed15125086
typefind: minor cosmetic change
...
No nee to abbrev variab nam here, nicer to read if full.
2014-12-10 11:17:25 +00:00
Tim-Philipp Müller
691bd8bd87
typefind: use GST_BUFFER_OFFSET_NONE for buffer offset
2014-12-10 11:16:09 +00:00
Edward Hervey
f1c2cd60c3
typefind: Propagate input buffer offset
...
The initial buffers might have non-default offsets, make sure they get
propagated if present.
2014-12-01 10:47:01 +01:00
Ognyan Tonchev
cf04dc0486
typefindelement: do not leak sticky events in flush_stop
...
https://bugzilla.gnome.org/show_bug.cgi?id=736813
2014-09-17 17:39:10 +01:00
Tim-Philipp Müller
64cc548c16
typefindelement: remove prototype for function that no longer exists
2014-07-25 11:45:56 +01:00
Edward Hervey
f1abac1109
typefindelement: Propagate input buffer PTS and DTS
...
The initial buffers (that were used for timestamping) might have PTS
and DTS set. In order to forward those properly, get the initial
PTS/DTS from the adapter and set them on the reconstructed output
buffer.
https://bugzilla.gnome.org/show_bug.cgi?id=733291
2014-07-17 09:45:54 +02:00
Sebastian Dröge
a91b51c9b7
typefind: Keep still meaningfull pending events on FLUSH_STOP
...
Only EOS and segment should be deleted in that case.
https://bugzilla.gnome.org/show_bug.cgi?id=709868
2014-05-31 17:35:52 +02:00
Sebastian Rasmussen
53ae1b2c9c
docs: Fix typos in function/object descriptions
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720029
2013-12-07 17:11:12 +00:00
Sebastian Dröge
631421b8af
typefind: Add missing break after handling the GAP event
...
Thanks to Edward Hervey for noticing.
2013-09-04 14:42:38 +02:00
Sebastian Dröge
4aef70fed1
typefind: Only advance offset by the number of bytes we actually read
...
There might be a short read at EOS.
2013-07-29 11:05:09 +02:00
Sebastian Dröge
d9f3d3560e
typefind: Use new group-id in stream-start event
2013-07-22 15:30:10 +02:00
Sebastian Dröge
1d1946a321
typefind: Handle the force-caps property more similar to all typefinding code flow
...
This makes sure that events happen in order and simplifies the code a bit.
2013-05-15 13:22:04 +02:00
Nicolas Dufresne
ba354f6b03
typefind: Send stream-start before anything else
...
To do so, send stream-start when the streaming thread goes up for the first
time.
https://bugzilla.gnome.org/show_bug.cgi?id=699767
2013-05-07 09:17:13 +02:00
Sebastian Dröge
c24bcbf511
typefind: Always leave TYPEFIND mode when we're stopping typefinding
2013-04-29 13:24:56 +02:00
Sebastian Dröge
11f6e08aae
typefind: Simplify code
...
This is only called when in TYPEFIND mode.
2013-04-29 13:24:56 +02:00
Sebastian Dröge
7982f682dd
typefind: Push pending events independent of the existence of a downstream chain function and peer
...
Downstream might create a peer only as result of the events in theory.
2013-04-29 13:24:56 +02:00
Sebastian Dröge
32e05f8a1e
typefind: Only push CAPS event once if we get one from upstream
...
https://bugzilla.gnome.org/show_bug.cgi?id=692784
2013-04-29 13:24:56 +02:00
Sebastian Dröge
2a34f767d4
typefind: Stop typefinding if we get a CAPS event from upstream
2013-04-29 13:24:56 +02:00
Sebastian Dröge
0fda329bbb
typefind: Improve handling of GAP events
...
There's still room for improvement though.
2013-04-29 13:24:56 +02:00
Sebastian Dröge
fc4105c1f9
typefind: Forward events that should happen before the caps event directly
...
There's no point in storing them and sending them later, and doing so would
later require to distinguish between events that should come before caps and
after.
https://bugzilla.gnome.org/show_bug.cgi?id=692784
2013-04-29 13:24:56 +02:00
Sebastian Dröge
cf0566f9ca
typefind: Only push pending buffers and events if we have caps
2013-04-29 13:24:56 +02:00
Sebastian Dröge
922815996f
typefind: Remove code that would cause caps to be sent twice
...
Whenever we set typefind->caps we will also send a caps event downstream.
2013-04-29 13:24:56 +02:00
Tim-Philipp Müller
e1c6a56596
typefind: fix caps leak when used in connection with uridecodebin and playbin
...
Don't leak forced sink caps.
2013-04-27 00:05:45 +01:00
Tim-Philipp Müller
666c8c11c6
Fix FSF address
...
https://bugzilla.gnome.org/show_bug.cgi?id=687520
2012-11-03 20:44:48 +00:00
Wim Taymans
701424be9b
typefind: send STREAM-START event
...
Send a STREAM_START event when we are operating in pull mode.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=684424
2012-09-26 13:25:03 +02:00
Tim-Philipp Müller
a85991eeb8
baseparse, typefind: only activate in pull mode if upstream is seekable
...
Upstream might support pull mode, but only sequential pulls,
which isn't gonna do much for us.
https://bugzilla.gnome.org/show_bug.cgi?id=634927
2012-09-11 01:40:53 +01:00
Tim-Philipp Müller
ba39106758
typefind: send segment_done event in addition to segment_done message
2012-08-02 00:22:29 +01:00
Wim Taymans
f05b0e222f
Update for new seeking variable name
...
When seeking, the start value and type are now called start and start_type.
2012-07-27 15:24:52 +02:00
Wim Taymans
a1f1bbd363
typefind: require bytes before typefinding
...
Require that we have some bytes in the adapter before we attempt to typefind.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=680479
2012-07-24 12:38:15 +02:00