Sebastian Dröge
90eb93c2ef
Don't compare booleans for equality to TRUE and FALSE
...
TRUE is 1, but every other non-zero value is also considered true. Comparing
for equality with TRUE would only consider 1 but not the others.
2014-12-01 09:51:12 +01:00
Tim-Philipp Müller
19d2a5255c
tagmux: fix criticals when there are no tags at all
2014-11-28 13:18:38 +00:00
Sebastian Dröge
1e64667fe0
libs: There is no G_TYPE_CHECK_INTERFACE_TYPE and G_TYPE_CHECK_INTERFACE_CAST
...
Remove the macros that used them, nobody could've used them anyway.
2014-06-26 16:18:46 +02:00
Tim-Philipp Müller
3f68f522ee
tag: xmp: fix leaks in error code paths
...
CID 1212133
2014-05-09 15:32:18 +01:00
Thiago Santos
03ba34f3a8
tag: exif: avoid adding empty strings
...
Fixes assertion with some jpeg files
2014-04-22 00:21:45 -03:00
Vincent Penquerc'h
22e12979ee
exiftag: catch buffer mapping failure
...
Might be what caused:
Coverity 1139734
2014-04-16 11:43:40 +01:00
Eric Trousset
2ca256acdb
tagdemux: Forward TIME seeks upstream too, maybe upstream can handle that
...
https://bugzilla.gnome.org/show_bug.cgi?id=723597
2014-02-04 13:56:29 +01:00
Sebastian Dröge
5a48fb7cdb
vorbistag: Read image-type from the GstSample info struct
...
But for backwards compatibility keep reading it from the caps and only
use the info struct if the caps don't contain the image-type.
2013-12-16 11:35:12 +01:00
Wim Taymans
b55de48843
tagdemux: accumulate buffers in adapter
...
Accumulate buffers in an adapter instead of appending them because append causes
a lot of memcpys.
Keep track of the last tagsize and accumulate enough data before attempting to
parse more data.
This patch implements a minimal amount of changes in order to not change the
behaviour. We should really rewrite the tag handling and trimming using
the adapter API instead of merging and trimming into a buffer.
2013-11-06 16:27:21 +01:00
Matthieu Bouron
7b3ca538fd
tag: id3: encapsulate ID3V2 blob frames in GstSample
...
id3mux and id3v2mux expect GST_TAG_ID3V2_FRAME type to be stored in a
GstSample and not a buffer, which is also needed because we can't
attach extradata/caps to buffers any more. These are private tags
no one should be poking at, and also the extra info is missing.
https://bugzilla.gnome.org/show_bug.cgi?id=707765
2013-09-09 23:49:14 +01:00
Matthieu Bouron
45edbacd23
tag: id3: handle publisher, interpreted-by and musical-key tags
...
https://bugzilla.gnome.org/show_bug.cgi?id=705999
2013-08-20 14:44:55 +02:00
Matthieu Bouron
541c061ee8
tag: add musical-key tag
...
https://bugzilla.gnome.org/show_bug.cgi?id=705999
2013-08-20 14:44:27 +02:00
Sebastian Dröge
bb870b8b7b
tagdemux: Properly implement seeking if tagdemux is driving the pipeline
...
https://bugzilla.gnome.org/show_bug.cgi?id=705062
2013-07-29 11:40:57 +02:00
Sebastian Dröge
b4365551d0
tagdemux: Add support for group-id in the stream-start event
2013-07-22 15:24:50 +02:00
Edward Hervey
0bb5065b62
id3: Use debug category and show FIXMEs
...
Allows spotting faster un-parsed tags
2013-07-18 07:45:47 +02:00
Olivier Crête
b550764da8
tagdemux: Put the modified time back in the time part of the segment
...
https://bugzilla.gnome.org/show_bug.cgi?id=704301
2013-07-16 14:02:40 -04:00
Marcin Lewandowski
cd00206059
tag: ignore malformed ID3v2 TDAT frames
...
Just skip them, don't cause criticals.
https://bugzilla.gnome.org/show_bug.cgi?id=703283
2013-07-05 00:47:08 +01:00
Edward Hervey
b81ca93de2
xmptag: Add a debug category
...
Instead of using the default category
2013-06-28 07:09:34 +02:00
Edward Hervey
420dacb2d5
xmptag: More efficient GSList usage
...
Instead of constantly appending (which gets more and more expensive), just
prepend to the list (O(1)) and reverse the list before usage.
https://bugzilla.gnome.org/show_bug.cgi?id=702545
2013-06-19 12:01:44 +02:00
Tim-Philipp Müller
7110c7216f
vorbistag: add mapping for TOTALTRACKS and TOTALDISCS tags
...
Found TOTALTRACKS in a FLAC file instead of TRACKTOTAL,
we should at least read this if present.
http://www.hydrogenaudio.org/forums/index.php?showtopic=91496&st=0&p=773857&#entry773857
2013-02-14 00:33:56 +00:00
Tim-Philipp Müller
664adc6e19
gst-libs: use GST_*_1_0 environment variables everywhere
...
The _1_0 suffixed environment variables override the
non-suffixed ones, so if we're in an environment that
sets the _1_0 suffixed ones, such as jhbuild, we need
to set those to make sure ours actually always get
used.
2013-01-16 10:16:27 +00:00
Tim-Philipp Müller
776bae5b84
docs: fix 0.10-ism in GstTagImageType docs
...
The image type is not in the info structure in the sample,
not in the caps.
https://bugzilla.gnome.org/show_bug.cgi?id=691687
2013-01-14 11:12:03 +00:00
Sebastian Dröge
3f82e919dd
libs: Use foo/foo.h as single-include header consistently everywhere
...
https://bugzilla.gnome.org/show_bug.cgi?id=688785
2012-12-12 17:13:10 +00:00
Sebastian Dröge
7af386fdaf
libs: Fix last commit by using correct include paths and only include existing headers
2012-11-21 11:12:57 +01:00
Evan Nemerson
4d77fba46c
libs: Add missing single include headers and use them in GIRs
2012-11-21 11:01:24 +01:00
Tim-Philipp Müller
5f59b4f7ee
Fix FSF address
...
https://bugzilla.gnome.org/show_bug.cgi?id=687520
2012-11-03 23:05:09 +00:00
Tim-Philipp Müller
a4f2df6341
Revert "g-i: change g-ir-scanner arg --library=libgstfoo-X.la to --library=gstfoo-X"
...
This reverts commit e39fbe6b7e
.
Looks like we need to pass the full .la file after all in a setup
with libtool, or it might not find the library, e.g. like
ERROR: can't resolve libraries to shared libraries: gstfft-1.0
Conflicts:
gst-libs/gst/audio/Makefile.am
gst-libs/gst/pbutils/Makefile.am
Also see https://bugzilla.gnome.org/show_bug.cgi?id=603710
2012-10-29 12:47:05 +00:00
Miguel Angel Cabrera Moya
e921b5b0f3
exiftag: fix use after free and memory leak
...
https://bugzilla.gnome.org/show_bug.cgi?id=687055
2012-10-28 20:19:56 +00:00
Miguel Angel Cabrera Moya
51c4e51d9c
vorbistag: fix memory leak
...
https://bugzilla.gnome.org/show_bug.cgi?id=687057
2012-10-28 20:16:06 +00:00
Tim-Philipp Müller
e39fbe6b7e
g-i: change g-ir-scanner arg --library=libgstfoo-X.la to --library=gstfoo-X
...
As it should be according to the man page.
https://bugzilla.gnome.org/show_bug.cgi?id=679315
2012-10-28 17:35:57 +00:00
Tim-Philipp Müller
60f93735c0
vorbistag: add mapping for 'ALBUM ARTIST' with space
...
As found in sample file for bug #684701 .
2012-10-23 15:56:10 +01:00
Tim-Philipp Müller
eb48b4d3cb
tag: remove unnecessary g_type_init() call from mklicensestable tool
...
https://bugzilla.gnome.org/show_bug.cgi?id=686456
2012-10-20 12:59:11 +01:00
Thiago Santos
b57d3252ec
vorbistag: fix 'TODO' on image tag parsing
...
Image tag now uses GstSample that has the buffer and caps
associated with it.
2012-10-18 17:50:41 -03:00
Tim-Philipp Müller
5e0dfec62c
Remove -DGST_USE_UNSTABLE_API
2012-09-17 16:05:37 +01:00
Mark Nauwelaerts
c629a44162
replace gst_tag_list_free with gst_tag_list_unref
2012-09-14 17:53:21 +02:00
Stefan Sauer
2fb27fa463
xmptag: migrate to the _full version of the API and drop the _full postfix
...
Fix up all invocations.
2012-09-12 21:32:04 +02:00
Tim-Philipp Müller
ec27f4e13c
tagdemux: also read tags if downstream activates us in pull mode right away
...
Fix reading of tags for the case filsrc ! footagdemux ! fooparse ! ..
where we would not read the tags because we never start our own
streaming thread.
https://bugzilla.gnome.org/show_bug.cgi?id=673185
2012-09-11 20:53:16 +01:00
Mark Nauwelaerts
899a809330
ext, gst-libs: only activate in pull mode if upstream is seekable
2012-09-11 17:37:27 +02:00
Tim-Philipp Müller
d2237b2276
tagdemux: operate in pull mode
...
When we are operating in pull mode, we need to pull from upstream and push
downstream. Also make sure to push tags first.
2012-09-10 17:16:26 +02:00
Tim-Philipp Müller
17c839c8a1
No statements with side-effects in g_assert() or g_return_*() please
2012-08-08 10:11:48 +01:00
Sebastian Dröge
880b9a20a6
tagdemux: Add stream-id to stream-start event
2012-08-06 14:01:28 +02:00
Tim-Philipp Müller
36f32d3f93
tag: fix month/day extraction in ID3v2 tags
...
We were passing month/day in the wrong order to
gst_date_time_new_ymd().
2012-08-02 00:23:28 +01:00
Tim-Philipp Müller
063dc1712e
tag: fix up EXIF writer for GstBuffer -> GstSample
2012-07-28 11:54:38 +01:00
Sebastian Dröge
99d73c94e9
tag: Update for taglist/tag event API changes
2012-07-28 00:35:02 +02:00
Wim Taymans
683a38ad65
update for new variable names
2012-07-27 15:24:43 +02:00
Tim-Philipp Müller
f46c383818
tag: use GST_TAG_DATE_TIME for storing dates instead of GST_TAG_DATE
...
So we can express partial dates.
2012-07-15 00:14:36 +01:00
Tim-Philipp Müller
54e9581a59
tag: extract dates from ID3v2 tags into GstDateTime instead of GDate
...
We may only have a year, or year and month+day, or (in future)
both date and time.
2012-07-14 15:37:46 +01:00
Tim-Philipp Müller
a1d1bd0517
tag: extract year from ID3v1 tag as GstDateTime instead of GDate
...
So we can signal properly that only the year is valid.
2012-07-14 15:34:56 +01:00
Edward Hervey
2817bdadc9
libs: Remove "Since" markers and minor doc fixups
2012-07-13 12:11:06 +02:00
Edward Hervey
666716a0f0
tagdemux: Push a STREAM_START on new caps
2012-07-13 12:10:01 +02:00