Commit graph

454 commits

Author SHA1 Message Date
Tim-Philipp Müller
112174bcea asfdemux: extract WM/PartOfSet disc number and count metadata
Fixes #30

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/merge_requests/54>
2020-06-02 12:26:41 +01:00
Tim-Philipp Müller
4f4b67bea4 asfdemux: sprinkle some INDENT-OFF
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly/-/merge_requests/54>
2020-06-02 12:26:41 +01:00
Derek Lesho
8fe8ed3dd2 asfdemux: Always re-initialize metadata and global_metadata
When transitioning from the PAUSED state, to the READY state, and back,
metadata and global_metadata are left uninitialized, unlike when the
demxuer transitions from NULL to READY, then to PAUSED.  I have found
this to cause a segmentation fault when fields in these structures are
set.
2020-04-08 11:06:27 +03:00
Tim-Philipp Müller
3cd445a490 Remove autotools build system 2019-10-13 14:19:11 +01:00
Aaron Boxer
3f24460e37 documentation: fix some typos 2019-09-02 09:33:15 -04:00
Tim-Philipp Müller
f93aa34200 asfdemux: remove some unused cruft in internal headers 2019-05-25 14:19:54 +02:00
Thibault Saunier
21ac37c61a docs: Port documentation to hotdoc 2019-05-13 17:00:00 -04:00
Thibault Saunier
2df9f6e5ce docs: Port all docstring to gtk-doc markdown 2019-04-26 20:32:26 -04:00
Edward Hervey
ff4cca75b2 asfdemux: Remove 0.10 code
This was used to "close" a segment. It's no longer needed anymore
in 1.x (it was essentially sending the same thing again)
2018-06-11 14:43:20 +02:00
Edward Hervey
fd59ea8c7d asfdemux: Only send flush event on seeking flushes
And not on all the time
2018-05-22 06:52:58 +02:00
Xavier Claessens
6b01999087 Meson: Generate pc file for all plugins in ugly
https://bugzilla.gnome.org/show_bug.cgi?id=794568
2018-04-25 11:07:39 +01:00
Sebastian Dröge
0c9a8e9e3b asfdemux: Set the stream-format field of H264 streams
If we have codec_data it will be AVC, otherwise assume byte-stream.
2018-04-16 20:14:16 +03:00
Edward Hervey
f86751d9f7 asfdemux: Fix prerolling files with "empty" streams
This is a regression that was introduced by
commit 1803b3c185
"    asfdemux: Add support for dvr-ms"

The problem is that some files/streams might contain stream definition
but there is no actual packets for those streams.

This was used to "define" streams with different bitrates for example.

The first_ts calculation resulted in never ever finding a valid first_ts
since some streams were empty, and therefore never "activating" itself.

Instead of that we first check if we are prerolled. And if we are we
unconditionally get the "first_ts"

The preroll check has been adapted to check whether streams of
each defined type (i.e. audio/video/sub) has been prerolled. This solves
the problem of having different streams of a particular type where only
one stream actually has data.
2017-11-13 11:13:30 +01:00
Edward Hervey
2d9867b120 asfdemux: Store the stream type in streams
The field was present but never set :)
2017-11-13 11:09:31 +01:00
Edward Hervey
ec24f4c9f2 asfdemux: More index handling
In the same vein as the previous commit, the end of the file might have been
cut and therefore contains bogus data.

If the object is too short, consider it as garbage and return a non-fatal
flow.

Regression introduced in 97294eb8bb
2017-06-27 11:49:21 +02:00
Edward Hervey
0bbdfa8ee9 asfdemux; Don't assume index is present at end of file
Some files have garbage at the end of the file, don't error out if we don't
find the index there.

Reverts back to previous behaviour (where corrupted/missing indexex were
not a fatal error).

Regression introduced in 97294eb8bb
2017-06-27 10:41:42 +02:00
Mark Nauwelaerts
3a25a3a948 asfdemux: adjust segment start to a keyframe ts only for a KEYUNIT seek
... which is how it has always been until changed coincidentally in commit
9ee60482b2 which then prompted commit
dba14178ce to consider ACCURATE as well
to compensate for that in a lateral way
2017-06-24 18:14:59 +02:00
Thiago Santos
42f8e22f17 asfdemux: fix checking for header objects
The if 'and' condition was mixed up with the last parameter of the
function and would lead to wrong results
2017-06-06 21:48:19 -07:00
Nicolas Dufresne
d02e7d8029 Remove plugin specific static build option
Static and dynamic plugins now have the same interface. The standard
--enable-static/--enable-shared toggle are sufficient.
2017-05-16 14:07:56 -04:00
Sebastian Dröge
66659f07f5 asfdemux: Fix compilation with gcc 7
gstasfdemux.c: In function 'gst_asf_demux_parse_stream_object':
gstasfdemux.c:3001:39: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
   is_encrypted = ! !((flags & 0x8000) << 15);
                     ~~~~~~~~~~~~~~~~~~^~~~~~

https://bugzilla.gnome.org/show_bug.cgi?id=779329
2017-02-27 20:55:34 +02:00
Sebastian Dröge
d21017b52a asfdemux: Check that we have enough data available before parsing bool/uint extended content descriptors
https://bugzilla.gnome.org/show_bug.cgi?id=777955
2017-01-31 13:50:21 +02:00
Sebastian Dröge
dec880031d asfdemux: Reset number of languages to 0 when freeing the array because of errors
Otherwise we will happily index into the array at NULL if the requested
index is smaller than the number of languages that were previously
allocated.

https://bugzilla.gnome.org/show_bug.cgi?id=777937
2017-01-30 15:39:59 +02:00
Sebastian Dröge
0ff3f79330 asfdemux: Fix memory leak of payload extensions for unusable/unsupported streams
https://bugzilla.gnome.org/show_bug.cgi?id=775515
2016-12-02 14:06:21 +02:00
Edward Hervey
9ad9e06fcb asfdemux: Allow 64bit sizes for DATA object
we *can* have files greater than 4GB, any other object should be
smaller than that
2016-11-25 12:41:03 +01:00
Edward Hervey
4a52e6c827 asfdemux: Add sanity check for asf_stream_audio
We should have enough bytes for the specified codec_data

https://bugzilla.gnome.org/show_bug.cgi?id=775070
2016-11-25 10:08:31 +01:00
Edward Hervey
8f05e8f449 asfdemux: Add sanity checks when reading asf_stream_video_format
It should report a size of at least 40 bytes
Also check for the size of the remaining data (i.e. codec_data)

https://bugzilla.gnome.org/show_bug.cgi?id=775070
2016-11-25 10:07:21 +01:00
Edward Hervey
97294eb8bb asfdemux: Add check for invalid/corrupt asf object
An asf object can't realistically be bigger than 2**32 bytes.

If it reports a size bigger than that, consider it corrupt and properly
propagate the error back.

https://bugzilla.gnome.org/show_bug.cgi?id=775070
2016-11-25 09:46:12 +01:00
Edward Hervey
48a493070a asfdemux: Handle EOS in push-mode on corrupted files
It is possible no streams were activated when receiving EOS, if so
handled it as if we hadn't seen the header

https://bugzilla.gnome.org/show_bug.cgi?id=774846
2016-11-22 18:21:46 +01:00
Edward Hervey
e7ff86665a asfdemux: FILE headers are mandatory in the header
As per the specification, also avoids ending up trying to play a
file with plenty of un-initialized values.

https://bugzilla.gnome.org/show_bug.cgi?id=774846
2016-11-22 18:21:46 +01:00
Edward Hervey
cc04255e94 asfdemux: Handle incomplete header in pull mode
pulling headers is meant to complete as a whole. If we don't have
enough data, it's an error.

Avoids pipeline hangs on corrupted files

https://bugzilla.gnome.org/show_bug.cgi?id=774846
2016-11-22 18:21:46 +01:00
Edward Hervey
45c7826d76 asfdemux: Handle issues with "empty" files
In some corrupted files, we could end up with no actual streams
being exposed.

In those cases, make sure we properly propagate the failure all
the way to the loop function. This avoids ending up in cases where
we are neither EOS'd nor ERROR'd out from a pipeline point of view.

https://bugzilla.gnome.org/show_bug.cgi?id=774846
2016-11-22 18:21:46 +01:00
Thibault Saunier
3e27368ce3 Use the new API to post flow ERROR messages on the bus
https://bugzilla.gnome.org/show_bug.cgi?id=770158
2016-08-26 19:23:28 -03:00
Thibault Saunier
40dbcd1b3e meson: Link asfdemux against the gstsdp library 2016-08-24 09:45:05 -03:00
Nirbheek Chauhan
c8260a1545 Add support for Meson as alternative/parallel build system
https://github.com/mesonbuild/meson

With contributions from:

Tim-Philipp Müller <tim@centricular.com>
Jussi Pakkanen <jpakkane@gmail.com> (original port)

Highlights of the features provided are:
* Faster builds on Linux (~40-50% faster)
* The ability to build with MSVC on Windows
* Generate Visual Studio project files
* Generate XCode project files
* Much faster builds on Windows (on-par with Linux)
* Seriously fast configure and building on embedded

... and many more. For more details see:

http://blog.nirbheek.in/2016/05/gstreamer-and-meson-new-hope.html
http://blog.nirbheek.in/2016/07/building-and-developing-gstreamer-using.html

Building with Meson should work on both Linux and Windows, but may
need a few more tweaks on other operating systems.
2016-08-20 11:29:37 +01:00
Carlos Rafael Giani
975f147abe asfdemux: Add byte rate based bitrate tag in case there are no audio props
https://bugzilla.gnome.org/show_bug.cgi?id=769418
2016-08-02 14:41:31 +03:00
Vootele Vesterblom
6ff1c761e4 asfdemux: fix seeking back after EOS has been reached in push mode
Fix seeking when demuxer is in INDEX state. This happens when we
reached the end of the stream. It should still be possible to do
a flushing seek and seek back to any other position though. Instead
the demuxer would just go straight to EOS again instead of going
back to processing packets again from the new position.

https://bugzilla.gnome.org/show_bug.cgi?id=749066
2016-05-27 17:18:32 +01:00
Vineeth TM
eacdaa56b3 ugly: use new gst_element_class_add_static_pad_template()
https://bugzilla.gnome.org/show_bug.cgi?id=763082
2016-03-24 14:38:13 +02:00
Edward Hervey
dba14178ce asfdemux: Don't modify segment values on accurate seeks
When dealing with accurate seeks, we want to return exactly the segment
that was requested by the seek event, and not adjust the values.

https://bugzilla.gnome.org/show_bug.cgi?id=755469
2016-03-08 12:27:36 +01:00
Tim-Philipp Müller
62f5601723 asfdemux: fix adding bitrate to stream tags
https://bugzilla.gnome.org/show_bug.cgi?id=699586
2016-02-22 22:08:12 +00:00
Tim-Philipp Müller
f1bb44460d win32: remove outdated build cruft
This hasn't been touched for generations, doesn't work,
and is just causing confusion. We also don't want to
maintain these files manually.
2016-02-21 10:11:12 +00:00
Ravi Kiran K N
9ee60482b2 asfdemux: Support reverse playback
Support reverse playback for ASF format.
Parse packets and queue the payloads, then push
the payload buffer to decoder in reverse order.
Video buffers are pushed from KeyFrame to next
Keyframe.

https://bugzilla.gnome.org/show_bug.cgi?id=757341
2016-01-04 16:13:03 -05:00
Sebastian Dröge
738e48ef49 asfdemux: Don't push any data on pads after the segment.stop
https://bugzilla.gnome.org/show_bug.cgi?id=755469
2015-09-25 23:53:47 +02:00
Sebastian Dröge
155c8fc6a6 asfdemux: Only change segment start to a keyframe for KEYUNIT seeks
Not for accurate seeks, which should accurately start at the requested
position.

https://bugzilla.gnome.org/show_bug.cgi?id=755469
2015-09-25 23:53:47 +02:00
Sebastian Dröge
f501188191 asfdemux: Update segment.position when pushing buffers
Without this, non-flushing seeks are not going to work well.

https://bugzilla.gnome.org/show_bug.cgi?id=755469
2015-09-25 23:53:47 +02:00
Sebastian Dröge
c526153ec9 asfdemux: Only push EOS event if we're not doing a segment seek
https://bugzilla.gnome.org/show_bug.cgi?id=755469
2015-09-25 23:53:47 +02:00
Sebastian Dröge
42d7aec412 asfdemux: If pushing buffers returned EOS, go into the EOS and not failure code path
We don't want to unconditionally send an EOS event downstream, but might want
to send a SEGMENT_DONE message/event instead if a segment seek was done
before.

https://bugzilla.gnome.org/show_bug.cgi?id=755469
2015-09-25 23:53:47 +02:00
Tim-Philipp Müller
b41376aba2 asfdemux: fix file mode of some source files 2015-08-28 19:18:32 +01:00
Vineeth TM
5e7d0a8285 asfdemux: fix assertion error when codec_data is not present in structure
When discovering a particular asf file, caps structure doesn't have
codec_data, and this was not being checked before using the same,
resulting in assertion error

https://bugzilla.gnome.org/show_bug.cgi?id=752803
2015-07-30 13:40:09 +01:00
Luis de Bethencourt
171a1df6eb asfdemux: remove unread value
Init value of idx2 is never used. First usage sets it to idx + 1. Removing
initial value.
2015-07-29 15:56:42 +01:00
Olivier Crête
f2e0276ce4 asfdemux: Don't post error on flushing while reading headers 2015-07-25 14:38:40 -04:00