Edward Hervey
0711d4e163
gst-validate: Avoid overreading array
...
If we offset the argv table as argument, we need to decrement the number
of items in the array (argc) when iterating it
2016-05-19 12:07:57 +02:00
Thibault Saunier
621bda9b62
validate: Use GstValidate logging system to print buffering avancement
...
So it can be used in the launcher.
And make sure to properly parse the info in the launcher.
2016-03-21 14:34:27 +01:00
Thibault Saunier
3657e7867f
validate: Namespace all our structures and objects
...
Making GI a bit happier.
Those are not stable API anyway...
Differential Revision: https://phabricator.freedesktop.org/D704
2016-02-23 11:46:58 +01:00
Thibault Saunier
8c760b0a0e
validate: Turn GstValidateRunner into a GstTracer
...
This way we do not need the LD_PRELOAD hack anymore
Add a new libgstvalidateplugin GStreamer plugin, making sure it shares
the exact same code as the library (exposing only the wanted symbols).
Fix the way we set where to install GstValidate plugins
Try to keep backward compatibility even if tracers should never be instantiated
after an GstElement has been instantiated.
Differential Revision: https://phabricator.freedesktop.org/D459
2016-02-23 11:46:32 +01:00
Edward Hervey
4e2c7af46c
tools: Fix relative track switching
...
I have no idea where that "-2" came from, but it was obviously wrong.
Just use modulo "total number of streams" to get the proper track id.
2016-01-21 14:30:46 +01:00
Vineeth T M
d57fca241a
validate: Fix memory leaks when context parse fails
...
When g_option_context_parse fails, context and error variables are not getting free'd
which results in memory leaks. Free'ing the same.
And replacing g_error_free with g_clear_error, which checks if the error being passed
is not NULL and sets the variable to NULL on free'ing.
https://bugzilla.gnome.org/show_bug.cgi?id=753862
2015-11-11 10:12:49 +01:00
Vineeth TM
5c0c42ed6d
validate:tools: set locale to all and change argument to FILENAME
...
When file name consists of characters from other languages, say korean,
then it throws an error
Error initializing: Invalid byte sequence in conversion input
Hence setting locale to all to fix this.
And changing the media-info argument to type G_OPTION_ARG_FILENAME
https://bugzilla.gnome.org/show_bug.cgi?id=753486
2015-10-02 17:32:19 +02:00
Sebastian Dröge
403b236426
validate: Don't override the target state of the scenario when receiving BUFFERING=100%
...
If the scenario handles the states and wants to stay in PAUSED, it's not a
good idea to change the state to PLAYING when receiving BUFFERING=100%. This
caused a race condition in varios seeking tests, most often in the dash scrub
seeking test.
2015-08-17 14:27:33 +02:00
Vineeth TM
c91ed016b1
validate:tools: set locale to all and change argument to FILENAME
...
When file name consists of characters from other languages, say korean,
then it throws an error
Error initializing: Invalid byte sequence in conversion input
Hence setting locale to all to fix this.
And changing the media-info argument to type G_OPTION_ARG_FILENAME
https://bugzilla.gnome.org/show_bug.cgi?id=752945
2015-07-30 14:06:41 +01:00
Thibault Saunier
dfe29c56e5
validate 🏃 Add a method to force exiting the runner
...
This method is similar to runner_printf() but can be used
only once. The user needs to make sure all the pipeline
are in NULL state when this is called.
The method emits a "STOPPING" signal and at that point
overrides or monitors should do extra processing/checks if
needed.
+ Make use of it everywhere where it makes sense.
API:
gst_validate_runner_exit
GstValidateRunner::stopping signal
2015-06-06 08:50:47 +02:00
Guillaume Desmottes
92fa2b5681
validate: add gst_validate_deinit()
...
Reviewers: thiblahute
Differential Revision: http://phabricator.freedesktop.org/D159
2015-05-11 21:55:24 +02:00
Thibault Saunier
101ed96b5a
validate:tools: EOS handling is the responsibility of the scenario
...
Summary: If any scenario set
Reviewers: Mathieu_Du
Differential Revision:
http://phabricator.freedesktop.org/D90
2015-04-13 11:27:08 +02:00
Guillaume Desmottes
5456ddbae0
call gst_deinit() when we are done
...
More valgrind friendly.
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
a35614d108
validate: call gst_bus_remove_signal_watch()
...
We are supposed to call gst_bus_remove_signal_watch() for each gst_bus_add_signal_watch() call to prevent leaks.
2015-03-23 13:41:03 +01:00
Guillaume Desmottes
08a9034576
validate: fix string arguments leaks
...
We are responsible of freeing the string arguments parsed by GOptionContext.
2015-03-20 12:15:03 +01:00
Thibault Saunier
bee292f548
validate: Wait for switch-track to complete before executing next action
...
This action type can take some time, we need to make sure that the
combiner/input-selector element properly pushed a buffer marked
as DISCONT to concider the action is done.
https://bugzilla.gnome.org/show_bug.cgi?id=743994
2015-02-14 16:32:08 +01:00
Thibault Saunier
1bc32a888f
validate: Avoid assert removing an already removed signal handler
...
And, make sure that we set the return value != 0 when we receive
SIGINT
2014-12-05 20:51:44 +01:00
Thibault Saunier
130a2892b1
validate: print execution of set_subtitles actions
2014-12-05 19:23:43 +01:00
Thibault Saunier
c5dfd9c8c8
validate: Add a way to pass a MediaDescriptor around monitors
...
And add an option in gst-validate so that the user can define what
media descriptor file to use.
https://bugzilla.gnome.org/show_bug.cgi?id=736138
2014-10-21 20:14:05 +02:00
Thibault Saunier
02ab99fcbb
validate: Rename gst_validate_add_action_type to gst_validate_register_action_type
...
The _register naming corresponds much better to what the method does
and makes it more similar to how we refer to this kind of action in
GStreamer.
It is a last minute API change, but that API should not change anymore
after 1.4 is released.
2014-10-12 20:10:19 +02:00
Thibault Saunier
8289f64904
validate: Rename --list-action-types to --inspect-action-type
...
Making clearer the meaning of the parameter and closer to the
usual naming in the GStreamer land.
2014-10-12 19:46:39 +02:00
Thibault Saunier
3755581fd3
validate: Take a const gchar ** in gst_validate_print_action_types
...
This is what we actually need and thus is cleaner.
2014-09-05 23:15:29 +02:00
Thibault Saunier
69165a9f04
validate: Implement the notion of implementer namespace to the action types
...
This allows users to know who implements an action type.
+ Enhance the printing of all action making it readable.
2014-09-05 23:03:58 +02:00
Thibault Saunier
15f52d4fa3
validate: Add informations on the switch-track action overrided for playbin
2014-09-05 19:30:52 +02:00
Thibault Saunier
34fd5af840
validate: docs: Add some GstValidate usage documentation
...
+ Fix minor issues in the gst-validate and gst-validate-transcoding
tools documentation
2014-09-05 19:00:23 +02:00
Thibault Saunier
4fd1939b21
validate: Rework the action parameter API
...
Making it possible to properly define parameters, and describe them.
+ Document all action types!
2014-09-05 19:00:23 +02:00
Thibault Saunier
d29a8e4a77
validate: Add an option to print all avalaible actions with details
...
+ Cleanup actions descriptions
+ Make GstValidateActionType internal only and only expose the structure
2014-09-05 19:00:23 +02:00
Thibault Saunier
45e6d86c92
validate: Use the buffering mode to see if pipeline is live or not
2014-09-05 19:00:23 +02:00
Anuj Jaiswal
eb16061fa9
gst-validate: fix some minor memory leaks
...
https://bugzilla.gnome.org/show_bug.cgi?id=735099
2014-08-23 11:57:12 +01:00
Thibault Saunier
161610c26e
validate: Print when we set pipeline state because of buffering
2014-08-12 13:17:20 +02:00
Thiago Santos
d7c3d652d0
gst-validate: properly set pipeline to null before unref
...
In case it fails when going ready->paused it will remain in ready state
and be unref'd in ready, leading to an assertion
2014-07-21 22:01:27 -03:00
Thibault Saunier
7d695fbed4
validate: Dot the pipeline on interuption
2014-07-19 09:48:17 +02:00
Thibault Saunier
f6884a5a54
validate: Do not auto flush pipeline bus
...
We want to see all messages in our async handler
And flush it when we are done.
2014-07-17 12:17:31 +02:00
Thibault Saunier
87ae465c77
validate: Let scenarios tell the apps about whether it handles states
...
The user only needs to add handles-states=true in the description line
of the scenario
2014-07-07 11:27:34 +02:00
Thibault Saunier
3607fd8deb
validate: Print the return value at the end
...
Making it easier to know whether the test passed or not.
2014-07-07 11:27:34 +02:00
Thibault Saunier
5c85e4500d
validate:tools: Dot the pipeline on usefull places
...
Meaning on warning and state changes.
2014-07-07 11:27:34 +02:00
Edward Hervey
ca44a11429
validate: Run gst-indent on all code
...
so whitespace. much indent. spacing !
2014-06-03 10:05:25 +02:00
Thibault Saunier
49ab41743b
validate: The 'buffering' variable needs to be static
...
We need its value between bus_callback calls to be the same
2014-05-04 09:30:16 +02:00
Luis de Bethencourt
eabcf8f106
gst-validate: some static variables can be local
...
buffering is only used inside the bus_callback, so it can have that local
scope. same thing with ret which is only used in the main function.
2014-05-02 17:25:07 -04:00
Luis de Bethencourt
0b01b578ce
gst-validate: small typo in usage summary
2014-05-02 16:53:51 -04:00
Thibault Saunier
5d200f8819
validate: Add a scenario that disable subtitles
...
+ Clean the sythax to define switch-track action that actually
desactivate the track
2014-05-02 18:30:23 +02:00
Thibault Saunier
1ffb6b4e1c
validate: Allow specifying scenarios to parse when lisiting them
...
It used to only handle the scenario present in proper paths, we
also need to handle special scenarios provided by users on the fly
2014-05-02 18:30:22 +02:00
Thibault Saunier
f165fb41d0
validate: Handle ERROR on the bus when monitoring the pipeline
...
This way the user get a clear information in the report about the issue
+ sensibly cleanup code
2014-05-02 18:30:22 +02:00
Thibault Saunier
a62560bc81
validate: Add an action to set an external URI file on playbin at runtime
2014-05-02 18:30:22 +02:00
Thibault Saunier
2a9e0824b2
validate: Override switch_track action when using a playbin
...
And use the playbin feature for that when the pipeline is based on playbin
2014-05-02 18:30:22 +02:00
Thibault Saunier
2d7d03d2f7
validate: Add a 'stop' action to stop a pipeline
...
It uses the GST_MESSAGE_REQUEST state with the scenario as a source
so that application can stop running when they receive it on the bus.
2014-04-25 14:33:06 +02:00
Thibault Saunier
38eda37341
validate: Handle position printing at the monitor level
...
Instead of replicating that code all around
2014-04-23 11:27:44 +02:00
Thibault Saunier
7f54c5dba8
validate:launcher: Always set sync=True on fakesink on playback pipelines
...
This way we are in closer condition of real sink playback.
+ some minor cleanup in gst-validate.c
2014-04-22 09:42:59 +02:00
Thibault Saunier
ad25b4d160
validate: Handle g_log errors at the gst-validate level
2014-04-17 12:23:04 +02:00
Thibault Saunier
6d8ff8a92a
tools:validate: Start printing position on ASYNC_DONE
...
As this is what is done in the scenarios.
2014-03-19 17:45:36 +01:00