Commit graph

149 commits

Author SHA1 Message Date
Sebastian Dröge
9931635e13 lame: Update example pipelines with the new properties 2009-05-04 11:18:14 +02:00
Sebastian Dröge
27c557c988 lame: Add lamemp3enc element with much simplified interface
This deprecates the lame element and fixes bug #494528.
2009-05-04 11:18:14 +02:00
Edward Hervey
c02f6b9092 lame: Remove unneeded variable, it's assigned a value never read. 2009-04-19 14:02:03 +02:00
Stefan Kost
d081a77016 Don't install static libs for plugins. Fixes #550851 for ugly.
Original commit message from CVS:
* ext/a52dec/Makefile.am:
* ext/amrnb/Makefile.am:
* ext/cdio/Makefile.am:
* ext/dvdnav/Makefile.am:
* ext/dvdread/Makefile.am:
* ext/lame/Makefile.am:
* ext/mad/Makefile.am:
* ext/mpeg2dec/Makefile.am:
* ext/sidplay/Makefile.am:
* gst/ac3parse/Makefile.am:
* gst/asfdemux/Makefile.am:
* gst/dvdlpcmdec/Makefile.am:
* gst/dvdsub/Makefile.am:
* gst/iec958/Makefile.am:
* gst/mpegaudioparse/Makefile.am:
* gst/mpegstream/Makefile.am:
* gst/realmedia/Makefile.am:
* gst/synaesthesia/Makefile.am:
Don't install static libs for plugins. Fixes #550851 for ugly.
2008-10-13 18:10:25 +00:00
Frederic Crozat
03141f0ff6 Make sure gettext returns translations in UTF-8 encoding rather than in the current locale encoding (#546822).
Original commit message from CVS:
Patch by: Frederic Crozat <fcrozat@mandriva.org>
* ext/dvdread/dvdreadsrc.c: (plugin_init):
* ext/lame/gstlame.c: (plugin_init):
* gst/asfdemux/gstasf.c: (plugin_init):
Make sure gettext returns translations in UTF-8 encoding rather
than in the current locale encoding (#546822).
2008-08-07 16:14:42 +00:00
Sebastian Dröge
ee74e87e50 ext/lame/gstlame.c: Use the default for the strict-iso property too.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_class_init),
(gst_lame_get_default_settings):
Use the default for the strict-iso property too.
Allow a bitrate setting of 0, which lets lame choose the default value
and which makes it possible to set the compression-ratio property.
2008-07-31 14:24:27 +00:00
Sebastian Dröge
252e387a89 ext/lame/gstlame.*: Get the defaults settings of LAME in the plugin initialization function and return FALSE here if ...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init),
(gst_lame_chain), (gst_lame_get_default_settings), (plugin_init):
* ext/lame/gstlame.h:
Get the defaults settings of LAME in the plugin initialization
function and return FALSE here if something goes wrong. This removes
the hacky failing instance init function.
Use LAMEs default value for all settings instead of overwriting some
of them. Overwriting some of them gives unexpected results if one only
sets a preset. Fixes bug #498004.
2008-07-29 16:57:16 +00:00
Sebastian Dröge
82c528d3ca ext/lame/gstlame.c: Use LAME's default for the min/max/mean VBR bitrate. Setting our own defaults will restrict the b...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_init):
Use LAME's default for the min/max/mean VBR bitrate. Setting our own
defaults will restrict the bitrate when using the presets in a bad way.
Fixes bug #498004.
2008-07-27 15:56:27 +00:00
Sebastian Dröge
adc231d2de Put the MPEG audio version into the caps as "mpegaudioversion".
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps):
* gst/mpegaudioparse/gstmpegaudioparse.c:
(mp3_type_frame_length_from_header), (mp3_caps_create),
(gst_mp3parse_chain):
Put the MPEG audio version into the caps as "mpegaudioversion".
This is different from "mpegversion".
2008-07-27 11:01:12 +00:00
Sebastian Dröge
0dd879921c ext/lame/gstlame.*: Fix build with lame >= 3.97. The padding type and cwlimit settings are deprecated now and the fun...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init),
(gst_lame_set_property), (gst_lame_get_property), (gst_lame_setup):
* ext/lame/gstlame.h:
Fix build with lame >= 3.97. The padding type and cwlimit settings
are deprecated now and the function declarations are hidden in the
headers so deprecate the GObject properties for them and remove them
in 0.11. Fixes bug #544039.
2008-07-22 18:25:08 +00:00
Stefan Kost
2c7dbc3ba7 Add missing elements to docs. Restore alphabetical order in section file. Document mad (it was included in docs alrea...
Original commit message from CVS:
* docs/plugins/gst-plugins-ugly-plugins-docs.sgml:
* docs/plugins/gst-plugins-ugly-plugins-sections.txt:
* ext/a52dec/gsta52dec.c:
* ext/amrnb/amrnbdec.c:
* ext/amrnb/amrnbenc.c:
* ext/amrnb/amrnbparse.c:
* ext/lame/gstlame.c:
* ext/mad/gstmad.c:
* ext/sidplay/gstsiddec.cc:
* gst/asfdemux/gstrtspwms.c:
* gst/mpegaudioparse/gstxingmux.c:
* gst/realmedia/rademux.c:
* gst/realmedia/rdtmanager.c:
* gst/realmedia/rtspreal.c:
* gst/synaesthesia/gstsynaesthesia.c:
Add missing elements to docs. Restore alphabetical order in section
file. Document mad (it was included in docs already).
Fix doc-markup: use convinience syntax for examples
(produces valid docbook), add several refsec2 when we have several
titles. Fix some types.
2008-06-13 06:57:21 +00:00
Stefan Kost
48d3413591 Do not use short_description in section docs for elements. We extract them from element details and there will be war...
Original commit message from CVS:
* ext/lame/gstlame.c:
* ext/sidplay/gstsiddec.cc:
* gst/mpegaudioparse/gstxingmux.c:
Do not use short_description in section docs for elements. We extract
them from element details and there will be warnings if they differ.
2008-06-13 05:52:17 +00:00
Tim-Philipp Müller
f1a4df75f6 ext/lame/gstlame.c: Fix broken GST_ELEMENT_ERROR macro, fixes compile with the Sun
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps):
Fix broken GST_ELEMENT_ERROR macro, fixes compile with the Sun
Workshop 12 compiler, but probably also crashes (#517985).
2008-02-22 14:55:57 +00:00
Sebastian Dröge
64b5df4dba ext/lame/gstlame.c: Don't leak the allowed caps.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_setup):
Don't leak the allowed caps.
* tests/check/pipelines/lame.c: (GST_START_TEST):
Stop leaking all buffers. Fixes bug #515575.
2008-02-11 09:13:33 +00:00
Zaheer Abbas Merali
b1a031b960 ext/lame/gstlame.*: Fix the case where you initially have stereo input, and so lame's mode is not set to mono, and th...
Original commit message from CVS:
* ext/lame/gstlame.c:
* ext/lame/gstlame.h:
Fix the case where you initially have stereo input, and so lame's
mode is not set to mono, and then you get input with mono audio and
soon after you get stereo input again. What happened before this
commit is that it would keep the encoding mode as mono. It should
change it back to the one requested by the app (or the default one)
if not requested.
2008-01-17 17:26:48 +00:00
Sebastian Dröge
9d87e1468b ext/lame/gstlame.c: Use gst_util_uint64_scale instead of gst_util_uint64_scale_int as 8 * GST_SECOND is too large for...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event):
Use gst_util_uint64_scale instead of gst_util_uint64_scale_int
as 8 * GST_SECOND is too large for int.
2008-01-14 11:24:57 +00:00
Mark Nauwelaerts
0e62059993 ext/lame/gstlame.c: Correctly set number of channels when using mono-encoding mode and fix the duration calculation o...
Original commit message from CVS:
Patch by: Mark Nauwelaerts <manauw at syknet dot be>
* ext/lame/gstlame.c: (gst_lame_sink_setcaps),
(gst_lame_sink_event):
Correctly set number of channels when using mono-encoding mode
and fix the duration calculation of the EOS buffer.
2008-01-14 09:17:47 +00:00
Tim-Philipp Müller
ead8e9facf ext/lame/gstlame.c: Fix up case where there is no peer, in which case _get_allowed_caps() will return NULL.
Original commit message from CVS:
* ext/lame/gstlame.c:
Fix up case where there is no peer, in which case
_get_allowed_caps() will return NULL.
2007-09-26 13:40:35 +00:00
Tim-Philipp Müller
8d9b031015 ext/lame/gstlame.c: Use GST_PTR_FORMAT to print caps in debug statement.
Original commit message from CVS:
* ext/lame/gstlame.c:
Use GST_PTR_FORMAT to print caps in debug statement.
2007-09-25 13:20:27 +00:00
Thomas Vander Stichele
74508a9f75 ext/lame/gstlame.c: Allow fixing the sample rate lame converts to by negotiating fixed sample rate on the src pad caps.
Original commit message from CVS:
* ext/lame/gstlame.c:
Allow fixing the sample rate lame converts to by negotiating fixed
sample rate on the src pad caps.
Add docs for it.
* tests/check/Makefile.am:
* tests/check/pipelines/lame.c:
Add a check for it.
2007-09-24 10:26:21 +00:00
Jan Schmidt
c39c53197c ext/lame/gstlame.c: Disable the bitrate checking when the user has requested
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_setup):
Disable the bitrate checking when the user has requested
Free Format mode, as all bitrates less than the maximum
are valid then.
2007-03-21 12:53:57 +00:00
Jan Schmidt
0e3f19744e ext/lame/gstlame.c: Display sensible defaults and limits for the vbr-min/max/mean properties. Fix the 'hard-limit' VB...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_class_init), (gst_lame_init),
(gst_lame_setup):
Display sensible defaults and limits for the
vbr-min/max/mean properties. Fix the 'hard-limit' VBR min
property - it's supposed to be a boolean 0/1 value.
2007-02-28 18:41:38 +00:00
Jan Schmidt
8974080b09 ext/lame/gstlame.c: Initialise the variables so gcc doesn't complain about possibly uninitialised uses, even though t...
Original commit message from CVS:
* ext/lame/gstlame.c:
Initialise the variables so gcc doesn't complain about possibly
uninitialised uses, even though they can't actually happen.
2007-02-28 16:01:08 +00:00
Thomas Vander Stichele
d092f55b65 ext/lame/gstlame.c: Fix up bitrate checking macro. Make it give us a
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps),
(gst_lame_set_property), (gst_lame_setup):
Fix up bitrate checking macro.  Make it give us a
GST_ELEMENT_WARNING message so the application has a chance of
reporting this to the user.  Move the checking to _setup, so we
are sure it runs in the READY state, when we hope to have a pipeline
and a bus that is not flushing.
This fixes e.g. using 96 kbit/sec as a bitrate.
2007-02-21 16:02:33 +00:00
Tim-Philipp Müller
16c774ff13 ext/lame/gstlame.*: On receiving EOS, we try to push a last buffer with the remaining samples. Don't do that if we go...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event), (gst_lame_chain),
(gst_lame_change_state):
* ext/lame/gstlame.h:
On receiving EOS, we try to push a last buffer with the remaining
samples. Don't do that if we got an unclean flow return on the last
gst_pad_push(), downstream might not handle this very gracefully
(see #403168).
* gst/mpegaudioparse/gstmpegaudioparse.c: (gst_mp3parse_chain):
Pass flow returns upstream (helps #403168).
2007-02-09 16:24:45 +00:00
Thomas Vander Stichele
26ee17bc28 ext/lame/gstlame.c: warn when outgoing sample rate is different from incoming
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps), (gst_lame_chain):
warn when outgoing sample rate is different from incoming
2006-12-30 20:01:35 +00:00
Roland Kay
90d92814d4 ext/lame/gstlame.*: Fix leak (by calling lame_init_params() before lame_close()); handle
Original commit message from CVS:
Based on patch by: Roland Kay  <roland.kay at ox compsoc net>
* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_chain),
(gst_lame_setup):
* ext/lame/gstlame.h:
Fix leak (by calling lame_init_params() before lame_close()); handle
NULL return from lame_init() more gracefully. Fixes #385311.
2006-12-14 10:15:24 +00:00
Wim Taymans
3f967e2e18 ext/lame/gstlame.*: Make lame timestamp flushed eos buffer by some additional timestamp accounting. Fixes #374760.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event), (gst_lame_chain),
(gst_lame_change_state):
* ext/lame/gstlame.h:
Make lame timestamp flushed eos buffer by some additional timestamp
accounting. Fixes #374760.
2006-11-14 10:29:37 +00:00
Tim-Philipp Müller
fef9929a06 ext/lame/gstlame.c: Round up not allowed bitrates to the next higher allowed one (Closes: #361140).
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_set_property):
Round up not allowed bitrates to the next higher allowed one
(Closes: #361140).
2006-10-13 14:45:11 +00:00
Tim-Philipp Müller
4b121d4b0d Add docs for lame and lame to docs. Specify allowed bitrates in the properties description (#361140). Canonicalise ob...
Original commit message from CVS:
* docs/plugins/Makefile.am:
* docs/plugins/gst-plugins-ugly-plugins-docs.sgml:
* docs/plugins/gst-plugins-ugly-plugins-sections.txt:
* ext/lame/gstlame.c: (gst_lame_class_init):
* ext/lame/gstlame.h:
Add docs for lame and lame to docs. Specify allowed bitrates
in the properties description (#361140). Canonicalise object
property names (ie. use hyphen instead of underscore).
* docs/plugins/inspect/plugin-a52dec.xml:
* docs/plugins/inspect/plugin-amrnb.xml:
* docs/plugins/inspect/plugin-asf.xml:
* docs/plugins/inspect/plugin-dvdlpcmdec.xml:
* docs/plugins/inspect/plugin-dvdread.xml:
* docs/plugins/inspect/plugin-dvdsub.xml:
* docs/plugins/inspect/plugin-iec958.xml:
* docs/plugins/inspect/plugin-lame.xml:
* docs/plugins/inspect/plugin-mad.xml:
* docs/plugins/inspect/plugin-mpeg2dec.xml:
* docs/plugins/inspect/plugin-mpegaudioparse.xml:
* docs/plugins/inspect/plugin-mpegstream.xml:
* docs/plugins/inspect/plugin-siddec.xml:
Update version to CVS.
2006-10-13 14:19:24 +00:00
Tim-Philipp Müller
da6dfba654 Add i18n magic to lame plugin. Throw decent error message when we fail to setup the encoder (#361140, 361151); misc. ...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_setcaps),
(gst_lame_set_property), (gst_lame_get_property), (gst_lame_chain),
(plugin_init):
* po/POTFILES.in:
Add i18n magic to lame plugin. Throw decent error message when we
fail to setup the encoder (#361140, 361151); misc. minor clean-ups.
2006-10-13 10:00:27 +00:00
Jan Schmidt
a4b48ed620 Add missing GST_LIBS to the link flags
Original commit message from CVS:
* ext/lame/Makefile.am:
* ext/mpeg2dec/Makefile.am:
* gst/dvdlpcmdec/Makefile.am:
* gst/dvdsub/Makefile.am:
* gst/mpegaudioparse/Makefile.am:
Add missing GST_LIBS to the link flags
2006-08-31 13:04:31 +00:00
Zaheer Abbas Merali
1bccf486c2 ext/lame/gstlame.c: Fix lame putting lots of 0's at start of mp3. Fixes bug #348786.
Original commit message from CVS:
2006-07-26  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

* ext/lame/gstlame.c: (gst_lame_setup):
Fix lame putting lots of 0's at start of mp3.  Fixes bug #348786.
2006-07-26 17:09:04 +00:00
Thomas Vander Stichele
4f1860aacb update build files
Original commit message from CVS:
* autogen.sh:
* configure.ac:
* ext/a52dec/Makefile.am:
* ext/dvdnav/Makefile.am:
* ext/dvdread/Makefile.am:
* ext/lame/Makefile.am:
* ext/mad/Makefile.am:
* ext/mpeg2dec/Makefile.am:
* ext/sidplay/Makefile.am:
update build files
2006-06-11 17:08:11 +00:00
Tim-Philipp Müller
04a9d7787e ext/lame/gstlame.*: Remove tag writing from lame (which was completely broken anyway, #329184). Leaving GstTagSetter ...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_get_type),
(gst_lame_release_memory), (gst_lame_init), (gst_lame_sink_event),
(gst_lame_setup), (gst_lame_change_state):
* ext/lame/gstlame.h:
Remove tag writing from lame (which was completely broken
anyway, #329184). Leaving GstTagSetter interface around for
now, albeit non-functional. Should be removed completely
in 0.11. Use the 'id3v2mux' plugin from -good for writing
tags.
2006-05-06 11:38:30 +00:00
Andres Salomon
4dba1fe993 ext/lame/gstlame.c: Fix typo (comma vs. semicolon) (#340710).
Original commit message from CVS:
Patch by: Andres Salomon  <dilinger at debian org>
* ext/lame/gstlame.c: (gst_lame_sink_event):
Fix typo (comma vs. semicolon) (#340710).
2006-05-05 08:23:39 +00:00
Ed Catmur
c9c991563e ext/lame/gstlame.c: Don't crash if we get an EOS event before the encoder has been set up (#339287).
Original commit message from CVS:
Patch by: Ed Catmur  <ed at catmur dot co dot uk>
* ext/lame/gstlame.c: (gst_lame_sink_event):
Don't crash if we get an EOS event before the encoder
has been set up (#339287).
2006-04-21 12:40:41 +00:00
Thomas Vander Stichele
6b137b65ea configure.ac: rework similarly to other modules
Original commit message from CVS:

* configure.ac:
rework similarly to other modules
* ext/a52dec/gsta52dec.c:
* ext/amrnb/amrnb.c:
* ext/dvdnav/dvdnavsrc.c:
* ext/dvdread/dvdreadsrc.c:
* ext/lame/gstlame.c:
* ext/mad/gstid3tag.c:
* ext/mpeg2dec/gstmpeg2dec.c:
* ext/sidplay/gstsiddec.cc:
* gst/asfdemux/gstasf.c:
* gst/dvdlpcmdec/gstdvdlpcmdec.c:
* gst/dvdsub/gstdvdsubdec.c:
* gst/iec958/ac3iec.c:
* gst/mpegaudioparse/gstmpegaudioparse.c:
* gst/mpegstream/gstmpegstream.c:
* gst/realmedia/rmdemux.c: (plugin_init):
use the correct defines
2006-04-01 09:54:39 +00:00
Tim-Philipp Müller
f3c0790eba ext/lame/gstlame.*: Make xingheader property non-functional, it's broken anyway after all (use xingmux instead).
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_set_property),
(gst_lame_get_property), (gst_lame_setup):
* ext/lame/gstlame.h:
Make xingheader property non-functional, it's broken anyway
after all (use xingmux instead).
2006-03-28 16:06:05 +00:00
Tim-Philipp Müller
d35582a50b ext/lame/gstlame.c: On EOS, flush encoder and send remaining data. Fix return value handling in sink event function.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event):
On EOS, flush encoder and send remaining data. Fix
return value handling in sink event function.
2006-03-28 15:10:18 +00:00
Christophe Fergeau
31b41270ac ext/lame/gstlame.c: use GST_DEBUG_FUNCPTR more often.
Original commit message from CVS:
Patch by: Christophe Fergeau  <teuf gnome org>
* ext/lame/gstlame.c: (gst_lame_release_memory),
(gst_lame_finalize), (gst_lame_class_init),
(gst_lame_sink_setcaps), (gst_lame_init), (gst_lame_sink_event),
(gst_lame_change_state):
Fix some memory leaks (#333345), use GST_DEBUG_FUNCPTR more often.
2006-03-15 13:43:42 +00:00
Christophe Fergeau
0b227dccec ext/lame/gstlame.c: mark the xing-header property as BROKEN (see http://bugzilla.gnome.org/show_bug.cgi?id=330317#c19...
Original commit message from CVS:
2006-03-12  Christophe Fergeau  <teuf@gnome.org>

Reviewed by: Tim-Philipp Müller  <tim at centricular dot net>

* ext/lame/gstlame.c: (gst_lame_class_init): mark the xing-header
property as BROKEN (see
http://bugzilla.gnome.org/show_bug.cgi?id=330317#c19 for an
explanation why it's broken).
2006-03-12 11:00:33 +00:00
Wim Taymans
f580c21add ext/lame/gstlame.c: Fix up lame a bit.
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_init), (gst_lame_chain),
(gst_lame_change_state):
Fix up lame a bit.
Apply patch #319782 by Gautier Portet.
2006-02-16 17:16:06 +00:00
Tim-Philipp Müller
d99d2bc9c2 ext/lame/gstlame.*: Contrary to what the const char in the lame API might suggest, lame expects us to keep the string...
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_finalize), (gst_lame_class_init),
(gst_lame_init), (add_one_tag), (gst_lame_set_metadata):
* ext/lame/gstlame.h:
Contrary to what the const char in the lame API might suggest,
lame expects us to keep the strings we pass to id3tag_set_foo()
around; it doesn't free them either though, so we have to store
them somewhere and free them later when we can be sure lame
doesn't need them any longer.
2006-01-23 18:37:16 +00:00
Tim-Philipp Müller
1bea0573bb ext/lame/gstlame.c: don't pass an uninitialised string pointer to lame if we don't know how to handle the tag type, a...
Original commit message from CVS:
* ext/lame/gstlame.c: (add_one_tag):
Fix handling of GST_TAG_DATE (#311679), don't pass an
uninitialised string pointer to lame if we don't know
how to handle the tag type, and fix minor memory leak.
2006-01-23 15:02:04 +00:00
Thomas Vander Stichele
28d6fa1937 expand tabs
Original commit message from CVS:
expand tabs
2005-12-06 19:48:07 +00:00
Thomas Vander Stichele
53e458f799 doh
Original commit message from CVS:
doh
2005-11-22 17:15:25 +00:00
Thomas Vander Stichele
e12465aa42 fix up GValueEnum
Original commit message from CVS:
fix up GValueEnum
2005-11-22 17:04:38 +00:00
Andy Wingo
9e6d73f2df Update for gst_tag_setter API changes.
Original commit message from CVS:
2005-11-22  Andy Wingo  <wingo@pobox.com>

* Update for gst_tag_setter API changes.
2005-11-22 12:39:29 +00:00
Edward Hervey
fda997a953 ext/lame/gstlame.c: Don't take the stream lock
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_sink_event):
Don't take the stream lock
2005-11-21 23:50:02 +00:00