Commit graph

194 commits

Author SHA1 Message Date
Justin Kim
8100d781b7 x264enc: add 'insert-vui' property for users to choose
VUI(Video Usability Information) parameters should be set
according to the specification. However, some of the existing
hardware decoders refuse to decode in certain combinations of
the resolution and VUI parameters. To support the legacy
decoders, this patch provides 'insert-vui' to skip the settings.

https://bugzilla.gnome.org/show_bug.cgi?id=791331
2017-12-08 15:40:47 -05:00
Mark Nauwelaerts
fc826ac6dc x264enc: add FIXME note for future configuration cleanup 2017-08-09 19:31:56 +02:00
Tim-Philipp Müller
0d73cb55b1 x264enc: fix indentation 2017-07-15 15:01:09 +01:00
Tim-Philipp Müller
58a23c99e9 x264enc: fix caps leak
Move creation of supported sink pads into class_init function
which is also the only place where they're used. Unref the
caps when no longer needed, the pad template will take its
own ref.

https://bugzilla.gnome.org/show_bug.cgi?id=784982
2017-07-15 14:59:42 +01:00
Mark Nauwelaerts
7074d31cb6 x264enc: relax bframes upper limit count to maximum encoder supported 2017-06-24 17:52:09 +02:00
Víctor Manuel Jáquez Leal
c15a00537f x264: fix memory leak
When the allowed caps are the same of template caps the allowed
caps are not unrefed, leaking memory.

https://bugzilla.gnome.org/show_bug.cgi?id=784060
2017-06-21 21:26:53 +02:00
Nicolas Dufresne
d02e7d8029 Remove plugin specific static build option
Static and dynamic plugins now have the same interface. The standard
--enable-static/--enable-shared toggle are sufficient.
2017-05-16 14:07:56 -04:00
Nirbheek Chauhan
c6a0026137 x264: Use __declspec(dllimport) with MinGW too
x264.h says this isn't needed with MinGW, but it looks like it is.

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=779249
2017-04-27 12:20:42 +03:00
Nirbheek Chauhan
184351ae48 x264: Initialize function vtable in plugin_init()
These values are defined in the x264.h header and are not const on
Windows due to the way DLLs work. See:
https://msdn.microsoft.com/en-us/library/619w14ds.aspx
https://msdn.microsoft.com/en-us/library/zw3za17w.aspx

https://bugzilla.gnome.org/show_bug.cgi?id=777903
2017-02-01 12:38:01 +02:00
Thibault Saunier
8d045b4197 meson: Install presets files 2017-01-03 08:15:43 -03:00
Mathieu Duponchelle
31e9641c4a x264enc: Add a youtube preset.
Based on https://support.google.com/youtube/answer/1722171

https://bugzilla.gnome.org/show_bug.cgi?id=751560
2017-01-03 08:15:43 -03:00
Vivia Nikolaidou
c40b40b36f x264enc: Add information for mixed mode
https://bugzilla.gnome.org/show_bug.cgi?id=775411
2016-11-30 18:54:20 +02:00
Vivia Nikolaidou
dae49907e2 x264enc: Correctly pass interlacing/TFF information
Give the interlacing information correctly to the encoder. Also parse
TFF/BFF information from the caps and pass it too.

https://bugzilla.gnome.org/show_bug.cgi?id=775411
2016-11-30 18:54:20 +02:00
Vivia Nikolaidou
f7d82312bb x264enc: Auto-detect interlace mode from caps
If the caps are interlaced, interlacing is always enabled on the
encoder. If the interlace-mode field is missing or if it's progressive,
the encoder uses the "interlaced" property.

https://bugzilla.gnome.org/show_bug.cgi?id=775228
2016-11-28 15:22:44 +02:00
Sebastian Dröge
7bf576b238 x264enc: Add configure parameter to specify additional x264 libraries with e.g. different depth configuration
x264 has to be compiled specifically for a target bit depth.
Distributions currently ship various libraries in their packages, with
different bit depths.

This change now allows to provide them all at configure time and have
the x264enc element dynamically switch between them based on the bit
depth of the input format.

https://bugzilla.gnome.org/show_bug.cgi?id=763297
2016-11-14 18:26:04 +02:00
Sebastian Dröge
590aa41bf5 x264enc: Set colorimetry and chroma-site information
https://bugzilla.gnome.org/show_bug.cgi?id=772159
2016-09-29 12:39:56 +03:00
Nirbheek Chauhan
c8260a1545 Add support for Meson as alternative/parallel build system
https://github.com/mesonbuild/meson

With contributions from:

Tim-Philipp Müller <tim@centricular.com>
Jussi Pakkanen <jpakkane@gmail.com> (original port)

Highlights of the features provided are:
* Faster builds on Linux (~40-50% faster)
* The ability to build with MSVC on Windows
* Generate Visual Studio project files
* Generate XCode project files
* Much faster builds on Windows (on-par with Linux)
* Seriously fast configure and building on embedded

... and many more. For more details see:

http://blog.nirbheek.in/2016/05/gstreamer-and-meson-new-hope.html
http://blog.nirbheek.in/2016/07/building-and-developing-gstreamer-using.html

Building with Meson should work on both Linux and Windows, but may
need a few more tweaks on other operating systems.
2016-08-20 11:29:37 +01:00
Nirbheek Chauhan
5ae5b2d3c7 plugins: Use <stdint.h> instead of _stdint.h
_stdint.h is generated by Autotools and we don't really need it. All
supported platforms now ship with stdint.h. The only stickler was MSVC,
and since Visual Studio 2015 it also ships stdint.h now.
2016-08-19 13:03:29 +01:00
Vineeth TM
eacdaa56b3 ugly: use new gst_element_class_add_static_pad_template()
https://bugzilla.gnome.org/show_bug.cgi?id=763082
2016-03-24 14:38:13 +02:00
Arjen Veenhuizen
f037e7e59e x264enc: increase bitrate limit from 100Mbps to 2Gbps
Don't artificially limit the bitrate, x264enc allows much
higher bitrates, and for intra-only 4k AVC they are needed.
x264 clips to 2Gbps internally, so use that as limit for now.

https://bugzilla.gnome.org/show_bug.cgi?id=758620
2015-11-26 15:49:47 +00:00
Reynaldo H. Verdejo Pinochet
7d7bab4640 x264enc: drop unnecessary NULL check before g_free 2015-11-18 23:20:59 -08:00
Jan Schmidt
05aa763561 x264: Add bitrate info to the tags output.
Makes it possible for muxers to know the target bitrate as soon
as encoding starts, which flvmux now uses.
2015-09-05 23:34:45 +10:00
Thiago Santos
7fef2de2d8 x264enc: actually return TRUE from accept-caps handler
The query was handled
2015-08-18 02:23:55 -03:00
Thiago Santos
ba5e19706d x264enc: implement accept-caps handling
Implement accept-caps handling without doing caps queries downstream
2015-08-16 14:27:44 -03:00
Matej Knopp
43d6ca85a0 x264enc: Use gst_video_encoder_set_min_pts
This method replace the manual adjustment of PTS and DTS to avoid
negative DTS issues. Using this method will also update the segment so
we don't loos sync.

https://bugzilla.gnome.org/show_bug.cgi?id=740575
2015-06-11 10:29:25 -04:00
Jan Schmidt
c6958c158f x264enc: Add support for stereoscopic video
Provide new frame-packing property to directly set
x264enc frame packing, or pass through upstream settings

The explicit layout from the frame-packing property is
preferred over any info from the caps.
2015-06-11 11:01:38 +10:00
Tim-Philipp Müller
c3c306b486 x264enc: don't artificially limit max allowed value of "threads" property
In auto mode it will happily chose much higher values anyway,
and a limit of 4 seems a bit low these days.
2015-05-26 17:58:18 +01:00
Tim-Philipp Müller
f034f77b73 docs: update example pipelines in element docs
Mostly gst-launch -> gst-launch-1.0, but also
use autoaudiosink/autovideosink in more places
and update pipelines a little or flesh out
descriptions.
2015-05-10 11:34:33 +01:00
Tim-Philipp Müller
19fd6f240d Remove obsolete Android build cruft
This is not needed any longer.
2015-04-26 17:56:31 +01:00
Sebastian Dröge
7dc03df3de Improve and fix LATENCY query handling
This now follows the design docs everywhere, especially the maximum latency
handling.

https://bugzilla.gnome.org/show_bug.cgi?id=744106
2015-02-11 13:56:48 +01:00
Sebastian Dröge
5dd1a28906 x264enc: Don't set max latency to the same value as the encoder latency
The meaning of the max latency is *not* the maximum latency this element will
introduce. It is the maximum latency this element can endure without
overflowing any buffers, which is infinite for x264enc.

Fixes latency configuration in zero latency mode, where max latency was
becoming 0... which usually won't work well if something else introduces
latency as then max < min in the end, and latency configuration just fails.
2015-02-06 19:04:32 +01:00
Vincent Penquerc'h
5f075f3361 x264enc: set annexb=1 in byte stream mode when downstream has ANY caps
This matches what is done when downstream caps are not ANY, and fixes
prerolling in byte stream mode when typefind is downstream.
2015-02-02 14:28:33 +00:00
Nicolas Dufresne
acc9529a36 x264enc: Don't set an allocation maximum
There is no reason x264enc should enforce a maximum allocation size.
The maximum is normally set by buffer pool which cannot grow, but we
don't offer a buffer pool. This would lead to stall when used with
element that don't implement allocation query.

Related to: https://bugzilla.gnome.org/show_bug.cgi?id=738302
2015-01-18 11:07:43 -05:00
Tim-Philipp Müller
5872a1454e x264: fix colour inversion with YV12 format
It's the same as I420 but with the U/V planes swapped.
2014-08-05 19:47:26 +01:00
Nicolas Dufresne
8aea88d261 x264enc: Request buffers in allocation query
https://bugzilla.gnome.org/show_bug.cgi?id=732288
2014-07-25 14:29:21 -04:00
Nicolas Dufresne
698714fc97 x264enc: Shift both PTS and DTS to ensure positive timestamp
Currently we only shift DTS to compensate that we don't support negative
timestamp. This cause a problem that PTS is no longer >= DTS and may
make muxers live much harder. Instead, shift both PTS/DTS forward. Also
remove all the hack to handle this which seems the result of thinking libx264
is bugged.

https://bugzilla.gnome.org/show_bug.cgi?id=731351
2014-07-19 12:59:05 -04:00
Aurélien Zanelli
84b2009155 x264enc: fix caps leak in set_format()
https://bugzilla.gnome.org/show_bug.cgi?id=730865
2014-05-28 10:09:41 +02:00
Dirk Van Haerenborgh
e15eb270f9 x264enc: allow lossless compression (qp=0)
https://bugzilla.gnome.org/show_bug.cgi?id=725051
2014-02-26 09:18:37 +01:00
Tim-Philipp Müller
88b27e30c9 x264enc: fix compiler warning
Compiler warns rightly about possibly uninitialized variable.
2013-11-29 15:54:55 +00:00
Tim-Philipp Müller
20d6dbd2f6 x264enc: fix crash on NULL caps when negotiation happens without a downstream peer
gst-launch-1.0 videotestsrc ! x264enc
2013-11-29 15:54:55 +00:00
Michael Esemplare
fc29cbaa54 x264enc: If FPS is available, set VFR to false
https://bugzilla.gnome.org/show_bug.cgi?id=708940
2013-10-04 12:07:31 +02:00
Andoni Morales Alastruey
03a98eabce x264enc: Update the documentation to match the default profile used
https://bugzilla.gnome.org/show_bug.cgi?id=708036
2013-09-24 10:47:41 +02:00
Olivier Crête
b82703170a x264enc: Implement getcaps that restricts the input format depending on the output profile
Also add some x264enc profile tests

https://bugzilla.gnome.org/show_bug.cgi?id=708326
2013-09-18 19:33:01 -04:00
Mathieu Duponchelle
0243810e1e x264enc: Don't unref future state but the old one
Being silly will lead us nowhere.
2013-09-05 22:56:48 +02:00
Sebastian Dröge
55037ab411 x264enc: Check if we have an input state before using it
Flushing might happen before caps were set on the encoder,
which would lead to crashes here.

Thanks to Matej Knopp for analyzing this.

https://bugzilla.gnome.org/show_bug.cgi?id=707414
2013-09-04 16:33:18 +02:00
Matej Knopp
ae45623450 x264enc: fix unsigned comparison warning 2013-09-04 10:47:55 +02:00
Tim-Philipp Müller
6572393629 x264enc: log when we output a lower profile than requested 2013-08-27 14:13:06 +01:00
Sebastian Dröge
aab5534573 x264enc: Consider subset relations of profiles when setting srcpad caps
constrained-baseline is a subset of baseline, is a subset of main,
is a subset of high profile.

https://bugzilla.gnome.org/show_bug.cgi?id=705425
2013-08-21 18:35:09 +02:00
Tim-Philipp Müller
e0ae81ebac x264enc: propagate flow return back to base class and upstream
https://bugzilla.gnome.org/show_bug.cgi?id=705425
2013-08-21 12:35:32 +01:00
Tim-Philipp Müller
71ce5136d1 x264enc: minor clean-up
We requires x264 build >= 120 now.
2013-08-17 23:09:15 +01:00