When going to ready, camerabin2 could create an empty file
if the videosink was put to ready. This patch only puts videosink
to ready on the PAUSED_TO_READY state change if it is on PAUSED
or PLAYING.
When passing an unexistent file to rsvgoverlay it would
crash because the svg loading would fail without setting
an error.
This patch makes it check if the handle was actually created
and logs an error in case it didn't. Maybe it should post an
error to the bus, but the previous error handling didn't, so
I just followed the same logic.
Don't set any default values for source element GstPhotography interface
settings, source elements should have sane defaults themselves.
Also, setting scene-mode is tricky as it is a superset of other GstPhotography
settings. This might cause problem with defaults e.g. setting scene-mode to
'night' may configure flash-mode as 'on' by definition, and after that
we don't want to override this flash-mode setting with gst-camerabin-test default
value. Moreover, user needs have an option to set scene mode first and then force
some individual setting to a different value from the scene-mode definition.
https://bugzilla.gnome.org/show_bug.cgi?id=639841
Implement previewing functionality using 2 properties. A boolean
(post-previews) that indicates if previews should be posted, and a
GstCaps (preview-caps) to provide the desired preview caps.
wrappercamerabinsrc implements previewing by supplying the captured
image to a pipeline to adapt it to the required caps before posting.
A camerabin2 tests depends on the commit
dcbba0932d for jpegenc on -good
that was released on 0.10.27.
This patch makes it check for this version before running the
test.
Don't unref the event if it hasn't been handled, because the caller
assumes it is still valid and might reuse it.
I ran into this problem when transcoding an AVI (with mp3 inside)
to gpp.
https://bugzilla.gnome.org/show_bug.cgi?id=639555
Sync both pads by waiting in the kate chain function.
Do not reset our internal segment from segment updates, in order
to be able to map video running time to kate running time, to
give libtiger the timestamp it expects. This allows us to use
running time to sync to video, which is The Right Way.
https://bugzilla.gnome.org/show_bug.cgi?id=600929
Fix copy'n'paste bug that made us look for the raw little endian
sync word twice instead of looking for the 14-bit LE sync word
as well. Fixes parsing of such streams (see #636234 for sample file).
Or possibly even at startup. If we couldn't find a sync within
the first few bytes, we'd just push more data into the adapter
but never discard any of the invalid data at the beginning, so
would never be able to re-sync.
https://bugzilla.gnome.org/show_bug.cgi?id=639063