Sebastian Dröge
0c073b2d1d
rtpcollision: Fix memory leaks in unit test
2014-04-17 16:39:59 +02:00
Tim-Philipp Müller
77badda6b9
videomixer: name collectpads object based on videomixer name
...
Makes it easier to track things in debug logs when there
are multiple mixers and muxers.
2014-04-16 21:40:45 +01:00
Tim-Philipp Müller
f8d15b1e56
videomixer: better logging of incoming events
...
The pad and parent names are already logged as part of logging
the object. Instead log the full event details.
2014-04-16 21:38:35 +01:00
Sebastian Dröge
cd4c17031b
videomixer: Fix memory leak in unit test
2014-04-16 19:03:47 +02:00
Sebastian Dröge
b21b46a07a
level: Use the correct number of samples to iterate over the input array
...
Fixes invalid memory accesses and accesses to uninitialised data.
2014-04-16 18:50:50 +02:00
Sebastian Dröge
bd65c36cbb
icydemux: Unref dropped events
2014-04-16 18:50:50 +02:00
Vincent Penquerc'h
457712b933
matroska: fix check for amount of data to read
...
History shows length==0 should set data to NULL and return,
so we do that too instead of trying to read nothing.
Coverity 206205
2014-04-16 17:44:51 +01:00
Vincent Penquerc'h
46a39bdd4f
deinterlace: fix sign comparison
...
history_count is unsigned, so the whole comparison will be made
as unsigned, and fail to reject what it was meant to.
Coverity 206204
2014-04-16 17:44:51 +01:00
Vincent Penquerc'h
c6acd6368b
avidemux: remove dead code
...
sub may not be NULL in this switch, there is a bail out just
before it if so.
Coverity 206098
2014-04-16 17:44:51 +01:00
Vincent Penquerc'h
937269d02e
flacparse: remove dead code
...
The block_size == 0 was shortcut earlier, and the variable is not
modified in the meantime.
Coverity 206097
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
2e120c9440
videomixer: remove dead code
...
While it seems to keep a compile time selection, I traced it
to some code copied from videoconvert, where it was removed,
with the following comment:
Also remove the high-quality I420 to BGRA fast-path as it needs
the same fix, which causes an additional instruction, which causes
orc to emit more than 96 variables, which then just crashes.
This can only be fixed in orc by breaking ABI and allowing more
variables.
Thus, I remove it here as well.
Coverity 206064
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
595a9cb5c5
isomp4: fix incorrect masking for multiple tags
...
Coverity 206058
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
a5b7c12e35
isomp4: fix wrong atom flags set when adding samples
...
Coverity 206057
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
d2b682c271
audiofx: fix comparison of delta time to a threshold
...
Coverity 206055
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
7ebfdbeaf8
wavparse: do not rely on call failure keeping return data unmodified
...
This is clearer this way too.
Coverity 206029
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
b344b29ff2
isomp4: catch fseek error
...
Coverity 206028
2014-04-16 17:44:50 +01:00
Vincent Penquerc'h
88eccee88c
isomp4: report failures to caller
...
Coverity 206027
2014-04-16 17:44:50 +01:00
Wim Taymans
783b4ba2c4
rtpjitterbuffer: refuse serialied query when buffering
...
When we are buffering, we can't block and wait for the serialized query
to complete because the jitterbuffer will not try to forward the query
while buffering. Instead, just refuse the query.
2014-04-16 18:16:33 +02:00
Wim Taymans
233e9e64b8
rtpjitterbuffer: don't free the serialized query
...
We should never free a serialized query in the queue, it is the upstream
caller that will free it.
2014-04-16 18:16:32 +02:00
Sebastian Dröge
6c02593386
aacparse: Fix memory leak in the test
2014-04-16 17:35:42 +02:00
Sebastian Dröge
74c23f0f4f
videomixer: Create hashtable only when we actually use it
...
In error cases we previously returned without freeing it.
2014-04-16 17:33:46 +02:00
Sebastian Dröge
d3a2b3c73a
videomixer: Chain up to the parent class' dispose function
2014-04-16 17:30:59 +02:00
Sebastian Dröge
ab02b1db6c
v4l2videodec: Initialise ioctl struct with zeroes before passing it to ioctl()
2014-04-16 17:23:52 +02:00
Marc Leeman
5b4681dfe7
udpsrc: correct LOG msg for -1
...
Signed-off-by: Marc Leeman <marc.leeman@gmail.com>
2014-04-16 13:54:40 +01:00
Sebastian Dröge
b038fd4eff
interleave: Fix negotiation to work at all again
...
The caps query handling function for the sinkpads was called for
the srcpad, and the sinkpads had none. This commit moves it to the
right pad, but nonetheless the negotiation still looks wrong.
This makes the test pass again after the recent coverity fix
and also allows interleave to work again, but someone should
really review the negotiation code and fix it.
2014-04-15 21:36:30 +02:00
Edward Hervey
da39a0bae7
oss4: Maximum number of channels support is 8
...
Avoids doing potential overwrites in ch_layout (which only has 8
fields).
CID #1139826
2014-04-13 09:03:41 +02:00
Sebastian Dröge
7c006edf8d
osxvideosink: Set rank to MARGINAL
...
If available we prefer using glimagesink over osxvideosink. It supports
more formats and in general has more features than osxvideosink.
2014-04-12 22:17:30 +02:00
Josep Torra
eaee14aff4
rtph264depay: only guess AU boundaries when aren't indicated by marker
...
The marker bit isn't mandatory and we had in place code to guess AU
boundaries by detecting a new picture start. This guessing code
didn't work with interlaced content that has proper marker bits
to indicate the AU boundaries. It was leaking the first field buffer
and producing a corrupted output.
fixes: https://bugzilla.gnome.org/show_bug.cgi?id=728041
2014-04-12 04:42:36 +02:00
Rafał Mużyło
b32de2794b
pngdec: enable libpng interlaced picture handling
...
Makes libpng deinterlace Adam7 interlaced pictures
by default. It is the only interlaced format available
and if the picture isn't interlaced the code should behave
as before.
https://bugzilla.gnome.org/show_bug.cgi?id=726161
2014-04-11 19:12:25 -03:00
Sebastian Dröge
37609c0a82
souphttpsrc: Only keep-alive the connection in stop() if we have finished all previous messages
...
After cancelling a request we need to create a new connection.
2014-04-11 13:30:53 +02:00
Edward Hervey
09ea92848b
dvdec: Don't set bogus timestamp/duration
...
This will happen if we have an incoming stream with a non-TIME segment
Could be improved later to figure out proper pts/duration.
CID #1199702
CID #1199703
2014-04-11 11:54:12 +02:00
Edward Hervey
10feb2ba7d
dvdec: Properly refuse incoming stream without framerate
...
The return value wasn't properly propagated back if the caps
didn't contain a framerate
2014-04-11 11:53:42 +02:00
Sebastian Dröge
847ba2a30d
souphttpsrc: Also retry on unexpected network failures
2014-04-10 16:47:21 +02:00
Sebastian Dröge
037dfb6723
souphttpsrc: New property to specify the maximum number of retries before we give up
2014-04-10 16:47:07 +02:00
Alexander Zallesov
b089524b21
souphttpsrc: Change default timeout to 15 seconds
...
If nothing happens after 15 seconds, chances are good that
our connection will never will work. Stop after 15 seconds
instead of waiting until the system's default timeout, which
can be > 1 minute.
2014-04-10 11:11:35 +02:00
Jimmy Ohn
ecf188e6cd
qtdemux: replace duplicated variable when parsing trex atom
...
https://bugzilla.gnome.org/show_bug.cgi?id=727878
2014-04-10 09:03:02 +02:00
Sebastian Dröge
d918212e12
souphttpsrc: Use GST_FLOW_FLUSHING when flushing, not GST_FLOW_EOS
...
... and reset it properly after flushing is done. Fixes playback
in many cases when buffering is used.
https://bugzilla.gnome.org/show_bug.cgi?id=727821
2014-04-09 10:56:29 +02:00
Sebastian Dröge
d47806320d
qtdemux: Properly return stream flags when parsing trex atom
...
https://bugzilla.gnome.org/show_bug.cgi?id=727867
2014-04-09 08:58:48 +02:00
Matthieu Bouron
7ac0204625
osxvideosink: use the video frame API instead of the video meta API
...
https://bugzilla.gnome.org/show_bug.cgi?id=726738
2014-04-08 13:56:10 +02:00
Matthieu Bouron
c6dcd3689d
osxvideosink: advertize video meta API support
...
https://bugzilla.gnome.org/show_bug.cgi?id=726737
2014-04-08 13:55:53 +02:00
Edward Hervey
9859515605
interleave: Add missing break in switch statement
...
The caps query is handled entirely already before.
CID #1139757
2014-04-08 11:31:06 +02:00
Reynaldo H. Verdejo Pinochet
f187d9fc7c
tests: souphttpsrc: use SoupKnownStatusCode if needed
...
From libsoup docs:
Prior to 2.44 SoupStatus was called SoupKnownStatusCode,
but the individual values have always had the names they
have now.
Fixes:
https://bugzilla.gnome.org/show_bug.cgi?id=727329
2014-04-07 17:48:35 -03:00
Vincent Penquerc'h
31f36d805a
avidemux: use frames, not bytes, for position query in VBR streams
...
Coverity 1139648
2014-04-07 12:58:23 +01:00
Vincent Penquerc'h
42298f65e8
smpte: fix copy/paste error causing unmap on wrong buffer
...
Coverity 1139647
2014-04-07 12:43:57 +01:00
Vincent Penquerc'h
1d7735b1d6
deinterlace: guard against finding no suitable pattern
...
The code handles a -1 pattern index, and it seems plausible
that a pattern might be found later, so it seems best to not
send an element error here.
Coverity 1139766
2014-04-07 12:20:12 +01:00
Wim Taymans
5b9945e0a6
rtspsrc: update for new MIKEY API
2014-04-04 17:38:14 +02:00
Wim Taymans
6210cbe1e2
rtspsrc: send sender SSRC in the MIKEY message
...
Allocate a new SSRC for our RTCP messages back to the server and set
this in the MIKEY message.
2014-04-03 17:40:01 +02:00
Wim Taymans
4f641ef18b
rtspsrc: make random number for the CSB
...
As recommended in the RFC
2014-04-03 17:39:30 +02:00
Wim Taymans
f932da3be6
rtspsrc: don't put spaces in keymgmt header
2014-04-03 12:21:27 +02:00
Wim Taymans
2edd450369
rtspsrc: create and send the RTCP encryption key
...
Create and make a key for encrypting the RTCP packets back to the server
and wrap this in a MIKEY message that we send as a header in the SETUP
request.
2014-04-03 12:21:27 +02:00