Internally videcrop can call gst_video_crop_set_info() with NULL as in
caps. Then critical messages are raised when the in caps are
processed.
To fix this the in caps are checked, and if they are present, its
capsfeature is extracted, otherwise, the previous raw caps detection
remains as before.
Also the videocrop-test removes the format field in the structure
because now its always passed.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1056>
When g_option_context_parse fails, context and error variables are not getting free'd
which results in memory leaks. Free'ing the same.
And replacing g_error_free with g_clear_error, which checks if the error being passed
https://bugzilla.gnome.org/show_bug.cgi?id=753853
hal elements were removed, remove them from docs too
change example for pad-block API (actually remove the pad block, an application
should not be bothered with working around bugs in elements)
Original commit message from CVS:
* tests/icles/videocrop-test.c: (main):
Default to xvimagesink instead of autovideosink while
autovideosink/ghostpads/whatever don't handle the way we use it in
the way we expect it to.
Original commit message from CVS:
* gst/videocrop/gstvideocrop.c:
(gst_video_crop_get_image_details_from_caps),
(gst_video_crop_transform_packed_complex):
Fix cropping for packed 4:2:2 formats YUYV/YUY2 and UYVY.
* tests/icles/videocrop-test.c: (check_bus_for_errors),
(test_with_caps), (main):
Block streaming thread before changing filter caps while the
pipeline is running so that we don't get random not-negotiated
errors just because GStreamer can't handle that yet.
Original commit message from CVS:
* tests/icles/videocrop-test.c: (main):
Call g_thread_init() right at the beginning. Remove superfluous
gst_init() - we've already been inited via the GOption stuff.
Original commit message from CVS:
* tests/icles/.cvsignore:
* tests/icles/Makefile.am:
* tests/icles/videocrop-test.c: (quit_mainloop), (tick_cb),
(test_with_caps), (video_crop_get_test_caps), (main):
Visual test for videocrop, shows that packed yuv doesn't work right
yet. --with-ffmpegcolorspace option doesn't work yet for unknown
reasons (another basetransform issue?)
