Commit graph

1681 commits

Author SHA1 Message Date
Seungha Yang
5a46f2eae9 uri-asset: Impl. dispose vfunc
... and fix GList/GESAsset leak
2019-01-18 20:32:02 +00:00
Seungha Yang
075a5df24f transition-clip: Don't leak GESAsset
Returned GESAsset from ges_asset_request should be freed since
ges_extractable_set_asset doesn't take ownership
2019-01-18 20:32:02 +00:00
Seungha Yang
f850da7e4b framepositioner: Fix invalid memory access
The GstFramePositioner might be finalized before the notify callback

Without this commit,
gst-editing-services / ges_basic / test_ges_timeline_remove_track
can reproduce the case.
2019-01-18 20:32:02 +00:00
Seungha Yang
e1fff8f864 asset: Fix various leak 2019-01-18 20:32:02 +00:00
Seungha Yang
eb226bc544 enums: Add missing unref 2019-01-18 20:32:02 +00:00
Seungha Yang
580f45dddb structure-parser: Add missig chain up code 2019-01-18 20:32:02 +00:00
Seungha Yang
e939cfebaf ges: Add missing type unref on deinit 2019-01-18 20:32:02 +00:00
Seungha Yang
ef173bb7c4 ges: Cleanup internal hash table on deinit
System-wide once allocated but it makes tracing leak hard
2019-01-18 20:32:02 +00:00
Seungha Yang
15c891e76a ges: Make init/deinit thread safe
Although it might be uncommon use case, init/deinit could be called
in non-main thread.
2019-01-18 20:32:02 +00:00
Seungha Yang
691b6f6f04 asset: Use static lock
The mutex life cycle follows processs.
2019-01-18 20:32:02 +00:00
Thibault Saunier
463ded894a ges: Register formatters during meta registration
So that formatters implemented outside GES itself are registered
2019-01-14 18:32:38 -03:00
Thibault Saunier
b3332e5ab3 ges: Add a ges_is_initialized function 2019-01-14 18:32:38 -03:00
Thibault Saunier
11334118fa formatter: sink ref of the temporary GESFormatter
To accomodate formatters implemented with bindings/in python
2019-01-14 18:32:38 -03:00
Seungha Yang
3b0da0611c pipeline: Ensure timeline state to be NULL on dispose
The GESTimeline's state might not be synced with parent
2019-01-09 20:25:24 +09:00
Alexandru Băluț
a83d539390 ges-meta-container: Fix warning message 2019-01-05 10:58:57 +00:00
Alexandru Băluț
fd7e6aa204 ges-meta-container: Minor documentation fixes 2019-01-05 10:58:57 +00:00
Thibault Saunier
9a20b4cfe9 track-element: Ignore writability for whitlisted children props
If the property was explicitely whitelisted, we should expose it
in any case.

This was a regression from 835d693749
2019-01-04 12:36:20 +01:00
Tim-Philipp Müller
84651fcac7 ges: avoid use of G_DECLARE_FINAL_TYPE which requires GLib 2.44
Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/48
2018-12-30 19:49:44 +00:00
Seungha Yang
1ba5911890 container: Fix GHashTable leak 2018-12-27 10:57:30 +09:00
Seungha Yang
f77eb964dd container: Fix wrong finalize() usage
finalize must chain up to parent's finalize(), not dispose()
2018-12-27 00:18:04 +09:00
Seungha Yang
acbd7e7bc5 timeline-element: Chain up to parent impl. on dispose()
... as documented in glib
2018-12-27 00:14:03 +09:00
Tim-Philipp Müller
a7347ca8f7 WIP: ges: fix API export/import and 'inconsistent linkage' on MSVC
Export GES library API in headers when we're building the
library itself, otherwise import the API from the headers.

This fixes linker warnings on Windows when building with MSVC.

Fix up some missing config.h includes when building the lib which
is needed to get the export api define from config.h

Fixes https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/42
2018-12-15 00:14:51 +00:00
Matthew Waters
059af7ba32 build: also allow building static libraries for e.g. Android/iOS 2018-12-10 13:28:16 +11:00
Thibault Saunier
906ee53a36 Add a way to disable xptv support
This formatter is in very bad shape and is generally not useful.

It has been deprecated since 1.0... and I bet noone uses it.
2018-11-30 15:40:43 -03:00
Thibault Saunier
1b75f8e5b1 track: Fix documentation about "binding_type" 2018-11-27 13:49:56 -03:00
Thibault Saunier
f85a1bd3a3 validate: cleanup the playback-time from validate structures
Otherwise we might fail on them in the ges-structure-interface
2018-11-26 14:50:03 -03:00
Thibault Saunier
f1baf1a739 effect: Create ghost pads ourself
As we can have effects with several pads and the default ghosting
doesn't allow that.

This way we also filter the pads to ghost to match our track type.
2018-11-23 11:44:14 -03:00
Thibault Saunier
8cf4605b92 effect: Consider the "Filter" classification to determine effect media type 2018-11-23 11:20:00 -03:00
Alexandru Băluț
f987db47a7 clip: Emit additional signals after child-removed
When removing an effect from a clip, first the notify::priority signals
were being emitted for the remaining effects which changed priority, and only
at the end the child-removed signal. Now the child-removed signal is emitted
first.
2018-11-07 09:09:22 -03:00
Víctor Manuel Jáquez Leal
c04342e4f1 timeline-element: Fix compilation errors
There were some code errors introduced in commit 6b738b7a
2018-11-05 13:58:06 +01:00
Corentin Noël
6b738b7aa4 timeline-element: Align virtual methods and invokers prototypes 2018-11-05 11:00:58 +01:00
Thibault Saunier
acc294bf5a ges: Check the thread from which our API is used
And add some missing API guards
2018-11-03 08:27:58 -03:00
Thibault Saunier
534855d42e ges: Mark GValue in child property setters as const
We can't change the vmethod at this point so just cast. This makes
the API more explicit so it is better in all cases.
2018-11-02 09:43:50 -03:00
Thibault Saunier
412fd0107c Keep GESSmartVideoMixer out of the Gir and add geseffectasset.h to ges.h
Fixing gstreamer-sys rust bindings.
2018-10-31 10:40:33 -03:00
Thibault Saunier
023bc72d9e Fix the package name in the gir to match the .pc filename 2018-10-31 10:06:08 -03:00
Thibault Saunier
3c7f488fc2 video-transition: Port to the new 'operator' API in compositor
Now subclassing a ghostpad with an alpha property so that
we can multiply the alpha of the frame positioning meta
and the alpha of that pad, setting it on the compositor pad.

https://bugzilla.gnome.org/show_bug.cgi?id=797169
2018-10-29 13:50:16 +00:00
Thibault Saunier
b64dd33661 Revert "video-transition: Make use of the new compositor::crossfade-ratio property"
This reverts commit 57be9b6799.
2018-10-28 15:33:31 +00:00
Thibault Saunier
77f8107d64 nlecomposition: Add a function that prints stacks as debug info 2018-10-28 13:23:49 +00:00
Sebastian Dröge
ee7c2d07b8 ges: Fix compilation with latest GLib
g_clear_pointer() is now preserving the type of its arguments for the
free function.

ges-xml-formatter.c: In function ‘_dispose’:
ges-xml-formatter.c:1635:7: error: function called through a non-compatible type [-Werror]
       (GDestroyNotify) g_hash_table_unref);
/usr/include/glib-2.0/glib/gmem.h:121:8: note: in definition of macro ‘g_clear_pointer’
       (destroy) (_ptr);                                                        \
        ^~~~~~~

https://bugzilla.gnome.org/show_bug.cgi?id=797310
2018-10-22 08:14:28 +01:00
Thibault Saunier
13b8c8554d Update for g_type_class_add_private() deprecation in recent GLib 2018-09-05 22:57:27 -03:00
Thibault Saunier
2443b1a413 clip: Resync priorities when removing an effect
When removing a top effect in the list of top effects, other
effects priorities need to take that into account to avoid
holes in the indices.
2018-09-05 21:52:37 -03:00
Thibault Saunier
e71e1cc9fb ges: Check that nle is avalaible when initializing 2018-09-03 12:37:59 -03:00
Nirbheek Chauhan
67f2be1987 meson: Maintain macOS ABI through dylib versioning
Requires Meson 0.48, but the feature will be ignored on older versions
so it's safe to add it without bumping the requirement.

Documentation:
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Reference-manual.md#shared_library
2018-08-31 14:44:58 +05:30
Thibault Saunier
e4d4e0df1e formatter: Fix mixup in variable check 2018-07-29 16:26:49 -04:00
Thibault Saunier
2381090378 xml-formatter: Bump format version
Previous commit makes the format not forward compat.
2018-07-28 14:29:11 -04:00
Thibault Saunier
bfb943be1b formatter: Serialize Transition border and invert properties
Marking them as children properties and properly allow serializing
clips children properties.

This doesn't handle several TrackElement of a same type with
different property values but this require more worked already
marked as fixme to allow specifying full path of elements in the
children properties API.

See https://gitlab.gnome.org/GNOME/pitivi/issues/1687
2018-07-28 14:25:07 -04:00
Thibault Saunier
5f5cbd111c project: Compute relocation URIs in missing-uri signal
Until know we were doing it outside of the signal and subclasses didn't
have a chance to know that some assets was relocated.

This is required so that Pitivi can handle proxy delation and relocated
assets.

Required for https://gitlab.gnome.org/GNOME/pitivi/issues/2203
2018-07-27 22:56:23 -04:00
Thibault Saunier
fd029e1251 pitivi-formatter: Do not g_file_test on a NULL pointer 2018-07-21 12:03:28 -04:00
Thibault Saunier
ad4eb9a065 project: Do not emit 'error-loading-asset' when we are trying to update the ID 2018-07-21 12:02:35 -04:00
Thibault Saunier
ab22f339e6 track: Set restriction caps when update_restriction before caps being set
And stop leaking intermediary restriction caps.

https://bugzilla.gnome.org/show_bug.cgi?id=796802
2018-07-12 15:47:13 -04:00