Mark Nauwelaerts
c1adec7c76
baseparse: reduce locking
...
... which is either already mute and/or implicitly handled by STREAM_LOCK.
2011-04-08 15:44:54 +01:00
Mark Nauwelaerts
d45cdf65d5
baseparse: avoid loop in frame locating interpolation
2011-04-08 15:44:54 +01:00
Thiago Santos
a3e55038ac
audioparsers: baseparse: Be careful to not lose the event ref
...
Don't unref the event if it hasn't been handled, because the caller
assumes it is still valid and might reuse it.
I ran into this problem when transcoding an AVI (with mp3 inside)
to gpp.
https://bugzilla.gnome.org/show_bug.cgi?id=639555
2011-04-08 15:44:54 +01:00
Tim-Philipp Müller
40a5458392
docs: minor baseparse docs/comment fixes
...
Remove copy'n'paste leftovers.
2011-04-08 15:44:54 +01:00
Mark Nauwelaerts
4dc486ddc5
baseparse: increase keyframe awareness
...
... which is not particular relevant for audio parsing, but more so
in video cases. In particular, auto-determine if dealing with video (caps).
2011-04-08 15:44:54 +01:00
Mark Nauwelaerts
aed933c0ce
baseparse: avoid unexpected stray metadata
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
0cb02472f0
baseparse: use proper _NONE output value when applicable
2011-04-08 15:44:53 +01:00
Edward Hervey
dab512bb15
audioparsers: Remove dead assignments
2011-04-08 15:44:53 +01:00
Andoni Morales Alastruey
fc4885a3a3
audioparse: fix possible division-by-zero
...
https://bugzilla.gnome.org/show_bug.cgi?id=635786
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
4230c0b2e1
baseparse: use correct offset when adding index entry
...
... bearing in mind that BUFFER_OFFSET is media specific and may not
reflect the basic offset after having been parsed.
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
3faccbd29f
baseparse: enhancements for timestamp marked framed formats
...
That is, as such formats allow subclass to extract position from frame,
it is possible to extract duration (if not otherwise provided)
from (near) last frame, and a seek can fairly accurately target the required
position.
Fixes #631389 .
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
454f21f077
baseparse: refactor frame scanning peformed by _loop
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
10eae096fe
baseparse: slightly optimize sending of pending newsegment events
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
6d3447c6ec
baseparse: minor fixes and enhancements
...
Arrange for upstream as well as downstream flushing when seeking.
Also determine upstream size as well as seekability. Adjust some comments
to reality and employ debug statement in proper order.
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
0f9435888a
baseparse: use only upstream duration if it provides one
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
78ef0387e7
baseparse: reflow update_bitrate code
...
... which makes local variables represent real state better, and avoids
triggering unneeded updates/actions.
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
85307bf969
baseparse: add some debug statements
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
9394662f35
baseparse: perform bitrate handling and posting after newsegment sending
2011-04-08 15:44:53 +01:00
Mark Nauwelaerts
07eff44306
baseparse: immediately post subclass provided bitrate
2011-04-08 15:44:53 +01:00
Tim-Philipp Müller
a4f5db7088
Revert "baseparse: add skip property"
...
This reverts commit b5a3d60363
.
Reverting this for now, since no one really seems to remember why this
property exists or what it could possibly be good for. It seems to have
been in the original mp3parse since the beginning of time and was back-
ported from there.
2011-04-08 15:44:52 +01:00
Sebastian Dröge
ad6ce1e2d8
audioparser: Let the format string agree with the parameters to fix compiler warning
2011-04-08 15:44:52 +01:00
Arun Raghavan
c56f223da7
baseparse: Fix debug output
...
We lose the reference to the buffer after gst_pad_push(), so the debug
print should happen before.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
cc8d04dad5
baseparse: support reverse playback
...
... in pull mode or upstream driven.
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
5e9cfceb26
baseparse: remove done TODOs and update documentation
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
67666768a2
baseparse: use determined seekability in answering SEEKING query
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
ba3d5da1ee
baseparse: add skip property
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
038821d30e
baseparse: use _set_frame_props to configure frame lead_in and lead_out
...
... provided a corresponding decoder with sufficient leading and following
frames to carry out full decoding for a particular segment.
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
668ad3836a
baseparse: use _set_duration to configure duration update interval
...
... as it logically belongs there as one or the other; either subclass
can provide a duration, or an estimate must be made (reguarly updated).
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
6b33f59406
baseparse: localize use of provided fps information
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
9db9d2eabf
baseparse: seek table and accurate seek support
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
3304f194a9
baseparse: proper and more extended segment and seek handling
...
That is, loop pause handling, segment seek support, newsegment for gaps, etc
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
4d20688af3
baseparse: add index support
2011-04-08 15:44:52 +01:00
Mark Nauwelaerts
224af37314
baseparse: refactor state reset
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
35bfc86e67
baseparse: prevent indefinite resyncing
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
31e676e4d7
baseparse: specific EOS handling if no output so far
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
d801f74366
baseparse: adjust _set_frame_prop documentation and set default as claimed
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
745de19963
baseparse: fix bitrate copy-and-paste and update heuristic
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
60a8533d48
baseparse: post duration message if average bitrates is updated
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
7ba1b6e4d7
baseparse: remove is_seekable vmethod and use a set_seek instead
...
Seekability, like duration, etc is unlikely to change (frequently), and
the default assumption covers most cases, so let subclass set when needed.
At the same time, allow subclass to indicate if it has seek-metadata (table)
available, and possibly have it provide an average bitrate.
2011-04-08 15:44:51 +01:00
Mark Nauwelaerts
4b0f92db79
baseparse: add another hook for subclass prior to pushing buffer
...
... and allow subclass to perform custom segment clipping, or to
emit tags or messages at this time.
2011-04-08 15:44:50 +01:00
Mark Nauwelaerts
b51b5d4b29
baseparse: 0 converts to 0 by default
2011-04-08 15:44:50 +01:00
Mark Nauwelaerts
3c656232eb
baseparse: refactor conversion using helper function and export default convert
2011-04-08 15:44:50 +01:00
Mark Nauwelaerts
12cc228d84
baseparse: streamline query handling
2011-04-08 15:44:50 +01:00
Mark Nauwelaerts
e274ebb292
baseparse: cleanup struct and remove unused member
2011-04-08 15:44:50 +01:00
Arun Raghavan
03164ad8ab
baseparse: Allow chaining of subclass event handlers
...
This allows the child class to chain its event handler with
GstBaseParse, so that subclasses don't have to duplicate all the default
event handling logic.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
2011-04-08 15:44:50 +01:00
Sebastian Dröge
f3f338f14a
baseparse: Don't use GST_FLOW_IS_FATAL()
...
Also don't post an error message for UNEXPECTED and do it
for NOT_LINKED.
2011-04-08 15:44:49 +01:00
Mark Nauwelaerts
08e8dbf027
baseparse: non-TIME seek event is simply not handled
2011-04-08 15:44:49 +01:00
Mark Nauwelaerts
dc80b52372
baseparse: fix seek event ref handling
2011-04-08 15:44:49 +01:00
Mark Nauwelaerts
b4f1778a7d
baseparse: prevent arithmetic overflows in pull mode buffer cache handling
2011-04-08 15:44:49 +01:00
Mark Nauwelaerts
1b8a96e999
baseparse: fix seek handling
...
Allow a few more seek event type combinations, and really use the result
of gst_segment_set_seek to perform the seek. Also add some debug.
2011-04-08 15:44:49 +01:00