Commit graph

7296 commits

Author SHA1 Message Date
Antonio Ospite
53d7a1298c pcapparse: bail out in case of fragmented packets
pcapparse cannot parse fragmented IP packets correctly, in particular it
will get confused when trying to parsing fragments as standalone frames
in two ways:

  1. the first fragment will have the packet length greater than the
     frame size and will always be discarded;

  2. fragments with non-zero offsets will be interpreted as full packets
     and the first part of their raw payload data will be parsed as the
     transport protocol header, resulting in bogus values for addresses
     and ports, thus evading the properties filtering on those values.

This can make it difficult for users to see why the data does not get
downstream.

So be more explicit and just bail out when fragmented packets are
encountered.

https://bugzilla.gnome.org/show_bug.cgi?id=795284
2018-04-16 11:22:27 +03:00
Antonio Ospite
a4df5132bc pcapparse: add some comments about the pcap format headers
Since the code is full of magic add at least some guidance for newbies.

https://bugzilla.gnome.org/show_bug.cgi?id=795284
2018-04-16 11:22:27 +03:00
Seungha Yang
3caf16a199 h265parse: Make caps writable before modifying them
Fix following assertion failure
GStreamer-CRITICAL **: gst_structure_remove_field: assertion 'IS_MUTABLE (structure)' failed

https://bugzilla.gnome.org/show_bug.cgi?id=795032
2018-04-11 22:47:21 -04:00
Philippe Normand
b26cc16d1e fakevideosink: explicit type cast for max-lateness property setter
g_object_set() expects the parameters values to be the exact type of the
property being set.
2018-04-10 10:26:38 +01:00
Guillaume Desmottes
9cd77b1644 fakevideosink: request an extra buffer if enable-last-sample is enabled
If the 'enable-last-sample' property is enabled, fakevideosink will keep
a reference on last rendered buffer which may lead to buffer starvation
in the pipeline.
Request one extra buffer in this case so we always have a buffer flying
in the pipeline.

https://bugzilla.gnome.org/show_bug.cgi?id=795109
2018-04-09 18:09:44 +02:00
Nirbheek Chauhan
8649cef462 audiolatency: Fix wave detection in buffers
-1/1000 is 0, so we were *always* detecting a buffer.
2018-04-03 23:57:20 +05:30
Nirbheek Chauhan
2ee16a5810 audiolatency: Avoid bogus pts values while starting 2018-04-03 23:57:20 +05:30
Sebastian Dröge
7a2110a499 mpegtsmux: Resend initial segments and header sections after FLUSH_STOP
https://bugzilla.gnome.org/show_bug.cgi?id=794816
2018-04-03 14:38:15 +03:00
Tim-Philipp Müller
4d76070f4e rtponviftimestamp: fix state change function init/reset
When starting up we need to initialise things *before*
streaming starts, so before we chain up to the parent
class in the state change function. And when we shut
down the element, we need to reset things after streaming
has stopped, so after we chain up to the parent class
in the state change function.

Possibly related to memory leak in:
https://bugzilla.gnome.org/show_bug.cgi?id=794353
2018-03-27 16:51:30 +01:00
Sebastian Dröge
93e56ed473 mpegtsmux: Explicitly resend PAT/SI/PMT on force-keyunit events
And don't randomly change the PCR stream, which would cause a new PMT
version to be generated instead and could confuse players.
2018-03-21 13:42:30 +02:00
Sebastian Dröge
3f0463c43e mpegtsmux: Deterministically set the PCR stream to the first stream of the program
Otherwise it would be randomly set to the first stream of the program
that receives a buffer.
2018-03-21 13:34:17 +02:00
Sebastian Dröge
19acd7b215 mpegtsmux: Reset a few more fields in mpegtsmux_reset() to their original values 2018-03-21 11:05:23 +02:00
Sebastian Dröge
e3740b58d7 tsmux: Don't use GST_DEBUG_OBJECT() with non-GObject types 2018-03-21 10:59:29 +02:00
Brendan Shanks
8e3827b7be h264parse: reset internal 'state' variable properly
Reset the internal 'state' variable when the parser is started, fixes
errors when parser is being re-used.

https://bugzilla.gnome.org/show_bug.cgi?id=794537
2018-03-21 09:12:28 +02:00
Guillaume Desmottes
9f25fcdfc9 h265parse: add support for 'Format range extensions profiles'
Those profiles have been introduced in version 2 of the HEVC spec
(A.3.5).

https://bugzilla.gnome.org/show_bug.cgi?id=793876
2018-03-05 13:22:12 -05:00
Guillaume Desmottes
d252f503fc h265parser: decouple GstH265Profile and GstH265ProfileIDC
We used to have the same enum to represent H265 profiles and idc values.
Those are no longer the same with extension profiles defined from
version 2 of the spec.
Split those enums so the semantic of each is clearer and we'll be able
to add extension profiles to GstH265Profile.

Also add gst_h265_profile_tier_level_get_profile() to retrieve the
GstH265Profile from the GstH265ProfileTierLevel. It will be used to
implement the detection of extension profiles.

https://bugzilla.gnome.org/show_bug.cgi?id=793876
2018-03-05 13:19:42 -05:00
Nicolas Dufresne
9865904d88 Revert "h265parse: early set src caps when input not byte-stream"
This reverts commit 93d29e8030.
2018-03-02 10:37:53 -05:00
Nicolas Dufresne
7e45b9f03f Revert "h264parse: early set src caps when input is avc"
This reverts commit 5ac886d85a.
2018-03-02 10:37:45 -05:00
Mathieu Duponchelle
39d408f3d6 Port to latest GstAggregator segment API
The aggregator segment is now exposed on the src pad

https://bugzilla.gnome.org/show_bug.cgi?id=793946
2018-03-01 15:37:06 +01:00
Mathieu Duponchelle
7771488edb mxfmux: instantiate adapter at the correct place 2018-02-28 23:46:44 +01:00
Nirbheek Chauhan
5089ab3428 audiolatency: Fix string format specifier and use microseconds everywhere
Should fix warnings or build errors on 32-bit platforms and on Windows.

Also clarify in logging that all timestamps are in microseconds.
2018-02-28 00:59:42 +05:30
Nirbheek Chauhan
307865ec7a audiolatency: Fix cerbero build failure
Average latency is a 64-bit integer.

https://ci.gstreamer.net/job/GStreamer-master/9962/
2018-02-28 00:41:20 +05:30
Nirbheek Chauhan
3fb81536ce audiolatency: New plugin for measuring audio latency
Measures the audio latency between the source pad and the sink pad by
outputting period ticks on the source pad and measuring how long they
take to arrive on the sink pad.

Very useful for quantifying latency improvements in audio pipelines.
This plugin was particularly useful during development of the
low-latency features of the wasapi plugin.

https://bugzilla.gnome.org/show_bug.cgi?id=793839
2018-02-27 23:54:28 +05:30
Sreerenj Balachandran
751e85fa45 checksumsink: remove src pad template from sink element
https://bugzilla.gnome.org/show_bug.cgi?id=793774
2018-02-23 23:32:44 +00:00
Nicolas Dufresne
a73e5eba55 doc: Add section for fakevideosink
https://bugzilla.gnome.org/show_bug.cgi?id=793624
2018-02-21 12:27:39 -05:00
Nicolas Dufresne
f0c676c0f9 Add fakevideosink element
This is a wrapper around fakesink that will advertise GstVideoMeta
and other meta API in order to achieve zero-copy whenever possible.
his new element is useful when doing performance testing with
video stream and don't want the sink capability to change the
upstream behaviour.

https://bugzilla.gnome.org/show_bug.cgi?id=793624
2018-02-21 11:30:33 -05:00
Nicolas Dufresne
ccb0837903 meson: Remove unused header list
https://bugzilla.gnome.org/show_bug.cgi?id=793624
2018-02-21 11:30:33 -05:00
Edward Hervey
235feecf46 Update ORC fallback disted code 2018-02-14 14:36:00 +01:00
Dimitrios Katsaros
3cf4a70dbc pnm: Fixed segfault in pnmenc
The pnmenc was not mapping the input buffers as video buffers. Because
of this, the video frame stride was not being set based on frame but
based on the caps, which make the assumption that the strides are a
power of 4. For input that is not a power of 4, this would lead to a
SIGSEGV.

https://bugzilla.gnome.org/show_bug.cgi?id=793419
2018-02-14 10:19:22 +02:00
Tim-Philipp Müller
c180f8ffed audiomixer: remove, moved to -base
https://bugzilla.gnome.org/show_bug.cgi?id=791218
2018-02-13 00:37:35 +00:00
Tim-Philipp Müller
843f118523 proxy: remove unneeded object private structs
Plugin headers are not installed.

Also mark internal funcs as internal.
2018-02-12 19:35:19 +00:00
Carlos Rafael Giani
ec963e688f interaudio: Make sure both PTS and DTS values are defined
The inter plugin originated in 0.10, which had only one timestamp. As a
result, during the port to 1.0, the DTS were left undefined. This can cause
subtle bugs with basesrc, which can end up incorrectly picking DTS over PTS
and producing output buffers with incorrect timestamps.

https://bugzilla.gnome.org/show_bug.cgi?id=791347
2018-02-11 20:41:14 +00:00
Víctor Manuel Jáquez Leal
8749c61e95 Revert "gdpdepay: don't use allocator if it has custom alloc"
This reverts commit f6cb16ab8c.
2018-02-08 11:15:46 +01:00
Nirbheek Chauhan
20a6dacf71 proxy: Fix plugin definition
I'm not sure how this was missed in review...
2018-02-08 15:19:12 +05:30
Nirbheek Chauhan
f6104ca38b proxy: Remove dead code from Makefile.am
There is no gstproxytest.c
2018-02-08 14:45:28 +05:30
Nirbheek Chauhan
3f7e29d5b3 Add new 'proxy' element to stream data between pipelines
This keep-it-simple plugin is useful when you want to pipe arbitrary
data to a different pipeline within the same process. Some advantages
over appsink/appsrc, the inter elements, etc:

* Ease of use. Buffers, events, and caps are transmitted as-is without
  copying or serialization.
* Enables zerocopy (especially DMABUF) transparently without any
  special-casing.
* Enables usage with sinks or elements that are unreliable and may
  throw errors and need re-initialization, such as a network sink, a
  USB device sink (v4l2), etc.
* Transmits arbitrary data, not just audio/video/subs
* Can easily implement 1 producer pipeline -> N dynamic consumer
  pipelines within a single process when combined with the `tee`
  element.

All queries, events, buffers, and buffer lists are proxied. State
changes, clocks, and base times for the two pipelines are independent
since the upstream and downstreams continue to be different pipelines.

https://bugzilla.gnome.org/show_bug.cgi?id=788200
2018-02-07 22:49:36 +05:30
Omar Akkila
c365ab7e66 netsim: fix format errors for different platforms
https://bugzilla.gnome.org/show_bug.cgi?id=793073
2018-02-01 11:10:50 +00:00
Víctor Manuel Jáquez Leal
f6cb16ab8c gdpdepay: don't use allocator if it has custom alloc
gdpdepay element uses the decide_allocation to fetch the downstream
allocator. Nonetheless it is possible that allocate uses a custom
alloc function, which is not usable by gdpdepay, crashing later the
application when the allocater buffer is NULL.

This patch checks for the allocator flags and reset it if the
allocator has a custom alloc function.

https://bugzilla.gnome.org/show_bug.cgi?id=789476
2018-01-31 14:03:36 +01:00
Víctor Manuel Jáquez Leal
f04b20e59e gdpdepay: don't allocation query if caps aren't fixed
When querying downstream for allocation, and the source caps hasn't
set its caps, using ANY by default, it raises a critical message in
console:

CRITICAL **: gst_video_info_from_caps: assertion 'gst_caps_is_fixed (caps)' failed

This patch bails out decide_allocation() if the caps aren't fixed.

https://bugzilla.gnome.org/show_bug.cgi?id=789476
2018-01-31 14:03:36 +01:00
Guillaume Desmottes
a1b271d2ec h26{4,5}parse: expose chroma format and bit depth in caps
This information could be used for example to pick a decoder supporting
a specific chroma and/or bit depth, like 4:2:2 10 bits.
It can also be used to inform earlier decoder about the format it is
about to decode.

https://bugzilla.gnome.org/show_bug.cgi?id=792039
2018-01-24 11:50:54 -05:00
Jun Xie
3f87a9dd7f netsim: fix misleading packet delay log
packet delay time shall be calculated by ready_time minus current time

https://bugzilla.gnome.org/show_bug.cgi?id=791838
2018-01-24 00:22:06 +00:00
Tim-Philipp Müller
c7e34a0b2f Update for renamed aggregator pad API
https://bugzilla.gnome.org/show_bug.cgi?id=791204
2018-01-23 09:01:00 +00:00
Edward Hervey
6c2fc31012 mxfdemux: Remove useless check
Any modification of ret in that "while (ret == GST_FLOW_OK)" loop will
break (and cause it to stop the iteration).

CID #1427095
2018-01-11 11:41:33 +01:00
Vivia Nikolaidou
c7a60ed909 Revert "WIP: Revert "Revert "debugutils: Added new jitterer element"""
This reverts commit a401cb9a61.
2018-01-04 15:41:50 +02:00
Vivia Nikolaidou
f042e57d4e Revert "WIP: Revert "Revert "timecodestamper: LTC from audio"""
This reverts commit e0be05dc70.
2018-01-04 15:41:49 +02:00
Vivia Nikolaidou
7ecf3347d1 Revert "WIP: Revert "Revert "timecodestamper: Modify ltc-add to tc-add"""
This reverts commit 2f9da0ab59.
2018-01-04 15:41:48 +02:00
Vivia Nikolaidou
2f9da0ab59 WIP: Revert "Revert "timecodestamper: Modify ltc-add to tc-add""
This reverts commit 05426d9298.
2018-01-04 13:54:37 +02:00
Vivia Nikolaidou
e0be05dc70 WIP: Revert "Revert "timecodestamper: LTC from audio""
This reverts commit 1998ccf1fb.
2018-01-04 13:54:37 +02:00
Vivia Nikolaidou
a401cb9a61 WIP: Revert "Revert "debugutils: Added new jitterer element""
This reverts commit ccc1624d09.
2018-01-04 13:54:37 +02:00
Nicolas Dufresne
191c8742d3 festival: Don't forward all queries
This fixes issues where wavparse would query the file size upstream
and assert because the file size is way smaller then what the WAVE
header says. This patch disable or cane a handful of queries that
make no sense to forward.

https://bugzilla.gnome.org/show_bug.cgi?id=791811
2017-12-20 14:01:56 -05:00