Sebastian Dröge
429b0e1e27
omxvideodec: Check return value of gst_omx_port_set_enabled() for errors
...
CID 1214589
2014-05-19 09:04:09 +02:00
Sebastian Dröge
e08c0dc88a
omxvideodec: Check return values of buffer pool config parsing functions
...
CID 1214588
2014-05-19 09:01:46 +02:00
Sebastian Dröge
4e20116bc6
omx: Add a hack for not disabling the output port after set_format until the output format is known
...
Needed on some OMX implementations, e.g. the one from Atmel. It does
not send the settings-changed event on the output port if it is
disabled.
2014-05-15 10:59:35 +02:00
Sebastian Dröge
cfbf5bf16d
omxvideodec: Set nTickCount based on the buffer's duration instead of something wrong
2014-05-10 22:47:56 +02:00
Julien Isorce
bdec8c0595
omxvideodec: can negotiate caps with memory:EGLImage feature when using EGLImage allocator
...
Previously when using gst EGLImage allocator the caps was
video/x-raw, format=RGBA instead of
video/x-raw(memory:EGLImage), format=RGBA
Kepp previous behavior in case negotiation fails with caps feature.
It means it will still have a chance to use EGLImage even if the
feature is not in the caps.
https://bugzilla.gnome.org/show_bug.cgi?id=729196
2014-05-02 18:00:48 +01:00
Aurélien Zanelli
da4cf3da1f
omxvideodec: don't unref caps before logging field from it
...
https://bugzilla.gnome.org/show_bug.cgi?id=728322
2014-04-17 09:33:47 +02:00
Julien Isorce
499fb23e9c
omxvideodec: use new libgstgl API since libgstegl has been removed
...
There is no point to retrieve a ref/unref type
instead of an EGLDisplay directly. It's like for EGLImage.
https://bugzilla.gnome.org/show_bug.cgi?id=703343
2014-04-15 18:32:12 +01:00
Julien Isorce
d4bb7cb4c7
configure.ac: check for libgstgl since libgstegl has been removed
...
https://bugzilla.gnome.org/show_bug.cgi?id=703343
2014-04-15 18:32:12 +01:00
Aurélien Zanelli
1b6879921c
omxvideodec: add support of more color format
...
Add support for ABGR, ARGB, RGB16, BGR16, YUY2, UYVY, YVYU, GRAY8 and
NV16 color format.
2014-04-15 15:09:24 +01:00
Aurélien Zanelli
f5f876f681
omxvideodec: simplify color format conversion in fill_buffer function
2014-04-15 15:09:24 +01:00
Aurélien Zanelli
c115da9fd5
omx: add an helper to convert OMX color format to GStreamer color format
2014-04-15 15:09:23 +01:00
Josep Torra
718fd1bb93
omxvideodec: Implement pipeline draining to support adaptive scenarios
...
When draining due a format change also drain
the pipeline to reclaim back all buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=726107
2014-03-28 11:40:20 +00:00
Josep Torra
73d83f311c
omxvideodec: fixes race condition during seeks
...
Acording 6.1.3 Seek Event Sequence in the OpenMAX IL 1.1.2 spec
document in order to flush the component it needs to be in
paused state.
https://bugzilla.gnome.org/show_bug.cgi?id=726038
2014-03-25 16:07:25 +00:00
Julien Isorce
39ca9f980e
omxvideodec: use flush because reset is deprecated
...
https://bugzilla.gnome.org/show_bug.cgi?id=726038
2014-03-25 16:07:15 +00:00
Julien Isorce
777411c286
omxvideodec: populate the most downstream output port on reset
...
Make seeking work when using egl_render component
https://bugzilla.gnome.org/show_bug.cgi?id=726038
2014-03-25 16:06:51 +00:00
Christian König
651e67e32d
omxvideodec: add missing unlock in the error path
...
Signed-off-by: Christian König <christian.koenig@amd.com>
https://bugzilla.gnome.org/show_bug.cgi?id=726958
2014-03-24 11:11:39 +00:00
Sebastian Dröge
a04ef276e5
omx: Rename function from _4_ to _for_ for clarity
2014-03-12 12:47:34 +01:00
Christian König
6bf4d9a498
omxvideo: start sharing more code between video decoder and encoder
...
Identical functionality spread of two different components.
We can't use a common base class because of different inheritance,
but let's try to share the code anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=726024
2014-03-12 12:47:09 +01:00
Christian König
325c90f99d
omxvideodec: separate the buffer pool from the decoder
...
https://bugzilla.gnome.org/show_bug.cgi?id=726025
2014-03-12 12:42:03 +01:00
Christian König
de5f940186
omx: simplify tunnel functions
...
Specifying the component is error prone and unnecessary.
https://bugzilla.gnome.org/show_bug.cgi?id=726021
2014-03-12 08:48:46 +01:00
Christian König
14a0da437f
omxvideodec: fix memory leak in gst_omx_video_dec_allocate_output_buffers
...
https://bugzilla.gnome.org/show_bug.cgi?id=725907
2014-03-08 15:23:59 +01:00
Christian König
5ac0fe2108
omxvideodec: fix memory leak gst_omx_video_dec_negotiate
...
https://bugzilla.gnome.org/show_bug.cgi?id=725907
2014-03-08 15:22:15 +01:00
Christian König
2cfe70ed5d
omxvideodec: simplify _find_nearest_frame
...
No need to make it more complicated and error prone than
necessary. Also give the function a gst_omx_video_dec prefix
to distinct it from the encoder function.
https://bugzilla.gnome.org/show_bug.cgi?id=724236
2014-03-03 20:12:51 +01:00
Christian König
bf0d2614c3
omxvideodec: remove dead code
...
This code doesn't seems to be used for quite a while,
remove it before it starts to rot.
https://bugzilla.gnome.org/show_bug.cgi?id=724236
2014-03-03 20:12:35 +01:00
Christian König
0a8cfcde87
omxvideodec: fix startup race condition
...
The reset function shouldn't start the src pad
loop if it wasn't started before.
Signed-off-by: Christian König <christian.koenig@amd.com>
2014-03-02 12:08:09 +01:00
Sebastian Dröge
1bf4edf721
omx: Don't handle FLUSHING and NOT_LINKED as errors
...
Also don't stop the task on NOT_LINKED. We're not a demuxer.
2014-01-25 17:44:57 +01:00
Tim-Philipp Müller
498b74ab6a
omx: don't use the 'z' modifier to print size_t
...
gcc will warn in some cases even if the size of the type
is exactly that of size_t on the platform.
https://bugzilla.gnome.org/show_bug.cgi?id=699008
2013-08-20 16:00:07 +01:00
Josep Torra
f3f9330332
omx: Take lock on EOS to update the flow return value
...
Fixes "GThread-ERROR **: file gthread-posix.c: line 171
(g_mutex_free_posix_impl): error 'Device or resource busy' during
'pthread_mutex_destroy ((pthread_mutex_t *) mutex)'" in _finalize.
2013-05-20 12:06:34 +02:00
Josep Torra
64ef1f0e11
omxvideodec: Redesign video size change reconfiguration code
...
Ensure stop the decoder before clossing the tunnel.
2013-05-10 12:25:07 +02:00
jitendra
715b44ea66
omx: Add pads based on element type
...
This allows to later add sources and sink that only have a srcpad
or sinkpad.
https://bugzilla.gnome.org/show_bug.cgi?id=699754
2013-05-06 16:20:20 +02:00
Tim-Philipp Müller
a2db76b048
Check for gstreamer-egl
...
And don't use if not available.
https://bugzilla.gnome.org/show_bug.cgi?id=697574
2013-04-23 11:05:19 +01:00
Tim-Philipp Müller
2cbbab3128
omx: more printf format fixes
...
Fix printf formats again, so that gst-omx compiles warning-
free on the Raspberry Pi as well. Unfortunately OMX_UINT32
maybe be typedefed to uint32_t or unsigned long, which
doesn't work well with our debugging printf format strings,
so just use %u for those and cast to guint.
2013-04-18 23:10:13 +01:00
Josep Torra
9d0763a91d
omxvideodec: don't use 'self->dec_out_port' anymore and use just 'port'
...
Fixes some criticals.
2013-04-18 16:03:56 +02:00
Josep Torra
9de6308382
omxvideodec: fixes 'port' may be used uninitialized in this function
2013-04-18 15:21:32 +02:00
Josep Torra
4974f75d91
omxvideodec: silence warnings building for RPI related to 'vcos_*'
2013-04-18 12:03:31 +02:00
Josep Torra
ae3454683e
omxvideodec: Use new type from libgstvideo
2013-04-18 11:45:50 +02:00
jitendra
960590f92f
omx: Disable output port before transition to idle state
...
https://bugzilla.gnome.org/show_bug.cgi?id=698109
2013-04-16 12:46:48 +02:00
Tim-Philipp Müller
0c08d375f4
omx: fix printf formats in debug messages
...
OMX_U32 is typedefed to an unsigned long,
OMX_TICKS to a 64-bit integer.
2013-04-08 17:02:32 +01:00
Josep Torra
16cf5d77db
omxvideodec: use the correct printf format in a debug message
2013-04-08 16:52:19 +02:00
Josep Torra
c46a6a757e
omxvideodec: use the correct OMX_IndexParam value
...
Fixes playback is not smooth in the EGL path.
2013-04-08 16:31:33 +02:00
Sebastian Dröge
31159a9b36
omxvideodec: Don't use API that is not in master yet
...
It's not really needed here yet, will be needed in future versions
2013-04-05 13:45:24 +02:00
Sebastian Dröge
8a1bb1b4a3
omxvideodec: Add support for egl_render on RPi
2013-03-26 14:00:03 +01:00
Sebastian Dröge
4483581e2a
omx: Add more constraints to the default sink template caps
2013-03-19 13:28:30 +01:00
Sebastian Dröge
e533da2b22
omxvideodec: Set ENDOFFRAME flag for the end of frames
2013-03-19 12:55:09 +01:00
Josep Torra
a5778efe16
omx: Clarify that loop task is also paused in EOS
2013-03-16 10:00:24 +01:00
Sebastian Dröge
2b580837f5
omxvideodec: Make sure that the first frame we pass to OpenMAX is a sync frame
2013-03-15 14:09:45 +01:00
Sebastian Dröge
e1f94660f7
omx: Stop output port task after draining
2013-03-15 11:46:34 +01:00
Sebastian Dröge
84c6fd44d2
omxvideodec: Deallocate output buffers with the right function
2013-03-15 10:38:58 +01:00
Sebastian Dröge
047b3735cf
omxvideodec: Don't interpolate timestamps
...
We will get exactly one frame per input buffer and assigning
timestamps between frames if more than one OMX buffer is required
per frame easily confuses timestamp tracking in OMX.
2013-03-15 09:51:42 +01:00
Sebastian Dröge
c59d8930ac
omxvideodec: Give the codec_data the timestamp of the first frame and no duration
2013-03-15 09:51:34 +01:00
Sebastian Dröge
bda1e97abd
omxvideodec: Simplify bufferpool implementation
2013-03-14 14:51:32 +01:00
Sebastian Dröge
9128ba5018
omxvideodec: Improve min/max buffer counts handling
2013-03-14 12:52:46 +01:00
Sebastian Dröge
22dce51dd4
omx: Handle the OMX_EventBufferFlag to detect EOS too
2013-03-14 12:51:54 +01:00
Sebastian Dröge
1ebd34e637
omxvideodec: Make sure to always get the right buffer
2013-03-13 09:38:03 +01:00
Sebastian Dröge
f4ad6e0858
omxvideodec: Make sure the buffer is released to the pool if it's not the one we wanted
2013-03-13 09:37:58 +01:00
Sebastian Dröge
ef357cce80
omxvideodec: Drop too late frames instead of finishing them
2013-03-13 09:37:43 +01:00
Sebastian Dröge
fa7be0b618
omx: Release buffers to the correct port
2013-03-13 09:37:36 +01:00
Sebastian Dröge
448ea34b75
omxvideodec: Don't provide buffers to downstream
...
This only works reliable if we have a way to tell downstream to
release all our buffers for reconfiguration.
2013-03-11 10:39:25 +01:00
Sebastian Dröge
00be69f4a0
omxvideodec: Disable output port when setting a new format
...
Based on a patch by Josep Torra <n770galaxy@gmail.com>
2013-03-11 10:22:07 +01:00
Sebastian Dröge
65174bbd7f
omx: Catch errors when releasing buffers to a port and handle them
2013-03-11 10:04:10 +01:00
Josep Torra
bd071327da
omx: Fix deadlock in encoders and add explainatory comments.
2013-03-09 14:14:40 +01:00
Josep Torra
7423e3e023
omxvideodec: fix printf format identifier
2013-03-09 13:27:08 +01:00
Josep Torra
cde5df17fa
omx: Minor changes on debuging info
2013-03-09 13:24:30 +01:00
Josep Torra
6d8bf76391
omxvideodec: avoid a deadlock
2013-03-09 13:24:16 +01:00
Sebastian Dröge
aa6be53375
omxvideodec: Don't forget to populate output port
2013-03-08 15:58:01 +01:00
Sebastian Dröge
c014b1c9a3
omx: Flush and stop srcpad when configuring new caps
2013-03-08 15:50:20 +01:00
Sebastian Dröge
ed0de9d699
omxvideodec: Only negotiate a color format with downstream on the initial caps
2013-03-07 17:38:40 +01:00
Sebastian Dröge
bbd30a96bd
omxvideodec: Make sure the output port is disabled while we allocate buffers
2013-03-07 17:29:43 +01:00
Sebastian Dröge
0cd96e8c6b
omxvideodec: Add buffer pool for sharing OpenMAX memory with downstream
2013-03-07 14:10:12 +01:00
Sebastian Dröge
7a1eaec3b9
omx: Add timeout to the flush operation and move buffer populating to a separate function
2013-03-07 13:57:00 +01:00
Sebastian Dröge
60861f3990
omx: Do number of buffers configuration explicitely
2013-03-07 13:56:44 +01:00
Josep Torra
cc495aeb16
omxvideodec: fixes reconfiguration
...
Avoid having fixed fields from previous caps on reconfiguration.
2013-03-07 11:24:54 +01:00
Sebastian Dröge
687a188dad
omxvideo{dec,enc}: Don't use the input state if it wasn't set yet
2013-03-01 11:44:17 +01:00
Sebastian Dröge
63e0d61971
omxvideodec: Only enable the output port after we know the output format
2013-03-01 11:21:25 +01:00
Sebastian Dröge
aeec430261
omx: Return the OMX_ERRORTYPE from gst_omx_port_update_port_definition
2013-02-28 15:49:14 +01:00
Sebastian Dröge
1a906da409
omx: Add API for allocating a specific number of buffers and using EGLImages or buffers allocated elsewhere
2013-02-28 11:20:52 +01:00
Sebastian Dröge
e42faae652
omx: Refactor code flow a bit if output port settings have changed
2013-02-27 16:56:02 +01:00
Sebastian Dröge
b12610efd7
omx: Clean up port settings change handling
2013-02-27 15:50:20 +01:00
Josep Torra
26b69d99a2
omxvideodec: initialize param structure before using it
2013-02-27 11:30:14 +01:00
Josep Torra
3973425689
omxvideodec: prevent a NULL pointer access
2013-02-26 17:25:49 +01:00
Sebastian Dröge
5b45cb0810
omx: Auto-detect the port indizes if possible
2013-02-25 12:42:05 +01:00
Sebastian Dröge
3e090dd83b
omx: Refactor querying of component supported caps into its own function
2013-02-25 11:42:38 +01:00
Sebastian Dröge
70368c31cd
omx: Refactor waiting for buffers to be released by the component to a separate function
2013-02-25 10:41:12 +01:00
Sebastian Dröge
e08b801fea
omxvideodec: Rename component variable
2013-02-25 09:19:08 +01:00
Sebastian Dröge
219a93bbaf
omx: Some minor refactoring and cleanup
2013-02-12 11:49:21 +01:00
Sebastian Dröge
c3bcc43db7
omx: Split enabling/disabling of port into sending the command and waiting for it
...
This allows to do anything necessary after sending the command to actually let it finish
2013-02-12 11:41:43 +01:00
Sebastian Dröge
be31e7273b
omx: Fix some memory leaks and suboptimal locking
2013-01-14 10:36:57 +01:00
Sebastian Dröge
2fd8d72c50
omxvideodec: Fix copying of the video frames from the OMX buffers
2013-01-14 10:36:38 +01:00
Sebastian Dröge
1bf69c8f69
omxvideodec: Set the OMX buffer nFilledLength field properly
2012-12-20 19:30:38 +01:00
Sebastian Dröge
1d01c0ebf0
omx: Fix ununsed variable compiler warning
2012-12-20 12:30:05 +01:00
Sebastian Dröge
83b4c1d892
omx: No need to start the srcpad task in ::start() already
...
It will be started properly after the caps are set.
2012-12-20 12:27:47 +01:00
Sebastian Dröge
4ef40839a2
omxvideodec: OMX_ErrorNoMore is no error and just means we ended iteration
2012-12-20 12:23:49 +01:00
Sebastian Dröge
f90a6ed9e9
omx: Improve debug output
2012-12-20 12:20:31 +01:00
Sebastian Dröge
f6f078e847
omxvideodec: Don't forget to free a GList
2012-12-20 12:02:30 +01:00
Sebastian Dröge
20280afa1f
omxvideodec: Map OMX_COLOR_FormatYUV420PackedPlanar to I420 too
...
This is used on the Raspberry Pi.
2012-12-20 11:56:29 +01:00
Sebastian Dröge
a80e2b9053
omxvideodec: During negotiation of the output format make sure we use the correct OpenMAX format
2012-12-20 11:55:36 +01:00
Sebastian Dröge
07e0d674a0
omxvideodec: If negotiation fails this could also mean that the component can't do it at this point yet
2012-12-20 11:42:17 +01:00
Sebastian Dröge
7354baec66
omxvideodec: Improve format negotiation a bit
...
Don't leak caps and make sure to fixate caps.
2012-12-20 11:40:28 +01:00
Sebastian Dröge
9c464924a5
omxvideodec: Extract data from the input buffer, not the codec data
2012-12-19 12:44:31 +01:00
Sebastian Dröge
7fa4616598
omx: Fix refcount problem with frames being dropped because of decoder bugs
2012-11-12 15:14:09 +01:00