Commit graph

8 commits

Author SHA1 Message Date
Jan Schmidt
1b7a2c9c72 Make theoraenc and the tests leak free. Like, really.
Original commit message from CVS:
* ext/theora/theoraenc.c: (gst_theora_enc_class_init),
(theora_enc_finalize), (theora_enc_sink_setcaps),
(theora_set_header_on_caps), (theora_enc_chain),
(theora_enc_change_state):
* tests/check/pipelines/theoraenc.c: (GST_START_TEST):
Make theoraenc and the tests leak free. Like, really.
2006-02-06 12:38:48 +00:00
Jan Schmidt
5109622dd0 Add a finalize method to ensure we clean up state even if someone omitted the state change back to NULL.
Original commit message from CVS:
(theora_enc_finalize), (theora_enc_sink_setcaps):
Add a finalize method to ensure we clean up state even if
someone omitted the state change back to NULL.

* ext/vorbis/vorbisenc.c: (gst_vorbisenc_metadata_set1),
(gst_vorbisenc_chain):
Free some more leaked bits.

* tests/check/pipelines/theoraenc.c: (start_pipeline),
(stop_pipeline):
Wait for state changes to happen if they're ASYNC.

This ought to teach those fancy pants buildbots a lesson.
2006-02-05 23:31:05 +00:00
Thomas Vander Stichele
10cf7276d1 comment on my understanding
Original commit message from CVS:
comment on my understanding
2006-02-02 08:53:27 +00:00
Thomas Vander Stichele
a80c8f6887 reformat to fit 80 chars
Original commit message from CVS:
reformat to fit 80 chars
2006-02-02 08:47:42 +00:00
Jan Schmidt
0bdf850dbe tests/check/pipelines/: Define constant using G_GINT64_CONSTANT to avoid errors when passing it around - otherwise it...
Original commit message from CVS:
* tests/check/pipelines/theoraenc.c:
* tests/check/pipelines/vorbisenc.c:
Define constant using G_GINT64_CONSTANT to avoid errors when
passing it around - otherwise it gets truncated to 32 bits.

Fixes failing tests.
2006-01-31 16:26:57 +00:00
Andy Wingo
f2476d444b ext/theora/theoraenc.c (theora_enc_sink_setcaps)
Original commit message from CVS:
2006-01-30  Andy Wingo  <wingo@pobox.com>

* ext/theora/theoraenc.c (theora_enc_sink_setcaps)
(gst_theora_enc_init): Pull the granule shift out of the encoder.
(granulepos_add): New function, handles the messiness of adjusting
granulepos values.
(theora_buffer_from_packet):
(theora_enc_chain):
(theora_enc_sink_event): Use granulepos_add, not +.

* tests/check/pipelines/theoraenc.c
(check_buffer_granulepos_from_starttime): Just check the frame
count, not the actual granulepos -- we can't dictate to the
encoder when it should be placing keyframes.
2006-01-30 19:21:07 +00:00
Andy Wingo
055cf96c4d tests/check/pipelines/: Totally remove the UINT64_CONSTANT macro, doesn't appear to be needed or available.
Original commit message from CVS:
2006-01-30  Andy Wingo  <wingo@pobox.com>

* tests/check/pipelines/vorbisenc.c (TIMESTAMP_OFFSET):
* tests/check/pipelines/theoraenc.c (TIMESTAMP_OFFSET): Totally
remove the UINT64_CONSTANT macro, doesn't appear to be needed or
available.
2006-01-30 17:08:11 +00:00
Andy Wingo
35f966cf13 ext/theora/: Same changes as were done to vorbisenc, although theoraenc was timestamping correctly. Added handling of...
Original commit message from CVS:
2006-01-30  Andy Wingo  <wingo@pobox.com>

* ext/theora/gsttheoraenc.h:
* ext/theora/theoraenc.c: Same changes as were done to vorbisenc,
although theoraenc was timestamping correctly. Added handling of
streams that start with nonzero timestamps.

* tests/check/Makefile.am:
* tests/check/pipelines/theoraenc.c: New file, basically does same
tests as vorbisenc.

* tests/check/pipelines/vorbisenc.c: I claim these bugs.
2006-01-30 17:01:54 +00:00