Luis de Bethencourt
4d43472c2b
mxfdemux: renaming GstFlowReturn variable
...
Having a variable named ret in a static void function is very confusing since
this usually is to store what the function will return.
2015-02-18 19:26:43 +00:00
Luis de Bethencourt
b7e0c7a163
mxfdemux: remove ignored value
...
Value stored in ret will be ovewritten in the next iteration of the loop. Which
means it is never used.
Plus a style issue to make gst-indent happy and allow the commit.
2015-02-18 18:00:54 +00:00
Mathieu Duponchelle
631663b854
mxfdemux: Use IndexTableSegments.
...
This speeds up seeking drastically.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732294
2014-12-14 12:53:55 +01:00
Vineeth T M
14acb6fb37
gst: remove unnecessary GLIB_DISABLE_DEPRECATION_WARNINGS
...
There are unnecessary definitions for disabling deprecation warnings.
Since GLIB_DISABLE_DEPRECATION_WARNINGS is not needed anymore in these files,
removing the same.
https://bugzilla.gnome.org/show_bug.cgi?id=737559
2014-10-02 10:51:35 +03:00
Sebastian Rasmussen
e79e96e59d
mxfmux: Avoid taking unnecessary ref
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=733123
2014-07-16 16:47:21 +02:00
Thiago Santos
b8d87c11ab
mxfdemux: remove unread last_flow variable
...
it isn't necessary anymore and is already unused
2014-05-27 07:42:46 -03:00
Sebastian Dröge
a3489ffa83
mxfdemux: Compare positions to find the earliest pad, not flow returns
2014-05-27 12:24:43 +02:00
Thiago Santos
ae839d8dc2
mxfdemux: use GstFlowCombiner
...
Removes flow return combination code to use the newly added GstFlowCombiner
https://bugzilla.gnome.org/show_bug.cgi?id=709224
2014-05-26 23:29:43 -03:00
Tim-Philipp Müller
f8d63c5ad9
mxfdemux: post error message when erroring out on unsupported essence wrapping
2014-05-14 00:25:09 +01:00
Vincent Penquerc'h
60d7e45cab
mxf: fix MP2 case
...
Testing mpegversion when mpegaudioversion was likely meant.
Similar tests in sys/androidmedia/gstamcaudiodec.c also test
mpegaudioversion with the same conditional code.
Coverity 206071
2014-04-21 13:23:46 +01:00
Vincent Penquerc'h
d111287995
mxfmux: guard against dividing by 0
...
Use a placeholder value in that case, it's better than crashing.
Coverity 1139697
2014-04-21 13:23:46 +01:00
Vincent Penquerc'h
52981d5a4a
mxfdemux: guard against NULL non source components
...
This component is dereferenced, and later code checking for
NULL in particular cases implies it can be NULL. This likely
does not fix the coverity warning as it was seeing another
path setting component to NULL explicitely, but this was
spotted by looking at:
Coverity 1139736
Which is actually OK from what I can see since the actual
dereference of the explicit NULL pointer will not happen
if the condition that led to the NULL pointer assignment
is met, since the assignment and defeference have mutually
exclusive tests.
2014-04-21 09:24:00 +01:00
Edward Hervey
3d6265a9f5
mxfdemux: Fix copy/paste error
...
We want to check whether the rate is different. We check changes in
numerator *and* denominator.
CID #1139631
CID #1139642
2014-04-16 16:25:29 +02:00
Edward Hervey
be859d02a6
mxf: Handle fraction parsing failure
...
And properly cleanup/reset the segment before returning on errors
CID #206012
2014-04-16 16:19:47 +02:00
Edward Hervey
fa72b4c870
mxf: Remove useless check
...
a guint will always smaller or equal to the maximum value it can
contain
CID #206049
2014-04-16 16:12:02 +02:00
Vincent Penquerc'h
172c398127
mxf: avoid dereferencing NULL mapping data pointer
...
Also unref buffers on error, as it seems to be done in one, but
not all, error paths.
The NULL pointer part is Coverity 206112
https://bugzilla.gnome.org/show_bug.cgi?id=727889
2014-04-16 16:08:38 +02:00
Tim-Philipp Müller
39dc1f0ebb
mxfdemux: guard against NULL material track
...
Just to be on the safe side.
2014-04-08 16:53:41 +01:00
Tim-Philipp Müller
6e764e5b11
mxfdemux: implement simple KEY_UNIT seeking
...
If a KEY_UNIT seek was requested, adjust segment
start to position of the key frame.
2014-04-08 14:37:34 +01:00
Tim-Philipp Müller
4898a51afe
mxfdemux: fix seeking, send data starting from a key unit
...
Fixes multiple seeking issues. When doing ACCURATE or normal
non-KEYUNIT seeks, mxfdemux would just send data from the
edit unit that covered the seek position, whether that's
a keyframe or not. Decoders would only output things from
the next keyframe then, which means there's a gap between
the start of the segment and the first decoded data in
some cases. In combination with gst-editing-services this
might result in a frozen picture for the duration of that
gap at the beginning (if videorate fixes up the first
buffer's start timestamp to cover the entire gap), or
a black frame (if no videorate is used and videomixer
fills the gap). Also fixes A/V sync issue when requesting
a KEYUNIT seek.
2014-04-08 13:26:49 +01:00
Vincent Penquerc'h
8e580ea6f1
mxf: fix stop date parsing using the wrong input
...
Coverity 1139645
2014-04-07 13:54:50 +01:00
Sjoerd Simons
f6da7ea8bb
mxfdemux: Don't go into pull mode when the sequential flag is set
...
When the scheduling query results has GST_SCHEDULING_FLAG_SEQUENTIAL set
in its flags don't go into pull mode to prevent over-eager seeking.
https://bugzilla.gnome.org/show_bug.cgi?id=722934
2014-01-24 22:14:47 +01:00
Sebastian Dröge
6812f96de4
gst: Don't swap start/stop for negative rates in the SEGMENT query
2013-07-29 12:14:08 +02:00
Sebastian Dröge
6b78fa336d
mxfdemux: Implement SEGMENT query
2013-07-29 11:02:54 +02:00
Sebastian Dröge
46e85b4a6c
mxfdemux: Add support for group-id in the stream-start event
2013-07-23 10:33:31 +02:00
Sebastian Dröge
e51cd4fe2f
gst: Add better support for static plugins
2013-04-15 15:59:22 +02:00
Stefan Sauer
2991e1ed48
mfxdemus: update todo (ther eis a muxer)
2013-04-11 10:06:23 +02:00
David Schleef
65cb59912b
mxfdemux: Use %03u for format in gst_pad_create_stream_id_printf()
2013-03-25 18:57:32 -07:00
David Schleef
6005ab322d
mxfdemux: Add a second MXF UL for uncompressed audio
2013-03-14 14:41:38 -07:00
David Schleef
f0ab12fe89
mxfdemux: Ignore missing metadata descriptors
2013-03-14 14:41:37 -07:00
Tim-Philipp Müller
dee6536421
mxfdemux: fix taglist leak
...
Don't leak demuxer tag list.
2013-02-11 20:24:14 +00:00
Tim-Philipp Müller
453438a9dd
mxfdemux: fix push mode unit test failure
...
In the sink event handler we end up sending multiple EOS
events per pad. Don't return FALSE when sending the
second EOS on an already-EOS pad fails. Not sure if there
was a reason for sending a second EOS, so leaving the
code in there for now, but assume all went fine if there
are source pads, which is slightly less wrong than before.
This function needs work.
2013-02-11 19:59:20 +00:00
Marc Leeman
6aa399ec9f
mxfdemux: deprecated GStaticRWLock -> GRWLock
...
https://bugzilla.gnome.org/show_bug.cgi?id=693322
2013-02-09 18:35:48 +00:00
Thijs Vermeir
35a5100bc3
mxf: use appropriate printf format for gsize
2012-12-18 16:50:37 +01:00
Tim-Philipp Müller
b0c30383ca
mxfdemux: printf format fixes for debug messages
2012-12-12 18:50:09 +00:00
Sebastian Dröge
3478231790
mxfdemux: Don't allow any wrapping other than frame wrapping
...
Bad things will happen otherwise, like reading a complete,
multiple GB large video track into a single buffer.
Conflicts:
gst/mxf/mxfdemux.c
2012-12-06 10:10:05 +01:00
Sebastian Dröge
76ca3c77d7
mxfdemux: Add function to get the essence track wrapping
2012-12-06 10:09:21 +01:00
Sebastian Dröge
28c11b2762
mxf: Add support for parsing filler structural components
...
This does not add support for actually producing filler data
if there's a filler component in a timeline.
2012-12-05 12:24:30 +01:00
Sebastian Dröge
a83b798312
mxf: Improve debug output during metadata resolval
2012-12-05 12:10:44 +01:00
Sebastian Dröge
84e5418cfc
mxf: Add more support for RP2008 (AVC in the MPEG mapping)
...
Conflicts:
gst/mxf/mxfmpeg.c
2012-11-30 15:19:35 +01:00
Tim-Philipp Müller
9e1b75fda3
Fix FSF address
...
https://bugzilla.gnome.org/show_bug.cgi?id=687520
2012-11-04 00:09:59 +00:00
Michael Smith
0c8a7fa46f
mxf: Port mxfdemux to 1.0
...
Also ports mxfmux to 1.0 to the extent that it compiles, but is 100% untested,
so remains disabled.
Conflicts:
gst/mxf/mxfdemux.c
gst/mxf/mxfmux.c
2012-10-26 13:48:06 -07:00
Tim-Philipp Müller
32ba17cd0f
Use gst_element_class_set_static_metadata()
...
where possible. Avoids some string copies. Also re-indent
some stuff. Also some indent fixes here and there.
2012-10-17 17:46:34 +01:00
Mark Nauwelaerts
578861abea
replace gst_element_class_set_details_simple with gst_element_class_set_metadata
2012-09-14 17:27:49 +02:00
Stefan Sauer
27cd08ad95
collectpads: remove gst_collect_pads_add_pad_full
...
Rename gst_collect_pads_add_pad_full() to gst_collect_pads_add_pad() and fix all
invocations.
2012-09-12 21:13:35 +02:00
Tim-Philipp Müller
489b102a43
gst_tag_list_free -> gst_tag_list_unref
2012-08-04 16:31:30 +01:00
Sebastian Dröge
9c7d7498bb
gst: Implement segment-done event
2012-07-05 13:18:47 +02:00
Wim Taymans
dbed726057
update for task api change
2012-06-20 10:40:42 +02:00
Mark Nauwelaerts
6578797245
collectpads2: rename to collectpads
2012-04-17 15:22:59 +02:00
Sebastian Dröge
cda192b3b7
gst: Update for GST_PLUGIN_DEFINE() API changes
2012-04-05 18:02:56 +02:00
Sebastian Dröge
1318a97e0a
gst: Update versioning
2012-04-04 14:44:34 +02:00