Haihao Xiang
a0943aec69
msdkvpp: don't use NV12 as default output in normal mode
...
If so, BGRA is the preferred output format hence BGRA will be selected
as input format by default, e.g. in the pipleline below, BGRA instead of
NV12 is selected without renegotiation, so we can avoid the NV12 issue
(see commit 3f2314a
) by default.
gst-launch-1.0 videotestsrc ! msdkvpp ! glimagesink
2019-01-08 10:08:43 +08:00
Haihao Xiang
7681566f29
msdkvpp: close the current VPP session if this session has been initialized
...
Otherwise MFXVideoVPP_Init will fail because it is called twice without
a close.
Example pipeline:
gst-launch-1.0 videotestsrc ! msdkvpp ! glimagesink
Sometimes glimagesink emits GST_EVENT_RECONFIGURE event which results
in that MFXVideoVPP_Init is called twice, then get the negotiation
failure below:
0:00:00.093715518 21218 0x558ef56231e0 ERROR msdkvpp
gstmsdkvpp.c:995:gst_msdkvpp_initialize:<msdkvpp0> Init failed
(undefined behavior)
WARNING: from element /GstPipeline:pipeline0/GstMsdkVPP:msdkvpp0: not
negotiated
After applying this commit, the pipeline above may run without
negotiation failure, however NV12 layout in dmabuf mode is selected in
renegotiation, the display image is corrupted due to the NV12 issue which
was mentioned in commit 3f2314a
. Some other fixes are needed to avoid
renegotiation by default
2019-01-08 10:08:43 +08:00
Haihao Xiang
e8d2f58e23
msdkvpp: don't update pads' info if nothing have changed
2019-01-08 10:08:43 +08:00
U. Artie Eoff
e91a53f693
msdkenc: break out of flush frames loop on error
...
In general, we should assume any unhandled error is
non-recoverable.
In the flush frames loop, some error states can cause us
to never increment the task and therefore we get stuck
in an infinite loop and generate GST_ELEMENT_ERROR
over and over again. This eventually consumes all
system memory and triggers OOM. Thus, assume the worst
and break out of the loop upon the first "unhandled" error.
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/859
2019-01-06 19:07:35 -08:00
Nirbheek Chauhan
8249763f6c
wasapi: Fix double call to Start when resetting the element
...
When either the source or sink goes from PLAYING -> NULL -> PLAYING,
we call _reset() which sets client_needs_restart, and then we call
prepare() which calls IAudioClient_Start(), so we don't need to call
it again in src_read() or sink_write(). Unlike when we're just going
PLAYING -> PAUSED -> PLAYING.
2019-01-04 18:47:07 +05:30
Sebastian Dröge
2f05ee9ba9
wasapisink: Don't call CoUninitialize() twice in unprepare()
...
It has to be symmetric with CoInitialize(), otherwise everything else
will fail.
2019-01-03 15:21:39 +00:00
Sebastian Dröge
822abde8a4
decklinkvideosink: Don't forget to unref clock after usage
...
And don't unref a clock that is potentially NULL.
2019-01-02 17:39:19 +02:00
Tim-Philipp Müller
9eb7f7cbc7
webrtc: include stdlib.h for atoi()
...
Fixes #857
2018-12-31 12:09:42 +00:00
Seungha Yang
82b921e1a4
tests: Enable more tests on Windows
2018-12-30 22:34:43 +09:00
Seungha Yang
33f867236b
tests: Remove compositor test
...
It's moved to -base and no more part of -bad
2018-12-30 22:34:43 +09:00
Seungha Yang
8cd89b2cdd
tests: Remove pointless unistd include
2018-12-30 22:34:43 +09:00
Tim-Philipp Müller
88683e5a1e
Remove openglmixers plugin, moved to -base
...
Merged into the existing opengl plugin in -base.
2018-12-28 13:48:29 +01:00
Tim-Philipp Müller
e42efbccb1
Remove compositor plugin which was moved to -base
...
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/138
2018-12-27 15:31:58 +01:00
Tim-Philipp Müller
b9e15fddb1
Remove GstVideoAggregator, moved into libgstvideo in -base
...
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/137
2018-12-26 19:06:33 +01:00
Tim-Philipp Müller
ae194e99d9
opencv: fix disting of new header files
...
Fixes distcheck.
2018-12-25 16:58:40 +01:00
Tim-Philipp Müller
63e961ff7a
stereo: remove plugin which has been merged into audiofx in -good
...
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/457
2018-12-25 13:06:40 +01:00
Seungha Yang
373580c7be
msdk: Fix invalid return type build warning
...
void function cannot have return value
gst-plugins-bad/sys/msdk/gstmsdkbufferpool.c(332): warning C4098:
'gst_msdk_buffer_pool_release_buffer': ...
2018-12-25 16:14:36 +09:00
Justin Kim
2faa08ff28
openal: Fix AL header path for Mac OS X
...
OpenAL.framework doesn't provide 'alext.h'.
Thus, openal is enabled only if the dependency
is set by pkg-config.
fixes : #852
2018-12-25 00:42:31 +09:00
Philippe Normand
b5af1b9f2e
player: Logging fix for updated audio info
...
Bitrate was logged a second time instead of the max_bitrate.
2018-12-22 18:39:44 +01:00
Sebastian Dröge
3891bf2695
timecodestamper: Don't use deprecated API
2018-12-20 10:13:45 +02:00
Matthew Waters
b4bdcf15b7
webrtc/receive-bin: block pads before dtlssrtpdec:
...
Fixes SSL errors in fast-start scenarios and whenever media stream may
be received before an answer is set.
2018-12-19 00:44:06 +00:00
Matthew Waters
26a5cbddbb
webrtcbin: only change the receive state after setting the dtls-client
...
Doing so before will cause SSL errors with fast-start implementations
like Chrome or if media data arrives before an answer.
2018-12-19 00:44:06 +00:00
Matthew Waters
0a3f662ed6
webrtc: A couple of documentation fixes
...
set-*-description only takes the combined GstWebRTCSessionDescription
object
2018-12-19 00:44:06 +00:00
Sebastian Dröge
c47fac42cd
decklinkvideosink: Fix support for raw CEA608 input and add support for raw CEA708 input
...
The former was only considering the first byte pair, for the latter we
have to convert raw CEA708 cc_data into CDP.
2018-12-19 00:20:26 +02:00
Sebastian Dröge
fcceb37bf2
ccconverter: Add unit test
2018-12-19 00:20:26 +02:00
Sebastian Dröge
39381643c8
closedcaption: Add ccconverter element that can convert between different types of Closed Caption formats
2018-12-19 00:19:39 +02:00
Xavier Claessens
f49da047dc
Fix build when we have tinyalsa but not its header
2018-12-18 21:08:10 +00:00
Seungha Yang
fa3ae13250
tests: Re-enable isoff test on Windows
...
... and drop libxml2 dependency since it never be used by
both test and gstisoff.
2018-12-18 16:48:17 +00:00
Seungha Yang
b606ff16a9
tests: Fix build with MSVC
2018-12-18 16:48:17 +00:00
Seungha Yang
1b0b2c37cc
meson: Prefer to use join_paths() over '/'
...
... to avoid mixing '/' and '\' in a path string on Windows.
2018-12-18 16:48:17 +00:00
Seungha Yang
f74ad82ddc
tests: Enable unit test on Windows
...
Allow run some unit tests on Windows.
* Add dependency explicitly for some test cases, otherwise plugins couldn't be
loaded on uninstalled environment of Windows.
* Add missing GST_PLUGIN_LOADING_WHITELIST on meson build.
2018-12-18 16:48:17 +00:00
Nicolas Dufresne
5b372a9707
kmssink: Accept underscore in property
...
Otherwise sdi_mode and similar properties would be canonicalised to
sdi-mode.
2018-12-18 16:36:57 +01:00
Guillaume Desmottes
cbff147f71
kmssink: fix tmp_kmsmem leaks
...
configure_mode_setting() keeps a ref on tmp_kmsmem which is released in
gst_kms_sink_show_frame().
But if for some reason configure_mode_setting() is re-called before
showing a frame or if none is showed this memory was leaked.
2018-12-18 15:44:23 +01:00
Tim-Philipp Müller
6ca10c633d
Remove acmmp3dec and acmenc plugins
...
ACM is an ancient legacy API, and there's no point in
keeping it around for a licensed mp3 decoder now that
mp3 patents have expired and we have a decoder in -good.
We didn't ship this in cerbero anyway. If there's a good
case for the AAC encoder (which is LC only anyway) someone
should write a new plugin based on current APIs, that can
actually be built out of the box.
Fixes #850
2018-12-18 10:06:59 +00:00
Tim-Philipp Müller
da7cf85e3c
meson: fix opencv=disabled case if opencv is available on the system
...
ext/opencv/meson.build:103:2: ERROR: Unknown variable "gstopencv_dep".
2018-12-17 18:58:52 +00:00
Tim-Philipp Müller
a26cce1833
meson: wildmidi detection fixes
...
Need at least 0.4.2 apparently.
ext/wildmidi/meson.build:11:2: ERROR: String '' cannot be converted to int
2018-12-17 17:11:00 +00:00
Jonathan Karlsson
d49bc71f00
curlhttpsink: free content type before assigning it
...
Not doing this would result in a memory leak.
2018-12-17 15:56:08 +00:00
Jonathan Karlsson
e8ec1c0143
curlbasesink: cleanup transfer immediately when done
2018-12-17 14:24:07 +00:00
Jan Alexander Steffens (heftig)
f964fb38b6
fdkaac: Syntax tweaks to increase readability
...
Mostly move some assignments out of conditionals that gst-indent
completely destroys.
2018-12-17 12:39:13 +00:00
Jan Alexander Steffens (heftig)
c5a17000b6
fdkaacdec: Enable 8-channel playback
...
The decoder seems to default to 6 channels max, downmixing 7.1 to 5.1.
Disable the channel limit to expose all channels to GStreamer.
In addition, none of the standard configurations use ACT_SIDE channels.
The rear channels of the 7.1 configuration have to be taken from
ACT_BACK. See the table in aacenc_lib.h, reproduced here:
----------------------------------------------------------------------------------------
ChannelMode | ChCfg | Height | front_El | side_El | back_El | lfe_El
-----------------------+-------+--------+---------------+----------+----------+---------
MODE_1 | 1 | NORM | SCE | | |
MODE_2 | 2 | NORM | CPE | | |
MODE_1_2 | 3 | NORM | SCE, CPE | | |
MODE_1_2_1 | 4 | NORM | SCE, CPE | | SCE |
MODE_1_2_2 | 5 | NORM | SCE, CPE | | CPE |
MODE_1_2_2_1 | 6 | NORM | SCE, CPE | | CPE | LFE
MODE_1_2_2_2_1 | 7 | NORM | SCE, CPE, CPE | | CPE | LFE
MODE_6_1 | 11 | NORM | SCE, CPE | | CPE, SCE | LFE
MODE_7_1_BACK | 12 | NORM | SCE, CPE | | CPE, CPE | LFE
-----------------------+-------+--------+---------------+----------+----------+---------
MODE_7_1_TOP_FRONT | 14 | NORM | SCE, CPE | | CPE | LFE
| | TOP | CPE | | |
-----------------------+-------+--------+---------------+----------+----------+---------
MODE_7_1_REAR_SURROUND | 0 | NORM | SCE, CPE | | CPE, CPE | LFE
MODE_7_1_FRONT_CENTER | 0 | NORM | SCE, CPE, CPE | | CPE | LFE
----------------------------------------------------------------------------------------
- NORM: Normal Height Layer. - TOP: Top Height Layer. - BTM: Bottom Height Layer.
- SCE: Single Channel Element. - CPE: Channel Pair. - LFE: Low Frequency Element.
Restores 8 channels to
https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4
2018-12-17 12:39:13 +00:00
Jan Alexander Steffens (heftig)
4ec3f2f193
fdkaacenc: Add support for v2.0.0 and its configurations
...
These are MPEG-standard configurations so should be checked first,
before the PCE clones added by v0.1.4.
2018-12-17 12:39:13 +00:00
Jan Alexander Steffens (heftig)
bc3c5ea7b1
fdkaacenc: Add support for MPEG configuration 7
2018-12-17 12:39:13 +00:00
Jan Alexander Steffens (heftig)
3a9f5a76e8
fdkaacenc: Add a description of each configuration
2018-12-17 12:39:13 +00:00
Jan Alexander Steffens (heftig)
383fe6f81d
fdkaacenc: Prefer REAR for surround channels
...
We (currently?) prefer to use the REAR positions for what MPEG calls
"surround" channels.
2018-12-17 12:39:13 +00:00
Tim-Philipp Müller
d3f174f77f
Remove daala plugin
...
Not so useful now that all effort is focused on AV1 instead.
Was only ever enabled with --enable-experimental anyway.
Fixes #848
2018-12-17 12:03:09 +00:00
Sebastian Dröge
38be1fb2db
meson: Add libsinc to the CFLAGS
...
Otherwise gst-i18n-plugin.h can't be found.
2018-12-17 12:30:27 +02:00
Tim-Philipp Müller
2e6510b9e2
meson: build openni2 plugin
2018-12-17 09:12:53 +00:00
Tim-Philipp Müller
094478d248
meson: build openmpt plugin
2018-12-17 09:12:53 +00:00
Tim-Philipp Müller
79d8855d87
meson: build openexr plugin
2018-12-17 09:12:53 +00:00
Tim-Philipp Müller
c23a1dc2b6
meson: build openal plugin
2018-12-17 09:12:53 +00:00