Tim-Philipp Müller
6c09710292
flacenc: avoid potential string overflow
...
We don't necessarily have full control over the input tags, so
it's possible that the ISRC tag contains a longer string than
expected, in which case we'd write over the end of the static-size
13 byte buffer that is FLAC__StreamMetadata_CueSheet_Track::isrc.
Make sure to only copy the ISRC if it's not too long, and make
sure the buffer we write to is always NUL-terminated by using
g_strlcpy().
CID 1324931.
2015-09-28 20:25:22 +01:00
Thiago Santos
13d49d9b3e
flacenc: actually return true for accept-caps query handling
2015-08-17 14:33:35 -03:00
Thiago Santos
0899529222
flacenc: remove single entry if from loop
...
Iterate from the 2nd channel on and create the 1 channel struct
outside to make loop structure simpler and only slightly faster.
2015-08-16 14:30:57 -03:00
Thiago Santos
a00546e078
flacenc: implement proper accept-caps
...
Should just compare with what can be immediatelly accepted by
the element. flacenc can't renegotiate so if it has a caps already
it should only accept if it is that caps otherwise just use the
template caps
2015-08-16 14:30:57 -03:00
Thiago Santos
3553493d96
flacenc: improve sink pad template caps
...
Removes the need for custom caps query handling and makes it more
correct from the beginning on the template. It is a bit uglier
to read because there is 1 entry per channel but makes code easier
to maintain.
2015-08-16 14:30:57 -03:00
Thiago Santos
65676c22ee
audiodecoders: use default pad accept-caps handling
...
Avoids useless check of downstream caps when handling an
accept-caps query
Elements: flacdec, speexdec, wavpackdec, mulawdec, alawdec
2015-08-15 11:46:34 -03:00
Vineeth TM
3f6a868f7e
flacdec: improve error handling
...
for files which have corrupted header, libflac is not able to
process the metadata properly. We just try to ignore the error
and continue with the processing, since metadata parsing is not
making much of a difference to libflac
https://bugzilla.gnome.org/show_bug.cgi?id=751334
2015-07-06 14:57:11 +01:00
Vincent Penquerc'h
0b36fe59e1
flacdec: set the channel positions using the appropriate API
...
This avoids _set_format setting the unpositioned flag when passed
NULL as channel positions, as it would not be cleared when setting
actual channel positions later.
2014-11-12 14:10:40 +00:00
Vincent Penquerc'h
b18d8b085a
flacenc: update output segment stop time to match clipped samples
...
This will let oggmux generate a granpos on the last page that properly
represents the clipped samples at the end of the stream.
2014-10-30 14:30:30 +00:00
Vincent Penquerc'h
592c34336e
flacdec: add const where appropriate
2014-06-10 12:15:15 +01:00
Sebastian Dröge
f5b2b6e696
flacdec: Add support for variable block size files and remove dead code
...
This dead code wasn't used since the 1.0 port and would need to
be modified heavily for variable block size support.
https://bugzilla.gnome.org/show_bug.cgi?id=729894
2014-05-10 09:30:16 +02:00
Vincent Penquerc'h
d2f66f5394
flacdec: fix theoretical integer overflow
...
This code isn't actually used at the moment, unsure if I should
just remove it or not...
Coverity 1139811
2014-05-02 13:59:07 +01:00
Vincent Penquerc'h
14ceb5727c
flacdec: remove dead code
...
For 8 bit width, we always have depth==gdepth==width==8.
Coverity 1139678
2014-04-30 18:06:40 +01:00
Tim-Philipp Müller
85501e6c2a
flacenc: order format in template caps by preference
...
To minimise risk of bad fixation, though audioconvert
at least should be smart enough to avoid it.
2014-02-04 21:26:56 +01:00
Rafał Mużyło
ac4df5e2c5
gst: Don't use endianness-specific S8 audio format
...
It does not exist.
https://bugzilla.gnome.org/show_bug.cgi?id=723331
2014-02-04 13:44:29 +01:00
Sebastian Dröge
774e56b051
flacdec: Require caps to be set before accepting any data
2013-12-05 12:13:10 +01:00
Sebastian Dröge
de7e1cb6dd
flacenc: Properly set headers via the base class instead of just pushing them downstream
...
Prevents buffers from being send before the caps and segment events.
2013-08-16 13:26:50 +02:00
Sebastian Dröge
c12c9e7632
flacenc: Fix handling of image tags
...
The caps should be used to get the mimetype and there is
only an info structure for the GstSample if the image-type
is not NONE.
2013-07-28 18:09:33 +02:00
Sebastian Dröge
2fa5c708f3
flacenc: Don't crash if there is no image tag information
...
https://bugzilla.gnome.org/show_bug.cgi?id=705018
2013-07-28 18:04:32 +02:00
Stefan Sauer
7e3793e378
flactag: forward caps event
...
This ensures that the downstream element will get the event and negotiates. Add
a FIXME for updating the streamheader field on th caps.
2013-04-17 21:12:55 +02:00
Stefan Sauer
ddedf6b797
flac: add more logging
2013-04-17 20:29:02 +02:00
Sebastian Dröge
b0b0557c48
gst: Add better support for static plugins
2013-04-15 15:54:11 +02:00
Stefan Sauer
ce06005f2a
flacenc: remove old since comments and update logging
...
Don't pretend that we have a timestamp on a buffer when we never set one.
2013-04-03 20:30:09 +02:00
Tim-Philipp Müller
83f9cfb928
flacenc: add more example pipelines
2013-03-23 13:11:02 +00:00
Tim-Philipp Müller
230cf41cc9
Fix FSF address
...
https://bugzilla.gnome.org/show_bug.cgi?id=687520
2012-11-04 00:07:18 +00:00
Tim-Philipp Müller
4bb52bbadf
docs: gst-launch -> gst-launch-1.0 and ffmpegcolorspace -> videoconvert
2012-08-27 21:20:30 +01:00
Tim-Philipp Müller
e4cb67fad8
docs: gst-launch-0.11 -> gst-launch-1.0
2012-08-27 21:20:29 +01:00
Anton Belka
59186f970d
flacenc: allow a TOC with single alternative top-level entry
...
Allow a TOC that has a single alternative top-level entry
with multiple sequence sub-entries
https://bugzilla.gnome.org/show_bug.cgi?id=540891
2012-08-10 14:24:28 +02:00
Anton Belka
fa86bf26df
flacenc: add TOC support
...
Add TOC as embedded cuesheets in flac files.
https://bugzilla.gnome.org/show_bug.cgi?id=54089
2012-08-07 18:04:41 +02:00
Tim-Philipp Müller
c074bfd0b9
gst_tag_list_free -> gst_tag_list_unref
2012-08-04 16:10:16 +01:00
Mark Nauwelaerts
94ab6e17f5
flacdec: improve and relax audio frame parsing
...
... so as to properly recognize first audio frame.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=681077
Conflicts:
ext/flac/gstflacdec.c
2012-08-03 14:02:23 +02:00
Sebastian Dröge
0827f54b93
tag: Update for taglist/tag event API changes
2012-07-28 00:19:51 +02:00
Mark Nauwelaerts
2e8260a787
flacenc: obtain image type from the sample info
2012-07-27 11:26:18 +02:00
Mark Nauwelaerts
e31bfd6ddb
flacenc: remove extraneous _unref
...
... since we did not obtain a buffer ref from the GstSample.
2012-07-27 11:25:49 +02:00
Robert Swain
7c94509243
flacenc: Update to use GstSample tag setting API
2012-07-27 10:14:23 +02:00
Mark Nauwelaerts
0f18a9aaaa
flacenc: only set complete output caps once
...
... so as to avoid downstream complaints about missing streamheaders.
2012-07-25 16:02:39 +02:00
Mark Nauwelaerts
a9b4ceefaf
flacdec: also support S24_32 output
2012-07-25 16:02:39 +02:00
Mark Nauwelaerts
c340deb8b6
flacenc: pass correct parameters to encoder lib
2012-07-25 16:02:38 +02:00
Mark Nauwelaerts
7e6338044c
flacenc: adjust to modified audioencoder getcaps helper API
2012-07-25 16:02:38 +02:00
Wim Taymans
f65495d405
update for audio api change
2012-06-08 10:11:12 +02:00
Wim Taymans
b5df4f0e62
update for tag event change
2012-06-06 13:02:12 +02:00
Tim-Philipp Müller
e09ae5736d
Use new gst_element_class_set_static_metadata()
2012-04-10 00:51:41 +01:00
Sebastian Dröge
aa2cd462da
gst: Update for GST_PLUGIN_DEFINE() API changes
2012-04-05 17:36:38 +02:00
Sebastian Dröge
5cdd49bf25
gst: Update versioning
2012-04-04 14:37:47 +02:00
Sebastian Dröge
b16f5637e8
ext: Update for GstAudioEncoder API changes
2012-03-30 12:18:45 +02:00
Mark Nauwelaerts
12d7acf6f6
flacenc: plug ref leak
2012-03-29 17:21:53 +02:00
Mark Nauwelaerts
03bde3f0d2
flacenc: query downstream for BYTE seeking support
2012-03-28 14:50:03 +02:00
Mark Nauwelaerts
5550d8bc6f
flacdec: clean up obsolete log statement
2012-03-28 14:50:03 +02:00
Wim Taymans
c44cd8f55b
Merge branch 'master' into 0.11
...
unport gdkpixbuf
not merged: https://bugzilla.gnome.org/show_bug.cgi?id=654850
Conflicts:
docs/plugins/Makefile.am
docs/plugins/gst-plugins-good-plugins-docs.sgml
docs/plugins/gst-plugins-good-plugins-sections.txt
docs/plugins/gst-plugins-good-plugins.hierarchy
docs/plugins/inspect/plugin-avi.xml
docs/plugins/inspect/plugin-png.xml
ext/flac/gstflacdec.c
ext/flac/gstflacdec.h
ext/libpng/gstpngdec.c
ext/libpng/gstpngenc.c
ext/speex/gstspeexdec.c
gst/audioparsers/gstflacparse.c
gst/flv/gstflvmux.c
gst/rtp/gstrtpdvdepay.c
gst/rtp/gstrtph264depay.c
2012-03-22 11:53:24 +01:00
Mark Nauwelaerts
19121249bd
flacdec: improve error handling and resilience
...
... by noting that one occurred in the first place, and then appropriately
ignoring some transient ones.
2012-03-19 12:02:42 +01:00